Page MenuHomePhabricator

Something is adding ridiculous damage rectangles
Closed, ResolvedPublic

Description

Just noticed this... happens every time I dismiss the menu in E - wonder if it's related to T7100

Thread 1 "enlightenment" hit Breakpoint 1, _evas_canvas_damage_rectangle_add (eo_e=0x40000000b1ba, e=0x294b6f0, x=-9513, y=-9861, w=20377, h=20794) at lib/evas/canvas/evas_render.c:245
245        evas_canvas_async_block(e);
(gdb) bt
#0  0x00007f54dce2661e in _evas_canvas_damage_rectangle_add (eo_e=0x40000000b1ba, e=0x294b6f0, x=-9513, y=-9861, w=20377, h=20794) at lib/evas/canvas/evas_render.c:245
#1  0x00007f54dcd9d635 in evas_canvas_damage_rectangle_add (obj=0x40000000b1ba, x=-9513, y=-9861, w=20377, h=20794) at ../src/lib/evas/canvas/evas_canvas.eo.c:184
#2  0x00007f54dcd9f43d in evas_damage_rectangle_add (obj=0x40000000b1ba, x=-9513, y=-9861, w=20377, h=20794) at ../src/lib/evas/canvas/evas_canvas.eo.c:706
#3  0x00007f54dcd7bb7b in _efl_canvas_object_clip_unset_common (obj=0x2b076d0, warn=0 '\000') at lib/evas/canvas/evas_clip.c:297
#4  0x00007f54dcd7c33d in _clip_unset (eo_obj=0x40000012d4ba, obj=0x2b076d0) at lib/evas/canvas/evas_clip.c:441
#5  0x00007f54dcd7c5f9 in _clipper_invalidated_cb (data=0x40000012d4ba, event=0x7ffdfae512e0) at lib/evas/canvas/evas_clip.c:478
#6  0x00007f54d7a923a8 in _event_callback_call (obj_id=0x40000012c8b9, pd=0x2aff290, desc=0x7f54d7c9d9f0 <_EFL_EVENT_INVALIDATE>, event_info=0x0, legacy_compare=0 '\000')
    at lib/eo/eo_base_class.c:1708
#7  0x00007f54d7a92597 in _efl_object_event_callback_call (obj_id=0x40000012c8b9, pd=0x2aff290, desc=0x7f54d7c9d9f0 <_EFL_EVENT_INVALIDATE>, event_info=0x0) at lib/eo/eo_base_class.c:1769
#8  0x00007f54d7a9263d in efl_event_callback_call (obj=0x40000012c8b9, desc=0x7f54d7c9d9f0 <_EFL_EVENT_INVALIDATE>, event_info=0x0) at lib/eo/eo_base_class.c:1772
#9  0x00007f54dcdb9f26 in _efl_canvas_object_efl_object_event_callback_call (eo_obj=0x40000012c8b9, obj=0x2aff2e0, desc=0x7f54d7c9d9f0 <_EFL_EVENT_INVALIDATE>, event_info=0x0)
    at lib/evas/canvas/evas_object_main.c:1192
#10 0x00007f54d7a9263d in efl_event_callback_call (obj=0x40000012c8b9, desc=0x7f54d7c9d9f0 <_EFL_EVENT_INVALIDATE>, event_info=0x0) at lib/eo/eo_base_class.c:1772
#11 0x00007f54d7a8dd6f in _efl_invalidate (obj=0x2aff250) at lib/eo/eo_base_class.c:167
#12 0x00007f54d7a8fad4 in _efl_object_parent_set (obj=0x40000012c8b9, pd=0x2aff290, parent_id=0x0) at lib/eo/eo_base_class.c:735
#13 0x00007f54d7a940cb in efl_parent_set (obj=0x40000012c8b9, parent=0x0) at lib/eo/efl_object.eo.c:12
#14 0x00007f54ddd40ac2 in _efl_loop_consumer_efl_object_parent_set (obj=0x40000012c8b9, pd=0x2aff2e0, parent=0x0) at lib/ecore/efl_loop_consumer.c:36
#15 0x00007f54d7a940cb in efl_parent_set (obj=0x40000012c8b9, parent=0x0) at lib/eo/efl_object.eo.c:12
#16 0x00007f54d7a8f8bd in efl_del (obj=0x40000012c8b9) at lib/eo/eo_base_class.c:687
#17 0x00007f54dcdb982e in evas_object_del (obj=0x40000012c8b9) at lib/evas/canvas/evas_object_main.c:1043
#18 0x00007f54db71e1dc in _edje_file_del (ed=0x2da8320) at lib/edje/edje_load.c:1938
#19 0x00007f54db73b69b in _efl_canvas_layout_efl_canvas_group_group_del (obj=0x40000012bcb6, ed=0x2da8320) at lib/edje/edje_smart.c:183
#20 0x00007f54dcdd0564 in efl_canvas_group_del (obj=0x40000012bcb6) at lib/evas/canvas/evas_object_smart.c:1864
#21 0x00007f54dcdcee29 in evas_object_smart_del (eo_obj=0x40000012bcb6) at lib/evas/canvas/evas_object_smart.c:1298
#22 0x00007f54dcdba925 in _efl_canvas_object_efl_object_invalidate (eo_obj=0x40000012bcb6, obj=0x2da8160) at lib/evas/canvas/evas_object_main.c:1338
#23 0x00007f54d7a951ac in efl_invalidate (obj=0x40000012bcb6) at lib/eo/efl_object.eo.c:76
#24 0x00007f54db73afb2 in _efl_canvas_layout_efl_object_invalidate (obj=0x40000012bcb6, ed=0x2da8320) at lib/edje/edje_smart.c:60
#25 0x00007f54d7a951ac in efl_invalidate (obj=0x40000012bcb6) at lib/eo/efl_object.eo.c:76
#26 0x00007f54d7a8dd96 in _efl_invalidate (obj=0x2da80d0) at lib/eo/eo_base_class.c:171
#27 0x00007f54d7a8fad4 in _efl_object_parent_set (obj=0x40000012bcb6, pd=0x2da8110, parent_id=0x0) at lib/eo/eo_base_class.c:735
#28 0x00007f54d7a940cb in efl_parent_set (obj=0x40000012bcb6, parent=0x0) at lib/eo/efl_object.eo.c:12
#29 0x00007f54ddd40ac2 in _efl_loop_consumer_efl_object_parent_set (obj=0x40000012bcb6, pd=0x2da8160, parent=0x0) at lib/ecore/efl_loop_consumer.c:36
#30 0x00007f54d7a940cb in efl_parent_set (obj=0x40000012bcb6, parent=0x0) at lib/eo/efl_object.eo.c:12
#31 0x00007f54d7a8f8bd in efl_del (obj=0x40000012bcb6) at lib/eo/eo_base_class.c:687
#32 0x00007f54dcdb982e in evas_object_del (obj=0x40000012bcb6) at lib/evas/canvas/evas_object_main.c:1043
#33 0x0000000000551cf2 in _e_menu_unrealize (m=0x2c249f0) at ../src/bin/e_menu.c:1876
#34 0x000000000054f4c7 in e_menu_idler_before () at ../src/bin/e_menu.c:1184
#35 0x0000000000549a64 in _e_main_cb_idle_before (data=0x0) at ../src/bin/e_main.c:1791
#36 0x00007f54ddd329b1 in _ecore_call_task_cb (func=0x549a53 <_e_main_cb_idle_before>, data=0x0) at lib/ecore/ecore_private.h:470
#37 0x00007f54ddd32a19 in _ecore_factorized_idle_process (data=0x278e930, event=0x7ffdfae51d70) at lib/ecore/ecore_idler.c:35
#38 0x00007f54d7a922c5 in _event_callback_call (obj_id=0x40000000018e, pd=0x27832c0, desc=0x7f54ddf92700 <_EFL_LOOP_EVENT_IDLE_ENTER>, event_info=0x0, legacy_compare=0 '\000')
    at lib/eo/eo_base_class.c:1685
#39 0x00007f54d7a92597 in _efl_object_event_callback_call (obj_id=0x40000000018e, pd=0x27832c0, desc=0x7f54ddf92700 <_EFL_LOOP_EVENT_IDLE_ENTER>, event_info=0x0) at lib/eo/eo_base_class.c:1769
#40 0x00007f54d7a9263d in efl_event_callback_call (obj=0x40000000018e, desc=0x7f54ddf92700 <_EFL_LOOP_EVENT_IDLE_ENTER>, event_info=0x0) at lib/eo/eo_base_class.c:1772
#41 0x00007f54ddd37198 in _ecore_main_loop_iterate_internal (obj=0x40000000018e, pd=0x2783340, once_only=0) at lib/ecore/ecore_main.c:2378
#42 0x00007f54ddd34af9 in _ecore_main_loop_begin (obj=0x40000000018e, pd=0x2783340) at lib/ecore/ecore_main.c:1191
#43 0x00007f54ddd3d3e5 in _efl_loop_begin (obj=0x40000000018e, pd=0x2783340) at lib/ecore/efl_loop.c:83
#44 0x00007f54ddd3fad6 in efl_loop_begin (obj=0x40000000018e) at lib/ecore/efl_loop.eo.c:28
#45 0x00007f54ddd34c6e in ecore_main_loop_begin () at lib/ecore/ecore_main.c:1274
#46 0x0000000000547ab8 in main (argc=1, argv=0x7ffdfae8a198) at ../src/bin/e_main.c:1090
ManMower created this task.Oct 2 2018, 11:00 AM

Can you add a trap here and see what clip->cur->geometry is ??

In src/lib/evas/canvas/evas_clip.c:297

evas_damage_rectangle_add(e->evas,
                          clip->cur->geometry.x + e->framespace.x,
                          clip->cur->geometry.y + e->framespace.y,
                          clip->cur->geometry.w,
                          clip->cur->geometry.h);

Oh wait, nvm. I see the values now in the backtrace

Can anyone confirm that this is still happening ?? I ran some tests here today with some printfs added, and I am not seeing any odd damage rectangles from evas_clip.c anymore...