Page MenuHomePhabricator

_create_locale and _free_locale undefined on Windows
Open, Showstopper IssuesPublic

Description

these 2 functions are undef hence compilation fails

include locale.h on Windows (in the #ifdef _WIN32 of Evil at the top)
but the link is the problem : these functions do not exist in msvcrt.dll, against which mingw-w64 links. you must add -lmsvcr100 but the DLL is not always installed.

vtorri created this task.Thu, Dec 6, 1:20 PM
vtorri triaged this task as Showstopper Issues priority.
vtorri updated the task description. (Show Details)Thu, Dec 6, 1:26 PM
bu5hm4n removed bu5hm4n as the assignee of this task.Thu, Dec 6, 1:36 PM
bu5hm4n added a subscriber: bu5hm4n.

I am not that sure, why I am assigned to this ... I am not the original author of that patch. I got quite a lot of things to do, not sure when I would get to this :)

vtorri added a comment.Thu, Dec 6, 2:14 PM

you reverted the revert so you knew what you were doing.
otherwise, don't revert