Page MenuHomePhabricator

C#: Hide DllImport'd methods into a NativeMethods subclass
Closed, ResolvedPublic

Description

Currently, the C api is dllimport'd into the normal class namespace (e.g. Efl.Ui.Button.efl_content.get). We should hide them so it becomes something like Efl.Content.NativeMethods.efl_content_get. (This may also help reduce the number of duplicated dllimports).

lauromoura triaged this task as TODO priority.
segfaultxavi moved this task from Backlog to TODO on the efl: language bindings board.
segfaultxavi raised the priority of this task from TODO to High.
felipealmeida lowered the priority of this task from High to Trivial.Jan 11 2019, 11:57 PM

@felipealmeida Is this work finished now?

The dotnet patch from D8069 replaced the DLLImport's in the public API class with some fields in the NativeInherit classes. I think this could be marked as resolved it that seems enough.

About actually hiding them from the docs, have you checked https://dotnet.github.io/docfx/tutorial/howto_filter_out_unwanted_apis_attributes.html? In our case, one of the rules would be hiding the *NativeInherit classes.

segfaultxavi closed this task as Resolved.Thu, Mar 7, 2:11 AM

*NativeInherit classes are already being excluded from the DocFx generation, yeah.

I'm closing this task, but can you please comment on T7702?