Page MenuHomePhabricator

Closed, ResolvedPublic


| | |abstract Efl.Canvas.Object
| | |├ (P) pointer_mode_by_device
| | |├ (P) pointer_mode
| | |├ (P) render_op
| | |├ (P) clip
| | |├ (P) repeat_events
| | |├ (P) key_focus
| | |├ (P) seat_focus
| | |├ (P) precise_is_inside
| | |├ (P) propagate_events
| | |├ (P) pass_events
| | |├ (P) anti_alias
| | |├ (P) clipees
| | |├ (P) render_parent
| | |├ (P) paragraph_direction
| | |├ (P) no_render
| | |├ (P) coords_inside
| | |├ (M) seat_focus_check
| | |├ (M) seat_focus_add
| | |├ (M) seat_focus_del
| | |├ (M) clipees_has
| | |├ (M) key_grab
| | |├ (M) key_ungrab

Related Objects

zmike created this task.Jan 8 2019, 11:29 AM
zmike triaged this task as TODO priority.
zmike removed a parent task: T7511:
This comment was removed by bu5hm4n.
zmike added a comment.Feb 15 2019, 6:48 AM

is_frame_object seems bad to expose since this should only be used by internals?

I agree is_frame_object() seems internal, as its own docs say.

Furthermore, freeze_events looks awfully similar to event_freeze, which it inherits from Efl.Object.
Are they related? At the very least this should be documented.
If they do the same, kill with fire or hammers.

I do not understand @bu5hm4n 's comment regarding parent.

I think event_animation can be a bit difficult and dangerous, you can see it with the implementation, two special cases for SHOW and HIDE. From a user POV this looks to me like i can go and add an animation to the POSITION_CHANGED event. However, you cannot, since the position will be moved. Not stopped by the animation, so to me this looks only usefull for hide and show. IMO it would be better to "copy" this functionality into efl_ui_stack.c (which is the only user of this). And remove this API and anim_* events from this object... What do you say @Jaehyun_Cho ?

seat_focus seems unused, do we want to remove it, its unclear to me what is actaully does. Additionally, it seems a bit off, that we have a list of seats *per* object.

bu5hm4n updated the task description. (Show Details)Feb 23 2019, 7:13 AM

After the patchset, things look good to me. seat_focus Is the last thing which looks doubious to me. @cedric @woohyun @Jaehyun_Cho opinions on that API ?

bu5hm4n updated the task description. (Show Details)Feb 25 2019, 1:39 AM
bu5hm4n updated the task description. (Show Details)
bu5hm4n updated the task description. (Show Details)
zmike added a comment.Feb 26 2019, 2:32 PM

I don't really like the term 'clipee'. This doesn't seem to be a "standard" term used anywhere, and googling it doesn't return useful results.

I think potentially all the seat stuff could just be left as beta for now?

Awesome, clip and clipees form yet another hierarchy. How many do we have?
I agree Google does not seem to know this word, but it seems pretty self-explanatory to me. At most, I would rename them to clipper and clipped_children.

Can't speak about seats, they are still mysterious to me.

zmike added a comment.Feb 27 2019, 4:16 AM

I like the idea of clipped_children , but they aren't exactly "child" objects? Can we bikeshed this a bit?

Let's settle on clipped_objects.

zmike updated the task description. (Show Details)Feb 27 2019, 8:50 AM
zmike moved this task from Backlog to Evaluating on the efl: api board.Feb 27 2019, 9:13 AM
zmike moved this task from Evaluating to Stabilized on the efl: api board.Feb 27 2019, 12:21 PM
zmike closed subtask T7563: efl.gfx.size_hint as Resolved.
zmike closed subtask T7564: as Resolved.
zmike closed subtask T7560: efl.gfx.stack as Resolved.
zmike closed subtask T7558: efl.gfx.entity as Resolved.
zmike closed this task as Resolved.
zmike claimed this task.