efl.input.interface
Closed, ResolvedPublic
Actions

Description

| | | |interface Efl.Input.Interface
| | | |├ (P) seat_event_filter
| | | |├ (E) pointer,move
| | | |├ (E) pointer,down
| | | |├ (E) pointer,up
| | | |├ (E) pointer,cancel
| | | |├ (E) pointer,in
| | | |├ (E) pointer,out
| | | |├ (E) pointer,wheel
| | | |├ (E) pointer,axis
| | | |├ (E) finger,move
| | | |├ (E) finger,down
| | | |├ (E) finger,up
| | | |├ (E) key,down
| | | |├ (E) key,up
| | | |├ (E) hold
| | | |├ (E) focus,in
| | | |├ (E) focus,out

Details

Differential Revisions: D8296: api: mark efl.loop_timer stable
Commits: D9264 / rEFL1c8f6132af0e: declare a few classes stable
D8290 / rEFLc73ca5d22914: efl.input.interface: mark seat_event_filter @beta

Related Objects
Search...

Status	Assigned	Task
Resolved	None	T7562 efl.input.interface
Resolved	None	T7963 Efl.Input.Pointer
Open	None	T7973 Efl.Input.Value
Resolved	None	T7964 Efl.Input.Key
Resolved	bu5hm4n	T7968 Efl.Input.State
Invalid	None	T7971 Efl.Input.Lock
Invalid	None	T7972 Efl.Input.Modifier
Resolved	None	T7965 Efl.Input.Hold
Resolved	None	T7967 Efl.Input.Event
Resolved	None	T7969 Efl.Input.Device
Resolved	None	T7970 Efl.Input.Device_Type

zmike created this task.Jan 8 2019, 11:33 AM

zmike triaged this task as TODO priority.

zmike edited projects, added efl: api; removed efl: language bindings.Jan 10 2019, 10:01 AM

zmike added subscribers: SanghyeonLee, JongminLee, myoungwoon.

This seems like it has some overlap with T7584?

Where? I cannot find any overlap.

(E) focus,in
(E) focus,out

Oh, I thought to meant "conceptual" overlap, sorry.

Yeah, right there, Efl.Ui.Win implements both interfaces, so a user will never know which one is receiving, or to which one he is subscribing.
Is this wrong, though? Do these two events mean the same thing?

I can't figure out what are the difference between this two set of focus events. @bu5hm4n do you have an idea?

It seems like this is the per-object input interface according to some sources.

I think this is maybe reasonable?

seat_event_filter seems @beta wörthy, the rest looks good to me :)

zmike added a revision: D8290: efl.input.interface: mark seat_event_filter @beta.Mar 11 2019, 8:47 AM

zmike moved this task from Evaluating to Stabilized on the efl: api board.Mar 11 2019, 10:50 AM

zmike added a revision: D8296: api: mark efl.loop_timer stable.Mar 11 2019, 10:51 AM

zmike added a commit: rEFLc73ca5d22914: efl.input.interface: mark seat_event_filter @beta.Mar 11 2019, 1:35 PM

This requires all the other input classes so it can't be stabilized yet

zmike edited projects, added efl (efl-1.23); removed efl (efl-1.22).Apr 10 2019, 5:01 AM

bu5hm4n added a parent task: T7845: Unstructured stabilization items.May 3 2019, 10:33 AM

bu5hm4n removed a parent task: T7555: efl.canvas.object.

segfaultxavi added a parent task: T7859: efl.ui.box.May 8 2019, 2:21 AM

segfaultxavi added a parent task: T7869: efl.ui.datepicker.May 8 2019, 2:23 AM

segfaultxavi added a parent task: T7870: efl.ui.grid.May 8 2019, 2:27 AM

segfaultxavi added a parent task: T7873: efl.ui.image.May 8 2019, 2:35 AM

segfaultxavi added a parent task: T7880: efl.ui.bg.May 8 2019, 2:44 AM

segfaultxavi added a parent task: T7881: efl.ui.list.May 8 2019, 2:48 AM

segfaultxavi added a parent task: T7885: efl.ui.list_view.May 8 2019, 2:54 AM

segfaultxavi added a parent task: T7891: efl.ui.scroller.May 8 2019, 3:23 AM

segfaultxavi added a parent task: T7893: efl.ui.slider.May 8 2019, 3:26 AM

segfaultxavi added a parent task: T7897: efl.ui.spin.May 8 2019, 3:30 AM

segfaultxavi added a parent task: T7899: efl.ui.table.

segfaultxavi added a parent task: T7849: efl.ui.text.May 8 2019, 3:34 AM

segfaultxavi added a parent task: T7901: efl.ui.timepicker.May 8 2019, 4:09 AM

segfaultxavi added a parent task: T7902: efl.ui.popup.

segfaultxavi added a parent task: T7905: efl.ui.item.May 8 2019, 4:25 AM

We need to get this done so we can have input events.

This misses all the types of the events.

This misses all the types of the events.

There, just added them.

Thank you :)

bu5hm4n closed subtask T7966: Efl.Input.Focus as Invalid.May 17 2019, 11:11 AM

bu5hm4n removed a subtask: T7966: Efl.Input.Focus.

I guess this is okay? I haven't really used it as an API too much (though I've worked on it), but I see that we do have some test cases for it so I guess it's probably functional enough?

bu5hm4n moved this task from Evaluating to Stabilized on the efl: api board.Jun 27 2019, 9:13 AM

bu5hm4n added a revision: D9264: declare a few classes stable.Jul 10 2019, 8:28 AM

What do you think about changing the name of this interface as follows?

Efl.Input.Interface -> Efl.Input.Events
Efl.Input.Event -> Efl.Input.Object or Efl.Input.Event_Object

To be honest, i like the name how it is. The interface here is rather low in the inheritance structure. No API will be named like this the event_prefix is efl_input. Further more, "Efl.Input.Event" implies that it is the content of a event, which is not. Given that, i would pretty much also just leave the name how it is.

Actually I don't mind the name Efl.Input.Event. It's ok but the reason why I suggested is to change the name "Efl.Input.Interface".

To me, it doesn't look common that the word "class" or "interface" is included in a class name or interface name.

I don't stick to the change from "Efl.Input.Interface" to "Efl.Input.Events". I wish we find better name than "Efl.Input.Interface".

Yeah, naming classes Class or interfaces Interface is bad practice. But in this case, it is not named Interface because it is an interface in the OOP sense, it's because this object represents the physical interface between the user and the program, that is, an input device.
There are a lot of names around this concept (input interface, input device, tool, pointer, finger, key, seat, ...) and we have used all of them in one place or another, so this name is complicated :)