Page MenuHomePhabricator

efl.ui.factory
Open, TODOPublic

Description

|interface Efl.Ui.Factory
|├ (M) create
|├ (M) release
|├ (E) created
zmike created this task.Jan 8 2019, 11:42 AM
zmike triaged this task as TODO priority.
zmike moved this task from Backlog to Evaluating on the efl: api board.Jan 28 2019, 8:38 AM
woohyun added a comment.EditedJan 28 2019, 11:27 PM

@SanghyeonLee @cedric @felipealmeida

I think Efl.Ui.Factory needs to include only "create", "release", and "created" event.
That is, "model_connect" needs to be included to another interface (or class).

I've heard from @SanghyeonLee that MVVM related things are still in changing, so please check this task together :)

I am not to sure why Efl.Ui.Layout is also an Efl.Ui.Factory by itself. This was done a long time ago with commit 6b9a35d7638a1ef3ffb7cb32ba43daead2f28627 . I am not convinced that it is what we really wanted.

I think we might move the specific call to bind another factory inside a factory to a specific Efl.Ui.GroupFactory or something like that as described in task T7405. Maybe this should actually require an interface so that Efl.Ui.Layout can use it. The logic was for Efl.Ui.Layout to be able to automatically create swallow by using the defined factory. Will have to think about this more and get this fixed in T7405.

zmike added a comment.Jan 30 2019, 6:04 AM

I am not to sure why Efl.Ui.Layout is also an Efl.Ui.Factory by itself. This was done a long time ago with commit 6b9a35d7638a1ef3ffb7cb32ba43daead2f28627 . I am not convinced that it is what we really wanted.

I did rEFL6b9a35d7638a1ef3ffb7cb32ba43daead2f28627 at your request, so I think probably only you know whether this is what we wanted.

Yes, I know and I don't know what I was thinking.

bu5hm4n updated the task description. (Show Details)Feb 22 2019, 1:27 AM

Conceptionally this looks small and just fine, the docs are a bit weird to someone reading it the first time, but that does not block stabilization. @segfaultxavi what do you say ?

@cedric I think i found a problem, Efl.Ui.Widget_Factory, takes either a Efl.Ui.View or Efl.Ui.Widget class, which it uses to create the objects, but the objects need to be Efl.Gfx.Entity, should this be changed ?

The docs are a bit weird to someone reading it the first time, but that does not block stabilization. @segfaultxavi what do you say ?

I say that the docs could certainly be improved (it's in my list), but that does not block stabilization.