|interface Efl.Canvas.Scene |├ (P) image_max_size |├ (P) group_objects_calculating |├ (P) device |├ (P) seat |├ (P) pointer_position |├ (M) group_objects_calculate |├ (M) objects_at_xy_get |├ (M) object_top_at_xy_get |├ (M) objects_in_rectangle_get |├ (M) object_top_in_rectangle_get |├ (M) seats |├ (M) pointer_iterate @beta |├ (E) focus,in |├ (E) focus,out |├ (E) object,focus,in |├ (E) object,focus,out |├ (E) render,pre |├ (E) render,post |├ (E) device,changed |├ (E) device,added |├ (E) device,removed
- D8275 / rEFLf234a2b6c77a: efl: mark types beta that have been missed before
D8274 / rEFL734d517035d1: efl_gfx_types: pull 2 types out of beta
D8273 / rEFL954cdb36561c: efl: apply the stabilzed column of the efl api board
D8021 / rEFLd16adf8d8210: efl.canvas.scene: rename "smart" methods to "group" methods
D7956 / rEFL2df6e1103de3: efl.canvas.scene: add 'seat_default' property
D7957 / rEFL99c3d42efdb6: efl.canvas.scene: clean up pointer_position property
D7955 / rEFLe16648610756: interfaces: move pointer_iterate method efl.canvas.scene -> efl.ui.win
D7954 / rEFL4935202caab9: efl.canvas.scene: improve class docs
I think device,changed is slightly ambiguously named given that there are also added and removed events; for example, if I hook changed then is that triggered with the other two?
Why is image_max_size here? That feels totally out of place.
Seat, device and device ID are utterly confusing to me. The docs in that file are not very helpful.
Therefore I do not know what to say, I cannot contribute here. Other than "The docs need serious rewrite."
seat is a widely used term meaning "group of devices", where a device is the representation of a physical input device. Not sure what you mean by "device ID"; sometimes an int is associated with a device/seat based on arbitrary ordering in the display backend.
Mostly these terms are taken from Wayland concepts and implemented for Wayland compatibility.
OK, I'm not familiar with Wayland (or X).
Still, this class looks like a bunch of unrelated things thrown together, I can see no clear purpose for it. It does not help that the class docs are:
[[Common interface for window and some internal classes in EFL.]]
It's not even consistent within itself, since seat is a read-only property, but seats is a method returning an iterator of seats.
Plus, it's got a couple of FIXMEs... overall, not a good vibe.
The lack of docs seems to be the main issue here. I am not very convinced of exposing smart_objects_calculating and smart_objects_calculate, but the rest seems to be properly related to a canvas scene.
smart_objects_calculating was specifically added in order to work around an infinite loop when recalc needs to be triggered but some determination needs to be made based on whether the current calculation is occurring during smart calc: https://git.enlightenment.org/core/enlightenment.git/tree/src/bin/e_gadget.c#n674
Yea I'll take a run at it today.