Page MenuHomePhabricator

efl.loop
Open, TODOPublic

Description

|class Efl.Loop
|├ (P) quit_when_all_windows_closed
|├ (P) throttle
|├ (P) time
|├ (M) iterate
|├ (M) iterate_may_block
|├ (M) begin
|├ (M) quit
|├ (M) job
|├ (M) idle
|├ (M) timeout
|├ (M) register
|├ (M) unregister
|├ (M) message_handler_get
|├ (E) idle,enter
|├ (E) idle,exit
|├ (E) idle
|├ (E) arguments
|├ (E) poll,high
|├ (E) poll,medium
|├ (E) poll,low
|├ (E) quit

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
zmike created this task.Wed, Jan 9, 10:18 AM
zmike triaged this task as TODO priority.
zmike moved this task from Backlog to Evaluating on the efl: api board.Thu, Jan 17, 11:09 AM
|├ (P) quit_when_all_windows_closed

I don't think this one landed yet. Except from that I am ok with the rest of the class.

I cannot comment on the API, since the relationship between Task, Loop and App is still unclear to me, however, I have some small concerns regarding the documentation for Efl.Loop. Parts of it could be made clearer.

bu5hm4n added a comment.EditedSat, Jan 19, 3:26 AM

Undefined API!:

eolian: efl_loop.eo:7:1: partially implemented function 'closed' (originally defined at efl_io_closer.eo:35:13)
eolian: efl_loop.eo:7:1: unimplemented function 'can_read' (originally defined at efl_io_reader.eo:39:13)
eolian: efl_loop.eo:7:1: unimplemented function 'can_write' (originally defined at efl_io_writer.eo:40:13)
eolian: efl_loop.eo:7:1: unimplemented function 'close_on_exec' (originally defined at efl_io_closer.eo:52:13)
eolian: efl_loop.eo:7:1: unimplemented function 'close_on_invalidate' (originally defined at efl_io_closer.eo:68:13)
eolian: efl_loop.eo:7:1: unimplemented function 'close' (originally defined at efl_io_closer.eo:18:9)
eolian: efl_loop.eo:7:1: unimplemented function 'eos' (originally defined at efl_io_reader.eo:49:13)
eolian: efl_loop.eo:7:1: unimplemented function 'read' (originally defined at efl_io_reader.eo:19:9)
eolian: efl_loop.eo:7:1: unimplemented function 'write' (originally defined at efl_io_writer.eo:19:9)

Quoting from T7514:

  • arguments event should move to efl_app
  • is regular, should probebly be abstract ?
  • there is no need to have message_handler_get beeing @class

We should btw. things about a namespace ?