Page MenuHomePhabricator

Progressbar is broken with unit format (againx4)
Closed, ResolvedPublic


So once again - in the same cycle of things - custom format strings that have %% (in other words desire to display format as a percentage without going the auto route) are broken and back to displaying %% without being correctly escaped.

This has been broken/fixed at least 3 times I can find by @raster @zmike @netstar and myself:

While the elementary_test has a progressbar test that displays this exact very behavior for the purpose of not breaking it - apparently only ninja tests are used these days so - once fixed - its apparent that a test should be made for it. Al has a task created for this it seems:

stephenmhouston triaged this task as High priority.

I added a test for this so that once this is fixed again, in the future ninja test will fail when it gets broken again:

Adding @Hermet @CHAN @woohyun so we can perhaps get someone to try and fix this properly so the cycle of fix/break with this particular functionality stops happening?

cedric closed this task as Resolved.Feb 11 2019, 3:41 PM
cedric claimed this task.