Page MenuHomePhabricator

master ticket for 1.22 api stabilization
Open, HighPublic

Description

  • verify *,changed events send event data where possible
  • figure out what types are needed and stabilize those (T7726)
  • T7454
  • T7724
  • fix colliding event names in stabilized classes:
    • focus,in and focus,out defined both in Efl.Canvas.Scene and Efl.Input.Interface and colliding in Efl.Ui.Win
zmike created this task.Wed, Mar 6, 6:13 AM
zmike triaged this task as TODO priority.
zmike updated the task description. (Show Details)
segfaultxavi updated the task description. (Show Details)Wed, Mar 6, 8:23 AM
segfaultxavi updated the task description. (Show Details)Wed, Mar 6, 9:07 AM
zmike updated the task description. (Show Details)Fri, Mar 8, 7:37 AM
bu5hm4n added a comment.EditedMon, Mar 11, 12:10 PM

To address point one:

https://git.enlightenment.org/core/efl.git/log/?h=devs/bu5hm4n/event_analysis

This is an analysis script which will verify each event type of the passed event data.

This will only work for meson builds, and will use libclang & eolian, hence this *should* catch every case that is wrong. When every event is right, then the ,changed events are always right.

However, this script is not ready for primetime yet, due to the lack of time.

The script is meanwhile "finished". You can find it in https://git.enlightenment.org/core/efl.git/log/?h=devs/bu5hm4n/event_analysis

However it brought up a few problems, and still has a few problems. The script will for now fail to verify the correct types of objects, as they are always void* in the code (I don't know why this is returned from clang).

bu5hm4n raised the priority of this task from TODO to High.Thu, Mar 14, 7:56 AM

Adding this to high, so we can make sure this is done before we do releases.

bu5hm4n updated the task description. (Show Details)Thu, Mar 21, 4:08 AM

With the script given in [1] you can check how many problem cases we have. We have 0 *direct* problem cases, but ~8 cases that cannot be checked by the script. However, they are looking fine to me.

[1]: https://git.enlightenment.org/core/efl.git/commit/?h=devs/bu5hm4n/event_analysis&id=49910bbecd9ca9a0a8bf8b4d2c62cf15bb0d9454

you must run this script from inside your meson build directory, with the argument "."