Page MenuHomePhabricator

Support ecore_win32
Closed, ResolvedPublic

Description

Additionally, add the support for the rending engine, meson.build files are in place in evas/modules/engines, only not used yet.

Related Objects

StatusAssignedTask
Resolvedzmike
Resolvedbu5hm4n
bu5hm4n created this task.Apr 6 2019, 2:51 AM
bu5hm4n triaged this task as TODO priority.
bu5hm4n renamed this task from Support ecore_wl2 to Support ecore_win2.Apr 6 2019, 3:06 AM
bu5hm4n renamed this task from Support ecore_win2 to Support ecore_win32.
vtorri assigned this task to bu5hm4n.Apr 10 2019, 4:52 AM

I have tried to add the support for ecore_win32. It seems to work and the DLL is created. Not sure if there are something else to do. The files are attached


I think the whole file content in meson.build should be inside a if sys_windows. Like:

if sys_windows
  CONTENT OF THE MESON.BUILD
else
  automatic_pkgfile = false
endif

This will prevent building it on linux, and prevent .pc generation.

something like that :

?

btw, in evil/meson.build I see 2 different things :

  • line 3 : if target_machine.system() == 'windows' I think that it should be sys_windows (as it's the host, needed for cross compilation)
  • line 60 : evil = declare_dependency() (in the else part) What does this do ?

Yes like this.

In evil/meson.build:3 yes. That is likely an artifact, from the time when sys_windows was not there. host_machine and target_machine are most of the time the same. At least if you do not change it in the cross-file.txt.
evil/meson.build:60: this is just a empty dependency, this is usefull as i do want to be able to just add evil where ever i need it. No matter if i am on windows or linux.

zmike added a comment.Apr 25 2019, 9:54 AM

This seems good, once the changes are submitted as a patch with authorship info then it can be merged.