Page MenuHomePhabricator

Backward compatibility broken.
Closed, ResolvedPublic

Description

Some widgets (gesture, panel or more?)
When on_disabled_update is called, they registered callbacks or deleted those.

But now the _XXX_efl_ui_widget_disabled_set() called many times.
So the widget registered callbacks many times. it makes problem.

+

I can't check the previous disable state.

When _XXX_efl_ui_widget_disabled_set () is called, a call to efl_ui_widget_disabled_get () to check the previous state will be disabled, even if it is not disabled.

There seems to be a problem with the logic itself that raises and lowers the value of pd->disabled in _mirror_disabled_state () when the parent of the widget changes.

CHAN created this task.Apr 10 2019, 11:53 PM
CHAN triaged this task as High priority.
bu5hm4n added a comment.EditedApr 11 2019, 2:18 AM

Can you add a if(disbled == efl_ui_widget_disabled_get(obj)) return; before the super call? Does that fix the issue ? I am on vacation, will return on the 17.04 :)

Jaehyun_Cho closed this task as Resolved.Apr 11 2019, 11:47 PM