Page MenuHomePhabricator

efl_ui_list existance
Open, HighPublic

Description

Code duplication between efl_ui_grid and efl_ui_list is enorm. Is there a reason that not just a second layout function in efl_ui_grid code is written ?

bu5hm4n created this task.Thu, Apr 25, 12:55 PM
bu5hm4n triaged this task as High priority.

Which parent are we talking about ?

As for your question, I guess time has been the answer.

bu5hm4n renamed this task from efl_ui_list internal box usage to efl_ui_list existance.Thu, Apr 25, 11:27 PM
bu5hm4n updated the task description. (Show Details)
bu5hm4n added a project: efl: widgets.

code could be duplicated because they are almost same item-based widget, except the layouting... but I don't know what you mean second layout function.
our plan is support list and grid layout with pack-interface on simple case and MVVM interface on more complex or hugh data handling.
efl_ui_list was written before efl_ui_grid, and I planed to use efl.ui.box internally for simple implements, and it works as well for list layout, but
about grid requirement comes, I couldn't use box anymore so I have to make whole pack interface internally.

I agreed their duplicated code can be merged one common places, except the layout. but its internal change and not that urgent as much as our MVVM delayed :p
so Indeed I agree that this task is about migrate duplicated code on efl_ui_list and grid,
but this is not an urgent task as I think unless it won't change any user-usages and APIs.