Page MenuHomePhabricator

Efl.Text_Font_Properties
Closed, ResolvedPublic

Description

 | |interface Efl.Text_Font_Properties @beta
| |├ (P) font_family
| |├ (P) font_size
| |├ (P) font_source
| |├ (P) font_fallbacks
| |├ (P) font_weight
| |├ (P) font_slant
| |├ (P) font_width
| |├ (P) font_lang
| |├ (P) font_bitmap_scalable
bu5hm4n created this task.May 3 2019, 11:12 AM
bu5hm4n triaged this task as TODO priority.
zmike moved this task from Backlog to Needs experts on the efl: api board.Jun 12 2019, 7:37 AM

The proposed rework:

interface Efl2.Text.Font.Properties
├ (P) font_family
├ (P) font_size
├ (P) font_source
├ (P) font_fallbacks
├ (P) font_weight
├ (P) font_slant
├ (P) font_width
├ (P) font_lang
├ (P) font_bitmap_scalable
zmike added a comment.Oct 1 2019, 9:17 AM

font_lang should be font_language I think since we've been consistent about not shortening words. Otherwise this is just doing font -> font_family and adding font_size. Seems reasonable, and the name Font.Properties also makes sense.

tasn added a comment.Oct 1 2019, 1:19 PM

I suspect this might change a bit tomorrow. This, as you said, is essentially a copy of what was there, though I'm having second thoughts about it. I'm in the process of reviewing everything now that we've had some time to absorb the new interfaces and I don't think I like this.

ali.alzyod updated the task description. (Show Details)Dec 20 2019, 1:00 AM
ali.alzyod moved this task from Needs experts to Evaluating on the efl: api board.

This is should be ready to stabilize, any comments ?

Well, we had a discussion with Tom back then were we agreed that we should rename this to Efl.Ui.Text_Properties (as its not really a font object, but something that implements the properties of a font). This still looks not done yet.

Well, we had a discussion with Tom back then were we agreed that we should rename this to Efl.Ui.Text_Properties (as its not really a font object, but something that implements the properties of a font). This still looks not done yet.

Can you please point out this (link or something)? I do not recall something similar in my memory

I cannot find the discussion, it was maybe on irc. But the outcome can be seen in toms last comment, where the name was changed.

ali.alzyod added a comment.EditedDec 24 2019, 4:02 AM

I cannot find the discussion, it was maybe on irc. But the outcome can be seen in toms last comment, where the name was changed.

I was working with @tasn at these changes and I do not remember such thing, is it related to: T6463 ?

I dont know - but we kind of agreed on that name, @zmike also agreed on that name.

I dont know - but we kind of agreed on that name, @zmike also agreed on that name.

Ohhhh, Now I get what you mean Efl2.Text.Font.Properties vs efl.text_font, sorry I was thinking of something totally different.

I can not think of more extensions can be added to font other than properties, but I am ok with renaming it.

for consistent naming :
Naming was :
Efl.Text.Style
Efl.Text.Format
Efl.Text.Font

Naming Now:
Efl.Text.Style
Efl.Text.Format
Efl.Text.Font.Properties

D10966

D10966 is updated, and it looks good for now.

Any other opinions on this subject ?

ali.alzyod renamed this task from efl.text_font to Efl.Text.Font.Properties.Dec 26 2019, 1:21 AM

Isn't it weird that we are creating an Efl.Text.Font namespace which only contains one class?

This should be Efl.Text_Font_Properties instead of Efl.Text.Font.Properties, to match Efl.Text_Font_Weight or Efl.Text_Font_Width, for example (or the other way around).

@segfaultxavi
Oh - good point.

@ali.alzyod
Do we have to add more classes in Efl.Text.Font namespace ?
If no, I also like @segfaultxavi 's idea to change the current class name to Efl.Text_Font_Properties.
How do you think about this ?

ali.alzyod renamed this task from Efl.Text.Font.Properties to Efl.Text_Font_Properties.
ali.alzyod updated the task description. (Show Details)

Do we have to add more classes in Efl.Text.Font namespace ?
If no, I also like @segfaultxavi 's idea to change the current class name to Efl.Text_Font_Properties.

Done, actually I feel Efl.Tex_Font was good enough, but since reviewer request, it is now Efl.Tex_Font_Properties

@ali.alzyod
Thanks for quick modification.

Another opinion on this ??

This looks fine now.

Let's move this to "stabilized" :) Thanks all !!!

woohyun moved this task from Evaluating to Stabilized on the efl: api board.Jan 3 2020, 5:05 PM