Page MenuHomePhabricator

efl.text_format
Open, TODOPublic

Description

| |interface Efl.Text_Format @beta
| |├ (P) ellipsis
| |├ (P) wrap
| |├ (P) multiline
| |├ (P) text_horizontal_align_auto_type
| |├ (P) text_horizontal_align
| |├ (P) text_vertical_align
| |├ (P) linegap
| |├ (P) linerelgap
| |├ (P) tabstops
| |├ (P) password
| |├ (P) replacement_char
bu5hm4n created this task.May 3 2019, 11:13 AM
bu5hm4n triaged this task as TODO priority.
zmike moved this task from Backlog to Needs experts on the efl: api board.Jun 12 2019, 7:38 AM
zmike added a comment.Oct 1 2019, 9:39 AM

The proposed rework:

interface Efl2.Text.Wrap.Properties
├ (P) ellipsis
├ (P) wrap

Previous API has been moved to other classes.

zmike added a comment.Oct 1 2019, 9:40 AM

This needs doc work, but so does everything else. Seems good.

I am unsure what are the plans for Efl.Text.Format, but having Format and Style interfaces is very confusing. We should find names that indicate what kind of properties each of these interfaces hold.

ali.alzyod updated the task description. (Show Details)Dec 20 2019, 12:59 AM
ali.alzyod moved this task from Needs experts to Evaluating on the efl: api board.

@segfaultxavi should we update

├ (P) linegap
├ (P) linerelgap

to have text_ in front?

Hmmmmm... I think Line already acts as a sort of prefix. Looks clear enough to me as it is.

Except that I would add an underscore to line_gap, line_rel_gap and tab_stops, like the other properties, of course :)

Except that I would add an underscore to line_gap, line_rel_gap and tab_stops, like the other properties, of course :)

Done in D10963

This is should be ready to stabilize, any comments ?

D10963 is updated, and it looks good for now.

Any other opinions on this subject ?

Looks good to me!

Let's move this to "stabilized !" Thanks :)

woohyun moved this task from Evaluating to Stabilized on the efl: api board.Mon, Dec 30, 5:51 PM