Page MenuHomePhabricator
Create Task
Maniphest T7856

efl.text_format
Closed, ResolvedPublic
Actions

Description

| |interface Efl.Text_Format @beta
| |├ (P) ellipsis
| |├ (P) wrap
| |├ (P) multiline
| |├ (P) text_horizontal_align_auto_type
| |├ (P) text_horizontal_align
| |├ (P) text_vertical_align
| |├ (P) linegap
| |├ (P) linerelgap
| |├ (P) tabstops
| |├ (P) password
| |├ (P) replacement_char

Details

Differential Revisions
D10963: efl_text_format: rename tabstops,lingap,linerelgap
Commits
D11264 / rEFL7f57e8e6019a: move stabelized items out of @beta

Related Objects
Search...

bu5hm4n created this task.May 3 2019, 11:13 AM
bu5hm4n triaged this task as TODO priority.
zmike moved this task from Backlog to Needs experts on the efl: api board.Jun 12 2019, 7:38 AM
zmike added a comment.Oct 1 2019, 9:39 AM

The proposed rework:

interface Efl2.Text.Wrap.Properties
├ (P) ellipsis
├ (P) wrap

Previous API has been moved to other classes.

zmike added a comment.Oct 1 2019, 9:40 AM

This needs doc work, but so does everything else. Seems good.

segfaultxavi added a comment.Nov 19 2019, 2:16 AM

I am unsure what are the plans for Efl.Text.Format, but having Format and Style interfaces is very confusing. We should find names that indicate what kind of properties each of these interfaces hold.

ali.alzyod updated the task description. (Show Details)Dec 20 2019, 12:59 AM
ali.alzyod moved this task from Needs experts to Evaluating on the efl: api board.
ali.alzyod added a subscriber: ali.alzyod.Dec 20 2019, 1:03 AM

@segfaultxavi should we update

├ (P) linegap
├ (P) linerelgap

to have text_ in front?

segfaultxavi added a comment.Dec 20 2019, 3:16 AM

Hmmmmm... I think Line already acts as a sort of prefix. Looks clear enough to me as it is.

Except that I would add an underscore to line_gap, line_rel_gap and tab_stops, like the other properties, of course :)

ali.alzyod added a revision: D10963: efl_text_format: rename tabstops,lingap,linerelgap.EditedDec 23 2019, 11:26 PM
In T7856#148507, @segfaultxavi wrote:

Except that I would add an underscore to line_gap, line_rel_gap and tab_stops, like the other properties, of course :)

Done in D10963

This is should be ready to stabilize, any comments ?

woohyun added a comment.Dec 26 2019, 1:07 AM

D10963 is updated, and it looks good for now.

Any other opinions on this subject ?

segfaultxavi added a comment.Dec 27 2019, 3:45 AM

Looks good to me!

woohyun added a comment.Dec 30 2019, 5:51 PM

Let's move this to "stabilized !" Thanks :)

woohyun moved this task from Evaluating to Stabilized on the efl: api board.Dec 30 2019, 5:51 PM