Page MenuHomePhabricator

efl.text_style
Open, TODOPublic

Description

| |interface Efl.Text_Style @beta
| |├ (P) normal_color
| |├ (P) backing_type
| |├ (P) backing_color
| |├ (P) underline_type
| |├ (P) underline_color
| |├ (P) underline_height
| |├ (P) underline_dashed_color
| |├ (P) underline_dashed_width
| |├ (P) underline_dashed_gap
| |├ (P) underline2_color
| |├ (P) strikethrough_type
| |├ (P) strikethrough_color
| |├ (P) effect_type
| |├ (P) outline_color
| |├ (P) shadow_direction
| |├ (P) shadow_color
| |├ (P) glow_color
| |├ (P) glow2_color
| |├ (P) gfx_filter
bu5hm4n created this task.May 3 2019, 11:14 AM
bu5hm4n triaged this task as TODO priority.
zmike moved this task from Backlog to Needs experts on the efl: api board.Jun 12 2019, 7:38 AM
zmike added a comment.Oct 1 2019, 9:20 AM

The proposed rework:

interface Efl2.Text.Style.Properties
├ (P) foreground_color
├ (P) background_type
├ (P) background_color
├ (P) underline_type
├ (P) underline_color
├ (P) underline_height
├ (P) underline_dashed_color
├ (P) underline_dashed_width
├ (P) underline_dashed_gap
├ (P) underline2_color
├ (P) strikethrough_type
├ (P) strikethrough_color
├ (P) effect_type
├ (P) outline_color
├ (P) shadow_direction
├ (P) shadow_color
├ (P) glow_color
├ (P) glow2_color
├ (P) gfx_filter
├ (P) halign_auto_type
├ (P) halign
├ (P) valign
├ (P) line_spacing
├ (P) line_spacing_factor
├ (P) line_height
├ (P) line_height_factor
├ (P) tab_width
zmike added a comment.EditedOct 1 2019, 9:27 AM
├ (P) underline2_color
├ (P) glow2_color

These seem like they should be renamed to something clearer.

The changes are:

  • rename the color properties (good imo)
  • add these properties
├ (P) halign_auto_type

I think the idea here is that you have the option of 1) disabling it 2) respecting the internal property value from being set in API 3) autodetecting it based on locale. I'm not sure why 3 exists, however, since it seems like 2 should be applied based on the locale? Confusing.

├ (P) halign
├ (P) valign

These properties seem duplicated around a few times in the text APIs; I'm not sure I see a need for this beyond using the content_align property at a higher level unless I'm missing something?

├ (P) line_spacing

This is pixels?

├ (P) line_spacing_factor
├ (P) line_height

This is pixels?

├ (P) line_height_factor
├ (P) tab_width

Should probably be uint type?