Page MenuHomePhabricator

efl.ui.image
Open, TODOPublic

Description

class Efl.Ui.Image @beta
├ (P) scalable
├ (P) align
├ (P) icon
├ (E) drop

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedsegfaultxavi
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
Resolvedbu5hm4n
InvalidNone
InvalidNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
bu5hm4n created this task.May 3 2019, 11:31 AM
bu5hm4n triaged this task as TODO priority.
zmike moved this task from Backlog to Evaluating on the efl: api board.Wed, Jun 12, 9:43 AM

also includes:

struct @beta Efl.Ui.Image_Progress
{
   [[
     Structure associated with smart callback 'download,progress'.
   ]]
   now:   double; [[Current percentage]]
   total: double; [[Total percentage]]
}

struct @beta Efl.Ui.Image_Error
{
   [[
     Structure associated with smart callback 'download,progress'.
   ]]
   status:     int; [[Error status of the download]]
   open_error: bool; [[$true if the error happened when opening the file, $false otherwise]]
}
zmike added a comment.Wed, Jun 12, 9:47 AM

The progress struct seems okay, the error struct is weird and I hate it; if there's no error then the status should be 0 since that's how Eina_Error works (and status is an Eina_Error), and there should be no bool.

Also worth noting that these structs are emitted from io copier events.

Sorry, but the concept of Total percentage confuses me. Isn't that always 100 by definition?

If status is an Eina_Error, shouldn't the eo file reflect it? If it cannot, then I think we have a critical dependency here which needs fixing before anything else.

I am wondering if we could not get rid of Efl.Ui.Image_Error and just use Eina_Error.

As for total percentage, if I remember correctly it is to reflect the multiple step of loading the image. You could be on a 50% of the downloading, but there is still decompressing, uploading texture and so on, so total percentage might be 25% with no indication on time that it would take to do the other percent.

I am wondering if we could not get rid of Efl.Ui.Image_Error and just use Eina_Error.

+1

As for total percentage, if I remember correctly it is to reflect the multiple step of loading the image. You could be on a 50% of the downloading, but there is still decompressing, uploading texture and so on, so total percentage might be 25% with no indication on time that it would take to do the other percent.

Then that needs a different name (and better docs). Even with your description it is still confusing :D

zmike added a comment.Fri, Jun 14, 7:14 AM

I am wondering if we could not get rid of Efl.Ui.Image_Error and just use Eina_Error.

As for total percentage, if I remember correctly it is to reflect the multiple step of loading the image. You could be on a 50% of the downloading, but there is still decompressing, uploading texture and so on, so total percentage might be 25% with no indication on time that it would take to do the other percent.

According to efl io copier internals, the total value is always based on the size of the buffer, which in this case means that total should always be 100...