Page MenuHomePhabricator

efl.ui.slider
Open, TODOPublic

Description

class Efl.Ui.Slider @beta
├ (E) changed
├ (E) delay,changed
├ (E) slider,drag,start
├ (E) slider,drag,stop

Related Objects

StatusAssignedTask
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
bu5hm4n created this task.May 3 2019, 11:55 AM
bu5hm4n triaged this task as TODO priority.
zmike added a comment.Wed, Jun 12, 9:49 AM

The changed events should send the current value, otherwise I guess this is okay?

Also there's the delay,changed event; should this be changed,delay or something instead?

zmike moved this task from Backlog to Evaluating on the efl: api board.Wed, Jun 12, 9:49 AM

I had to look at the code to understand what is delay,changed.
This is emitted 0.2s after the slider stops moving. Every time the slider moves, the timer is restarted.
There's no doc about this, but thanks to my background in GStreamer I know this is useful to delay any expensive action (like seeking on a media stream) until the user stops scrubbing the slider up and down.

So, armed with this knowledge, I propose we rename this event to changed,stable.
I don't think delayed is a good name, since I would expect to receive as many delayed events as changed events (only later).

zmike added a comment.Thu, Jun 13, 9:13 AM

That's a good point, but stable has sort of a weird feel to it as well.

I think stable conveys the exact meaning, but that might be my signal processing background.
stabilized instead of changed?
changed,steady?

zmike added a comment.Thu, Jun 13, 9:35 AM

I think the issue for me is that changed is still in the signal name, and changed implies that a change was completed. Having changed,stable or similar is weird because it implies that regular changed events are not "complete".

So just steady? How about that?

zmike added a comment.Fri, Jun 14, 6:48 AM

I think that's also not quite what we want either?