Page MenuHomePhabricator
Create Task
Maniphest T7895

efl.ui.range_display
Closed, ResolvedPublic
Actions

Description

| |interface Efl.Ui.Range_Display @beta
| |├ (P) range_value
| |├ (P) range_limits
  • Move changed min,reached max,reached here, add spec test suite for it.

Details

Differential Revisions
D9242: efl_ui_spec_suite: introduce two new test suites
Commits
D10008 / rEFLda594413bef4: declare first round of classes stable
D9372 / rEFL8f7fa82244dd: efl_ui_*: add the new events to the widgets
D9373 / rEFL14ff01060154: efl_ui_spec: add test suite for range_display events
D9371 / rEFLc0082b1c71ed: efl_ui_range_display: move events from spin
rEFLe922a23ddf3f: efl_ui_spec_suite: introduce two new test suites
D9110 / rEFL969c7f72877c: efl_ui_range_display: range_min_max -> range_limits

Related Objects
Search...

StatusAssignedTask
 ResolvedNoneT8097 efl_ui_spin_button
 ResolvedNoneT7897 efl.ui.spin
 ResolvedNoneT7893 efl.ui.slider
 ResolvedNoneT7894 efl.ui.range_interactive
 ResolvedNoneT7895 efl.ui.range_display
bu5hm4n created this task.May 3 2019, 11:55 AM
bu5hm4n triaged this task as TODO priority.
woohyun added a comment.Jun 18 2019, 1:10 AM

Except the wondering why this interface needs to be separated with efl.ui.range_interactive (T7894),
this looks ok for me.

bu5hm4n added a comment.Jun 18 2019, 1:27 AM

A few interfaces are only implementing efl.ui.range_display, others are implementing efl.ui.range_interactive. If we would not have this split, we would have a lot of unimplemented API.

woohyun added a comment.Jun 18 2019, 1:31 AM

Woops. I missed the extension relation between two interfaces.
That is, "Efl.Ui.Range_Interactive extends Efl.Ui.Range_Display"

Then, I am ok with current status.

segfaultxavi added a comment.Jun 18 2019, 2:17 AM

This looks OK to me too. Docs need polishing, as usual.

bu5hm4n moved this task from Backlog to Stabilized on the efl: api board.Jun 18 2019, 2:20 AM
zmike added a comment.Jun 18 2019, 8:59 AM

Do we want to perhaps rename range_min_max to range_limits?

segfaultxavi added a comment.Jun 18 2019, 9:16 AM

We seem to have far more properties in our API with limit than with min_max, so OK, I buy that.

zmike added a comment.Jun 25 2019, 6:20 AM

This seems okay now

bu5hm4n added a comment.Jul 10 2019, 8:13 AM

Events should be moved here. lets keep this out of stabilization for now.

bu5hm4n moved this task from Stabilized to Trivial on the efl: api board.Jul 10 2019, 8:14 AM
bu5hm4n updated the task description. (Show Details)Jul 12 2019, 6:15 AM

We might want to check, if setting limits to the same value (min=max) results in the implementor beeing disabled?

woohyun added a comment.EditedJul 13 2019, 1:35 AM
In T7895#138264, @bu5hm4n wrote:

We might want to check, if setting limits to the same value (min=max) results in the implementor beeing disabled?

@bu5hm4n

If you are meaning that "setting min = max" will call efl_ui_widget_disabled_set(obj, EINA_TRUE),
I don't like the way because I cannot imagine what would be happened when efl_ui_widget_enabled_set would be called on that.

I think just making the button (on the efl_ui_slider) not be movable on the slider looks enough.

bu5hm4n added a comment.Jul 22 2019, 3:10 AM

Okay - lets forget about this idea for now :)

bu5hm4n updated the task description. (Show Details)Jul 31 2019, 1:46 AM
bu5hm4n added a comment.Jul 31 2019, 4:10 AM

Looks good i think?

segfaultxavi added a comment.Jul 31 2019, 5:00 AM

Yeah, I think so too.

bu5hm4n moved this task from Trivial to Stabilized on the efl: api board.Jul 31 2019, 5:07 AM