Page MenuHomePhabricator
Create Task
Maniphest T7897

efl.ui.spin
Open, TODOPublic
Actions

Description

class Efl.Ui.Spin @beta
├ (P) special_value
├ (E) changed
├ (E) min,reached
├ (E) max,reached

Related Objects
Search...

StatusAssignedTask
 OpenNoneT7510 evaluate stabilization potential of efl.ui classes and dependencies
 OpenNoneT7897 efl.ui.spin
 OpenNoneT7894 efl.ui.range_interactive
 OpenNoneT7895 efl.ui.range_display
 OpenNoneT7896 efl.access.value
 OpenNoneT7586 efl.access.widget.action
 OpenNoneT7898 efl.ui.format
 OpenNoneT7562 efl.input.interface
 OpenNoneT7963 Efl.Input.Pointer
 OpenNoneT7973 Efl.Input.Value
 OpenNoneT7964 Efl.Input.Key
 Resolvedbu5hm4nT7968 Efl.Input.State
 InvalidNoneT7971 Efl.Input.Lock
 InvalidNoneT7972 Efl.Input.Modifier
 OpenNoneT7965 Efl.Input.Hold
 OpenNoneT7967 Efl.Input.Event
 OpenNoneT7969 Efl.Input.Device
 OpenNoneT7970 Efl.Input.Device_Type
 OpenNoneT7912 enum Efl.Input.Object_Pointer_Mode
 OpenNoneT7573 efl.ui.l10n
 OpenNoneT7566 efl.ui.i18n
 OpenNoneT7574 efl.ui.selection
 OpenNoneT7913 function Efl.Ui.Selection_Data_Ready
 OpenNoneT7914 struct Efl.Ui.Selection_Changed
 OpenNoneT7915 enum Efl.Ui.Selection_Type
 OpenNoneT7916 enum Efl.Ui.Selection_Format
 OpenNoneT7578 efl.ui.view
 OpenNoneT7917 enum Efl.Ui.Activate
 OpenNoneT7919 enum Efl.Orient
bu5hm4n created this task.May 3 2019, 11:58 AM
bu5hm4n triaged this task as TODO priority.
bu5hm4n added a subtask: T7894: efl.ui.range_interactive.
bu5hm4n added a subtask: T7896: efl.access.value.
bu5hm4n added a subtask: T7586: efl.access.widget.action.
zmike added a comment.Wed, Jun 12, 9:49 AM
struct @beta Efl.Ui.Spin_Special_Value
{
   [[Special value]]
   value: double; [[Target value]]
   label: string; [[String to replace]]
}
zmike added a comment.Wed, Jun 12, 9:50 AM

This special_value is pretty weird. It feels like it should be a format thing?

zmike moved this task from Backlog to Evaluating on the efl: api board.Wed, Jun 12, 9:51 AM
bu5hm4n added a comment.Wed, Jun 12, 5:32 PM

Totally agreed. I think we should have simply implemented the format mixin on this here...

bu5hm4n added a comment.Thu, Jun 13, 1:18 AM

The min max events, should they be on the range interactive interface ?

zmike added a comment.Thu, Jun 13, 6:11 AM

I agree with both of the above ideas.

segfaultxavi added a comment.Thu, Jun 13, 8:17 AM

How would you implement the special values with a format string? The Efl.Ui.Format mixin is still beta and I do not understand how format_string and format_cb interact.

Also, the min,max events belong to the Efl.Ui.Range_Display interface, since it's the one actually defining the min and max values, and the range value. The docs for Range_Display are all wrong, btw 😢

zmike added a comment.Fri, Jun 14, 7:15 AM

I agree with both of the above ideas.

segfaultxavi added a comment.Fri, Jun 14, 8:25 AM

And I still don't know how would you implement the special values with a format string.

zmike added a comment.Fri, Jun 14, 9:07 AM

I think you would use the callback?

segfaultxavi added a comment.Fri, Jun 14, 9:18 AM

I've written my concerns in T7898.

segfaultxavi added a comment.Tue, Jun 18, 2:32 AM

OK, I think the special_value property is redundant if we use the Efl.Ui.Format mixin. Probably a leftover from older times.

How about we remove special_value from here and we study if it is worth adding it to Efl.Ui.Format?

zmike added a comment.Tue, Jun 18, 9:00 AM

I think it's a corner case. This should be handled through the callback I think, if I'm remembering correctly how that works.

segfaultxavi added a comment.Tue, Jun 18, 9:18 AM

The callback can handle every case. format_string is useful for printf-like strings, and I think special_value could be beneficial too.
I would not consider it a corner case, since that is how spinners with weekday names, or month names are implemented.

zmike added a comment.Tue, Jun 18, 9:24 AM

Yea I read this before I saw the format ticket comments.