class Efl.Ui.Timepicker @beta ├ (P) time ├ (P) ampm ├ (E) changed
- ampm -> is_24hour (WooHyun)
- changed -> time,changed
class Efl.Ui.Timepicker @beta ├ (P) time ├ (P) ampm ├ (E) changed
Status | Assigned | Task | ||
---|---|---|---|---|
Resolved | CHAN | T7901 efl.ui.timepicker | ||
Open | None | T7912 enum Efl.Input.Object_Pointer_Mode | ||
Open | None | T7573 efl.ui.l10n | ||
Open | None | T7566 efl.ui.i18n | ||
Open | None | T7574 efl.ui.selection | ||
Open | None | T7913 function Efl.Ui.Selection_Data_Ready | ||
Open | None | T7914 struct Efl.Ui.Selection_Changed | ||
Open | None | T7915 enum Efl.Ui.Selection_Type | ||
Open | None | T7916 enum Efl.Ui.Selection_Format | ||
Resolved | None | T7578 efl.ui.view | ||
Open | None | T7917 enum Efl.Ui.Activate | ||
Resolved | None | T7919 enum Efl.Orient |
Yes, I like 24hour much better. Also, the parameter to the ampm property is already called 24hour :D
Following the comments in T7869, I'll not change to "current_time" :)
I'll just update 24hour, soon.
While trying to apply "24hour", I noticed that eolian does not allow to include <number> in a property name !!
eolian: /home/woohyun/EFL/efl/src/lib/elementary/efl_ui_timepicker.eo:26:17: '<value>' expected near '<number>' @property 24hour { ^ eolian: could not parse file '../src/lib/elementary/efl_ui_timepicker.eo' [10/2626] Linking target src/bin/edje/edje_cc. ninja: build stopped: subcommand failed.
Do you have any idea on this ?
Ooooohhhh... that's interesting. I guess it makes sense, since C does not allow that either.
How about use24hour, use24h, format24hour or format24h ?
Hmm. As you know well, I'm not a good person for naming something. :(
My recommendation -
Let's see what other people think. We have other properties named is_, so is_24hour seems good to me too.
I think only one thing remained is "changed" which has the same discussion in T7869.
Or any other opinions on this task ?