Page MenuHomePhabricator

enum Efl.Ui.Select_Mode
Open, TODOPublic

Description

enum @beta Efl.Ui.Select_Mode {
   [[Type of multi selectable object.]]
   single, [[Only single child is selected. if the child is selected,
             previous selected child will be unselected.]]
   single_always, [[Same as single select except, this will be selected
                    in every select calls though child is already been selected.]]
   multi, [[allow multiple selection of children.]]
   none [[Last value of select mode. child cannot be selected at all.]]
}
segfaultxavi triaged this task as TODO priority.

I hope we separate the single select option and select mode,

select, select_multi, select_none is considered as select_mode.

I personally think there are two way of selection,
one is toggle,
click once, selected, click again, unselected.
the other way is button,
click once, selected, click again, select again.

child propagation is another topic,

so we tied these three different concept in one select_mode which is very confusing..
I want to separate them in each own enum so that user can combine them and use it properly.

It seems that this task is related to T8057.

@SanghyeonLee I think i do not understand what you mean. This enum just tells if we allow single / multi / or emit everytime a event when something is single selected again ?

@SanghyeonLee
Could you give a reply on question of @bu5hm4n ?

I think i do not understand what you mean. This enum just tells if we allow single / multi / or emit everytime a event when something is single selected again ?

zmike moved this task from Backlog to Evaluating on the efl: api board.Sep 16 2019, 7:22 AM

After further explanation from @SanghyeonLee i am understanding what he is meaning, can we mark single_always as explcitly beta, or can we remove it ? (Everyone okay with that ?)

SanghyeonLee added a comment.EditedSep 17 2019, 1:24 AM

I'm good of removing or beta(can we make one enum value for beta?)
one little problem is, if we push it again in the select_mode after all discussion,
enum value will be single = 0 multi = 1 none = 2 single_always = 3
seems wierd...
but I think it should not in the select_mode that is my opinion :)

zmike added a comment.Sep 17 2019, 5:17 AM

I agree with this removal. The "always" select mode seems like it should be something entirely different, e.g., "the widget can have any number of items selected, but it must always have at least one item selected".

Its gone :) So this is now fine ?

@zmike

GTK_SELECTION_BROWSE

Exactly one element is selected. In some circumstances, such as initially or during a search operation, it’s possible for no element to be selected with GTK_SELECTION_BROWSE. What is really enforced is that the user can’t deselect a currently selected element except by selecting another element.

our select mode is quite similar of gtk selection mode and they have browse mode exactly same like you said :)

zmike added a comment.Sep 17 2019, 5:36 AM

@SanghyeonLee Ah, this is a nice reference to have, thank you for providing it.

I think this enum should be fine now.

I think now it is ready to out of beta.

it is beta for this release version same as T7871
the mode itself is stable but it must comes with multi_selectable.