Page MenuHomePhabricator

enum Efl.Gfx.Border_Fill_Mode
Closed, ResolvedPublic

Description

enum @beta Efl.Gfx.Border_Fill_Mode
{
   [[How an image's center region (the complement to the border region) should be rendered by EFL]]
   none = 0, [[Image's center region is $not to be rendered]]
   default = 1, [[Image's center region is to be $blended with objects underneath it, if it has transparency. This is the default behavior for image objects]]
   solid = 2 [[Image's center region is to be made solid, even if it has transparency on it]]
}

Related Objects

StatusAssignedTask
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
segfaultxavi triaged this task as TODO priority.

This naming seems objectively terrible. What does "border fill" mean to anyone?

zmike moved this task from Backlog to Trivial on the efl: api board.Aug 30 2019, 11:10 AM

This is what "border fill" means, doh!
https://i.ytimg.com/vi/1Lm1-96k-6g/maxresdefault.jpg

Jokes aside, the property using that enum in Efl.Gfx.Image is even worse: border_center_fill.
This was part of a series of properties prefixed border_, so I guess it made sense in somebody's mind.

I propose to rename this enum simply to Fill_Mode, and I'll make more change proposals to Efl.Gfx.Image's properties.

zmike added a comment.Sep 2 2019, 5:42 AM

I think the origin of this is that EFL specifies opaque regions in images by setting the "border" around the image instead of the actual opaque region (the inverse of how everyone else does it).

Fill_Mode seems like a much clearer name and intent.

zmike added a comment.Sep 23 2019, 7:18 PM

Renamed and done.

zmike moved this task from Trivial to Stabilized on the efl: api board.Sep 23 2019, 7:18 PM