Page MenuHomePhabricator

struct Efl.Text_Change_Info
Closed, ResolvedPublic

Description

struct @beta Efl.Text_Change_Info {
   [[This structure includes all the information about content changes.

     It's meant to be used to implement undo/redo.
   ]]
   content: string; [[The content added/removed]]
   position: size; [[The position where it was added/removed]]
   length: size; [[The length of content in characters (not bytes, actual unicode characters)]]
   insert: bool; [[$true if the content was inserted, $false if removei]]
   merge: bool; [[$true if can be merged with the previous one. Used for example with insertion when something is already selected]]
}
segfaultxavi triaged this task as TODO priority.
zmike moved this task from Backlog to Needs experts on the efl: api board.Jun 12 2019, 7:39 AM
ali.alzyod renamed this task from struct Efl.Ui.Text_Change_Info to struct Efl.Text_Change_Info.Dec 20 2019, 12:55 AM
ali.alzyod updated the task description. (Show Details)
ali.alzyod moved this task from Needs experts to Evaluating on the efl: api board.

"insert" looks a bit weird. I like "inserted"
"merge" is also ambiguous. How about "can_merge" or something else.

@segfaultxavi @ali.alzyod
Do you have better idea on these ?

Aside from the two above, the rest looks good to me.

I suggest insertion and mergeable.

The rest looks OK to me, except the docs, as usual :)

@segfaultxavi

I just updated following your recommendation :)

Another opinion on this definition ?

Ok. I think there is no problem to move this task to "stabilized".

Thank you !!!!

woohyun moved this task from Evaluating to Stabilized on the efl: api board.Jan 7 2020, 5:55 PM