Page MenuHomePhabricator

enum Efl.Text_Style_Background_Type
Closed, ResolvedPublic

Description

enum @beta Efl.Text_Style_Background_Type
{
   [[Whether to apply backing style to the displayed text or not]]
   none = 0, [[Do not use Background]]
   solid_color,     [[Use solid color Background style]]
}
segfaultxavi triaged this task as TODO priority.

Way to go, doc writers! WTF is "backing"???

zmike moved this task from Backlog to Needs experts on the efl: api board.Jun 12 2019, 7:40 AM
ali.alzyod renamed this task from enum Efl.Text_Style_Backing_Type to enum Efl.Text_Style_Background_Type.Dec 20 2019, 12:53 AM
ali.alzyod updated the task description. (Show Details)
ali.alzyod moved this task from Needs experts to Evaluating on the efl: api board.

This is should be ready to stabilize, any comments ?

I think this one is good to go. This could be implemented with a simple boolean, but an enum is more future-proof. Doc are already reviewed.

I think this one is good to go. This could be implemented with a simple boolean, but an enum is more future-proof. Doc are already reviewed.

we can change enable to be color, where the background will be represented from background_color property, and in future, there will be more enums. what do you think?

Without some idea of what these future modes might be it's hard to find a good name for this one.
But you are right that if the current values are enabled and disabled there's little room for future values.
How about solid_color, solid_rectangle, color_rectangle?

solid color seems more appropriate
D10967

ali.alzyod updated the task description. (Show Details)Dec 26 2019, 10:29 PM

I closed D10967 ~ and now the definition looks good :)

Another opinion ??

Let's move this to "stabilized" !!! :)

woohyun moved this task from Evaluating to Stabilized on the efl: api board.Jan 3 2020, 2:38 AM