Page MenuHomePhabricator

CI test failure
Closed, ResolvedPublic


textblock tests are failing on travis after the recent textblock variation patch was merged:

This patch fixes it on travis, but it is then broken locally:

diff --git a/src/tests/evas/evas_test_textblock.c b/src/tests/evas/evas_test_textblock.c
index f826a481c7..8a5e4ff9bb 100644
--- a/src/tests/evas/evas_test_textblock.c
+++ b/src/tests/evas/evas_test_textblock.c
@@ -4139,7 +4139,8 @@ EFL_START_TEST(evas_textblock_variation_sequence)
    evas_object_textblock_size_formatted_get(tb, &fw, &fh);
    evas_object_textblock_text_markup_set(tb, str2);
    evas_object_textblock_size_formatted_get(tb, &fw_new, &fh_new);
-   fail_if(fw_new == fw && fh_new == fh);
+   ck_assert_int_eq(fw_new, fw);
+   ck_assert_int_eq(fh_new, fh);

I don't know what's going on here, but this needs to be fixed asap.

zmike created this task.Jul 30 2019, 6:56 AM
zmike triaged this task as Showstopper Issues priority.

This is dependant on system, font file.

I will update to add font file with the test

Is it okay for you if we just do a revert and resubmit the patch with the added testfile ?

Is it possible to comment testing part, then fix testing in separate patch ?

For now its reverted, can you update the revision ?

Sure, thank you

ali.alzyod closed this task as Resolved.Aug 15 2019, 1:31 AM