Page MenuHomePhabricator

efl_ui_spin_button
Closed, ResolvedPublic

Description

class Efl.Ui.Spin @beta
├ (P) circulate
├ (P) editable

Related Objects

StatusAssignedTask
ResolvedNone
ResolvedNone
ResolvedNone
ResolvedNone
OpenNone
OpenNone
ResolvedCHAN
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
OpenNone
ResolvedNone
OpenNone
ResolvedNone
bu5hm4n created this task.Jul 31 2019, 6:18 AM
bu5hm4n triaged this task as TODO priority.
bu5hm4n added a subtask: T7897: efl.ui.spin.

We have all worked way too much on this widget now and we are all sick of it.
However...

How about wraparound instead of circulate?
Also, editable-text instead of editable? Because the value is always editable (through buttons, keyboard, mouse wheel), but this property is about editing the text.

how about "text_edit" ? I like the other one.

I also like wraparound.

For me, "text_editable" looks a bit better. How do you think about this ?

@bu5hm4n @segfaultxavi

Are you ok with "wraparound" and "text_editable" ?
Then, I'll add action items, and will do by my own soon.

Sounds good to me :)

I'm OK with wraparound but I really think editable_text is better than text_editable (adjective before noun).
Another option is text_is_editable.

@zmike @bu5hm4n @segfaultxavi

Hmm. I am still confused which one is better.
And, I could not find similar names in other platforms, so it is much difficult problem for me.
(Plus, I'm not that good person for naming !!)

  1. efl_ui_spin_button_editable_text_set(obj, EINA_TRUE);
  2. efl_ui_spin_button_text_editable_set(obj, EINA_TRUE);
  3. efl_ui_spin_button_text_is_editable_set(obj, EINA_TRUE);
  1. spinButton.SetEditableText(true); (=> spinButton.EditableText = true;)
  2. spinButton.SetTextEditable(true); (=> spinButton.TextEditable = true;)
  3. spinButton.SetTextIsEditable(true); (=> spinButton.TextIsEditable = true;)

Which one looks better ?
Let's do vote !! :)

hmmmm... I don't like any of them, I am a horrible person :)

  • EditableText looks like this property should be text, not a boolean
  • TextEditable sounds weird in English
  • TextIsEditable sounds best to me, but we have nothing like this in the current API
  • Editable sounds like the opposite of Enabled

Maybe we need to take a step back. How about DirectInput, DirectTextInput, EditableTextEntry, EditableTextBox... ?

direct_text_input +1

@segfaultxavi

You are not such a horrible person :)

I also bet to "direct_text_input".

My last comment! EnableDirectTextInput?

I think its quite clear that a boolean flag is either to turn it on or off, DirectTextInput (direct_text_input) sounds very good to me :)

bu5hm4n moved this task from Backlog to Evaluating on the efl: api board.Aug 22 2019, 6:45 AM

I think this can be a candidate for stabilized one. :)

bu5hm4n moved this task from Evaluating to Stabilized on the efl: api board.Aug 25 2019, 11:13 PM
zmike moved this task from Stabilized to Evaluating on the efl: api board.Sep 20 2019, 11:19 AM

I don't know if this can be stabilized now. It uses an elm_entry internally (legacy) and then has a custom theme for that entry which inherits from efl/text, the theme for Efl.Ui.Text, which is not stable.

How about we are simply declaring "direct_text_input" beta for now ? That would mean that the object is themed, but not displayed, which is not blocking the whole widget ?

zmike added a comment.Sep 23 2019, 8:55 AM

Would need to see if that's acceptable with @woohyun @Jaehyun_Cho for now. It's possible that we could replace this implementation post-release if there is a usable eo-based text widget then, but I have not gotten a reply for anyone about this issue on the mailing list thread or T8231 so imo there's no way to move forward here.

@zmike
I also think there is no way except to mark it @beta.
But I hope it would be handled just after completion of Tom's work.

Alright, i will mark this property explicitly beta.

zmike added a comment.Sep 24 2019, 1:52 PM

Alright, we're leaving this for when text stuff is done just after 1.23.

Oh right I forgot how we were doing this.

So, could we go to the stabilized column now ? :)

zmike moved this task from Evaluating to Stabilized on the efl: api board.Sep 24 2019, 9:53 PM

@zmike

You there Thanks :)

zmike added a comment.Sep 24 2019, 9:56 PM

Need to get all these stabilization patches landed today!