class Efl.Ui.Spin @beta ├ (P) circulate ├ (P) editable
Description
Details
- Differential Revisions
- D10008: declare first round of classes stable
- Commits
- D10152 / rEFLb7ed1901d56b: api: mark Efl.Ui.Spin_Button stable
D10140 / rEFL14a6dd6ab0e5: efl_ui_spin_button: mark "direct_text_input" property @beta
D9474 / rEFL42bbe0e58ffc: efl_ui_spin_button: fix initial displaying of formatting string
D9461 / rEFLfd860eb6e80d: efl_ui_spin_button: rename circulate to wraparound
D9459 / rEFL45b763a2dc2a: efl_ui_spin_button: use the newly emitted event from range_interactive
Status | Assigned | Task | ||
---|---|---|---|---|
Resolved | None | T8097 efl_ui_spin_button | ||
Resolved | None | T7897 efl.ui.spin | ||
Resolved | None | T7894 efl.ui.range_interactive | ||
Resolved | None | T7895 efl.ui.range_display | ||
Open | None | T7896 efl.access.value | ||
Open | None | T7586 efl.access.widget.action | ||
Resolved | CHAN | T7898 efl.ui.format | ||
Open | None | T7912 enum Efl.Input.Object_Pointer_Mode | ||
Open | None | T7573 efl.ui.l10n | ||
Open | None | T7566 efl.ui.i18n | ||
Open | None | T7574 efl.ui.selection | ||
Open | None | T7913 function Efl.Ui.Selection_Data_Ready | ||
Open | None | T7914 struct Efl.Ui.Selection_Changed | ||
Open | None | T7915 enum Efl.Ui.Selection_Type | ||
Open | None | T7916 enum Efl.Ui.Selection_Format | ||
Resolved | None | T7578 efl.ui.view | ||
Open | None | T7917 enum Efl.Ui.Activate | ||
Resolved | None | T7919 enum Efl.Orient |
We have all worked way too much on this widget now and we are all sick of it.
However...
How about wraparound instead of circulate?
Also, editable-text instead of editable? Because the value is always editable (through buttons, keyboard, mouse wheel), but this property is about editing the text.
I also like wraparound.
For me, "text_editable" looks a bit better. How do you think about this ?
Are you ok with "wraparound" and "text_editable" ?
Then, I'll add action items, and will do by my own soon.
I'm OK with wraparound but I really think editable_text is better than text_editable (adjective before noun).
Another option is text_is_editable.
Hmm. I am still confused which one is better.
And, I could not find similar names in other platforms, so it is much difficult problem for me.
(Plus, I'm not that good person for naming !!)
- efl_ui_spin_button_editable_text_set(obj, EINA_TRUE);
- efl_ui_spin_button_text_editable_set(obj, EINA_TRUE);
- efl_ui_spin_button_text_is_editable_set(obj, EINA_TRUE);
- spinButton.SetEditableText(true); (=> spinButton.EditableText = true;)
- spinButton.SetTextEditable(true); (=> spinButton.TextEditable = true;)
- spinButton.SetTextIsEditable(true); (=> spinButton.TextIsEditable = true;)
Which one looks better ?
Let's do vote !! :)
hmmmm... I don't like any of them, I am a horrible person :)
- EditableText looks like this property should be text, not a boolean
- TextEditable sounds weird in English
- TextIsEditable sounds best to me, but we have nothing like this in the current API
- Editable sounds like the opposite of Enabled
Maybe we need to take a step back. How about DirectInput, DirectTextInput, EditableTextEntry, EditableTextBox... ?
I think its quite clear that a boolean flag is either to turn it on or off, DirectTextInput (direct_text_input) sounds very good to me :)
I don't know if this can be stabilized now. It uses an elm_entry internally (legacy) and then has a custom theme for that entry which inherits from efl/text, the theme for Efl.Ui.Text, which is not stable.
How about we are simply declaring "direct_text_input" beta for now ? That would mean that the object is themed, but not displayed, which is not blocking the whole widget ?
Would need to see if that's acceptable with @woohyun @Jaehyun_Cho for now. It's possible that we could replace this implementation post-release if there is a usable eo-based text widget then, but I have not gotten a reply for anyone about this issue on the mailing list thread or T8231 so imo there's no way to move forward here.
@zmike
I also think there is no way except to mark it @beta.
But I hope it would be handled just after completion of Tom's work.