Page MenuHomePhabricator

C#: Remove I prefix from regular classes
Closed, ResolvedPublic

Description

  1. 'I' prefix for Interface only
    • Now : class or abstract may begin with prefix 'I' e.g. public class IEntityVisibilityChangedEvt_Args (this is related to interface IEntity)
    • Suggested : class and abstract should not begin with prefix 'I' e.g. public class EntityVisibilityChangedEventArgs

This happens mostly on Evt_Args classes

lauromoura triaged this task as High priority.

The interface name was added to the struct name in order to avoid collisions between event arg structures with the same name. Removing this prefix leads at least to the following clashes:

  • message event
    • Efl.Loop_Message
    • Efl.Loop_Message_Handler
  • item,selected event
    • Efl.Ui.Tags
    • Efl.Ui.Container_Selectable
  • item,longpressed event
    • Efl.Ui.Tags
    • Efl.Ui.Collection
  • item,clicked event
    • Efl.Ui.Tags
    • Efl.Ui.Collection

Just to be sure, we're talking about removing the I prefix from the EventArgs classes, no? This makes sense.

Just to be sure, we're talking about removing the I prefix from the EventArgs classes, no? This makes sense.

Yeah yeah. Originally this task was about removing just the I prefix. I was wondering if we could strip the interface name completely instead.

Can we change this task name?

C#: Remove I prefix from argument structs for class events -> C#: Remove 'I' prefix from all names which are not interface

Because the original suggestion is to remove 'I' prefix from all names which are not interface.

lauromoura renamed this task from C#: Remove I prefix from argument structs for class events to C#: Remove I prefix from regular classes.Aug 30 2019, 5:58 AM
lauromoura updated the task description. (Show Details)
lauromoura closed this task as Resolved.Sep 9 2019, 2:04 PM

Resolved in D9816