Page MenuHomePhabricator
Create Task
Maniphest T8331

C#: Fix stylecop warnings
Open, NormalPublic
Actions

Description

Umbrella task for the stylecop violations in EFL# reported by Tizen.

Related Objects
Search...

StatusAssignedTask
 OpenfelipealmeidaT8331 C#: Fix stylecop warnings
 OpenfelipealmeidaT8332 C#: Stylecop CA1721: The property name 'XYZ' is confusing given the existence of method 'GetVisible'. Rename or remove one of these members
 OpenbrunobeloT8333 C#: Stylecop CA1707: Remove the underscores from type name
 ResolvedlauromouraT8389 C#: CA1000: Do not declare static members on generic types
 OpenfelipealmeidaT8390 C#: CA1030: Use events where appropriate
 OpenNoneT8391 C#: CA1031: Do not catch general exception types
 ResolvedlauromouraT8392 C#: CA1032: Implement standard exception constructors
 OpenNoneT8393 C#: CA1034: Nested types should not be visible
 OpenfelipealmeidaT8394 C#: CA1036: Override methods on comparable types
 ResolvedlauromouraT8395 C#: CA1040: Avoid empty interfaces
 ResolvedYOhohoT8396 C#: CA1044: Properties should not be write only
 OpenNoneT8397 C#: CA1051: Do not declare visible instance fields
 OpenNoneT8398 C#: CA1052: Static holder types should be Static or NotInheritable
 ResolvedfelipealmeidaT8399 C#: CA1062: Validate arguments of public methods
 ResolvedlauromouraT8400 C#: CA1063: Implement IDisposable correctly
 ResolvedlauromouraT8401 C#: CA1064: Exceptions should be public
 OpenNoneT8402 C#: CA1065: Do not raise exceptions in unexpected locations
 OpenNoneT8403 C#: CA1303: Do not pass literals as localized parameters
 OpenNoneT8404 C#: CA1305: Specify IFormatProvider
 ResolvedlauromouraT8405 C#: CA1307: Specify StringComparison
 ResolvedlauromouraT8406 C#: CA1401: P/Invokes should not be visible
 OpenNoneT8407 C#: CA1507: Use nameof in place of string
 OpenNoneT8408 C#: CA1710: Identifiers should have correct suffix
 OpenNoneT8409 C#: CA1715: Identifiers should have correct prefix
 OpenNoneT8410 C#: CA1716: Identifiers should not match keywords
 OpenNoneT8411 C#: CA1717: Only FlagsAttribute enums should have plural names
 OpenNoneT8412 C#: CA1720: Identifiers should not contain type names
 OpenNoneT8413 C#: CA1724: Type names should not match namespaces
 OpenfelipealmeidaT8414 C#: CA1801: Review unused parameters
 OpenNoneT8415 C#: CA1806: Do not ignore method results
 OpenNoneT8416 C#: CA1810: Initialize reference type static fields inline
 OpenNoneT8417 C#: CA1812: Avoid uninstantiated internal classes
 ResolvedlauromouraT8418 C#: CA1815: Override equals and operator equals on value types
 ResolvedlauromouraT8419 C#: CA1816: Call GC.SuppressFinalize correctly
 OpenNoneT8420 C#: CA1822: Mark members as static
 ResolvedlauromouraT8421 C#: CA1825: Avoid zero-length array allocations
 ResolvedlauromouraT8422 C#: CA1829: Use Length/Count property instead of `Count()` when available
 ResolvedlauromouraT8423 C#: CA2000: Dispose objects before losing scope
 ResolvedlauromouraT8424 C#: CA2007: Do not directly await a Task
 OpenNoneT8425 C#: CA2101: Specify marshaling for P/Invoke string arguments
 ResolvedlauromouraT8426 C#: CA2200: Rethrow to preserve stack details
 ResolvedlauromouraT8427 C#: CA2207: Initialize value type static fields inline
 ResolvedlauromouraT8428 C#: CA2208: Instantiate argument exceptions correctly
 OpenNoneT8429 C#: CA2214: Do not call overridable methods in constructors
 ResolvedlauromouraT8430 C#: CA2225: Operator overloads have named alternates
 OpenNoneT8459 C#: Indent elements inside namespace
 OpenNoneT8466 C#: Consistently use `indent` instead of just `scope_tab` in generators
lauromoura created this task.Oct 10 2019, 6:03 PM
lauromoura triaged this task as Normal priority.
lauromoura added a comment.Oct 18 2019, 10:50 AM

I've pushed a branch to devs/lauromoura/dotnet that has all Stylecop rules silenced individually. This helps avoiding the noise of all warnings and focus on each rule.

lauromoura added a comment.Oct 18 2019, 1:27 PM

As of T8430, all CA-style warnings are covered by tasks.

lauromoura added a comment.Oct 25 2019, 7:47 AM

Updated devs/lauromoura/dotnet with the these fixed warnings enabled in the ruleset file.