This task contains some of my cleanup suggestions, tests and thoughts for the future. Not all are urgent/needed, but wanted to have them written down somewhere so they can be addressed (or not) before the release.
Remove format nodes internally and just use annotations.
As the title says, we don't need format nodes anymore, we should just have annotations, so we can remove all of the extra bloat that's format nodes from the internals.
Verify all of the events are called when they should, and only then
We have text related events, make sure they are called when needed.
Fix newly added FIXMEs and #warning directives
They point to things that need to be addressed before the release - so address them.
Make sure styles work as expected
Make sure that there aren't any memory leaks
Run the tests with valgrind and verify nothing was added.
Make sure annotations work as expected
They should, as a lot of the code is shared with the old one, but still need some nice tests for this.
Especially for the newly added ephemeral types.
Context menu functions in Efl2.Ui.Text needs changing
This was discussed in T8289. My suggested alternative:
- Do like we do for other menus in elementary - best one, need to verify what's done there.
- Make it support generic objects instead of the current design and use an item class that can be created to create the items.
- Have a callback on the item object rather than the item, and add a key to items so we can know which item was clicked.
Merge back or share a lot of code between Efl.Canvas.Text and Textblock.Legacy
I split them so I can make changes without being hindered by legacy. Though a lot of the code is still the same. These could potentially be merged into the same object, as many of the internal changes were improvements that can be backported.
I think though it's better not to merge them, but rather share only parts of the code, because, for example, the internals of Efl.Canvas.Text can now be greatly improved due to the simpler API that doesn't leak implementation details.
This is not urgent, but better to do it before they diverge too much (if many changes are planned).