Page MenuHomePhabricator

efl.divisor_interpolator
Open, NormalPublic

Description

class Efl.Divisor_Interpolator

Related Objects

StatusAssignedTask
Resolvedbu5hm4n
OpenNone
segfaultxavi moved this task from Backlog to Evaluating on the efl: api board.Dec 3 2019, 8:18 AM

I don't know what this does so I cannot write proper documentation.
I inferred the parameter names and types by looking at the code but that's as far as I got.

segfaultxavi triaged this task as Normal priority.Dec 3 2019, 9:25 AM
bu5hm4n moved this task from Evaluating to Stabilized on the efl: api board.Dec 19 2019, 5:58 AM
bu5hm4n moved this task from Stabilized to Evaluating on the efl: api board.Dec 19 2019, 6:04 AM

This class was added based on ELM_TRANSIT_TWEEN_MODE_DIVISOR_INTERP, ECORE_POS_MAP_DIVISOR_INTERP and ECORE_POS_MAP_DIVISOR_INTERP.

But as @segfaultxavi mentioned, it seems that "DIVISOR Interpolation" is not a term that is commonly used.

The documentation of ELM_TRANSIT_TWEEN_MODE_DIVISOR_INTERP describes as follows,

Start at gradient v1, interpolated via power of v2 curve.

Therefore, if this interpolation is not the one commonly used (or well-known), then we may remove this class instead of stabilizing it.

What do you think?

Thanks for pointing this out, @Jaehyun_Cho!

I have finally managed to understand how this interpolator works, and I suggest we rename it to Power_Interpolator.
I prefer we keep it rather than removing a feature that was available in legacy.

If you agree to the name change, the docs would look something like this:

Power interpolator. The value quickly reaches 1.0 since it is raised to a configurable $power.

The speed at which the value "takes off" can be controlled with the $divisor parameter.
A value of 1 produces linear interpolation, and smaller values take progressively longer to begin to raise.

I agree with your opinion! Power_Interpolator :)