Page MenuHomePhabricator

Efl.Canvas.Gesture_Manager
Open, NormalPublic

Description

This class keeps track of active @Efl.Canvas.Gesture_Recognizer objects.        
For internal use only.                                                          
                                                                                
This gesture class defines methods that register and unregister a recognizer and
get a recognizer according to gesture event type.                               

- (M) recognizer_register
- (M) recognizer_unregister
- (M) recognizer_get
- (P) config
segfaultxavi triaged this task as Normal priority.
segfaultxavi moved this task from Backlog to Evaluating on the efl: api board.
zmike added a comment.Dec 24 2019, 6:33 AM

If this is internal-only why are we evaluating it for stabilization?

Its needed if you want to write custom recognizer. As you register it here, and this will handle the rest.

(Just looking from the API pov, not really checked if its really working)

zmike added a comment.Dec 24 2019, 7:10 AM

The above comment is in reference to the statement that this class is for internal use in the OP text, so we can disregard I guess.

zmike added a comment.EditedJan 29 2020, 11:30 AM

Current:

class Efl.Canvas.Gesture_Manager
├ (M) recognizer_register
├ (M) recognizer_unregister
├ (M) recognizer_cleanup
zmike added a comment.Feb 11 2020, 6:45 AM

The biggest issue here is the config values. We must document these, which means they effectively become hardcoded. Unfortunately, our config value names are all bound to the legacy glayer elm widget, and so they have names like glayer_double_tap_timeout which is not good. A decision must be made about what to do here.

This is related to the now-ancient discussion about how to handle configuration in a generic way, right?
I'm talking about T7383.

zmike added a comment.Feb 11 2020, 7:03 AM

Vaguely, but not anything specific. I'm just talking about it in the sense that we should document the config values in the gesture classes.

Yeah, that ticket includes discussion about how to document these config values (starting at T7356#124323) but we never got to any conclusion.
The global config is in the same state of disarray as the gestures config.