Page MenuHomePhabricator

Terminilogy is forcing display of tab
Closed, ResolvedPublic

Description

I have updated recently my terminology and now it always show the tab even when show tab is unchecked. If I change the config when any tab is displayed, terminology will crash with the backtrace below:

terminology: ../src/bin/win.c:3054: _tabs_get_or_create_boxes: Assertion `term->tabbar.l.box == NULL' failed.
==1416704==
==1416704== Process terminating with default action of signal 6 (SIGABRT): dumping core
==1416704==    at 0x55ACF25: raise (in /usr/lib/libc-2.30.so)
==1416704==    by 0x5596896: abort (in /usr/lib/libc-2.30.so)
==1416704==    by 0x5596766: __assert_fail_base.cold (in /usr/lib/libc-2.30.so)
==1416704==    by 0x55A5525: __assert_fail (in /usr/lib/libc-2.30.so)
==1416704==    by 0x17C64C: _tabs_get_or_create_boxes (in /usr/bin/terminology)
==1416704==    by 0x17FA32: _tabs_recreate (in /usr/bin/terminology)
==1416704==    by 0x17E0F6: _tabs_update (in /usr/bin/terminology)
==1416704==    by 0x177212: _win_update (in /usr/bin/terminology)
==1416704==    by 0x185CCA: windows_update (in /usr/bin/terminology)
==1416704==    by 0x137EF7: _cb_op_behavior_show_tabs (in /usr/bin/terminology)
==1416704==    by 0x574F090: _event_callback_call (eo_base_class.c:2138)
==1416704==    by 0x5749E5F: efl_event_callback_legacy_call (eo_base_class.c:2214)

If I change the setting without any tab open, it will just ignore the change.

cedric created this task.Jan 28 2020, 11:09 PM
billiob removed billiob as the assignee of this task.Jan 29 2020, 1:38 AM
billiob added a subscriber: billiob.

I should have pushed a fix last night.
Was it like that : https://twitter.com/m0rb/status/1221927857389215746?s=19 ?
Should be fixed in bee2482fe76ab5a9fd3b35f36cdd36c919e8c860
Could you please test?

billiob claimed this task.Jan 29 2020, 1:38 AM
cedric closed this task as Resolved.Jan 29 2020, 10:11 AM

Yes, it is resolved. Twitter bug report is the future :-)

Yes, it is resolved. Twitter bug report is the future :-)

And there I thought I could make user experience better using phab... I should stop dreaming, right?

T8581