Page MenuHomePhabricator

EFL_CANVAS_LAYOUT_BETA still used ?
Open, Pending on user inputPublic

Description

doing a fgrep -r EFL_CANVAS_LAYOUT_BETA I get

./builddir/src/bindings/cxx/efl_canvas_layout.eo.hh:#ifdef EFL_CANVAS_LAYOUT_BETA
./src/tests/edje/edje_test_container.c:#define EFL_CANVAS_LAYOUT_BETA
./src/tests/edje/edje_test_edje.c:#define EFL_CANVAS_LAYOUT_BETA
./src/tests/edje/edje_test_features.c:#define EFL_CANVAS_LAYOUT_BETA
./src/tests/edje/edje_test_signal.c:#define EFL_CANVAS_LAYOUT_BETA
./src/tests/edje/edje_test_swallow.c:#define EFL_CANVAS_LAYOUT_BETA
./src/tests/edje/edje_test_text.c:#define EFL_CANVAS_LAYOUT_BETA

so it is not used instead of a c++ generated file

so :

  • can I remove EFL_CANVAS_LAYOUT_BETA from the tests
  • what about this generated file ?

Related Objects

vtorri created this task.May 16 2020, 1:36 AM
zmike added a comment.May 18 2020, 6:25 AM

Defines of the format EFL_[A-Z0-9_]_BETA are generated from eo-based APIs through eolian. As such, the "usedness" of each define can be determined by checking the corresponding eo file (in this case efl_canvas_layout.eo) to determine if the class is still in beta (noted by the @beta tag in the class declaration at the top of the file).

In this case, the corresponding class does appear to be in beta, which means those defines are required in order to use the efl_canvas_layout API.

ProhtMeyhet triaged this task as Pending on user input priority.Oct 8 2020, 9:44 AM