Page MenuHomePhabricator

efl-git: data/elementary/desktop/elementary_config.desktop doesn't pass desktop-file-validate
Open, Incoming QueuePublic

Description

Hey,

https://freedesktop.org/wiki/Software/desktop-file-utils/ includes a file to validate .desktop files. When building efl for my distro, QA tools integrate this check as one of them. To my knowledge, many distros do this. Here's the result:

* Messages for package dev-libs/efl-1.24.3:

* QA Notice: This package installs one or more .desktop files that do not
* pass validation.
* 
* 	/usr/share/applications/elementary_config.desktop: warning: value "Agordi Elementary" for key "Comment[eo]" in group "Desktop Entry" looks the same as that of key "Name[eo]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Configuració Elementary" for key "Comment[ca]" in group "Desktop Entry" looks the same as that of key "Name[ca]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Configuration pour Elementary" for key "Comment[fr]" in group "Desktop Entry" looks the same as that of key "Name[fr]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Configurazione di Elementary" for key "Comment[it]" in group "Desktop Entry" looks the same as that of key "Name[it]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Configure Elementary" for key "Comment[es]" in group "Desktop Entry" looks the same as that of key "Name[es]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Configure Elementary" for key "Comment[gl]" in group "Desktop Entry" looks the same as that of key "Name[gl]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Configure o Elementary" for key "Comment[pt]" in group "Desktop Entry" looks the same as that of key "Name[pt]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Elementary Configuration" for key "Comment" in group "Desktop Entry" looks the same as that of key "Name"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Elementary Yapılandırması" for key "Comment[tr]" in group "Desktop Entry" looks the same as that of key "Name[tr]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Elementary nustatymai" for key "Comment[lt]" in group "Desktop Entry" looks the same as that of key "Name[lt]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Elementary 設定" for key "Comment[ja]" in group "Desktop Entry" looks the same as that of key "Name[ja]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Elementary-Konfiguration" for key "Comment[de]" in group "Desktop Entry" looks the same as that of key "Name[de]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Elementaryn asetukset" for key "Comment[fi]" in group "Desktop Entry" looks the same as that of key "Name[fi]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Konfigurace Elementary" for key "Comment[cs]" in group "Desktop Entry" looks the same as that of key "Name[cs]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Konfigurasi Elementary" for key "Comment[ms]" in group "Desktop Entry" looks the same as that of key "Name[ms]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Podstawowa konfiguracja" for key "Comment[pl]" in group "Desktop Entry" looks the same as that of key "Name[pl]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Параметры Elementary" for key "Comment[ru]" in group "Desktop Entry" looks the same as that of key "Name[ru]"
* 	/usr/share/applications/elementary_config.desktop: warning: value "Поставке Еламентарија" for key "Comment[sr]" in group "Desktop Entry" looks the same as that of key "Name[sr]"
*

This seems present in the current -git version too. Here's a patch to "fix" it:

diff -Naur efl/data/elementary/desktop/elementary_config.desktop efl-1/data/elementary/desktop/elementary_config.desktop
--- efl/data/elementary/desktop/elementary_config.desktop	2020-07-18 10:32:45.785921519 +0300
+++ efl-1/data/elementary/desktop/elementary_config.desktop	2020-07-18 10:43:20.521719126 +0300
@@ -18,24 +18,6 @@
 Name[ru]=Параметры Elementary
 Name[sr]=Поставке Еламентарија
 Name[tr]=Elementary Yapılandırması
-Comment=Elementary Configuration
-Comment[ca]=Configuració Elementary
-Comment[cs]=Konfigurace Elementary
-Comment[de]=Elementary-Konfiguration
-Comment[eo]=Agordi Elementary
-Comment[es]=Configure Elementary
-Comment[fi]=Elementaryn asetukset
-Comment[fr]=Configuration pour Elementary
-Comment[gl]=Configure Elementary
-Comment[it]=Configurazione di Elementary
-Comment[ja]=Elementary 設定
-Comment[lt]=Elementary nustatymai
-Comment[ms]=Konfigurasi Elementary
-Comment[pl]=Podstawowa konfiguracja
-Comment[pt]=Configure o Elementary
-Comment[ru]=Параметры Elementary
-Comment[sr]=Поставке Еламентарија
-Comment[tr]=Elementary Yapılandırması
 Icon=elementary
 Exec=elementary_config
 Terminal=false
juippis created this task.Jul 18 2020, 12:44 AM

FYI this check has been marked as irrelevant in my distro (ignored), but the latest Freedesktop validation tool still flags it, so this'll most likely end up being reported by other parties.