Page MenuHomePhabricator

evas_object_textblock / elm_entry - line merge up junk characters.
Closed, ResolvedPublic

Description

Using ecrire, I noticed that new lines were not displayed corrected. If I close/open ecrire, it seems to display correctly. The file was natively made in linux (using nano).

https://www.enlightenment.org/ss/display.php?image=e-5f5d1bd0c18ae6.65894655.png

Testing in elementary, I can get a "?" symbol if I create / delete new lines a few times - perhaps it's something broken in elementary?

https://www.enlightenment.org/ss/display.php?image=e-5f5d1fd411f134.31577743.png

abrouwers triaged this task as High priority.
netstar raised the priority of this task from High to Showstopper Issues.
netstar added a subscriber: raster.
netstar added a subscriber: netstar.

It's rendering newlines in the editor when it shouldn't be. When merging up...you can see then if you copy the text into copy buffer then pass it to hexdump it's additional '\n' characters.

netstar added a comment.EditedSat, Sep 12, 3:23 PM
4976097bd427c09b493e428ce476b83d6427199e breaks it

Not true...

I tried downgrading to 1.24.3, and it seemed to have the same issues. So, maybe not a showstopper for 1.25.x? But, it still seems to break text editors built off of EFL.

netstar removed stefan_schmidt as the assignee of this task.Sun, Sep 13, 3:55 AM
netstar lowered the priority of this task from Showstopper Issues to Normal.
netstar added a subscriber: stefan_schmidt.

When removing a newline in a multi-line elm_entry, a trailing newline glyph is being appended to the end of the new line.

If the font used does not handle a '\n' character and display it as whitespace then the above will happen.

This behaviour is 100% reproducible.

If you create some new lines in an entry widget then delete them, after the line is merged the cursor can move over the glyph. Press right arrow after a newline merge, you will see an additional whitespace.

This might not seem problematic but these new lines are copyable therefore you can get bogus copy data from the widget.

evas_object_textblock should not be rendering a '\n' character as it is currently doing in this scenario.

netstar renamed this task from Elementary Entry (1.25) / new line broken? to evas_object_textblock / elm_entry - line merge up junk characters..Sun, Sep 13, 12:14 PM
netstar raised the priority of this task from Normal to High.

This is an old issue:

Easy steps to produce:
1- Open elementry_text -> entry
2- SelectAll + and Press "Delete"
3- Press "Enter" 3 times
4- Press "Page Up"
5- Press "Delete"

stefan_schmidt closed this task as Resolved.Wed, Sep 16, 5:41 AM