Page MenuHomePhabricator

efl 1.25.1 or git master fails to compile with libavif v0.8.2
Open, Showstopper IssuesPublic

Description

efl 1.25.1 or git master fails to compile with libavif v0.8.2 as:

/builddir/build/BUILD/efl-1.25.1/src/modules/evas/image_loaders/avif/evas_image_load_avif.c:68:10: error: too many arguments to function ‘avifDecoderParse’
   68 |    res = avifDecoderParse(decoder, &raw);
      |          ^~~~~~~~~~~~~~~~
In file included from /builddir/build/BUILD/efl-1.25.1/src/modules/evas/image_loaders/avif/evas_image_load_avif.c:7:
/usr/include/avif/avif.h:707:12: note: declared here
  707 | avifResult avifDecoderParse(avifDecoder * decoder);
      |            ^~~~~~~~~~~~~~~~
/builddir/build/BUILD/efl-1.25.1/src/modules/evas/image_loaders/avif/evas_image_load_avif.c: In function ‘evas_image_load_file_data_avif_internal’:
/builddir/build/BUILD/efl-1.25.1/src/modules/evas/image_loaders/avif/evas_image_load_avif.c:155:15: error: too many arguments to function ‘avifDecoderParse’
  155 |         res = avifDecoderParse(decoder, &raw);
      |               ^~~~~~~~~~~~~~~~
In file included from /builddir/build/BUILD/efl-1.25.1/src/modules/evas/image_loaders/avif/evas_image_load_avif.c:7:
/usr/include/avif/avif.h:707:12: note: declared here
  707 | avifResult avifDecoderParse(avifDecoder * decoder);
      |            ^~~~~~~~~~~~~~~~

libavif side change starts with https://github.com/AOMediaCodec/libavif/commit/be4cbb92c087349bdd0df35bd202a711e29f988d

mtasaka created this task.Oct 26 2020, 4:23 AM

Trial patch to fix FTBFS with libavif 0.8.2, but completely UNTESTED.

Note that avifDecoderSetIOMemory API changed also at https://github.com/AOMediaCodec/libavif/commit/7de4445a3929847f28bb8bae45b42f81053dad7b

ProhtMeyhet added a project: Restricted Project.Oct 26 2020, 5:41 AM
ProhtMeyhet triaged this task as Showstopper Issues priority.
ProhtMeyhet added a subscriber: bu5hm4n.
ProhtMeyhet added a subscriber: raster.
ProhtMeyhet added a subscriber: stefan_schmidt.