Needs unit test(s).
I have one concern about View_Manager.
latest release is 1.9.1, released in april 2019
Please check a comment.
Actually, Evas_GL_Image could be shared among images as it's optimal, what makes texture loading fails?
I left some comments and asked some questions.
Enhanced based on comment. This is much more neat!
There edje (vector animation), elementary(efl_ui_animation_view) patches could be submitted soon if evas patches has been approved.
added co-author info.
Because you are probably the only one developing other things in this area, so it you look like a good candidate for a review :).
If the clipping area is not changed frequently then this provides a massive performance boost.
I wonder if it would make sense to just use the direct clipper geometry for this and the related proxy sizing patch; the cases that these are being written for is when there is a static clipper applied to the proxy/mask which always causes them to be clipped to a smaller size.
I have no idea how this api is guaranteed for it's purpose... if It's unlikely work as you purposed.
Please check a comment.
After LOTS of brainstorming, we came up with Efl.Ui.Layout_Orientable and Efl.Ui.Layout_Orientation, which will only contain Horizontal and Vertical values.
We came up with a better name.
To add more information:
The only current users of Efl.Ui.Direction are Spin_Button, Slider(T7893), Panes, Grid(T7870), Table(T7899), Box(T7859) and Progressbar.
All of these are only concerned with the Horizontal or Vertical configurations except Progressbar, which accepts reversed directions.
I installed sway to try and test this, but ... how the heck do you use this thing lol ? It's just a grey background with no way to launch apps :(
Aha, I missed that. Thanks!
@bu5hm4n Why was I added as reviewer on this ? I don't deal with X stuff anymore, nor do I do key mapping stuffs lol
Tue, May 21
The C# bindings now automatically add the Part suffix, so we do not need to use any prefix or suffix. label, icon and extra should be good enough names for parts now.
The problem is that Eolian is still enforcing that part names do not clash with property names. Can this restriction be removed, @q66?
Also, be careful, there's still commented-out code in efl_ui_grid_default_item.c
I am a bit confused by this patch. At ecore_ipc.c:748 the close_on_invalidate flag is clearly set to true. Can you explain more about this or provide a case in which this behavior is different?
I see nothing suspicious now and the only test I could find still works, so...
split func calls based on mul_col
use same ptr in _evas_common_scale_rgba_sample_scale_mask funcs
how many times was this block of code copied around???
Way too many.