Page MenuHomePhabricator
Feed All Stories

Today

brunobelo edited projects for D9692: eolian-mono: Renaming suffix for event args., added: Restricted Project, efl (efl-1.23), efl: language bindings; removed efl.
Wed, Aug 21, 2:02 PM · efl: language bindings, efl (efl-1.23), Restricted Project
brunobelo added a task to D9692: eolian-mono: Renaming suffix for event args.: T8164: C#: Event args suffix.
Wed, Aug 21, 1:54 PM · efl: language bindings, efl (efl-1.23), Restricted Project
brunobelo added a revision to T8164: C#: Event args suffix: D9692: eolian-mono: Renaming suffix for event args..
Wed, Aug 21, 1:54 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
brunobelo requested review of D9692: eolian-mono: Renaming suffix for event args..
Wed, Aug 21, 1:53 PM · efl: language bindings, efl (efl-1.23), Restricted Project
lauromoura added a comment to T8163: C#: Event naming.

From C# guidelines in https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/names-of-type-members#names-of-events:

Wed, Aug 21, 1:01 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8163: C#: Event naming.

Here is a list of generated events from the C# files. (without the prefix).

Wed, Aug 21, 12:59 PM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
cedric closed D9682: evas/object: remove errors when user min/max size hints conflict.
Wed, Aug 21, 12:53 PM · efl
cedric closed D9659: efl_ui_spec_suite: that fixture is unneeded.
Wed, Aug 21, 12:52 PM · efl
ali.alzyod added a comment to T8136: harfbuzz 2.6 breaks text layout.

This is fixed from Harfbuzz Side.
https://github.com/harfbuzz/harfbuzz/issues/1910

Wed, Aug 21, 12:47 PM · efl
bu5hm4n added a comment to D9674: efl_ui: add scrollable_content mixin.

I actually think that this is an ok usage of key/data API. The call has to stay private. So implementing it as a constructor property require the addition of a private .h function and all the custom thingy to be done manually. A lot more code for something that two line of code solve here. As I am against writing unnecessary line as they bring more problem in the future usually, let's just go with a simple solution aka key/data.

Wed, Aug 21, 12:43 PM · efl: widgets
zmike added a task to D9691: efl/gfx: redo image scale_type enum: T7927: enum Efl.Gfx.Image_Scale_Type.
Wed, Aug 21, 12:38 PM · efl
zmike added a revision to T7927: enum Efl.Gfx.Image_Scale_Type: D9691: efl/gfx: redo image scale_type enum.
Wed, Aug 21, 12:38 PM · efl: api, efl (efl-1.23), efl: language bindings
zmike requested review of D9691: efl/gfx: redo image scale_type enum.
Wed, Aug 21, 12:38 PM · efl
zmike added a child revision for D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop: D9691: efl/gfx: redo image scale_type enum.
Wed, Aug 21, 12:38 PM · efl: widgets
cedric added a comment to D9674: efl_ui: add scrollable_content mixin.

I actually think that this is an ok usage of key/data API. The call has to stay private. So implementing it as a constructor property require the addition of a private .h function and all the custom thingy to be done manually. A lot more code for something that two line of code solve here. As I am against writing unnecessary line as they bring more problem in the future usually, let's just go with a simple solution aka key/data.

Wed, Aug 21, 12:35 PM · efl: widgets
zmike created T8169: how to reference events with commas in eo docs?.
Wed, Aug 21, 12:35 PM · Restricted Project
bu5hm4n added a comment to D9674: efl_ui: add scrollable_content mixin.

yes.

Wed, Aug 21, 12:24 PM · efl: widgets
bu5hm4n accepted D9676: efl_ui/scrollable_content: add scrollable_text property.

cool.

Wed, Aug 21, 12:24 PM · efl: widgets
zmike closed D9689: elm_test: fix background radio usage.
Wed, Aug 21, 12:23 PM · efl
zmike added inline comments to D9676: efl_ui/scrollable_content: add scrollable_text property.
Wed, Aug 21, 12:13 PM · efl: widgets
felipealmeida requested review of D9690: eolian-mono: Add support for partial classes.
Wed, Aug 21, 12:11 PM · efl
zmike requested review of D9689: elm_test: fix background radio usage.
Wed, Aug 21, 12:09 PM · efl
lauromoura assigned T8034: C#: Make C# classes partials to felipealmeida.
Wed, Aug 21, 12:07 PM · efl: language bindings
lauromoura moved T8034: C#: Make C# classes partials from Backlog to InProgress on the efl: language bindings board.
Wed, Aug 21, 12:07 PM · efl: language bindings
raster added a commit to T8135: cnp stopped respecting newlines when pasting into etnry: rEFL3716cfe1a2a3: elm entry - respect plain text newlines on paste again....
Wed, Aug 21, 12:02 PM · efl
bu5hm4n added a comment to D9678: efl_ui/popup: use array for internal anchor callbacks.

Okay - then i do not see a reason for this patch...

Wed, Aug 21, 12:02 PM · efl: widgets
zmike added a comment to D9678: efl_ui/popup: use array for internal anchor callbacks.

For the record, i am talking of:

static void
_anchor_del_cb(void *data, const Efl_Event *ev EINA_UNUSED)
{
   efl_ui_popup_anchor_set(data, NULL);
}
Wed, Aug 21, 11:57 AM · efl: widgets
lauromoura added a comment to T8165: C#: Hide unecessary API.

We could try hiding them but AFAIR they should be public so inherited classes can use them.

Wed, Aug 21, 11:54 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8164: C#: Event args suffix.

Evt today comes from the name of the event. Related to T8163

Wed, Aug 21, 11:53 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura added a comment to T8163: C#: Event naming.

This could be kinda tricky to do in a generic way. We may end up having to build a list of irregular verbs and their past tense in order to generate them.

Wed, Aug 21, 11:47 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
bu5hm4n accepted D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop.

Okay.

Wed, Aug 21, 11:46 AM · efl: widgets
cedric accepted D9662: efl_ui_single_selectable: add a fallback element.
Wed, Aug 21, 11:46 AM · efl
cedric accepted D9663: efl_input_clickable: add a flag for showing user interaction.
Wed, Aug 21, 11:44 AM · efl
cedric accepted D9664: efl_ui_collection: honor desktop vs. touch setting of elm config.
Wed, Aug 21, 11:41 AM · efl
bu5hm4n added a comment to D9678: efl_ui/popup: use array for internal anchor callbacks.

For the record, i am talking of:

static void
_anchor_del_cb(void *data, const Efl_Event *ev EINA_UNUSED)
{
   efl_ui_popup_anchor_set(data, NULL);
}

But it seems that the deletion of the anchor is different to what is happening if you are unsetting it (or i am just not seeing the equalness), anyways:
_anchor_calc already gets the private data of the widget, also getting the pd of the popup is not that much more.

Wed, Aug 21, 11:38 AM · efl: widgets
cedric accepted D9659: efl_ui_spec_suite: that fixture is unneeded.
Wed, Aug 21, 11:36 AM · efl
cedric accepted D9682: evas/object: remove errors when user min/max size hints conflict.
Wed, Aug 21, 11:35 AM · efl
lauromoura added a comment to T8162: C#: .cs file naming with PascalCase.

We may encounter some difficulty generating the files in sub folders as a meson issue [1] limits the output of custom_target command to be placed in the same folder as it is called.

Wed, Aug 21, 11:35 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
cedric accepted D9681: efl_ui/scroll_util: block scroll calc tsunamis caused by repeat signal emits.
Wed, Aug 21, 11:32 AM · efl: widgets
zmike added a comment to D9674: efl_ui: add scrollable_content mixin.

So you want to have efl.ui.widget.scrollable_content with a scroller_style property?

Wed, Aug 21, 11:31 AM · efl: widgets
zmike added a comment to D9678: efl_ui/popup: use array for internal anchor callbacks.

How would your proposed change handle _anchor_calc without performing another eoid lookup?

Wed, Aug 21, 11:30 AM · efl: widgets
lauromoura triaged T8168: C#: Build with dotnet and upstream meson as High priority.
Wed, Aug 21, 11:30 AM · efl: language bindings
cedric accepted D9680: theme/scroller: don't "check" bar positions randomly in other programs.
Wed, Aug 21, 11:29 AM · efl: widgets
cedric updated subscribers of T8160: Wrong Usage For Callback Forwarder.

You are right the documentation and the code do not agree on this. I have no strong feeling on how to fix it and will accept a patch that goes one way or the other. Maybe @segfaultxavi has an idea.

Wed, Aug 21, 11:28 AM
cedric closed D9606: efl: mark Efl.Ui.Factory.create a protected method..
Wed, Aug 21, 11:26 AM · efl
cedric closed D9658: Ecore : does not build linux-only ecore modules on Windows.
Wed, Aug 21, 11:26 AM · efl
cedric closed D9604: efl: use a @static function so that binding can pick it up..
Wed, Aug 21, 11:26 AM · efl
cedric closed D9635: elementary: use the right function for creating object from Efl.Ui.Factory..
Wed, Aug 21, 11:26 AM · efl
cedric closed D9603: elementary: prefer use of Efl unified API..
Wed, Aug 21, 11:26 AM · efl
cedric closed D9599: elementary: allow Efl.Ui.Factory to have a chance to call constructor function..
Wed, Aug 21, 11:26 AM · efl
cedric closed D9602: elementary: Efl.Ui.Layout_Factory should not set the theme if there isn't any defined..
Wed, Aug 21, 11:26 AM · efl
cedric closed D9579: elementary: switch Efl.Ui.Factory API to a batch API and update all class using it..
Wed, Aug 21, 11:26 AM · efl
cedric updated subscribers of D9679: efl_ui/popup: reuse existing internal data pointer.

I think @bu5hm4n will not be happy with this patch. Is @bu5hm4n the object cop?

Wed, Aug 21, 11:24 AM · efl: widgets
cedric accepted D9686: efl_ui/image: add group_calc implementation, use deferred calc for sizing.
Wed, Aug 21, 11:21 AM · efl: widgets
zmike added a comment to D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop.

Maybe later.

Wed, Aug 21, 11:19 AM · efl: widgets
bu5hm4n accepted D9677: efl_ui/popup: remove text_alert class.
Wed, Aug 21, 11:19 AM · efl: widgets
bu5hm4n accepted D9675: efl_ui/popup: remove scroll_alert class.
Wed, Aug 21, 11:18 AM · efl: widgets
bu5hm4n added a comment to D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop.

Nice! can you add it to the spec unit test ?

Wed, Aug 21, 11:18 AM · efl: widgets
bu5hm4n accepted D9687: efl_ui/image: remove geometry from internal struct, clean up geometry methods.
Wed, Aug 21, 11:17 AM · efl: widgets
bu5hm4n requested changes to D9678: efl_ui/popup: use array for internal anchor callbacks.

I think the move to the callback array does make a lot of sense, but the usage of a object pointer in the private data is not a good idea, we should get rid of that. in the invalidate case you could also just use the same API again to set the anchor to NULL (which would also garantee that we have additional cleanup operations) in one place, and so reduce code dups.

Wed, Aug 21, 11:13 AM · efl: widgets
lauromoura triaged T8167: C#: Fix indentation and blanklines as High priority.
Wed, Aug 21, 11:05 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
cedric updated the diff for D9606: efl: mark Efl.Ui.Factory.create a protected method..

rebase

Wed, Aug 21, 11:04 AM · efl
cedric updated the diff for D9604: efl: use a @static function so that binding can pick it up..

rebase

Wed, Aug 21, 11:04 AM · efl
bu5hm4n accepted D9599: elementary: allow Efl.Ui.Factory to have a chance to call constructor function..

<3

Wed, Aug 21, 11:04 AM · efl
cedric updated the diff for D9635: elementary: use the right function for creating object from Efl.Ui.Factory..

rebase

Wed, Aug 21, 11:04 AM · efl
cedric updated the diff for D9603: elementary: prefer use of Efl unified API..

rebase

Wed, Aug 21, 11:04 AM · efl
cedric updated the diff for D9602: elementary: Efl.Ui.Layout_Factory should not set the theme if there isn't any defined..

rebase

Wed, Aug 21, 11:04 AM · efl
bu5hm4n accepted D9685: elm: fix macro for group_calc function naming.
Wed, Aug 21, 11:03 AM · efl
cedric updated the diff for D9599: elementary: allow Efl.Ui.Factory to have a chance to call constructor function..

rebase and avoid using key/data API to please @bu5hm4n :-)

Wed, Aug 21, 11:03 AM · efl
lauromoura triaged T8166: C#: Remove I prefix from argument structs for class events as High priority.
Wed, Aug 21, 11:02 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
cedric updated the diff for D9579: elementary: switch Efl.Ui.Factory API to a batch API and update all class using it..

rebase

Wed, Aug 21, 11:02 AM · efl
bu5hm4n added inline comments to D9676: efl_ui/scrollable_content: add scrollable_text property.
Wed, Aug 21, 11:02 AM · efl: widgets
lauromoura triaged T8165: C#: Hide unecessary API as High priority.
Wed, Aug 21, 11:01 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura triaged T8164: C#: Event args suffix as High priority.
Wed, Aug 21, 10:57 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
bu5hm4n requested changes to D9674: efl_ui: add scrollable_content mixin.

Looks great otherwise :)

Wed, Aug 21, 10:57 AM · efl: widgets
tasn added a comment to T8151: RFC: Text interfaces design proposal.

This is clear things up, to know that we are based on current existing stuff

So how about break this @property font
Into :
@property fontfamily
@property fontSize
To make it more clear what does it mean.

Wed, Aug 21, 10:56 AM · efl: api
lauromoura triaged T8163: C#: Event naming as High priority.
Wed, Aug 21, 10:56 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
lauromoura triaged T8162: C#: .cs file naming with PascalCase as High priority.
Wed, Aug 21, 10:55 AM · efl (efl-1.23), Active Work Proposal, Restricted Project, efl: language bindings
bu5hm4n added a comment to D9661: suite_helpers: punsh some sanity into function names.

https://i.redd.it/i8933fmx30l11.png

Wed, Aug 21, 10:52 AM · efl
zmike added a reviewer for D9661: suite_helpers: punsh some sanity into function names: segfaultxavi.

This looks like it's removing docs, summoning doc cop...

Wed, Aug 21, 10:49 AM · efl
cedric closed D9684: efl_ui_widget: fix model listenting logic.
Wed, Aug 21, 10:46 AM · efl
cedric closed D9683: efl_ui_widget: remove self reference.
Wed, Aug 21, 10:46 AM · efl
tasn added a comment to T8151: RFC: Text interfaces design proposal.

@tasn
Again Font should not be interface, Are there font-able objects other than font object?
If my class use font object then he composite inside, not adopt new interface, do you have any example from other platforms ?

Wed, Aug 21, 10:17 AM · efl: api
cedric accepted D9683: efl_ui_widget: remove self reference.
Wed, Aug 21, 10:07 AM · efl
zmike requested review of D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop.
Wed, Aug 21, 10:03 AM · efl: widgets
zmike added a child revision for D9687: efl_ui/image: remove geometry from internal struct, clean up geometry methods: D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop.
Wed, Aug 21, 10:03 AM · efl: widgets
zmike requested review of D9687: efl_ui/image: remove geometry from internal struct, clean up geometry methods.
Wed, Aug 21, 10:03 AM · efl: widgets
zmike added a revision to T7873: efl.ui.image: D9688: efl_ui/image: implement efl.gfx.arrangement content_align to replace align prop.
Wed, Aug 21, 10:03 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a child revision for D9686: efl_ui/image: add group_calc implementation, use deferred calc for sizing: D9687: efl_ui/image: remove geometry from internal struct, clean up geometry methods.
Wed, Aug 21, 10:02 AM · efl: widgets
zmike requested review of D9686: efl_ui/image: add group_calc implementation, use deferred calc for sizing.
Wed, Aug 21, 10:02 AM · efl: widgets
zmike added a child revision for D9685: elm: fix macro for group_calc function naming: D9686: efl_ui/image: add group_calc implementation, use deferred calc for sizing.
Wed, Aug 21, 10:02 AM · efl
cedric accepted D9684: efl_ui_widget: fix model listenting logic.
Wed, Aug 21, 10:02 AM · efl
zmike added a parent revision for D9685: elm: fix macro for group_calc function naming: D9677: efl_ui/popup: remove text_alert class.
Wed, Aug 21, 10:02 AM · efl
zmike added a child revision for D9677: efl_ui/popup: remove text_alert class: D9685: elm: fix macro for group_calc function naming.
Wed, Aug 21, 10:01 AM · efl: widgets
zmike requested review of D9685: elm: fix macro for group_calc function naming.
Wed, Aug 21, 10:01 AM · efl
bu5hm4n added inline comments to D9599: elementary: allow Efl.Ui.Factory to have a chance to call constructor function..
Wed, Aug 21, 9:52 AM · efl
tasn closed T8161: RFC: Eolian support for lightweight classes as Invalid.

Even though I sat on this for a few days before posting it here, I'm now not sure if we want to encourage this "out of eo" behaviour. So I'm closing it for now, but at least we have it for posterity.

Wed, Aug 21, 9:51 AM
cedric planned changes to D9599: elementary: allow Efl.Ui.Factory to have a chance to call constructor function..
Wed, Aug 21, 9:46 AM · efl
bu5hm4n requested review of D9684: efl_ui_widget: fix model listenting logic.
Wed, Aug 21, 9:44 AM · efl
bu5hm4n added a child revision for D9683: efl_ui_widget: remove self reference: D9684: efl_ui_widget: fix model listenting logic.
Wed, Aug 21, 9:44 AM · efl