Page MenuHomePhabricator
Feed All Stories

Today

netstar closed T6318: E crash after Chromium browser usage as Resolved.

2017 I think this can be safely terminated.

Thu, Apr 2, 5:24 AM · enlightenment-git
netstar added a comment to T8490: efreetd: FreeBSD segfault..

I use FreeBSD E for my main workstation. I haven't seen an efreetd.core file for a LONG time.

Thu, Apr 2, 5:21 AM · E on FreeBSD, efl (efl-1.24)
segfaultxavi closed D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 4:02 AM · efl
stefan_schmidt accepted D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 4:00 AM · efl
segfaultxavi updated the diff for D11637: exactness docs: Add docs, fix docs, remove docs.

Take comments into account.

Thu, Apr 2, 3:57 AM · efl
segfaultxavi added a child revision for D11634: exactness: protect against forked calls: D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 3:57 AM · efl
stefan_schmidt closed D11636: ci: travis: switch exactness testing to normal test file.
Thu, Apr 2, 3:53 AM · efl
bu5hm4n accepted D11636: ci: travis: switch exactness testing to normal test file.

Macro feels_good:

Thu, Apr 2, 3:41 AM · efl
stefan_schmidt requested changes to D11637: exactness docs: Add docs, fix docs, remove docs.
Thu, Apr 2, 3:38 AM · efl
stefan_schmidt added a comment to D11637: exactness docs: Add docs, fix docs, remove docs.

Thanks for taking the time and making this usable! :-)

Thu, Apr 2, 3:38 AM · efl
segfaultxavi added a comment to D11638: C#: Remove warning about `if constexpr`.

I confirm this patch removes the C++17 warnings I reported, but I'll let somebody else review the code.

Thu, Apr 2, 1:42 AM · efl
jf_simon added a comment to T8641: elm_popup: EPhoto Regression.

but works with the flat theme :)

Thu, Apr 2, 1:17 AM · efl (efl-1.24)

Yesterday

lucas added a comment to D11434: C#: Update C# code-generation to use a new ICustomMarshaler in some string usages that were leaking.

@segfaultxavi D11638 should deal with it.

Wed, Apr 1, 2:29 PM · efl
lucas requested review of D11638: C#: Remove warning about `if constexpr`.
Wed, Apr 1, 2:27 PM · efl
raster added a commit to T8622: Mouse pointer shifted ~10px: rE64f87877a629: fix pointer offset fpor older themes.
Wed, Apr 1, 12:28 PM · E on FreeBSD, enlightenment-git
raster closed T8622: Mouse pointer shifted ~10px as Resolved.

fixed by 64f87877a6294ab46684f0da36ef7bc6f1dabe59

Wed, Apr 1, 12:16 PM · E on FreeBSD, enlightenment-git
netstar triaged T8641: elm_popup: EPhoto Regression as High priority.
Wed, Apr 1, 12:14 PM · efl (efl-1.24)
segfaultxavi removed a parent revision for D11637: exactness docs: Add docs, fix docs, remove docs: D11634: exactness: protect against forked calls.
Wed, Apr 1, 10:28 AM · efl
segfaultxavi removed a child revision for D11634: exactness: protect against forked calls: D11637: exactness docs: Add docs, fix docs, remove docs.
Wed, Apr 1, 10:28 AM · efl
Diffusion closed D11634: exactness: protect against forked calls.
Wed, Apr 1, 10:27 AM · efl
segfaultxavi requested review of D11637: exactness docs: Add docs, fix docs, remove docs.
Wed, Apr 1, 9:44 AM · efl
segfaultxavi added a child revision for D11634: exactness: protect against forked calls: D11637: exactness docs: Add docs, fix docs, remove docs.
Wed, Apr 1, 9:44 AM · efl
bu5hm4n added a comment to D11634: exactness: protect against forked calls.

That does also not work, because a eventual execp would overwrite anything in there, that is not in a environmemt variable .

Wed, Apr 1, 8:46 AM · efl
zmike added a comment to D11634: exactness: protect against forked calls.

In that case you should probably have a ecore_fork_reset_callback_add() call to correctly handle forks.

Wed, Apr 1, 8:42 AM · efl
bu5hm4n added a comment to D11634: exactness: protect against forked calls.

@zmike mhm it cannot fix the issue here, as the same might happen theoretically due to evas forking, or efl_net or eio or eeze ... we have a lot places where we do that ...

Wed, Apr 1, 8:39 AM · efl
zmike added a comment to D11634: exactness: protect against forked calls.

efreet_cache_disable() for exactness overall might be a more permanent solution here.

Wed, Apr 1, 8:33 AM · efl
segfaultxavi accepted D11634: exactness: protect against forked calls.

I confirm this fixes my problems with Exactness. Please land.

Wed, Apr 1, 8:31 AM · efl
bu5hm4n added reviewers for D11634: exactness: protect against forked calls: stefan_schmidt, segfaultxavi, zmike.
Wed, Apr 1, 8:24 AM · efl
bu5hm4n updated the diff for D11634: exactness: protect against forked calls.

this time a working possibility

Wed, Apr 1, 8:24 AM · efl
netstar moved T6106: Code folding from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Apr 1, 7:23 AM · Restricted Project
netstar moved T6108: Automatic code indenting / formatting from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Apr 1, 7:23 AM · Restricted Project
netstar moved T6135: wrap mode for editor widgets from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Apr 1, 7:23 AM · Restricted Project
netstar moved T6230: Add markdown preview when editing markdown documents from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Wed, Apr 1, 7:22 AM · Restricted Project
netstar claimed T6135: wrap mode for editor widgets.

I'll take this on post 1.24 release. Would be good to chat with you about it.

Wed, Apr 1, 7:20 AM · Restricted Project
netstar claimed T6230: Add markdown preview when editing markdown documents .

I'll see if we cant do this in 0.9 and efl 1.25.

Wed, Apr 1, 7:20 AM · Restricted Project
netstar closed T6515: Move Edi skeleton projects to Meson as Resolved.
Wed, Apr 1, 7:19 AM · Restricted Project
netstar closed T6515: Move Edi skeleton projects to Meson, a subtask of T5330: Evaluate and review how easy it is to write new EFL based application, as Resolved.
Wed, Apr 1, 7:19 AM · efl: api, efl: docs
netstar added a comment to T6515: Move Edi skeleton projects to Meson.

This is in edi 0.8 which is out after efl 1.24.

Wed, Apr 1, 7:19 AM · Restricted Project
netstar closed T6114: non-project mode...not what I expected as Resolved.

This is actually done.

Wed, Apr 1, 7:18 AM · Restricted Project
stefan_schmidt added a reviewer for D11636: ci: travis: switch exactness testing to normal test file: bu5hm4n.
Wed, Apr 1, 6:34 AM · efl
stefan_schmidt requested review of D11636: ci: travis: switch exactness testing to normal test file.
Wed, Apr 1, 6:33 AM · efl
ali.alzyod closed T8637: evas_textblock : segmentation fault when using markup set with <ps> as Resolved.
Wed, Apr 1, 5:56 AM · efl
netstar closed T5390: Modify EDI to start with editor, bypass project wizard as Resolved.

This is actually done in 0.8 which will release after efl-1.24

Wed, Apr 1, 5:50 AM · Restricted Project
netstar abandoned D11635: elm_naviframe: Do not pop top item if top item..

Thanks guys.

Wed, Apr 1, 5:48 AM · efl
netstar updated subscribers of D11635: elm_naviframe: Do not pop top item if top item..

@Jaehyun Is that a feature or a miracle? It works here. @bu5hm4n probably a good idea, the solution is a bit tricky and could do with being documented.

Wed, Apr 1, 5:40 AM · efl
Jaehyun_Cho added a comment to D11635: elm_naviframe: Do not pop top item if top item..

I think that if EDI's wizard registers pop_cb and does nothing in pop_cb and returns EINA_FALSE in the pop_cb, then the last item is not popped.

Wed, Apr 1, 3:47 AM · efl
bu5hm4n added a comment to D11635: elm_naviframe: Do not pop top item if top item..

While i agree with @Jaehyun_Cho what do you think of adding a flag to enable that feature ? The feature itself sounds usefull to me :)

Wed, Apr 1, 3:44 AM · efl
Jaehyun_Cho requested changes to D11635: elm_naviframe: Do not pop top item if top item..

I think this patch breaks the backward compatibility.
Because users can register their own pop_cb by using elm_naviframe_item_pop_cb_set().
So if the popped item is the last item, then users' pop_cb is called and elm_win or something is deleted manually in the pop_cb.
However, this patch do not allow pop_cb is called if the popped item is the last item.
So I think this patch should not be accepted.

Wed, Apr 1, 3:42 AM · efl
netstar requested review of D11635: elm_naviframe: Do not pop top item if top item..
Wed, Apr 1, 3:29 AM · efl
bu5hm4n updated the diff for D11634: exactness: protect against forked calls.

git add -p mistake

Wed, Apr 1, 3:15 AM · efl
bu5hm4n requested review of D11634: exactness: protect against forked calls.
Wed, Apr 1, 3:02 AM · efl

Tue, Mar 31

jf_simon added a reviewer for D11633: cpuclock - allow setting to open although the popup is visible: raster.
Tue, Mar 31, 11:28 PM · enlightenment-git
jf_simon requested review of D11633: cpuclock - allow setting to open although the popup is visible.
Tue, Mar 31, 11:26 PM · enlightenment-git
kimcinoo abandoned D11626: support density independent pixel.

@devilhorns thanks for your review, but I would like to abandon this patch.

Tue, Mar 31, 9:54 PM · efl
netstar added a comment to T8622: Mouse pointer shifted ~10px.

I'm using Debian and X and Simotek's Ice theme.

Tue, Mar 31, 11:58 AM · E on FreeBSD, enlightenment-git
zmike requested review of D11632: tests/hover: add behavior tests for elm_hover.
Tue, Mar 31, 10:02 AM · efl
zmike added a child revision for D11631: tests/layout: add explicit test for freeze and thaw no-op correctness: D11632: tests/hover: add behavior tests for elm_hover.
Tue, Mar 31, 10:02 AM · efl
zmike requested review of D11631: tests/layout: add explicit test for freeze and thaw no-op correctness.
Tue, Mar 31, 10:02 AM · efl
zmike added a child revision for D11630: tests/elm: add wrapper for forcing manual render in tests: D11631: tests/layout: add explicit test for freeze and thaw no-op correctness.
Tue, Mar 31, 10:02 AM · efl
zmike requested review of D11630: tests/elm: add wrapper for forcing manual render in tests.
Tue, Mar 31, 10:01 AM · efl
zmike added a child revision for D11629: tests/elm: add helper macros for asserting size and position of objects: D11630: tests/elm: add wrapper for forcing manual render in tests.
Tue, Mar 31, 10:01 AM · efl
zmike requested review of D11629: tests/elm: add helper macros for asserting size and position of objects.
Tue, Mar 31, 10:01 AM · efl
zmike added a child revision for D11628: efl_ui/layout: correctly batch object changed state when using freeze/thaw: D11629: tests/elm: add helper macros for asserting size and position of objects.
Tue, Mar 31, 10:01 AM · efl
zmike requested review of D11628: efl_ui/layout: correctly batch object changed state when using freeze/thaw.
Tue, Mar 31, 10:00 AM · efl
stefan_schmidt closed D11627: exactness: error when _src_unit is NULL.
Tue, Mar 31, 6:02 AM · efl
stefan_schmidt closed D11624: exactness: equip with ERR and CRIT.
Tue, Mar 31, 6:02 AM · efl
stefan_schmidt closed D11618: exactness: correctly call mkdir.
Tue, Mar 31, 6:01 AM · efl
stefan_schmidt closed D11617: exactness: do not efl_del the evas.
Tue, Mar 31, 6:01 AM · efl
stefan_schmidt closed D11616: exactness_play: introduce runner script.
Tue, Mar 31, 6:01 AM · efl
stefan_schmidt closed D11614: exactness_player: refactor main method.
Tue, Mar 31, 5:59 AM · efl
stefan_schmidt closed D11615: exactness_play: transform to LD_PRELOAD library.
Tue, Mar 31, 5:59 AM · efl
stefan_schmidt closed D11613: exactness: remove code for compiling.
Tue, Mar 31, 5:59 AM · efl
stefan_schmidt closed D11611: exactness_record: introduce runner script.
Tue, Mar 31, 5:58 AM · efl
stefan_schmidt closed D11610: exactness_recorder: move to preload.
Tue, Mar 31, 5:58 AM · efl
stefan_schmidt closed D11623: exactness_recorder: refactor main method.
Tue, Mar 31, 5:58 AM · efl
stefan_schmidt accepted D11627: exactness: error when _src_unit is NULL.
Tue, Mar 31, 5:48 AM · efl
stefan_schmidt accepted D11624: exactness: equip with ERR and CRIT.
Tue, Mar 31, 5:45 AM · efl
stefan_schmidt accepted D11623: exactness_recorder: refactor main method.
Tue, Mar 31, 5:44 AM · efl
stefan_schmidt accepted D11620: Replace strncmp code.

Let's take this patch as one cleanup and if we want to tackle the other patterns we can do as follow up patches.

Tue, Mar 31, 5:41 AM · efl
stefan_schmidt accepted D11616: exactness_play: introduce runner script.
Tue, Mar 31, 5:39 AM · efl
stefan_schmidt accepted D11615: exactness_play: transform to LD_PRELOAD library.
Tue, Mar 31, 5:35 AM · efl
stefan_schmidt accepted D11614: exactness_player: refactor main method.
Tue, Mar 31, 5:33 AM · efl
stefan_schmidt accepted D11610: exactness_recorder: move to preload.
Tue, Mar 31, 5:28 AM · efl
devilhorns requested changes to D11626: support density independent pixel.
Tue, Mar 31, 4:49 AM · efl
ali.alzyod added a comment to D11621: evas_textblock : fix text insertion & selection with ps in single line.

Testing is failing because text nodes don't recreated on efl_multiline_set.
in simple words

Tue, Mar 31, 3:37 AM · efl
ali.alzyod requested changes to D11621: evas_textblock : fix text insertion & selection with ps in single line.
Tue, Mar 31, 3:34 AM · efl
ali.alzyod updated the diff for D11621: evas_textblock : fix text insertion & selection with ps in single line.
  • add test case
Tue, Mar 31, 3:34 AM · efl
bu5hm4n updated the diff for D11610: exactness_recorder: move to preload.

add mingw stubs

Tue, Mar 31, 2:45 AM · efl
bu5hm4n updated the diff for D11615: exactness_play: transform to LD_PRELOAD library.

add windows stubs

Tue, Mar 31, 2:43 AM · efl
bu5hm4n requested review of D11627: exactness: error when _src_unit is NULL.
Tue, Mar 31, 1:33 AM · efl
bu5hm4n added a child revision for D11624: exactness: equip with ERR and CRIT: D11627: exactness: error when _src_unit is NULL.
Tue, Mar 31, 1:33 AM · efl

Mon, Mar 30

kimcinoo planned changes to D11626: support density independent pixel.
Mon, Mar 30, 8:13 PM · efl
kimcinoo requested review of D11626: support density independent pixel.
Mon, Mar 30, 8:10 PM · efl
netstar closed T7344: Terminology: allow fonts to be rendered without anti-aliasing. as Resolved.

This isn't going to happen. We don't do sub pixel rendering.

Mon, Mar 30, 1:15 PM · Terminology
netstar closed T7317: EFL: make progressbar example. as Resolved.

Fixed by okra in https://phab.enlightenment.org/D7745

Mon, Mar 30, 1:14 PM
netstar closed T5723: Various EFL applications including EFL are installing icons in the wrong location as Resolved.
Mon, Mar 30, 1:12 PM · Restricted Project, Restricted Project
netstar closed T8365: Eo files not recognized by EDI as text as Resolved.

This is fixed. It was due to mime type handling.

Mon, Mar 30, 1:12 PM
bu5hm4n updated the diff for D11615: exactness_play: transform to LD_PRELOAD library.

typo

Mon, Mar 30, 10:46 AM · efl
bu5hm4n updated the diff for D11616: exactness_play: introduce runner script.

typo

Mon, Mar 30, 10:45 AM · efl
bu5hm4n added inline comments to D11615: exactness_play: transform to LD_PRELOAD library.
Mon, Mar 30, 10:43 AM · efl