Reasonable commit. thank you.
The default values for underline_type and background_type are off, which is an invalid value for Unified (should be none).
Please review the docs for style_apply, they still mention underline and strikethrough, for example, and they use off in several places.
looks good to me.
I think I know what the intended commit is, though
@zmike Thank you for the details.
Needs serious rebasing after 581bec9598943cc9274dfe7db1a73a4c878c3cdd.
Rebase after caused_by has been added
- update all style types
fix leaks & adjust to ecore evas emitting changed events for self caused buffer changes
I can't comment on the code or whether the generated code works or not, but I confirm this fixes the build break after D11190.
fixes + also call changed event for self-caused events
This patch would be covered by https://phab.enlightenment.org/D11188.
Please check D11214
fix leaks, fix wrongly annotated drop,drop event
removing underline in GetPropBind and GetFactoryBind for complying mono naming rule.
virtual public to public virtual.
line indent fix.
I made that move autoplay and looping to Efl.Player and implements in Efl.Ui.Vg_animation.
This looks ok. :) Thanks you.
this patch will be replaced to D11211
I think we get agreement about this patch, so if I update new layoutFactory depends on this patch, it is ready for accept, am I right @cedric?
update patch with removing layoutFactory, and generic for all.
fill the doc comments but it need to be updated later.
Thank you for review.
Added constrain for Layout_Base
This looks ok :) Accepted. Thanks !
Thanks - and another opinion ?
I think everything seems ok now :)
The accessor<string> part is generating invalid C# code:src/bindings/mono/efl_ui_dnd.eo.cs(438,69): error CS0029: Cannot implicitly convert type `System.Collections.Generic.IEnumerable<string>' to `System.IntPtr' src/bindings/mono/efl_ui_dnd.eo.cs(448,69): error CS0029: Cannot implicitly convert type `System.IntPtr' to `System.Collections.Generic.IEnumerable<string>'
fix array usage because eina_array is dumb
add a couple missing cases
The accessor<string> part is generating invalid C# code:
src/bindings/mono/efl_ui_dnd.eo.cs(438,69): error CS0029: Cannot implicitly convert type `System.Collections.Generic.IEnumerable<string>' to `System.IntPtr' src/bindings/mono/efl_ui_dnd.eo.cs(448,69): error CS0029: Cannot implicitly convert type `System.IntPtr' to `System.Collections.Generic.IEnumerable<string>'
@woohyun This is still important AFAIU, right?
Yes, that addresses the issue I raised.
Ah yeah, looks great, thanks!.
In fact, this should probably be ignored entirely in a multi-touch scenario since the info will already be passed directly to the move function. So the simpler solution here would be to verify whether a multi-event is occurring and then skip this code entirely (I think).
I actually don't think this is correct. An event like this should only occur after a button press event has occurred, meaning that it should be possible to detect that we're inside a multi-touch event, check the Ecore_Event_Last struct to pull out the device info for whichever "devices" are currently pressed, and feed it accurately to the multi move function.
Works as expected, builds, passes tests and fixes T8588. What else can a guy ask for?
Use current indent level instead of arbitrary level 2.