Comments regarding this class:

• orientation: it appears that the only entity that is actaully setting is the window implementation. There is no user of the on_* method. To me it looks like the efl_ui_win.c implementation could just go and walk the widget tree, and emit events on the layouts that dont orientation_mode_set set to DISABLE.
• focus_highlight_{animate, style, enabled}: They should be moved to the Efl.Ui.Win, as the comments in the .eo file state
• focused_item: this should go, there are no items in the new API.
• show_region: interest_region: This should be merged into one concept, and in the API this should only be the getter of one single rectable IMO (pos relative to the widget)
• on_disabled: Should be disabled,changed event.
• scroll_*: Not sure what it does here ...
• theme_apply: what it tells to do makes sense. However, it syncs up mirrored states o_O.

Can you add @since 1.22 at the same time that you remove the @beta from the class? (as suggested in T7704).

I suggest the same commit that removes the @beta tag adds @since 1.22 to the class docs.

Rebase & Update

Rebase & Update

Rebase & Update

Rebase & Update

Rebase & Update

Rebase & Update

After the patchset, things look good to me. seat_focus Is the last thing which looks doubious to me. @cedric @woohyun @Jaehyun_Cho opinions on that API ?

so fast!

Fixed in the update before your comment :)

Rebase & Update

Rebase & Update

Rebase & Update

Rebase & Update

Rebase & Update

can you be slightly more specific with your commit log, e.g., "this code was duplicated so I created function named XYZ to deduplicate"

Alright I'm gonna hammer this in to expedite things.

...

looks good to me.

rebase

rebase

rebase

@bu5hm4n @YOhoho
Thank you,
and I made D8005 because both of your comments looked correct :)

I think this might fix your problem @zmike

As @bu5hm4n is pointing out, you want to clean the future when it is resolved. Best way would be to have a .free method in efl_io_manager_future. Also you seems to have a very small test that exhibit the problem, could you add it to elementary fileselector test suite?

Maybe a test to trigger this problem would be useful.

no punctuation in error msgs please

...

Ahmen!

@zmike i think group_member_is is fine, its quite handy and support efl.canvas.group objects which do not force theire children to have them as render parent. Seems like it is somehow usefull.

seat_focus seems unused, do we want to remove it, its unclear to me what is actaully does. Additionally, it seems a bit off, that we have a list of seats *per* object.

I think event_animation can be a bit difficult and dangerous, you can see it with the implementation, two special cases for SHOW and HIDE. From a user POV this looks to me like i can go and add an animation to the POSITION_CHANGED event. However, you cannot, since the position will be moved. Not stopped by the animation, so to me this looks only usefull for hide and show. IMO it would be better to "copy" this functionality into efl_ui_stack.c (which is the only user of this). And remove this API and anim_* events from this object... What do you say @Jaehyun_Cho ?

Rebased

one minor nit