Page MenuHomePhabricator
Feed All Stories

Today

bu5hm4n added a comment to D8920: efl_ui_stack: remove!.

@segfaultxavi this depends on the parameter, when delete_on_transition_end is true, then the user does not need to care about the value of the promise, only the point of time. When the user passes false as argument, then the user *needs* to handle the value of the promise. However, you have to note here, that when the user does not *want* to take care of that returned value, the widget that got unpackt will just float arround on the UI, which is probebly not what a user wants ... :)

Sat, Jun 15, 8:05 AM · efl
segfaultxavi added a comment to D8920: efl_ui_stack: remove!.

@bu5hm4n I'm not arguing against using a Promise, I'm just trying to see if there are alternatives :)

Sat, Jun 15, 6:46 AM · efl
bu5hm4n added a comment to T7905: efl.ui.item.

@SanghyeonLee Can you verify that all usages of the Efl.Ui.Item class do only require a numeric index as parent, never something like an object ?

Sat, Jun 15, 3:18 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7847: efl.ui.clickable.

It was also brought up that it is confusing to have this in the ui namespace, we should probebly move this to the gfx namespace ...

Sat, Jun 15, 3:16 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n removed parent tasks for T7866: efl.ui.nstate: T7510: evaluate stabilization potential of efl.ui classes and dependencies, T7865: efl.ui.check.
Sat, Jun 15, 3:15 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n removed a subtask for T7865: efl.ui.check: T7866: efl.ui.nstate.
Sat, Jun 15, 3:15 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n removed a subtask for T7510: evaluate stabilization potential of efl.ui classes and dependencies: T7866: efl.ui.nstate.
Sat, Jun 15, 3:15 AM · efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7866: efl.ui.nstate.

Undependend from this, we do not need this widget, lets remove it from the list.

Sat, Jun 15, 3:15 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to D8920: efl_ui_stack: remove!.

@segfaultxavi in all honesty, not returning the promise is not an option here, if we require that in future we need a new API, which basically does the same. It is perfectly possible right now to do that, bindings do lack this feature, but they should add that.

Sat, Jun 15, 3:09 AM · efl
bu5hm4n added a comment to D8920: efl_ui_stack: remove!.

@Jaehyun_Cho Can you answer if you are happy with pop / push ?

Sat, Jun 15, 2:59 AM · efl
bu5hm4n added a comment to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

@cedric @segfaultxavi @Jaehyun_Cho so my actions items here are:

Sat, Jun 15, 2:57 AM · efl
bu5hm4n added a comment to D9060: efl_ui_radio: cleanup API.

@cedric @segfaultxavi @Jaehyun_Cho so my actions items here are:

Sat, Jun 15, 2:56 AM · efl

Yesterday

bu5hm4n planned changes to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

@segfaultxavi i rebased now the whole thing and tested again, this seems to work for me.

Fri, Jun 14, 5:45 PM · efl
bu5hm4n updated the diff for D9060: efl_ui_radio: cleanup API.

remove asdf

Fri, Jun 14, 5:42 PM · efl
bu5hm4n added a comment to D9060: efl_ui_radio: cleanup API.
In D9060#167031, @zmike wrote:

One of the main points of the efl_add extended construction mechanics was to allow things like this, where you could set all the properties during construction. The only thing that perhaps was not clearly defined from here would be e.g., whether packing the widget into a box during construction is allowed, but probably we did want that functionality too so that every function can be called during construction.

Fri, Jun 14, 5:39 PM · efl
bu5hm4n updated the diff for D9060: efl_ui_radio: cleanup API.

rebase

Fri, Jun 14, 5:33 PM · efl
bu5hm4n updated the diff for D9059: efl_ui_radio: refactor for usage of efl_ui_check_selected.

rebase

Fri, Jun 14, 5:33 PM · efl
bu5hm4n updated the diff for D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

fix bug, remove printf

Fri, Jun 14, 5:33 PM · efl
cedric requested review of D9105: evas: add a test for loading Android 9patch file..
Fri, Jun 14, 5:17 PM · efl
cedric added a child revision for D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas.: D9105: evas: add a test for loading Android 9patch file..
Fri, Jun 14, 5:17 PM · efl
cedric updated the diff for D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..
Fri, Jun 14, 5:17 PM · efl
cedric updated the diff for D9103: evas: add support for .9.png file to PNG loader..
Fri, Jun 14, 5:17 PM · efl
cedric updated the diff for D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Fri, Jun 14, 5:16 PM · efl
cedric updated the diff for D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:16 PM · efl
cedric updated the diff for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:16 PM · efl
cedric updated the diff for D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:16 PM · efl
cedric updated the diff for D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:15 PM · efl
cedric updated the diff for D9096: evas: add support for stretchable zone..
Fri, Jun 14, 5:15 PM · efl
cedric updated the diff for D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:15 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:14 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:14 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:13 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:13 PM · efl
cedric requested review of D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..
Fri, Jun 14, 5:13 PM · efl
cedric added a child revision for D9103: evas: add support for .9.png file to PNG loader.: D9104: ecore_evas: on internal Evas canvas uncontrolled death, properly clean up Ecore_Evas..
Fri, Jun 14, 5:13 PM · efl
cedric requested review of D9103: evas: add support for .9.png file to PNG loader..
Fri, Jun 14, 5:13 PM · efl
cedric added a child revision for D9102: evas: add infrastructure to feed 9 patch information from file loader to image object.: D9103: evas: add support for .9.png file to PNG loader..
Fri, Jun 14, 5:12 PM · efl
cedric updated the diff for D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Fri, Jun 14, 5:12 PM · efl
cedric updated the diff for D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:12 PM · efl
cedric updated the diff for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:12 PM · efl
cedric updated the diff for D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:11 PM · efl
cedric updated the diff for D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:11 PM · efl
cedric updated the diff for D9096: evas: add support for stretchable zone..
Fri, Jun 14, 5:11 PM · efl
cedric updated the diff for D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:11 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:10 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:10 PM · efl
cedric requested review of D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Fri, Jun 14, 5:09 PM · efl
cedric added a child revision for D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image.: D9102: evas: add infrastructure to feed 9 patch information from file loader to image object..
Fri, Jun 14, 5:09 PM · efl
cedric updated the diff for D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:09 PM · efl
cedric updated the diff for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:09 PM · efl
cedric updated the diff for D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:08 PM · efl
cedric updated the diff for D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:07 PM · efl
cedric updated the diff for D9096: evas: add support for stretchable zone..
Fri, Jun 14, 5:07 PM · efl
cedric updated the diff for D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:07 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:06 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:06 PM · efl
cedric requested review of D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:06 PM · efl
cedric added a child revision for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader.: D9101: evas: break ImagE_Loader API to allow for getting property from the data field of an image..
Fri, Jun 14, 5:05 PM · efl
cedric updated the diff for D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:05 PM · efl
cedric updated the diff for D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:05 PM · efl
cedric updated the diff for D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:05 PM · efl
cedric updated the diff for D9096: evas: add support for stretchable zone..
Fri, Jun 14, 5:05 PM · efl
cedric updated the diff for D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:05 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:05 PM · efl
cedric requested review of D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:04 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:04 PM · efl
cedric requested review of D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:04 PM · efl
cedric added a child revision for D9098: evas: improve test to evaluate stretch zone effect on content zone.: D9099: evas: break Evas_Loader API and introduce a version numbering for Image_Loader..
Fri, Jun 14, 5:03 PM · efl
cedric requested review of D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:03 PM · efl
cedric added a child revision for D9097: evas: take stretch zone into account when content zone is requested.: D9098: evas: improve test to evaluate stretch zone effect on content zone..
Fri, Jun 14, 5:03 PM · efl
cedric requested review of D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:03 PM · efl
cedric added a child revision for D9096: evas: add support for stretchable zone.: D9097: evas: take stretch zone into account when content zone is requested..
Fri, Jun 14, 5:03 PM · efl
cedric requested review of D9096: evas: add support for stretchable zone..
Fri, Jun 14, 5:03 PM · efl
cedric added a child revision for D9095: evas: add test for the new efl_gfx_image_content_zone_get API.: D9096: evas: add support for stretchable zone..
Fri, Jun 14, 5:02 PM · efl
cedric updated the diff for D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:02 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:02 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 5:02 PM · efl
cedric requested review of D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:02 PM · efl
cedric added a child revision for D9093: evas: add an API to know where inside an object content can be layout over.: D9095: evas: add test for the new efl_gfx_image_content_zone_get API..
Fri, Jun 14, 5:01 PM · efl
cedric updated the diff for D9093: evas: add an API to know where inside an object content can be layout over..

Just screwed by phab.

Fri, Jun 14, 5:01 PM · efl
cedric updated the diff for D9092: eina: add an error for incorrect parameter common error..

Just screwed by phab

Fri, Jun 14, 5:01 PM · efl
cedric requested review of D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 5:00 PM · efl
cedric added a child revision for D9092: eina: add an error for incorrect parameter common error.: D9093: evas: add an API to know where inside an object content can be layout over..
Fri, Jun 14, 4:59 PM · efl
cedric requested review of D9092: eina: add an error for incorrect parameter common error..
Fri, Jun 14, 4:59 PM · efl
segfaultxavi added a comment to D9060: efl_ui_radio: cleanup API.

Good point! Agreed!

Fri, Jun 14, 11:03 AM · efl
cedric requested changes to D9060: efl_ui_radio: cleanup API.

I am actually wondering if it wouldn't make sense to make efl_ui_radio_state_value_set and efl_ui_radio_group_register actually @constructor as I don't think we want to deal with changing them once the object are created?

Fri, Jun 14, 11:01 AM · efl
zmike requested review of D9091: tests: add functional unit tests for radio widgets.
Fri, Jun 14, 10:13 AM · efl
zmike added a comment to T7898: efl.ui.format.

https://i.imgur.com/m4vDHwO.gifv

Fri, Jun 14, 10:10 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

https://media.giphy.com/media/oOX5qIDkzDjeo/giphy.gif

Fri, Jun 14, 9:45 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7898: efl.ui.format.

We try to leave some functionality to the imagination of the user; no docs can possibly hope to capture the gestalt of efl's splendor.

Fri, Jun 14, 9:18 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7897: efl.ui.spin.

I've written my concerns in T7898.

Fri, Jun 14, 9:18 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7898: efl.ui.format.

This class needs serious doc love. I do not understand how format_cb and format_string are supposed to interact. Also, Format_Func_Cb only has input parameters, no output, where is the formatted string supposed to be written?

Fri, Jun 14, 9:17 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike added a comment to T7897: efl.ui.spin.

I think you would use the callback?

Fri, Jun 14, 9:07 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike closed D9090: Efl.Ui.Slider: Rename event delay,changed to steady.
Fri, Jun 14, 9:06 AM · efl
zmike added a comment to T7900: efl.pack_table.

Future me.

Fri, Jun 14, 9:04 AM · efl: api, efl (efl-1.23), efl: language bindings
zmike accepted D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.

Oh ok.

Fri, Jun 14, 9:04 AM · efl
zmike accepted D9090: Efl.Ui.Slider: Rename event delay,changed to steady.
Fri, Jun 14, 9:03 AM · efl
segfaultxavi added a comment to T7897: efl.ui.spin.

And I still don't know how would you implement the special values with a format string.

Fri, Jun 14, 8:25 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added a comment to T7900: efl.pack_table.

When you say "Let us cut it"... who exactly is us? 😁

Fri, Jun 14, 8:22 AM · efl: api, efl (efl-1.23), efl: language bindings
segfaultxavi added inline comments to D9058: Introduce Efl.Ui.Radio_Group & Efl.Ui.Radio_Box.
Fri, Jun 14, 8:20 AM · efl