Page MenuHomePhabricator
Feed All Stories

Today

CHAN accepted D11207: efl/gesture: ignore successive press events in zoom recognizer when canceled.

Reasonable commit. thank you.

Tue, Jan 28, 3:10 AM · efl
segfaultxavi requested changes to D11188: efl.canvas.textblock: update style strings.

The default values for underline_type and background_type are off, which is an invalid value for Unified (should be none).
Please review the docs for style_apply, they still mention underline and strikethrough, for example, and they use off in several places.

Tue, Jan 28, 3:09 AM · efl
CHAN accepted D11208: efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer.

looks good to me.

Tue, Jan 28, 3:07 AM · efl
CHAN added a comment to D11163: evas/events: fix multi-touch object targeting on touch down events.

I think I know what the intended commit is, though

Tue, Jan 28, 3:01 AM · efl
subodh6129 requested review of D11215: edje_entry: Fix to have event over item object..
Tue, Jan 28, 2:53 AM · efl
CHAN added a comment to D11144: efl/gesture: redo (and make stupider) hash usage in gesture manager.

@zmike Thank you for the details.

Tue, Jan 28, 2:44 AM · efl
segfaultxavi requested changes to D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator.

Needs serious rebasing after 581bec9598943cc9274dfe7db1a73a4c878c3cdd.

Tue, Jan 28, 2:41 AM · efl
bu5hm4n removed a child revision for D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator: D11196: efl_ui_draggable: move these events back to legacy.
Tue, Jan 28, 2:26 AM · efl
bu5hm4n removed a parent revision for D11196: efl_ui_draggable: move these events back to legacy: D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator.
Tue, Jan 28, 2:26 AM · efl
bu5hm4n updated the diff for D11190: rewrite efl cnp and dnd handling.

update

Tue, Jan 28, 2:16 AM · efl
segfaultxavi added a child revision for D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator: D11196: efl_ui_draggable: move these events back to legacy.
Tue, Jan 28, 2:05 AM · efl
segfaultxavi added a parent revision for D11196: efl_ui_draggable: move these events back to legacy: D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator.
Tue, Jan 28, 2:05 AM · efl
segfaultxavi removed a parent revision for D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator: D11190: rewrite efl cnp and dnd handling.
Tue, Jan 28, 2:05 AM · efl
segfaultxavi removed a child revision for D11190: rewrite efl cnp and dnd handling: D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator.
Tue, Jan 28, 2:05 AM · efl
segfaultxavi updated the diff for D11204: docs: Strengthen docs for Copy&Paste and Drag&Drop.

Rebase after caused_by has been added

Tue, Jan 28, 2:02 AM · efl
ali.alzyod updated the summary of D11188: efl.canvas.textblock: update style strings.
Tue, Jan 28, 1:58 AM · efl
ali.alzyod updated the diff for D11188: efl.canvas.textblock: update style strings.
  • update all style types
Tue, Jan 28, 1:54 AM · efl
bu5hm4n updated the diff for D11190: rewrite efl cnp and dnd handling.

fix leaks & adjust to ecore evas emitting changed events for self caused buffer changes

Tue, Jan 28, 1:33 AM · efl
segfaultxavi added a comment to D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator.

I can't comment on the code or whether the generated code works or not, but I confirm this fixes the build break after D11190.

Tue, Jan 28, 1:33 AM · efl
bu5hm4n updated the diff for D11192: ecore_evas: Introduce cnp / dnd API for ecore evas.

fixes + also call changed event for self-caused events

Tue, Jan 28, 1:31 AM · efl
woohyun abandoned D11064: evas_object_textblock: add format strings for new efl_text_style.

This patch would be covered by https://phab.enlightenment.org/D11188.

Tue, Jan 28, 1:10 AM · efl
CHAN added a comment to T8016: Write test cases for Ecore_Wl2 API.

Please check D11214

Tue, Jan 28, 12:25 AM · Restricted Project, efl
CHAN added a task to D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions.: T8016: Write test cases for Ecore_Wl2 API.
Tue, Jan 28, 12:21 AM · efl
CHAN added a revision to T8016: Write test cases for Ecore_Wl2 API: D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Tue, Jan 28, 12:21 AM · Restricted Project, efl
CHAN requested review of D11214: tests/ecore_wl2: Add dummy tests for ecore_wl2_* functions..
Tue, Jan 28, 12:16 AM · efl

Yesterday

jsuya requested review of D11213: Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4.
Mon, Jan 27, 11:45 PM · efl
jsuya added a child revision for D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale): D11213: Efl.Gfx.Vg.Value_Provider: Change transform value type to Matrix4.
Mon, Jan 27, 11:45 PM · efl
bu5hm4n updated the diff for D11192: ecore_evas: Introduce cnp / dnd API for ecore evas.

fix leak

Mon, Jan 27, 11:39 PM · efl
bu5hm4n updated the diff for D11195: Introduce initial selection & dnd support for x..

fix leaks

Mon, Jan 27, 11:37 PM · efl
bu5hm4n updated the diff for D11190: rewrite efl cnp and dnd handling.

fix leaks, fix wrongly annotated drop,drop event

Mon, Jan 27, 11:34 PM · efl
SanghyeonLee updated the diff for D11211: C#: Create GenericFactory for non-layout objects.

removing underline in GetPropBind and GetFactoryBind for complying mono naming rule.
virtual public to public virtual.
line indent fix.

Mon, Jan 27, 10:12 PM · efl
jsuya added a comment to T8476: efl_ui_animation_view.

I made that move autoplay and looping to Efl.Player and implements in Efl.Ui.Vg_animation.

Mon, Jan 27, 10:06 PM · efl (efl-1.24), efl: api
woohyun closed D11146: eolian_mono: make struct immutable.
Mon, Jan 27, 9:51 PM · efl
woohyun added a commit to T8397: C#: CA1051: Do not declare visible instance fields: rEFL581bec959894: eolian_mono: make struct immutable.
Mon, Jan 27, 9:51 PM · efl: language bindings
woohyun accepted D11146: eolian_mono: make struct immutable.

This looks ok. :) Thanks you.

Mon, Jan 27, 9:46 PM · efl
jsuya requested review of D11212: Efl.Player: Move autoplay/playback_loop from Efl.Ui.Vg_Animation.
Mon, Jan 27, 9:40 PM · efl
jsuya added a revision to T8476: efl_ui_animation_view: D11212: Efl.Player: Move autoplay/playback_loop from Efl.Ui.Vg_Animation.
Mon, Jan 27, 9:40 PM · efl (efl-1.24), efl: api
YOhoho updated the diff for D11146: eolian_mono: make struct immutable.

rebase

Mon, Jan 27, 9:24 PM · efl
SanghyeonLee abandoned D11161: eolian_mono : rename ItemFactory<T> to GenericFactory<T>.

this patch will be replaced to D11211

Mon, Jan 27, 8:49 PM · efl
SanghyeonLee added a comment to D11160: efl_ui: rename Layout_Factory to Generic_Factory..

I think we get agreement about this patch, so if I update new layoutFactory depends on this patch, it is ready for accept, am I right @cedric?

Mon, Jan 27, 8:49 PM · efl
SanghyeonLee updated the diff for D11211: C#: Create GenericFactory for non-layout objects.

update patch with removing layoutFactory, and generic for all.
fill the doc comments but it need to be updated later.

Mon, Jan 27, 8:47 PM · efl
jsuya updated the diff for D11159: eina_matrix: Add eina_matrix4 operator(translate, rotate, scale).

Update docs
Thank you for review.

Mon, Jan 27, 6:11 PM · efl
felipealmeida updated the diff for D11211: C#: Create GenericFactory for non-layout objects.

Added constrain for Layout_Base

Mon, Jan 27, 5:02 PM · efl
felipealmeida requested review of D11211: C#: Create GenericFactory for non-layout objects.
Mon, Jan 27, 3:32 PM · efl
woohyun closed D11141: efl_ui_textbox / efl_ui_image_zoomable: remove duplicated code.
Mon, Jan 27, 2:09 PM · efl
woohyun added a commit to T8522: Efl.Ui.Textbox class: rEFLb3c0da13d804: efl_ui_textbox / efl_ui_image_zoomable: remove duplicated code.
Mon, Jan 27, 2:09 PM · efl (efl-1.24), efl: api, efl: language bindings
woohyun accepted D11141: efl_ui_textbox / efl_ui_image_zoomable: remove duplicated code.

This looks ok :) Accepted. Thanks !

Mon, Jan 27, 1:52 PM · efl
woohyun added a comment to T8522: Efl.Ui.Textbox class.

Thanks - and another opinion ?
I think everything seems ok now :)

Mon, Jan 27, 1:48 PM · efl (efl-1.24), efl: api, efl: language bindings
jptiz added a comment to D11190: rewrite efl cnp and dnd handling.

The accessor<string> part is generating invalid C# code:

src/bindings/mono/efl_ui_dnd.eo.cs(438,69): error CS0029: Cannot implicitly convert type `System.Collections.Generic.IEnumerable<string>' to `System.IntPtr'
src/bindings/mono/efl_ui_dnd.eo.cs(448,69): error CS0029: Cannot implicitly convert type `System.IntPtr' to `System.Collections.Generic.IEnumerable<string>'

As far as I can see, this is the first time we try to use this in our API.
Calling in the C# people... @felipealmeida, @jptiz, any idea what is happening?

Mon, Jan 27, 1:40 PM · efl
jptiz requested review of D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator.
Mon, Jan 27, 1:36 PM · efl
jptiz added a child revision for D11190: rewrite efl cnp and dnd handling: D11210: csharp: Add IntPtr to/from IEnumerable conversion in struct implicit operator.
Mon, Jan 27, 1:36 PM · efl
segfaultxavi updated the diff for D11204: docs: Strengthen docs for Copy&Paste and Drag&Drop.

Rebase

Mon, Jan 27, 11:38 AM · efl
zmike updated the diff for D11176: efl/gesture: remove 'config' property from recognizers.

doc updates

Mon, Jan 27, 11:16 AM · efl
zmike updated the diff for D11175: efl/gesture: expose 'continues' as a public property for recognizers.

doc updates

Mon, Jan 27, 11:16 AM · efl
zmike updated the diff for D11085: efl/gesture: move Point_Data to eo and add methods to fetch it for recognizers.

fix array usage because eina_array is dumb

Mon, Jan 27, 11:15 AM · efl
zmike requested review of D11209: tests/gesture: add a 10-touch tap test.
Mon, Jan 27, 11:14 AM · efl
zmike added a child revision for D11208: efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer: D11209: tests/gesture: add a 10-touch tap test.
Mon, Jan 27, 11:14 AM · efl
zmike requested review of D11208: efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer.
Mon, Jan 27, 11:14 AM · efl
zmike added a child revision for D11207: efl/gesture: ignore successive press events in zoom recognizer when canceled: D11208: efl/gesture: conditionally ignore multi-touch unpress events in zoom recognizer.
Mon, Jan 27, 11:14 AM · efl
zmike requested review of D11207: efl/gesture: ignore successive press events in zoom recognizer when canceled.
Mon, Jan 27, 11:14 AM · efl
zmike added a child revision for D11206: efl/gesture: ignore multi-touch end events in tap gesture recognizer: D11207: efl/gesture: ignore successive press events in zoom recognizer when canceled.
Mon, Jan 27, 11:14 AM · efl
zmike requested review of D11206: efl/gesture: ignore multi-touch end events in tap gesture recognizer.
Mon, Jan 27, 11:14 AM · efl
zmike added a child revision for D11198: efl/gesture: avoid direct double access in structs: D11206: efl/gesture: ignore multi-touch end events in tap gesture recognizer.
Mon, Jan 27, 11:14 AM · efl
zmike updated the diff for D11198: efl/gesture: avoid direct double access in structs.

add a couple missing cases

Mon, Jan 27, 11:13 AM · efl
zmike requested review of D11205: ecore/input: attempt to more accurately handle multi-touch mouse-in events.
Mon, Jan 27, 11:12 AM · DO NOT MERGE
segfaultxavi updated subscribers of D11190: rewrite efl cnp and dnd handling.

The accessor<string> part is generating invalid C# code:

src/bindings/mono/efl_ui_dnd.eo.cs(438,69): error CS0029: Cannot implicitly convert type `System.Collections.Generic.IEnumerable<string>' to `System.IntPtr'
src/bindings/mono/efl_ui_dnd.eo.cs(448,69): error CS0029: Cannot implicitly convert type `System.IntPtr' to `System.Collections.Generic.IEnumerable<string>'

As far as I can see, this is the first time we try to use this in our API.
Calling in the C# people... @felipealmeida, @jptiz, any idea what is happening?

Mon, Jan 27, 10:19 AM · efl
felipealmeida added a comment to D9510: eolian: Add @static to classes.

@woohyun This is still important AFAIU, right?

Mon, Jan 27, 10:15 AM · efl
segfaultxavi requested review of D11204: docs: Strengthen docs for Copy&Paste and Drag&Drop.
Mon, Jan 27, 10:06 AM · efl
segfaultxavi added a child revision for D11190: rewrite efl cnp and dnd handling: D11204: docs: Strengthen docs for Copy&Paste and Drag&Drop.
Mon, Jan 27, 10:06 AM · efl
zmike resigned from D11064: evas_object_textblock: add format strings for new efl_text_style.

Yes, that addresses the issue I raised.

Mon, Jan 27, 9:40 AM · efl
zmike added a comment to D11188: efl.canvas.textblock: update style strings.

Ah yeah, looks great, thanks!.

Mon, Jan 27, 9:39 AM · efl
zmike added a comment to D11203: ecore_input_evas: move in multi when in multi config.

In fact, this should probably be ignored entirely in a multi-touch scenario since the info will already be passed directly to the move function. So the simpler solution here would be to verify whether a multi-event is occurring and then skip this code entirely (I think).

Mon, Jan 27, 9:37 AM · efl
zmike requested changes to D11203: ecore_input_evas: move in multi when in multi config.

I actually don't think this is correct. An event like this should only occur after a button press event has occurred, meaning that it should be possible to detect that we're inside a multi-touch event, check the Ecore_Event_Last struct to pull out the device info for whichever "devices" are currently pressed, and feed it accurately to the multi move function.

Mon, Jan 27, 9:34 AM · efl
devilhorns requested changes to D11203: ecore_input_evas: move in multi when in multi config.
Mon, Jan 27, 9:00 AM · efl
segfaultxavi closed D11202: csharp: Escape contents of struct fields' value tag..
Mon, Jan 27, 8:56 AM · efl
segfaultxavi closed T8588: Ampersand is not escaped in some <value> tags. as Resolved by committing rEFL5d982dd985c6: csharp: Escape contents of struct fields' value tag..
Mon, Jan 27, 8:56 AM · Restricted Project, efl: language bindings, efl: docs
segfaultxavi accepted D11202: csharp: Escape contents of struct fields' value tag..

Works as expected, builds, passes tests and fixes T8588. What else can a guy ask for?

Mon, Jan 27, 8:55 AM · efl
bu5hm4n added reviewers for D11203: ecore_input_evas: move in multi when in multi config: devilhorns, zmike, stefan_schmidt.
Mon, Jan 27, 8:55 AM · efl
bu5hm4n requested review of D11203: ecore_input_evas: move in multi when in multi config.
Mon, Jan 27, 8:51 AM · efl
jptiz updated the diff for D11202: csharp: Escape contents of struct fields' value tag..

Use current indent level instead of arbitrary level 2.

Mon, Jan 27, 8:45 AM · efl
jptiz requested review of D11202: csharp: Escape contents of struct fields' value tag..
Mon, Jan 27, 8:37 AM · efl
jptiz added a revision to T8588: Ampersand is not escaped in some <value> tags.: D11202: csharp: Escape contents of struct fields' value tag..
Mon, Jan 27, 8:37 AM · Restricted Project, efl: language bindings, efl: docs
ali.alzyod closed T8561: efl.canvas.textblock multi-line with Paragraph separator as Resolved.
Mon, Jan 27, 8:31 AM
ali.alzyod removed a revision from T8561: efl.canvas.textblock multi-line with Paragraph separator : D11201: efl.ui.textbox: Keyboard Enter will add paragraph separator.
Mon, Jan 27, 8:30 AM
ali.alzyod removed a task from D11201: efl.ui.textbox: Keyboard Enter will add paragraph separator: T8561: efl.canvas.textblock multi-line with Paragraph separator .
Mon, Jan 27, 8:30 AM · efl
ali.alzyod added revisions to T8561: efl.canvas.textblock multi-line with Paragraph separator : D11201: efl.ui.textbox: Keyboard Enter will add paragraph separator, D9064: evas_textblock: <ps> tag respects multiline propertie.
Mon, Jan 27, 8:30 AM
ali.alzyod added a task to D9064: evas_textblock: <ps> tag respects multiline propertie: T8561: efl.canvas.textblock multi-line with Paragraph separator .
Mon, Jan 27, 8:30 AM · efl
ali.alzyod added a task to D11201: efl.ui.textbox: Keyboard Enter will add paragraph separator: T8561: efl.canvas.textblock multi-line with Paragraph separator .
Mon, Jan 27, 8:29 AM · efl
ali.alzyod added reviewers for D11201: efl.ui.textbox: Keyboard Enter will add paragraph separator: woohyun, segfaultxavi, bu5hm4n, zmike.
Mon, Jan 27, 8:28 AM · efl
ali.alzyod requested review of D11201: efl.ui.textbox: Keyboard Enter will add paragraph separator.
Mon, Jan 27, 8:24 AM · efl
devilhorns closed D11200: ecore_wl2: do not silently return.
Mon, Jan 27, 8:22 AM · efl
devilhorns closed D11199: ecore_wl2: only ungrab/grab on last/first down/up event.
Mon, Jan 27, 8:22 AM · efl
devilhorns accepted D11200: ecore_wl2: do not silently return.
Mon, Jan 27, 8:18 AM · efl
devilhorns accepted D11199: ecore_wl2: only ungrab/grab on last/first down/up event.
Mon, Jan 27, 8:17 AM · efl
bu5hm4n updated the diff for D11190: rewrite efl cnp and dnd handling.

xavi input

Mon, Jan 27, 8:10 AM · efl
ali.alzyod updated the diff for D11188: efl.canvas.textblock: update style strings.
  • update
Mon, Jan 27, 8:06 AM · efl
bu5hm4n requested review of D11200: ecore_wl2: do not silently return.
Mon, Jan 27, 8:05 AM · efl
bu5hm4n added a child revision for D11199: ecore_wl2: only ungrab/grab on last/first down/up event: D11200: ecore_wl2: do not silently return.
Mon, Jan 27, 8:05 AM · efl
bu5hm4n requested review of D11199: ecore_wl2: only ungrab/grab on last/first down/up event.
Mon, Jan 27, 8:05 AM · efl
segfaultxavi triaged T8588: Ampersand is not escaped in some <value> tags. as Normal priority.
Mon, Jan 27, 7:55 AM · Restricted Project, efl: language bindings, efl: docs