Page MenuHomePhabricator
Feed All Stories

Today

lauromoura closed T8418: C#: CA1815: Override equals and operator equals on value types as Resolved.

Resolved and enabled CA1815 on the devs/lauromoura/stylecop branch.

Tue, Nov 19, 7:26 PM · efl: language bindings
lauromoura closed T8418: C#: CA1815: Override equals and operator equals on value types, a subtask of T8331: C#: Fix stylecop warnings, as Resolved.
Tue, Nov 19, 7:26 PM · efl: language bindings
lauromoura requested review of D10697: csharp: CA1307 Add missing StringComparison in manual code.
Tue, Nov 19, 7:24 PM · efl
lauromoura added a revision to T8405: C#: CA1307: Specify StringComparison: D10697: csharp: CA1307 Add missing StringComparison in manual code.
Tue, Nov 19, 7:24 PM · efl: language bindings
lauromoura requested review of D10696: csharp: CA1307 Add CultureInfo to generated code..
Tue, Nov 19, 7:23 PM · efl
lauromoura added a revision to T8405: C#: CA1307: Specify StringComparison: D10696: csharp: CA1307 Add CultureInfo to generated code..
Tue, Nov 19, 7:23 PM · efl: language bindings
lauromoura added inline comments to D10650: csharp: Specifying StringComparison..
Tue, Nov 19, 7:23 PM · efl
lauromoura requested changes to D10650: csharp: Specifying StringComparison..

Ooops. Looks like we might have an issue with this one on Mono (6.4.0.198 here):

Tue, Nov 19, 7:10 PM · efl
lauromoura accepted D10650: csharp: Specifying StringComparison..
Tue, Nov 19, 7:00 PM · efl
akanad added a reviewer for D10695: eina_matrix: replace cosf by cos to gain more accuracy: vtorri.
Tue, Nov 19, 6:14 PM · efl
akanad added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

Yes. I think it's needed. Because

Tue, Nov 19, 6:13 PM · efl
lauromoura closed D10694: csharp: Fix CA1815 for generated structs and aliases.
Tue, Nov 19, 4:50 PM · efl
ProhtMeyhet added a comment to T7406: enlightenment-0.22.4 doesn't install '/usr/share/wayland-sessions/enlightenment.desktop' with '--enable-wayland'.

This was fixed in https://phab.enlightenment.org/D9868 and should make it into the next major release, but can hopefully make it into the next minor release.

Tue, Nov 19, 4:44 PM · Restricted Project, Restricted Project, enlightenment-git
ProhtMeyhet updated subscribers of T7978: some icons do not get the theme applied on startup.
Tue, Nov 19, 4:42 PM · Restricted Project, enlightenment-git
ProhtMeyhet added projects to T7978: some icons do not get the theme applied on startup: enlightenment-git, Restricted Project.
Tue, Nov 19, 4:41 PM · Restricted Project, enlightenment-git
brunobelo updated the diff for D10541: csharp: Components enum are flags now..

update

Tue, Nov 19, 1:45 PM · efl
532910 added a comment to T7978: some icons do not get the theme applied on startup.

https://sourceforge.net/p/enlightenment/mailman/enlightenment-users/thread/f7286c30-cff4-525b-4474-c4b567878459%40outerface.net/

Tue, Nov 19, 1:38 PM · Restricted Project, enlightenment-git
bu5hm4n added a comment to D10607: Efl Canvas Text : Modify Style Property.

There is no need to discuss something like "please make use of a macro here" or "this should be tested", nor are these *suggesstions*, they changes that i am requesting.
I am also not saying that discussions are not allowed, but coming to a discussion with a argument "its also like this somewhere else" is not going to be usefull at any rate.
Replying to a inline comment where we would like to have a change with "we will do it later" is also not really a discussion, why would you start later on again on old code file fixing something that was said ahead of time, even if it could have been fixed before this piece of code would have even landed ? That makes no sense to me. Fix it now, no need to discuss things, no need to revisit things, and more testing, review can happen.

Tue, Nov 19, 11:07 AM · efl
ali.alzyod added a comment to D10607: Efl Canvas Text : Modify Style Property.

@bu5hm4n first of all Thank you for your help

Okay, i am starting to be annoyed by replies like this. I am called here to do review, i do review, and all that is coming back is "we will do it later" "its used somewhere else like this" "we should not document concepts like this".

All our comments are we will do it later !!, this is not true, check the comments
These changes and patches talk about specific features, we will fix any new change we cause, but fixing old stuff should be done in separate patches, not these ones

Tue, Nov 19, 9:55 AM · efl
segfaultxavi resigned from D10615: introduce efl_canvas_object_animation.

Making Xavi happy is VERY important!

Tue, Nov 19, 9:40 AM · efl
bu5hm4n added a comment to D10607: Efl Canvas Text : Modify Style Property.

Okay, i am starting to be annoyed by replies like this. I am called here to do review, i do review, and all that is coming back is "we will do it later" "its used somewhere else like this" "we should not document concepts like this".
There is no golden rule about what we declare as easy to read code, however, this block is the perfect example of what it is NOT, it takes ONE single macro to get this cleaned up, where you have something like MY_MACRO("off", EVAS_TEXT_STYLE_PLAIN, EFL_TEXT_STYLE_EFFECT_TYPE_NONE) one call for each line up there. Which is WAY more readable than what is there right now. We also do EXACTLY this macro stuff ALL over the place, so the argument of "used in other part of text" is completely irrelevant and does not mean anything.
Other people have to READ that code again, have to MAINTAIN that code in some way, and someone on a bug-hunt will likely come across it, why should we make the life of these people harder ?
Have you ever heard of the "Broken windows theory" ? Whenever there is something broken or ugly, someone else, who does not want to make it any better will exactly refer to this code "eh, it was done like this before", could you please try to get off that attitude a bit ? This code here will last a long time, and why would you want to start with a hard-to-read version if you can invest 5 min. and make it nice ? (Same applies to other comments and revisions regarding tests, or string parsing, or or or )

Tue, Nov 19, 9:27 AM · efl
bu5hm4n updated the diff for D10615: introduce efl_canvas_object_animation.

make xavi happy

Tue, Nov 19, 9:08 AM · efl
ali.alzyod added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Tue, Nov 19, 9:05 AM · efl
segfaultxavi updated the task description for T7717: docs todo.
Tue, Nov 19, 7:52 AM · efl (efl-1.24), efl: docs, efl: api
segfaultxavi resigned from D10542: Efl.Text.Cursor.

I think this is OK regarding the API. I will take care of the rest of the documentation concerns in future patches.

Tue, Nov 19, 7:49 AM · efl
segfaultxavi updated the task description for T7717: docs todo.
Tue, Nov 19, 7:46 AM · efl (efl-1.24), efl: docs, efl: api
segfaultxavi updated the task description for T7717: docs todo.
Tue, Nov 19, 7:41 AM · efl (efl-1.24), efl: docs, efl: api
devilhorns added a comment to D9215: ecore_wl2: add new APIs.

I have merged some of these API functions today, so this patch will most certainly not apply cleanly anymore. There are still a few APIs on this that are not in upstream yet (mostly cursor APIs, and the input rectangle one).

Tue, Nov 19, 7:00 AM · Restricted Project, efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFL8195368929be: tests/ecore_wl2: Add test for ecore_wl2_window_type functions.
Tue, Nov 19, 6:45 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 19, 6:44 AM · Restricted Project, efl
thierry1970 closed T8467: e_comp - not possible to disable effects as Resolved.

I understand,
We apply our theme on the popup.
commit 822680869ff70a0f69dd383e3a810f3f18462dbc removes the possibility of not drawing the shadow.
Pity.
I rewrote our popups and deleted the arrows.
I already have enough patches to work correctly on X.
Thank you for watching.

Tue, Nov 19, 6:38 AM · Bug Report
ali.alzyod added inline comments to D10542: Efl.Text.Cursor.
Tue, Nov 19, 6:01 AM · efl
ali.alzyod added a comment to D10542: Efl.Text.Cursor.

I did find open comments in efl_text_cursor.eo for example

Tue, Nov 19, 5:57 AM · efl
devilhorns added a commit to T8016: Write test cases for Ecore_Wl2 API: rEFLdd74c6ed35e2: tests/ecore_wl2: Add test for ecore_wl2_window_geometry functions.
Tue, Nov 19, 5:52 AM · Restricted Project, efl
devilhorns updated the task description for T8016: Write test cases for Ecore_Wl2 API.
Tue, Nov 19, 5:45 AM · Restricted Project, efl
lauromoura added a revision to T8418: C#: CA1815: Override equals and operator equals on value types: D10694: csharp: Fix CA1815 for generated structs and aliases.
Tue, Nov 19, 5:31 AM · efl: language bindings
lauromoura added a task to D10694: csharp: Fix CA1815 for generated structs and aliases: T8418: C#: CA1815: Override equals and operator equals on value types.
Tue, Nov 19, 5:31 AM · efl
brunobelo accepted D10694: csharp: Fix CA1815 for generated structs and aliases.
Tue, Nov 19, 5:25 AM · efl
SanghyeonLee added a comment to T8471: Header and Footer in Item Widget.

One big question regarding this header and footer is...
how we support horizontal header/footer.

Tue, Nov 19, 4:37 AM
raster added a comment to T8470: Building efl on x86 error: symbol lookup error: /eolian_gen: undefined symbol: eolian_state_new.

This does happen - the RUNTIME linker (ld.so) will search and if it finds the libs in a system dir it seems to prefer those to the ones in the tree. this happened under autofoo and still happens with meson it seems. i know they SHOULD be using an rpath which SHOULD make the in-tree libs preferred ... but that seems broken when running eolian_gen and edje_cc as part of the build... :(

Tue, Nov 19, 4:29 AM · efl (efl-1.24), Restricted Project
segfaultxavi requested changes to D10542: Efl.Text.Cursor.

I did find open comments in efl_text_cursor.eo for example.

Tue, Nov 19, 4:10 AM · efl
segfaultxavi added inline comments to D10542: Efl.Text.Cursor.
Tue, Nov 19, 4:04 AM · efl
vtorri added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

is this accuracy really needed ?

Tue, Nov 19, 3:46 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • fix implicit casting int to a unsigned int
  • added EINA_SAFETY_CHECK
  • updated docs
Tue, Nov 19, 3:44 AM · efl
ali.alzyod added inline comments to D10542: Efl.Text.Cursor.
Tue, Nov 19, 3:42 AM · efl
akanad updated the diff for D10695: eina_matrix: replace cosf by cos to gain more accuracy.

restore everything, just remove a 'f' characters

Tue, Nov 19, 3:42 AM · efl
akanad updated the diff for D10695: eina_matrix: replace cosf by cos to gain more accuracy.
  • keep meaning of removed comment.
  • modify a corresponding testcase.
Tue, Nov 19, 3:25 AM · efl
ali.alzyod added a comment to D10542: Efl.Text.Cursor.

There are still many open comments.

Tue, Nov 19, 3:20 AM · efl
ali.alzyod added inline comments to D10542: Efl.Text.Cursor.
Tue, Nov 19, 3:20 AM · efl
ali.alzyod updated the diff for D10542: Efl.Text.Cursor.

update documentation

Tue, Nov 19, 3:20 AM · efl
segfaultxavi added a comment to T7864: efl.gfx.arrangement.

This has been stopped for more than a month and we didn't come up with a better name.
Plus, the only person against "arrangement" is Mike who won't be available for another month...

Tue, Nov 19, 3:14 AM · efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T8380: efl.ui.relative_layout.

Looks good to me!

Tue, Nov 19, 3:11 AM · efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi closed D10690: docs: Copy all images to output folder.
Tue, Nov 19, 3:08 AM · efl
bu5hm4n accepted D10690: docs: Copy all images to output folder.

I am pretty much fine with this,i think we can still move to python if there are issues. I am also not sure if the doc build works anywhere except linux ... :/

Tue, Nov 19, 3:04 AM · efl
segfaultxavi requested changes to D10542: Efl.Text.Cursor.

There are still many open comments.

Tue, Nov 19, 2:52 AM · efl
jsuya added a comment to D10695: eina_matrix: replace cosf by cos to gain more accuracy.

I agree that change cosf to cos.
But in my opinion, we should to keep note messages. And you also need to change the test. (src/tests/eina/eina_test_matrix.c)

Tue, Nov 19, 2:50 AM · efl
bu5hm4n added a comment to D10679: Revert "efl_ui/layout: selectively inhibit theme,changed event".

No problem, @zmike is on vacation ... :)

Tue, Nov 19, 2:29 AM · efl
jsuya added a comment to D10679: Revert "efl_ui/layout: selectively inhibit theme,changed event".

Hi @bu5hm4n :)
sorry I don't know how to i get event name in _efl_ui_layout_base_efl_object_event_callback_priority_add function.
Can you tell me more detail?
And most of all I don't know why desc == EFL_CANVAS_GROUP_EVENT_MEMBER_ADDED was added.
7ad8acc290f078aa9d2bfd32ec15a4e5677ab01f I checked this patch but I still don't understand.
So I couldn't find a way to improve this problem and made this revert patch.
I hope @zmike to check this :)

Tue, Nov 19, 2:22 AM · efl
bu5hm4n added a comment to D10607: Efl Canvas Text : Modify Style Property.

@bu5hm4n

can you check that all branches of the parsing function is checked and tested (also with asan enabled)?

I have tested only new code.

Tue, Nov 19, 2:17 AM · efl
segfaultxavi added a comment to T7856: efl.text_format.

I am unsure what are the plans for Efl.Text.Format, but having Format and Style interfaces is very confusing. We should find names that indicate what kind of properties each of these interfaces hold.

Tue, Nov 19, 2:16 AM · efl (efl-1.24), efl: api, efl: language bindings
ali.alzyod added inline comments to D10607: Efl Canvas Text : Modify Style Property.
Tue, Nov 19, 2:11 AM · efl
AbdullehGhujeh updated the diff for D10607: Efl Canvas Text : Modify Style Property.
  • fix implicit casting int to a unsigned int
Tue, Nov 19, 2:05 AM · efl
akanad requested review of D10695: eina_matrix: replace cosf by cos to gain more accuracy.
Tue, Nov 19, 2:05 AM · efl
AbdullehGhujeh added a comment to D10607: Efl Canvas Text : Modify Style Property.

can you check that all branches of the parsing function is checked and tested (also with asan enabled)?

I have tested only new code.

Tue, Nov 19, 1:57 AM · efl
bu5hm4n requested changes to D10646: Efl.Text.Attribute_Factory.

I think the errors in efl_text_attribute_factory.c should be done using EINA_SAFETY_ON_FALSE_RETURN. Which will also print the conditions, otherwise these errors are not really helpful.

Tue, Nov 19, 1:49 AM · efl
segfaultxavi requested changes to D10646: Efl.Text.Attribute_Factory.

The file src/lib/efl/interfaces/efl_text_annotate.eo must be removed from the tree. ninja test is failing for me because it picks it up.

Tue, Nov 19, 1:45 AM · efl
woohyun added a comment to T7864: efl.gfx.arrangement.

If there is no better alternative names for "content_" prefix and "arrangement",
I think we can go with current definitions.

Tue, Nov 19, 1:34 AM · efl (efl-1.24), efl: api, efl: language bindings
woohyun added a comment to T8380: efl.ui.relative_layout.

I think this looks good now.
Is it ok to remove @beta ? or any other opinions ?

Tue, Nov 19, 1:28 AM · efl (efl-1.24), efl: api, efl: language bindings
segfaultxavi added a comment to T8305: RFC: Items.

These are my thoughts:

  • I think Efl.Ui.Title_Item can be useful. I like the name too.
  • Efl.Ui.List_Double_Label_Item looks useful too. However, I think it will look strange if it is only available for List and not for Grid. We should provide it also for Grids even if it's not commonly used. About the name, how about Efl.Ui.Double_Text_Item, or Efl.Ui.Default_With_Subtitle_Item?
  • I also think item padding should be handled by the container (implementing the Efl.Gfx.Arrangement interface). Inserting items to achieve padding will get messy very soon :)
Tue, Nov 19, 12:54 AM · efl: api
stefan_schmidt added reviewers for D10691: ci: travis: add job to build efl and run tests with address sanitizer: bu5hm4n, raster.
Tue, Nov 19, 12:37 AM · efl
stefan_schmidt updated the diff for D10691: ci: travis: add job to build efl and run tests with address sanitizer.

Use the same check retry logic as we have for the normal runs

Tue, Nov 19, 12:36 AM · efl
ali.alzyod updated the diff for D10646: Efl.Text.Attribute_Factory.

rebase

Tue, Nov 19, 12:04 AM · efl

Yesterday

ali.alzyod updated the summary of D10646: Efl.Text.Attribute_Factory.
Mon, Nov 18, 11:09 PM · efl
CHAN triaged T8483: edje_calc: group type part calc failure. as High priority.
Mon, Nov 18, 9:19 PM
lauromoura added inline comments to D10694: csharp: Fix CA1815 for generated structs and aliases.
Mon, Nov 18, 9:12 PM · efl
woohyun closed D10693: slider: fix behavior of slider when mirrored.
Mon, Nov 18, 9:09 PM · efl
lauromoura requested review of D10694: csharp: Fix CA1815 for generated structs and aliases.
Mon, Nov 18, 9:08 PM · efl
woohyun accepted D10693: slider: fix behavior of slider when mirrored.
Mon, Nov 18, 8:59 PM · efl
lauromoura closed D10647: csharp: Add IEquatable on classes..
Mon, Nov 18, 8:41 PM · efl
lauromoura added a commit to T8418: C#: CA1815: Override equals and operator equals on value types: rEFL2c5ea739e7f9: csharp: Add IEquatable on classes..
Mon, Nov 18, 8:41 PM · efl: language bindings
SanghyeonLee added a comment to T8305: RFC: Items.

I'm thinking to adding more item styles,

Mon, Nov 18, 7:55 PM · efl: api
lauromoura accepted D10647: csharp: Add IEquatable on classes..

There was a conflict after D10616 but I resolved locally.

Mon, Nov 18, 7:48 PM · efl
bowonryu requested review of D10693: slider: fix behavior of slider when mirrored.
Mon, Nov 18, 6:53 PM · efl
CHAN added a comment to D10437: gesture_manager: Changed function param to reduce internal function calls..

@zmike @q66 any idea?

Mon, Nov 18, 6:45 PM · efl
segfaultxavi added a comment to D10646: Efl.Text.Attribute_Factory.

Once you start adding dependencies between tasks, you are building a "patchset" (or "stack"). In the five tabs just above the diff (Files, History, Commits, Stack and Similar) you can select Stack and see all your dependencies and dependent patches (it can show very complex trees).
If you now try to apply a patch with arcanist (arc patch Dxxxx) it will first apply all its dependencies.

Mon, Nov 18, 9:15 AM · efl
ali.alzyod added a comment to D10646: Efl.Text.Attribute_Factory.

@bu5hm4n I do not know if it is possible to make this patch base on another patch. (this patch is dependent on D10542)

In the Phabricator web interface, in the top-right menu box, there's Edit Related Revisions. There you can add "parent" revisions, which means that your patch depends on them.
Arcanist will do this automatically if your commit message includes the words "Depends on Dxxxxx".

Mon, Nov 18, 8:34 AM · efl
ali.alzyod added a parent revision for D10646: Efl.Text.Attribute_Factory: D10542: Efl.Text.Cursor.
Mon, Nov 18, 8:18 AM · efl
ali.alzyod added a child revision for D10542: Efl.Text.Cursor: D10646: Efl.Text.Attribute_Factory.
Mon, Nov 18, 8:18 AM · efl
segfaultxavi added a comment to D10646: Efl.Text.Attribute_Factory.

@bu5hm4n I do not know if it is possible to make this patch base on another patch. (this patch is dependent on D10542)

Mon, Nov 18, 8:09 AM · efl
stefan_schmidt added a comment to D10691: ci: travis: add job to build efl and run tests with address sanitizer.

https://travis-ci.org/Enlightenment/efl/builds/613538455

Mon, Nov 18, 8:03 AM · efl
a.srour added a comment to D10692: Edje: edc text_class applied without font or font_size in style.

Resolve required changes

Mon, Nov 18, 8:02 AM · efl
a.srour updated the diff for D10692: Edje: edc text_class applied without font or font_size in style.

Remove whitespace

Mon, Nov 18, 8:01 AM · efl
a.srour updated the diff for D10692: Edje: edc text_class applied without font or font_size in style.

Resolve required changes

Mon, Nov 18, 8:00 AM · efl
ali.alzyod added inline comments to D10692: Edje: edc text_class applied without font or font_size in style.
Mon, Nov 18, 7:54 AM · efl
ali.alzyod added a comment to D10692: Edje: edc text_class applied without font or font_size in style.

Hahaha, I always wondered why you add the description after submitting the patch. What process do you follow?

Mon, Nov 18, 7:42 AM · efl
segfaultxavi resigned from D10692: Edje: edc text_class applied without font or font_size in style.

Hahaha, I always wondered why you add the description after submitting the patch. What process do you follow?

Mon, Nov 18, 7:39 AM · efl
ali.alzyod added a comment to D10692: Edje: edc text_class applied without font or font_size in style.

Can you please explain in the commit message what is the exact problem you are trying to fix, and how are you fixing it?
Otherwise, this is very hard to review.

Mon, Nov 18, 7:37 AM · efl
segfaultxavi requested changes to D10692: Edje: edc text_class applied without font or font_size in style.

Can you please explain in the commit message what is the exact problem you are trying to fix, and how are you fixing it?
Otherwise, this is very hard to review.

Mon, Nov 18, 7:35 AM · efl
a.srour updated the test plan for D10692: Edje: edc text_class applied without font or font_size in style.
Mon, Nov 18, 7:35 AM · efl
ali.alzyod added a comment to T8480: Edje: Text_class New API file level override.

We use the edje file path gotten from edje_object_file_get. (@cedric any comments?)

Mon, Nov 18, 7:34 AM