Page MenuHomePhabricator
Feed All Stories

Today

bu5hm4n added a comment to T7553: efl.ui.widget.

Comments regarding this class:

  • orientation: it appears that the only entity that is actaully setting is the window implementation. There is no user of the on_* method. To me it looks like the efl_ui_win.c implementation could just go and walk the widget tree, and emit events on the layouts that dont orientation_mode_set set to DISABLE.
  • focus_highlight_{animate, style, enabled}: They should be moved to the Efl.Ui.Win, as the comments in the .eo file state
  • focused_item: this should go, there are no items in the new API.
  • show_region: interest_region: This should be merged into one concept, and in the API this should only be the getter of one single rectable IMO (pos relative to the widget)
  • on_disabled: Should be disabled,changed event.
  • scroll_*: Not sure what it does here ...
  • theme_apply: what it tells to do makes sense. However, it syncs up mirrored states o_O.
Sat, Feb 23, 12:41 PM · efl: api, efl (efl-1.22)
segfaultxavi added a comment to D8000: eo: mark efl_object stable.

Can you add @since 1.22 at the same time that you remove the @beta from the class? (as suggested in T7704).

Sat, Feb 23, 9:05 AM · efl
segfaultxavi requested review of D8012: mono-docs: Use @since tags properly.
Sat, Feb 23, 8:59 AM · efl
segfaultxavi added a comment to T7704: verify @since tags for stabilized apis.

I suggest the same commit that removes the @beta tag adds @since 1.22 to the class docs.

Sat, Feb 23, 7:45 AM · efl (efl-1.22), efl: docs, efl: api
bu5hm4n accepted D8005: efl_ui_widget: remove "moved" event.
Sat, Feb 23, 7:36 AM · efl
bu5hm4n updated the diff for D8011: efl_canvas_object: remove event_freeze.

Rebase & Update

Sat, Feb 23, 7:31 AM · efl
bu5hm4n updated the diff for D8010: efl_canvas_object: make is_frame_object internal.

Rebase & Update

Sat, Feb 23, 7:31 AM · efl
bu5hm4n updated the diff for D8009: efl_canvas_object: get rid of event_animation set/get.

Rebase & Update

Sat, Feb 23, 7:31 AM · efl
bu5hm4n updated the diff for D8008: efl_ui_stack: use direct events instead of event_animation.

Rebase & Update

Sat, Feb 23, 7:31 AM · efl
bu5hm4n updated the diff for D8007: efl_ui_slack: remove explicit animation removings.

Rebase & Update

Sat, Feb 23, 7:31 AM · efl
bu5hm4n updated the diff for D8006: efl_ui_stack: refactor code.

Rebase & Update

Sat, Feb 23, 7:31 AM · efl
bu5hm4n added a comment to T7555: efl.canvas.object.

After the patchset, things look good to me. seat_focus Is the last thing which looks doubious to me. @cedric @woohyun @Jaehyun_Cho opinions on that API ?

Sat, Feb 23, 7:16 AM · efl: api, efl (efl-1.22)
bu5hm4n updated the task description for T7555: efl.canvas.object.
Sat, Feb 23, 7:13 AM · efl: api, efl (efl-1.22)
zmike accepted D8008: efl_ui_stack: use direct events instead of event_animation.

so fast!

Sat, Feb 23, 7:00 AM · efl
zmike accepted D8007: efl_ui_slack: remove explicit animation removings.
Sat, Feb 23, 7:00 AM · efl
bu5hm4n requested review of D8008: efl_ui_stack: use direct events instead of event_animation.

Fixed in the update before your comment :)

Sat, Feb 23, 6:58 AM · efl
zmike triaged T7706: deduplicate code between efl.ui.image and efl.ui.image.zoomable as TODO priority.
Sat, Feb 23, 6:55 AM · Restricted Project, efl: widgets
zmike accepted D8011: efl_canvas_object: remove event_freeze.
Sat, Feb 23, 6:53 AM · efl
zmike accepted D8010: efl_canvas_object: make is_frame_object internal.
Sat, Feb 23, 6:52 AM · efl
zmike accepted D8009: efl_canvas_object: get rid of event_animation set/get.
Sat, Feb 23, 6:50 AM · efl
zmike requested changes to D8008: efl_ui_stack: use direct events instead of event_animation.
Sat, Feb 23, 6:47 AM · efl
zmike accepted D8006: efl_ui_stack: refactor code.
Sat, Feb 23, 6:46 AM · efl
bu5hm4n requested review of D8011: efl_canvas_object: remove event_freeze.
Sat, Feb 23, 6:44 AM · efl
bu5hm4n added a child revision for D8010: efl_canvas_object: make is_frame_object internal: D8011: efl_canvas_object: remove event_freeze.
Sat, Feb 23, 6:44 AM · efl
bu5hm4n added a revision to T7555: efl.canvas.object: D8011: efl_canvas_object: remove event_freeze.
Sat, Feb 23, 6:44 AM · efl: api, efl (efl-1.22)
bu5hm4n updated the diff for D8010: efl_canvas_object: make is_frame_object internal.

Rebase & Update

Sat, Feb 23, 6:44 AM · efl
bu5hm4n updated the diff for D8009: efl_canvas_object: get rid of event_animation set/get.

Rebase & Update

Sat, Feb 23, 6:44 AM · efl
bu5hm4n updated the diff for D8008: efl_ui_stack: use direct events instead of event_animation.

Rebase & Update

Sat, Feb 23, 6:44 AM · efl
bu5hm4n updated the diff for D8007: efl_ui_slack: remove explicit animation removings.

Rebase & Update

Sat, Feb 23, 6:44 AM · efl
bu5hm4n updated the diff for D8006: efl_ui_stack: refactor code.

Rebase & Update

Sat, Feb 23, 6:43 AM · efl
bu5hm4n requested review of D8006: efl_ui_stack: refactor code.
Sat, Feb 23, 6:27 AM · efl
bu5hm4n updated the summary of D8006: efl_ui_stack: refactor code.
Sat, Feb 23, 6:27 AM · efl
zmike closed D7865: eio: enforce proper lifecycle for all Efl.Io_Model and fix discovered lifecycle bugs..
Sat, Feb 23, 6:14 AM · efl
zmike closed D7866: efl: improve Efl.Container_Model test to have proper lifecycle..
Sat, Feb 23, 6:14 AM · efl
zmike closed D7864: ecore: enforce proper lifecycle for all Efl.Composite_Model children..
Sat, Feb 23, 6:14 AM · efl
zmike requested changes to D8006: efl_ui_stack: refactor code.

can you be slightly more specific with your commit log, e.g., "this code was duplicated so I created function named XYZ to deduplicate"

Sat, Feb 23, 6:03 AM · efl
zmike accepted D7865: eio: enforce proper lifecycle for all Efl.Io_Model and fix discovered lifecycle bugs..

Alright I'm gonna hammer this in to expedite things.

Sat, Feb 23, 5:56 AM · efl
bu5hm4n requested review of D8010: efl_canvas_object: make is_frame_object internal.
Sat, Feb 23, 5:36 AM · efl
bu5hm4n added a child revision for D8009: efl_canvas_object: get rid of event_animation set/get: D8010: efl_canvas_object: make is_frame_object internal.
Sat, Feb 23, 5:36 AM · efl
bu5hm4n added a revision to T7555: efl.canvas.object: D8010: efl_canvas_object: make is_frame_object internal.
Sat, Feb 23, 5:36 AM · efl: api, efl (efl-1.22)
bu5hm4n requested review of D8009: efl_canvas_object: get rid of event_animation set/get.
Sat, Feb 23, 5:36 AM · efl
bu5hm4n added a child revision for D8008: efl_ui_stack: use direct events instead of event_animation: D8009: efl_canvas_object: get rid of event_animation set/get.
Sat, Feb 23, 5:36 AM · efl
bu5hm4n added a revision to T7555: efl.canvas.object: D8009: efl_canvas_object: get rid of event_animation set/get.
Sat, Feb 23, 5:36 AM · efl: api, efl (efl-1.22)
bu5hm4n requested review of D8008: efl_ui_stack: use direct events instead of event_animation.
Sat, Feb 23, 5:36 AM · efl
bu5hm4n added a child revision for D8007: efl_ui_slack: remove explicit animation removings: D8008: efl_ui_stack: use direct events instead of event_animation.
Sat, Feb 23, 5:36 AM · efl
bu5hm4n added a revision to T7555: efl.canvas.object: D8008: efl_ui_stack: use direct events instead of event_animation.
Sat, Feb 23, 5:36 AM · efl: api, efl (efl-1.22)
bu5hm4n requested review of D8007: efl_ui_slack: remove explicit animation removings.
Sat, Feb 23, 5:36 AM · efl
bu5hm4n added a child revision for D8006: efl_ui_stack: refactor code: D8007: efl_ui_slack: remove explicit animation removings.
Sat, Feb 23, 5:36 AM · efl
bu5hm4n requested review of D8006: efl_ui_stack: refactor code.
Sat, Feb 23, 5:36 AM · efl
bu5hm4n updated the diff for D7999: eolian: validate betaness.

...

Sat, Feb 23, 5:34 AM · efl
YOhoho accepted D8005: efl_ui_widget: remove "moved" event.

looks good to me.

Sat, Feb 23, 5:02 AM · efl
YOhoho updated the diff for D7840: test/ui_table: add unittest for Efl.Ui.Table.

rebase

Sat, Feb 23, 4:50 AM · efl
YOhoho updated the diff for D7892: ui.table: implement homogeneous mode.

rebase

Sat, Feb 23, 4:47 AM · efl
YOhoho updated the diff for D7841: efl_ui_table: refactor layout_update.

rebase

Sat, Feb 23, 4:13 AM · efl
woohyun added a comment to T7553: efl.ui.widget.

@bu5hm4n @YOhoho
Thank you,
and I made D8005 because both of your comments looked correct :)

Sat, Feb 23, 2:42 AM · efl: api, efl (efl-1.22)
woohyun requested review of D8005: efl_ui_widget: remove "moved" event.
Sat, Feb 23, 2:40 AM · efl
woohyun added a revision to T7553: efl.ui.widget: D8005: efl_ui_widget: remove "moved" event.
Sat, Feb 23, 2:40 AM · efl: api, efl (efl-1.22)
YOhoho removed a parent revision for D7841: efl_ui_table: refactor layout_update: D7838: efl_ui_table: fix correct parameters of table_rows_get.
Sat, Feb 23, 1:30 AM · efl
YOhoho removed a child revision for D7838: efl_ui_table: fix correct parameters of table_rows_get: D7841: efl_ui_table: refactor layout_update.
Sat, Feb 23, 1:30 AM · efl

Yesterday

zmike triaged T7705: evaluate error code usage as TODO priority.
Fri, Feb 22, 2:07 PM · efl, Restricted Project
zmike triaged T7704: verify @since tags for stabilized apis as TODO priority.
Fri, Feb 22, 10:30 AM · efl (efl-1.22), efl: docs, efl: api
cedric updated subscribers of D7970: eio: cancel registered future before it's freed.

I think this might fix your problem @zmike

Fri, Feb 22, 10:08 AM · efl
cedric requested changes to D7970: eio: cancel registered future before it's freed.
Fri, Feb 22, 10:08 AM · efl
cedric added a comment to D7970: eio: cancel registered future before it's freed.

As @bu5hm4n is pointing out, you want to clean the future when it is resolved. Best way would be to have a .free method in efl_io_manager_future. Also you seems to have a very small test that exhibit the problem, could you add it to elementary fileselector test suite?

Fri, Feb 22, 10:08 AM · efl
cedric accepted D7996: Revert "eo: fix to remove unreachable loop".
Fri, Feb 22, 10:06 AM · efl
cedric added a comment to D7997: eo: fix reflection.

Maybe a test to trigger this problem would be useful.

Fri, Feb 22, 10:05 AM · efl
fanf42 created T7703: External screen configuration not restaured between plug/unplug.
Fri, Feb 22, 9:24 AM
q66 requested changes to D7999: eolian: validate betaness.

no punctuation in error msgs please

Fri, Feb 22, 9:18 AM · efl
vitor.sousa closed D7981: efl-csharp: Add support for containers in events..
Fri, Feb 22, 9:07 AM · efl
vitor.sousa accepted D7981: efl-csharp: Add support for containers in events..
Fri, Feb 22, 8:56 AM · efl
segfaultxavi closed D8003: examples: Fix cxx examples compilation..
Fri, Feb 22, 8:23 AM · efl
bu5hm4n updated the diff for D7999: eolian: validate betaness.

...

Fri, Feb 22, 8:05 AM · efl
segfaultxavi accepted D8003: examples: Fix cxx examples compilation..
Fri, Feb 22, 7:56 AM · efl
bu5hm4n accepted D8004: efl-csharp: Remove legacy Evas bindings..

Ahmen!

Fri, Feb 22, 7:53 AM · efl
lauromoura requested review of D8004: efl-csharp: Remove legacy Evas bindings..
Fri, Feb 22, 7:50 AM · efl
lauromoura requested review of D8003: examples: Fix cxx examples compilation..
Fri, Feb 22, 7:49 AM · efl
bu5hm4n added a comment to T7554: efl.canvas.group.

@zmike i think group_member_is is fine, its quite handy and support efl.canvas.group objects which do not force theire children to have them as render parent. Seems like it is somehow usefull.

Fri, Feb 22, 7:43 AM · efl: api, efl (efl-1.22)
bu5hm4n added a comment to T7555: efl.canvas.object.

seat_focus seems unused, do we want to remove it, its unclear to me what is actaully does. Additionally, it seems a bit off, that we have a list of seats *per* object.

Fri, Feb 22, 7:30 AM · efl: api, efl (efl-1.22)
q66 closed D7980: eolian: introduce typed slice types.
Fri, Feb 22, 7:19 AM · efl
bu5hm4n added a comment to T7555: efl.canvas.object.

I think event_animation can be a bit difficult and dangerous, you can see it with the implementation, two special cases for SHOW and HIDE. From a user POV this looks to me like i can go and add an animation to the POSITION_CHANGED event. However, you cannot, since the position will be moved. Not stopped by the animation, so to me this looks only usefull for hide and show. IMO it would be better to "copy" this functionality into efl_ui_stack.c (which is the only user of this). And remove this API and anim_* events from this object... What do you say @Jaehyun_Cho ?

Fri, Feb 22, 7:18 AM · efl: api, efl (efl-1.22)
segfaultxavi closed D7998: docs: Polish focus documentation..
Fri, Feb 22, 6:58 AM · efl
segfaultxavi updated the diff for D7998: docs: Polish focus documentation..

Rebased

Fri, Feb 22, 6:54 AM · efl
zmike edited projects for T7512: efl.ui.layout, added: efl: api; removed efl: language bindings.
Fri, Feb 22, 6:03 AM · efl: api, efl (efl-1.22)
zmike edited projects for T7511: efl.ui.win, added: efl: api; removed efl: language bindings.
Fri, Feb 22, 6:02 AM · efl: api, efl (efl-1.22)
zmike closed T7561: efl.animator as Resolved.
Fri, Feb 22, 6:01 AM · efl: api, efl (efl-1.22)
zmike closed T7561: efl.animator, a subtask of T7555: efl.canvas.object, as Resolved.
Fri, Feb 22, 6:01 AM · efl: api, efl (efl-1.22)
zmike moved T7558: efl.gfx.entity from Evaluating to Stabilized on the efl: api board.
Fri, Feb 22, 6:00 AM · efl: api, efl (efl-1.22)
zmike closed D7995: build: fix macos build.
Fri, Feb 22, 5:53 AM · efl
zmike accepted D7995: build: fix macos build.
Fri, Feb 22, 5:53 AM · efl
zmike updated the task description for T7558: efl.gfx.entity.
Fri, Feb 22, 5:52 AM · efl: api, efl (efl-1.22)
zmike closed D8002: evas_callbacks: redo legacy smart object events for recently changed event names.
Fri, Feb 22, 5:51 AM · efl
zmike added a commit to T7599: efl.io.reader: rEFL421bf2d0a3f8: api: add bool data to efl.io.reader/writer 'changed' events.
Fri, Feb 22, 5:51 AM · efl: api, efl (efl-1.22)
zmike added a commit to T7600: efl.io.writer: rEFL421bf2d0a3f8: api: add bool data to efl.io.reader/writer 'changed' events.
Fri, Feb 22, 5:51 AM · efl: api, efl (efl-1.22)
zmike closed D7984: api: add bool data to efl.io.reader/writer 'changed' events.
Fri, Feb 22, 5:51 AM · efl
bu5hm4n accepted D8002: evas_callbacks: redo legacy smart object events for recently changed event names.
Fri, Feb 22, 5:49 AM · efl
zmike requested changes to D7865: eio: enforce proper lifecycle for all Efl.Io_Model and fix discovered lifecycle bugs..

one minor nit

Fri, Feb 22, 5:48 AM · efl
zmike requested review of D8002: evas_callbacks: redo legacy smart object events for recently changed event names.
Fri, Feb 22, 5:46 AM · efl
bu5hm4n requested review of D8001: ecore: declare efl_app and the inherits stable.
Fri, Feb 22, 5:37 AM · efl
bu5hm4n added a child revision for D8000: eo: mark efl_object stable: D8001: ecore: declare efl_app and the inherits stable.
Fri, Feb 22, 5:37 AM · efl
bu5hm4n added a revision to T7514: efl.app / efl.loop: D8001: ecore: declare efl_app and the inherits stable.
Fri, Feb 22, 5:37 AM · efl: api, efl (efl-1.22)