Page MenuHomePhabricator
Feed Advanced Search

Yesterday

zmike requested review of D7986: evas_object: reduce method calls for efl_gfx_entity_geometry_set.

This is only viable if all classes which reimplement size/position set() also implement geometry_set()

Thu, Feb 21, 3:02 PM · DO NOT MERGE, efl

Fri, Feb 15

segfaultxavi updated the diff for D7620: efl-api: Mark Efl.Io.Reader as stable.

Remove @beta tag instead of moving includes around Efl.h

Fri, Feb 15, 1:25 AM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7619: efl-api: Mark Efl.Io.Writer as stable.

Remove @beta tag instead of moving includes around Efl.h

Fri, Feb 15, 1:24 AM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7618: efl-api: Mark Efl.Io.Closer as stable.

Remove @beta tag instead of moving includes around Efl.h

Fri, Feb 15, 1:21 AM · DO NOT MERGE, efl

Mon, Feb 11

cedric closed D7745: elm_progressbar test: Add test for custom format strings to show when %% is not escaped correctly..
Mon, Feb 11, 3:41 PM · DO NOT MERGE, efl
cedric accepted D7620: efl-api: Mark Efl.Io.Reader as stable.
Mon, Feb 11, 2:49 PM · DO NOT MERGE, efl
cedric accepted D7619: efl-api: Mark Efl.Io.Writer as stable.
Mon, Feb 11, 2:48 PM · DO NOT MERGE, efl
cedric accepted D7618: efl-api: Mark Efl.Io.Closer as stable.
Mon, Feb 11, 2:48 PM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7618: efl-api: Mark Efl.Io.Closer as stable.

Rebase

Mon, Feb 11, 2:44 AM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7619: efl-api: Mark Efl.Io.Writer as stable.

Rebase

Mon, Feb 11, 2:44 AM · DO NOT MERGE, efl
segfaultxavi updated the diff for D7620: efl-api: Mark Efl.Io.Reader as stable.

Rebase

Mon, Feb 11, 2:43 AM · DO NOT MERGE, efl
segfaultxavi added a parent revision for D7620: efl-api: Mark Efl.Io.Reader as stable: D7619: efl-api: Mark Efl.Io.Writer as stable.
Mon, Feb 11, 2:27 AM · DO NOT MERGE, efl
segfaultxavi added a child revision for D7619: efl-api: Mark Efl.Io.Writer as stable: D7620: efl-api: Mark Efl.Io.Reader as stable.
Mon, Feb 11, 2:27 AM · DO NOT MERGE, efl
segfaultxavi added a parent revision for D7619: efl-api: Mark Efl.Io.Writer as stable: D7618: efl-api: Mark Efl.Io.Closer as stable.
Mon, Feb 11, 2:27 AM · DO NOT MERGE, efl
segfaultxavi added a child revision for D7618: efl-api: Mark Efl.Io.Closer as stable: D7619: efl-api: Mark Efl.Io.Writer as stable.
Mon, Feb 11, 2:27 AM · DO NOT MERGE, efl

Fri, Feb 8

zmike updated the diff for D7899: api: remove efl.ui.cursor interface.

update

Fri, Feb 8, 11:54 AM · efl: api
zmike requested review of D7899: api: remove efl.ui.cursor interface.
Fri, Feb 8, 11:36 AM · efl: api

Thu, Feb 7

segfaultxavi closed D7855: efl: Change non required constructors to @optional..
Thu, Feb 7, 9:05 AM · DO NOT MERGE, efl
cedric accepted D7855: efl: Change non required constructors to @optional..
Thu, Feb 7, 6:07 AM · DO NOT MERGE, efl

Fri, Feb 1

lauromoura added inline comments to D7855: efl: Change non required constructors to @optional..
Fri, Feb 1, 4:55 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

What do you mean ? Does my patch work or not ? :)

Fri, Feb 1, 2:28 AM · DO NOT MERGE, efl
SanghyeonLee requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

oh its wrong patch.

Fri, Feb 1, 2:23 AM · DO NOT MERGE, efl
SanghyeonLee accepted D7857: eo: Fix efl_isa for class checking of recursively inherited types.

I tested and it fix the problem well :) thank you.

Fri, Feb 1, 2:23 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

@SanghyeonLee please check the attached patch :)

Fri, Feb 1, 2:12 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

It appears that we are recursivly skipping interfaces, but not on the direct implementer. I will look later next week into it.

Fri, Feb 1, 2:07 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

It appears that we are recursivly skipping interfaces, but not on the direct implementer. I will look later next week into it.

Fri, Feb 1, 1:56 AM · DO NOT MERGE, efl
SanghyeonLee edited reviewers for D7857: eo: Fix efl_isa for class checking of recursively inherited types, added: q66; removed: QA_Igor.
Fri, Feb 1, 1:50 AM · DO NOT MERGE, efl
SanghyeonLee added a reviewer for D7857: eo: Fix efl_isa for class checking of recursively inherited types: QA_Igor.
Fri, Feb 1, 1:46 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Do you have a old efl_ui_layout.eo.c arround somewhere in your tree ?

Fri, Feb 1, 1:45 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

I think I resolve the problem by recursive calls of efl_isa for mro

Fri, Feb 1, 1:42 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Parts of my output with "EINA_LOG_DOMAINS="eo:10" elementary_test"

Fri, Feb 1, 1:35 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Can you paste you efl_ui_layout.eo.c ? I just checked it and it seems that efl.ui.view is part of efl.ui.layout's MRO here.

Fri, Feb 1, 1:30 AM · DO NOT MERGE, efl
segfaultxavi accepted D7855: efl: Change non required constructors to @optional..

These look OK to me, except the Model and Factory ones which @cedric should review.

Fri, Feb 1, 1:05 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

The issue case is easily found in example of efl_ui_list_view_example_1.c

Fri, Feb 1, 12:46 AM · DO NOT MERGE, efl
YOhoho added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

What do you think to check extensions after checking mro?

kls_itr = lookinto->extensions;
if (!kls_itr) return EINA_FALSE;
return (efl_isa((Eo *)(*kls_itr)->header.id, klass_id));
Fri, Feb 1, 12:38 AM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Mhmmm MRO should contain all recursive classes.

Fri, Feb 1, 12:19 AM · DO NOT MERGE, efl
bu5hm4n requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

Mhmmm MRO should contain all recursive classes.

Fri, Feb 1, 12:10 AM · DO NOT MERGE, efl
SanghyeonLee requested changes to D7857: eo: Fix efl_isa for class checking of recursively inherited types.

looks something wrong in the patch.

Fri, Feb 1, 12:09 AM · DO NOT MERGE, efl
SanghyeonLee added a project to D7857: eo: Fix efl_isa for class checking of recursively inherited types: DO NOT MERGE.
Fri, Feb 1, 12:08 AM · DO NOT MERGE, efl

Thu, Jan 31

lauromoura added a project to D7855: efl: Change non required constructors to @optional.: DO NOT MERGE.
Thu, Jan 31, 4:03 PM · DO NOT MERGE, efl

Wed, Jan 30

SanghyeonLee closed D7533: efl_model : rename all efl_model based classes..
Wed, Jan 30, 9:59 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

fix few typo which was generated by conflict resolving

Wed, Jan 30, 9:28 PM · DO NOT MERGE, efl
SanghyeonLee updated the summary of D7533: efl_model : rename all efl_model based classes..
Wed, Jan 30, 9:16 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

rebasing patch and resolve conflict

Wed, Jan 30, 9:14 PM · DO NOT MERGE, efl
bu5hm4n added a comment to D7745: elm_progressbar test: Add test for custom format strings to show when %% is not escaped correctly..

I added do not merge so it is out of the queue, we can land it once this is fixed.

Wed, Jan 30, 4:31 AM · DO NOT MERGE, efl
bu5hm4n added a project to D7745: elm_progressbar test: Add test for custom format strings to show when %% is not escaped correctly.: DO NOT MERGE.
Wed, Jan 30, 4:31 AM · DO NOT MERGE, efl

Mon, Jan 28

SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

rebase patch

Mon, Jan 28, 10:51 PM · DO NOT MERGE, efl
SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

update patch. fix build errors

Mon, Jan 28, 10:13 PM · DO NOT MERGE, efl

Sat, Jan 26

SanghyeonLee added a project to D7533: efl_model : rename all efl_model based classes.: DO NOT MERGE.
Sat, Jan 26, 5:42 AM · DO NOT MERGE, efl

Jan 23 2019

SanghyeonLee abandoned D7614: efl_ui : add dummy object for verificate factory class..

abandoned

Jan 23 2019, 2:30 AM · DO NOT MERGE, efl

Jan 16 2019

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Remove resize object again. :(

Jan 16 2019, 12:46 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

optimize chain_calc

Jan 16 2019, 12:39 AM · efl

Jan 15 2019

segfaultxavi added a project to D7620: efl-api: Mark Efl.Io.Reader as stable: DO NOT MERGE.
Jan 15 2019, 5:45 AM · DO NOT MERGE, efl
segfaultxavi added a project to D7619: efl-api: Mark Efl.Io.Writer as stable: DO NOT MERGE.
Jan 15 2019, 5:45 AM · DO NOT MERGE, efl
segfaultxavi added a project to D7618: efl-api: Mark Efl.Io.Closer as stable: DO NOT MERGE.
Jan 15 2019, 5:36 AM · DO NOT MERGE, efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Remove resize object. it is unnecessary.

Jan 15 2019, 12:47 AM · efl

Jan 14 2019

SanghyeonLee added a project to D7614: efl_ui : add dummy object for verificate factory class.: DO NOT MERGE.
Jan 14 2019, 9:38 PM · DO NOT MERGE, efl
segfaultxavi accepted D7524: efl_ui_relative_layout: introduce new relative container.

Nice docs! I am approving, but only documentation-wise :)

Jan 14 2019, 8:58 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Add documentations.

Jan 14 2019, 3:50 AM · efl

Jan 13 2019

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.
  1. rebase
  2. refactoring
  3. add more tests
  4. implement chain relation (efl_ui_relative_layout_example_02)
Jan 13 2019, 10:13 PM · efl

Jan 11 2019

ManMower added a child revision for D7588: evas: Make clipee list removal O(1): D7609: ecore_evas: Don't walk mice list twice.
Jan 11 2019, 11:21 AM · DO NOT MERGE, efl

Jan 10 2019

zmike updated subscribers of D7588: evas: Make clipee list removal O(1).
Jan 10 2019, 11:42 AM · DO NOT MERGE, efl
zmike added a comment to D7588: evas: Make clipee list removal O(1).

Oh this does indeed seem like it could relate to some of the performance improvements speculated on by @raster in D7471. I wonder how this might impact any potential gains which blist could have provided?

Jan 10 2019, 11:41 AM · DO NOT MERGE, efl
cedric added a comment to D7588: evas: Make clipee list removal O(1).

This is really interesting. I am wondering what the memory impact will really be. We moved clipper into the COW part of Evas_Object as it wasn't used that much. So my guess is that it shouldn't impact memory consumption that much. Still I would be interested to get a memory profile of elementary_test, enlightenment and terminology and see what it says.

Jan 10 2019, 10:50 AM · DO NOT MERGE, efl
ManMower added reviewers for D7588: evas: Make clipee list removal O(1): cedric, raster.

Ticket D7471 proposes a new list technique with some compelling cache efficiency and memory usage characteristics. However, one of the things it's not great at is removes, as it has no equivalent to eina_list_remove_list, which is an O(1) list removal.

Jan 10 2019, 8:32 AM · DO NOT MERGE, efl

Jan 9 2019

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Rebase and remove relation_dir_to_set, relation_dir_relative_set apis.

Jan 9 2019, 8:24 PM · efl
YOhoho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

@cedric
Agreed.

relation_left_set(Eo *obj, Eo *child, Eo *target, double relative);

Would cover all cases passing NULL.

Jan 9 2019, 8:21 PM · efl
cedric added a comment to D7524: efl_ui_relative_layout: introduce new relative container.
  1. add elementary_test example.
  2. rename to left, right, top, bottom.
  3. remove register api. (when a child have relation, it is registered)

    I want overload relation_#direction# apis. for example,
  4. relation_left_set(Eo *obj, Eo *child, Eo *target) to set only to.
  5. relation_left_set(Eo *obj, Eo *child, double relative) to set only relative.
  6. relation_left_set(Eo *obj, Eo *child, Eo *target, double relative) to set both to and relative.

    However, EO doesn't support method overloading. so there are xxx_to, xxx_relative apis.
Jan 9 2019, 12:21 PM · efl
YOhoho updated the test plan for D7524: efl_ui_relative_layout: introduce new relative container.
Jan 9 2019, 4:33 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

update a meson build file

Jan 9 2019, 4:05 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.
  1. add elementary_test example.
  2. rename to left, right, top, bottom.
  3. remove register api. (when a child have relation, it is registered)
Jan 9 2019, 4:03 AM · efl

Jan 7 2019

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

implement margin

Jan 7 2019, 5:57 PM · efl
segfaultxavi requested changes to D7524: efl_ui_relative_layout: introduce new relative container.

OK, I'll wait for the new docs before reviewing. I am rejecting this version so we do not forget and this patch gets merged without documentation :)

Jan 7 2019, 9:32 AM · efl
YOhoho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

I am not to sure of the name of this new class as it doesn't express in the name the fact that it is a container. Also, and it is something that I am sure @segfaultxavi will point out, it is lacking a lot of documentation :-)

Jan 7 2019, 2:40 AM · efl
YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.

Rename to Efl.Ui.Relative_Layout

Jan 7 2019, 2:02 AM · efl

Jan 6 2019

YOhoho updated the diff for D7524: efl_ui_relative_layout: introduce new relative container.
  1. Rename Efl_Ui_Relative_Param -> Efl_Ui_Relative_Relation and integrate rel1 and rel2.
  2. (API) Rename rel1 -> left, rel2 -> right for intuitive names.
  3. Add Get method for properies.
  4. Update Class Diagram (check above comment)
Jan 6 2019, 11:54 PM · efl

Jan 4 2019

cedric added a reviewer for D7524: efl_ui_relative_layout: introduce new relative container: segfaultxavi.

I am not to sure of the name of this new class as it doesn't express in the name the fact that it is a container. Also, and it is something that I am sure @segfaultxavi will point out, it is lacking a lot of documentation :-)

Jan 4 2019, 6:09 PM · efl
Jaehyun_Cho added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

Could you move the definition of struct Efl.Ui.Relative_Params to efl_ui_relative.eo file?

Jan 4 2019, 3:18 AM · efl

Dec 30 2018

kimcinoo added a comment to D7524: efl_ui_relative_layout: introduce new relative container.

Interesting :D

Dec 30 2018, 2:05 PM · efl

Dec 28 2018

YOhoho added a project to D7524: efl_ui_relative_layout: introduce new relative container: DO NOT MERGE.
Dec 28 2018, 12:27 AM · efl

Dec 4 2018

vitor.sousa accepted D7394: eolian_mono: Add support for C# style properties.
Dec 4 2018, 10:42 AM · efl: language bindings
lauromoura updated the diff for D7394: eolian_mono: Add support for C# style properties.

Update generating documentation for properties.

Dec 4 2018, 9:58 AM · efl: language bindings
segfaultxavi requested changes to D7394: eolian_mono: Add support for C# style properties.

On a second thought... properties should have documentation :)

Dec 4 2018, 4:26 AM · efl: language bindings
lauromoura updated the diff for D7394: eolian_mono: Add support for C# style properties.

Rebase.

Dec 4 2018, 3:53 AM · efl: language bindings
segfaultxavi accepted D7394: eolian_mono: Add support for C# style properties.

Meanwhile, as the patch just adds new functionality, we could merge it, and once these three properties are dealt with a new commit would remove them from the blacklist and turn the Getters/Setters private.

Dec 4 2018, 2:56 AM · efl: language bindings

Dec 3 2018

lauromoura added a comment to D7394: eolian_mono: Add support for C# style properties.

Only renaming the interfaces won't be enough. As per IRC discussion, these three properties have conflicts: Efl.Ui.Text.Text, Efl.Input.Key.Key and Efl.Input.Hold.Hold. I guess the easiest solution is to just rename either the property or the type (whatever is easier) instead of trying to come up with a clever C# trick. I'm working on a proposal.

Dec 3 2018, 1:45 PM · efl: language bindings
segfaultxavi added a comment to D7394: eolian_mono: Add support for C# style properties.

Only renaming the interfaces won't be enough. As per IRC discussion, these three properties have conflicts: Efl.Ui.Text.Text, Efl.Input.Key.Key and Efl.Input.Hold.Hold. I guess the easiest solution is to just rename either the property or the type (whatever is easier) instead of trying to come up with a clever C# trick. I'm working on a proposal.

Dec 3 2018, 10:04 AM · efl: language bindings
segfaultxavi added a comment to D7394: eolian_mono: Add support for C# style properties.

6ec6d93535ebda03e1a4fac28b13d81b9ec79ee7 fixed make check for me.

Dec 3 2018, 3:13 AM · efl: language bindings

Nov 30 2018

lauromoura added a comment to D7394: eolian_mono: Add support for C# style properties.

Well, just renaming the interfaces wouldn't be enough, as implementing classes like Efl.Ui.Text would still conflict when they implement the interface property.

Nov 30 2018, 5:28 PM · efl: language bindings
lauromoura updated the diff for D7394: eolian_mono: Add support for C# style properties.

Updated version supporting interface properties.

Nov 30 2018, 12:49 PM · efl: language bindings
lauromoura edited projects for D7394: eolian_mono: Add support for C# style properties, added: efl: language bindings, DO NOT MERGE; removed efl.
Nov 30 2018, 12:48 PM · efl: language bindings

Nov 28 2018

bu5hm4n abandoned D6578: elm_scroller: mark the scroller as regular focus element.
Nov 28 2018, 1:16 PM · DO NOT MERGE, efl

Nov 5 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

fix conflicts and rebasing commits

Nov 5 2018, 3:12 AM · efl

Nov 1 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

rebasing commit

Nov 1 2018, 10:53 PM · efl

Oct 22 2018

YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

I guess problem is that scroller have focusable dummy element when it doesn't have focusable content. but it is not included in pd->iterator_list in _efl_ui_focus_manager_root_focus_efl_ui_focus_manager_border_elements_get. so, scroller can't find focusable element.

Oct 22 2018, 4:22 AM · DO NOT MERGE, efl
YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

I meant focus move policy when scroller have focusable content.
The interaction problem between scroller and other widget is focus manager side issue.

Oct 22 2018, 1:19 AM · DO NOT MERGE, efl
bu5hm4n updated subscribers of D6578: elm_scroller: mark the scroller as regular focus element.

Yes - you said that @eagleeye will handle it and assigned it to him... https://phab.enlightenment.org/D6587#118371

Oct 22 2018, 12:15 AM · DO NOT MERGE, efl

Oct 21 2018

YOhoho added a comment to D6578: elm_scroller: mark the scroller as regular focus element.

@bu5hm4n
ping, scroller which have no content still can't get focus

Oct 21 2018, 8:16 PM · DO NOT MERGE, efl

Oct 15 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

Update grid widget and test / examples

  • update wrong grid item position calculation
  • update grid test with scrolls
  • update grid example to test vertical case with text
Oct 15 2018, 5:28 AM · efl

Oct 12 2018

SanghyeonLee updated the diff for D6985: efl_ui_grid : introduce new packable grid widget for Efl.Ui.Widget.

update test cases and themes.

Oct 12 2018, 4:33 AM · efl