Page MenuHomePhabricator
Feed Advanced Search

Yesterday

lauromoura added a comment to D9717: csharp: Revamp dotnet support.

Tentative patch. Added DO_NOT_MERGE while we get feedback from @woohyun and @Jaehyun_Cho regarding this dotnet change.

Thu, Aug 22, 8:31 PM · DO NOT MERGE, efl
lauromoura added a task to D9717: csharp: Revamp dotnet support: T8168: C#: Build with dotnet and upstream meson.
Thu, Aug 22, 8:29 PM · DO NOT MERGE, efl

Tue, Aug 20

lauromoura added a comment to D9653: csharp: Add bindable factory parts support.

This is a tentative patch with the C# syntax changes for factory binding static parts that are based on Efl.IContent.

Tue, Aug 20, 4:57 PM · efl
lauromoura added a task to D9653: csharp: Add bindable factory parts support: T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono.
Tue, Aug 20, 4:55 PM · efl

Sun, Aug 18

bu5hm4n added a child revision for D9587: efl_ui_position_manager_list: make it handle group items: D9607: efl_ui_position_manager_common: fix buffer_id.
Sun, Aug 18, 1:15 AM · efl
bu5hm4n updated the diff for D9587: efl_ui_position_manager_list: make it handle group items.

fix invalid item placement

Sun, Aug 18, 1:15 AM · efl
bu5hm4n updated the diff for D9586: efl_ui_position_manager: pass on information about group ids.

update docs

Sun, Aug 18, 1:14 AM · efl
bu5hm4n updated the diff for D9587: efl_ui_position_manager_list: make it handle group items.
Sun, Aug 18, 1:14 AM · efl

Fri, Aug 16

bu5hm4n added a project to D9587: efl_ui_position_manager_list: make it handle group items: DO NOT MERGE.

This needs rethinking.

Fri, Aug 16, 10:32 PM · efl
bu5hm4n added a project to D9586: efl_ui_position_manager: pass on information about group ids: DO NOT MERGE.

Okay i think we need to overthink this patch. It decreases the cache efficiancy a lot, and makes everything ... slower.

Fri, Aug 16, 10:31 PM · efl

Wed, Aug 14

lauromoura updated the diff for D9564: csharp: MVVM parts support.

Update the test after updates in the C binding process

Wed, Aug 14, 11:48 AM · efl

Tue, Aug 13

lauromoura added a comment to D9564: csharp: MVVM parts support.

Added the DO NOT MERGE tag so we can start reviewing this while we fix an issue regarding getting the part from the binder.

Tue, Aug 13, 7:55 PM · efl
lauromoura added a project to D9564: csharp: MVVM parts support: DO NOT MERGE.
Tue, Aug 13, 7:54 PM · efl
SanghyeonLee abandoned D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM.
Tue, Aug 13, 7:03 PM · DO NOT MERGE, efl

Mon, Aug 5

bu5hm4n added a comment to D8442: efl_ui_selectable: separate efl_ui_selectable into item and text.

Sorry i forgot about this, i ironically redid the same, and just found your ticket, and this revision. I could kick my own ass for that ... :|

Mon, Aug 5, 9:43 AM · DO NOT MERGE, Restricted Project

Tue, Jul 30

bu5hm4n abandoned D8845: efl_ui_grid: refactor into container subclass.

this is irrelevant.

Tue, Jul 30, 10:25 AM · DO NOT MERGE, efl
zmike added a comment to D7986: evas_object: reduce method calls for efl_gfx_entity_geometry_set.

Oh I forgot about this.

Tue, Jul 30, 5:44 AM · DO NOT MERGE, efl

Mon, Jul 29

cedric added a comment to D7986: evas_object: reduce method calls for efl_gfx_entity_geometry_set.

What the state of this one?

Mon, Jul 29, 11:36 AM · DO NOT MERGE, efl

Wed, Jul 24

zmike accepted D9285: Introduce Efl.Ui.Item_Container.
Wed, Jul 24, 10:02 AM · efl
cedric accepted D9285: Introduce Efl.Ui.Item_Container.

I think this is good enough for landing and we can iterate from there.

Wed, Jul 24, 9:50 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • update docs
Wed, Jul 24, 9:27 AM · efl
segfaultxavi resigned from D9285: Introduce Efl.Ui.Item_Container.

I've added a few more comments but this has become unmanageable. I'd rather wait until this lands and then I'll update the docs.

Wed, Jul 24, 7:59 AM · efl

Jul 24 2019

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

rebase + updates to docs

Jul 24 2019, 6:33 AM · efl
bu5hm4n removed parent revisions for D9285: Introduce Efl.Ui.Item_Container: D9304: efl_ui_spotlight_container: fix ownership behavior of view_manager, D9325: efl_ui_win: optimize shutdown.
Jul 24 2019, 6:24 AM · efl
bu5hm4n added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 24 2019, 6:23 AM · efl

Jul 23 2019

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • update docs
Jul 23 2019, 8:48 AM · efl

Jul 22 2019

cedric added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 22 2019, 11:20 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • fixup benchmarks, improve output of the binary
Jul 22 2019, 1:06 AM · efl

Jul 21 2019

SanghyeonLee added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 21 2019, 10:35 PM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • fix lookup cache of the accessor
Jul 21 2019, 6:55 AM · efl
bu5hm4n planned changes to D9285: Introduce Efl.Ui.Item_Container.
Jul 21 2019, 5:11 AM · efl
bu5hm4n added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 21 2019, 5:10 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

update docs and all the marked comments.

Jul 21 2019, 5:08 AM · efl
bu5hm4n planned changes to D9285: Introduce Efl.Ui.Item_Container.
Jul 21 2019, 4:44 AM · efl

Jul 19 2019

cedric requested changes to D9285: Introduce Efl.Ui.Item_Container.
Jul 19 2019, 4:21 PM · efl
segfaultxavi added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 19 2019, 8:37 AM · efl
SanghyeonLee added a task to D9285: Introduce Efl.Ui.Item_Container: T8058: Naming our collection container.
Jul 19 2019, 4:48 AM · efl

Jul 18 2019

zmike added a comment to D9285: Introduce Efl.Ui.Item_Container.

Also a number of lines need wrapping because they go off screen even in my 160col editor.

Jul 18 2019, 10:01 AM · efl
zmike requested changes to D9285: Introduce Efl.Ui.Item_Container.

One issue I have with this is the bool: animation param for various methods. Typically we provide some options for this kind of thing like linear, accelerate, decelerate, ...

Jul 18 2019, 9:59 AM · efl
SanghyeonLee added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 18 2019, 5:11 AM · efl
bu5hm4n added inline comments to D9285: Introduce Efl.Ui.Item_Container.
Jul 18 2019, 4:43 AM · efl
segfaultxavi requested changes to D9285: Introduce Efl.Ui.Item_Container.

I've made quite a few comments on the API and the docs... make sure to mark them as done so none is forgotten!

Jul 18 2019, 4:22 AM · efl

Jul 17 2019

bu5hm4n updated subscribers of D9285: Introduce Efl.Ui.Item_Container.

I would like to merge this widget at the latest on the 27.07.

Jul 17 2019, 9:47 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

add multiselect radio

Jul 17 2019, 8:23 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

fix scroller bouncing

Jul 17 2019, 8:01 AM · efl

Jul 16 2019

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

more fixes better tests in elm_test

Jul 16 2019, 2:13 AM · efl

Jul 14 2019

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

forgot a few files

Jul 14 2019, 10:05 AM · efl
bu5hm4n added a comment to D9285: Introduce Efl.Ui.Item_Container.

The widget meanwhile is feature complete, there are tests for the grid position manager and list position manager. The tests for now are only plain copies. Given the complexity of this widget, there will 100% be more bugs to find, and things to clarify, so I would be very happy if people could write examples for that, play with the API, do things that i did not think of. Or simply play around in the tests. Thank you :)

Jul 14 2019, 2:03 AM · efl
bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.
  • more tests
Jul 14 2019, 2:00 AM · efl

Jul 12 2019

bu5hm4n updated the diff for D9285: Introduce Efl.Ui.Item_Container.

add grid position manager and tests

Jul 12 2019, 2:36 AM · efl
bu5hm4n added a comment to D9285: Introduce Efl.Ui.Item_Container.

On the technical side, I am not sure how I am going to implement the accessor for items as they will be build asynchronously on demand, I wonder how to notify the position manager that they now exist while they didn't before. I am guessing that the best approach for the CollectionView will be to use custom accessor that bind to the data model and the local storage for widget. It seems doable at this point.

Jul 12 2019, 2:08 AM · efl

Jul 11 2019

SanghyeonLee added a comment to D9285: Introduce Efl.Ui.Item_Container.

well then we could think about another names,
itemBox, itemWidget, itemScroller(?) itemCollection, itemLayout, itemController...
but most of these also have same problem...

Jul 11 2019, 8:22 PM · efl
cedric added a comment to D9285: Introduce Efl.Ui.Item_Container.

Not to sure of the naming. Efl.Ui.Item_Container seems wrong. What other kind of Efl.Ui.Container would we have that would contain something different? It sounds like a boat for water kind of naming. Not really the most important bit, but that is going to take some time to discuss and find a good name.

Jul 11 2019, 4:50 PM · efl
bu5hm4n added a project to D9285: Introduce Efl.Ui.Item_Container: DO NOT MERGE.
Jul 11 2019, 8:29 AM · efl

Jul 10 2019

lauromoura updated the diff for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

Updating after big changes.

Jul 10 2019, 3:16 PM · efl: language bindings, Restricted Project

Jul 8 2019

zmike added a project to D9123: ci: move release-ready to default build and enable tests+install on it: DO NOT MERGE.

Alright this is fixed in upstream meson but it'll probably be a while before the changes are available and I don't really want to be patching meson manually on CI

Jul 8 2019, 9:29 AM · DO NOT MERGE, efl

Jun 28 2019

lauromoura updated the diff for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

Another round with some fixes.

Jun 28 2019, 3:18 PM · efl: language bindings, Restricted Project
lauromoura commandeered D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.
Jun 28 2019, 3:10 PM · efl: language bindings, Restricted Project

Jun 27 2019

zmike accepted D9171: efl_input_interface: verify check cancel event.
Jun 27 2019, 7:24 AM · efl
bu5hm4n updated the diff for D9171: efl_input_interface: verify check cancel event.

more test

Jun 27 2019, 7:22 AM · efl
zmike requested changes to D9171: efl_input_interface: verify check cancel event.

Like I said, this should also verify that the sequence of down -> cancel -> up occurs in the expected order and that the event info in down matches the info in cancel.

Jun 27 2019, 6:59 AM · efl
bu5hm4n updated the diff for D9171: efl_input_interface: verify check cancel event.

yey there is a event!!!

Jun 27 2019, 6:22 AM · efl

Jun 26 2019

zmike requested changes to D9171: efl_input_interface: verify check cancel event.

Check out D9184, I think this test needs to verify that the 'up' event is also emitted after cancel

Jun 26 2019, 7:32 AM · efl

Jun 25 2019

bu5hm4n added a project to D9171: efl_input_interface: verify check cancel event: DO NOT MERGE.

This here is a funny one, we are defining the event, but we are not emitting it at all, where or how should we emit this one ? In legacy it seems like we do not have something like this.
Does someone know where or how to emit this ?

Jun 25 2019, 1:36 AM · efl

May 27 2019

segfaultxavi added a comment to D9027: autotools: REMOVAL!.

May 27 2019, 1:14 AM · efl

May 26 2019

bu5hm4n added a comment to D9027: autotools: REMOVAL!.

According to the mailing thread, this should be merged on the 30.05, if nothing else comes up.

May 26 2019, 9:42 AM · efl
bu5hm4n added a project to D9027: autotools: REMOVAL!: DO NOT MERGE.
May 26 2019, 9:41 AM · efl

May 19 2019

SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

can you update status of this diff?

May 19 2019, 10:56 PM · efl: language bindings, Restricted Project

May 17 2019

bu5hm4n added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Thank you :)

May 17 2019, 4:01 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

I apologize. I've submitted a patch to fix it. 099eb2c315a277bda10f41709d7f936b0ae7fb20

May 17 2019, 3:53 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

@Jaehyun_Cho Can you *please* *please* *please* be more carefull reviewing these meson changes. The eo files here are just plainly not installed anymore. because line 26 was removed. Additionally, its pure luck that this still works in meson, because you actually pass now a array with a array in array element nr. 0 followed by strings. This is not supported by meson and really only works by luck.

May 17 2019, 2:18 AM · DO NOT MERGE, efl

May 14 2019

Jaehyun_Cho closed D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
May 14 2019, 12:38 AM · DO NOT MERGE, efl
Jaehyun_Cho accepted D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
May 14 2019, 12:36 AM · DO NOT MERGE, efl
Jaehyun_Cho updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

rebase

May 14 2019, 12:35 AM · DO NOT MERGE, efl

May 9 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

mesong build support

May 9 2019, 10:18 PM · DO NOT MERGE, efl
zmike removed a parent revision for D8852: evas: enable setting any object as a clipper: D8851: edje/calc: correctly handle swallow/group objects as clippers for state clips.
May 9 2019, 5:54 AM · efl
zmike added a child revision for D8852: evas: enable setting any object as a clipper: D8850: elm_test: add smart object mask test to existing masking test.
May 9 2019, 5:54 AM · efl
zmike edited parent revisions for D8850: elm_test: add smart object mask test to existing masking test, added: 1; removed: 1.
May 9 2019, 5:54 AM · efl
zmike removed a child revision for D8850: elm_test: add smart object mask test to existing masking test: D8851: edje/calc: correctly handle swallow/group objects as clippers for state clips.
May 9 2019, 5:54 AM · efl
zmike added a project to D8850: elm_test: add smart object mask test to existing masking test: DO NOT MERGE.
May 9 2019, 5:53 AM · efl
zmike added a project to D8853: edje_cc: remove compile fails when setting a complex object as a clipper: DO NOT MERGE.
May 9 2019, 5:53 AM · efl
zmike added a project to D8852: evas: enable setting any object as a clipper: DO NOT MERGE.

This is a good point. I've done some testing locally and it doesn't work quite right yet.

May 9 2019, 5:52 AM · efl

May 8 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Meson build support

May 8 2019, 11:46 PM · DO NOT MERGE, efl

May 7 2019

bu5hm4n planned changes to D8845: efl_ui_grid: refactor into container subclass.
May 7 2019, 9:31 AM · DO NOT MERGE, efl
bu5hm4n added a project to D8845: efl_ui_grid: refactor into container subclass: DO NOT MERGE.
May 7 2019, 9:31 AM · DO NOT MERGE, efl
bu5hm4n removed a parent revision for D8845: efl_ui_grid: refactor into container subclass: D8830: efl_ui_item: migrate to Efl.Ui.Clickable.
May 7 2019, 9:31 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

When I tried to build with meson, build error happens because efl_gesture_events.eo is dependent on efl_canvas_gesture_xxx.eo

May 7 2019, 4:31 AM · DO NOT MERGE, efl

May 2 2019

Jaehyun_Cho requested changes to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

need to check meson build

May 2 2019, 5:37 AM · DO NOT MERGE, efl
Jaehyun_Cho accepted D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
May 2 2019, 5:33 AM · DO NOT MERGE, efl
CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Code clean up to following comments.

May 2 2019, 5:19 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Could you check and remove EINA_UNUSED which are not supposed to be used?

May 2 2019, 4:10 AM · DO NOT MERGE, efl

Apr 29 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Fix build warning.

Apr 29 2019, 12:40 AM · DO NOT MERGE, efl
CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Remove Conflict

Apr 29 2019, 12:33 AM · DO NOT MERGE, efl
CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Code clean up.

Apr 29 2019, 12:02 AM · DO NOT MERGE, efl

Apr 28 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Update code to supprt c# binding.

Apr 28 2019, 11:09 PM · DO NOT MERGE, efl
Jaehyun_Cho requested changes to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

@CHAN is updating this patch to support EFL C#.

Apr 28 2019, 10:11 PM · DO NOT MERGE, efl

Apr 25 2019

SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

ping?

Apr 25 2019, 10:59 PM · efl: language bindings, Restricted Project

Apr 12 2019

segfaultxavi added a comment to D8433: efl.pack_linear: Clarify behavior and docs.

Fixed!

Apr 12 2019, 12:04 AM · efl
segfaultxavi updated the diff for D8433: efl.pack_linear: Clarify behavior and docs.

Fix copy&paste error.

Apr 12 2019, 12:03 AM · efl

Apr 11 2019

YOhoho added inline comments to D8433: efl.pack_linear: Clarify behavior and docs.
Apr 11 2019, 11:41 PM · efl