Page MenuHomePhabricator
Feed Advanced Search

Mon, May 27

segfaultxavi added a comment to D9027: autotools: REMOVAL!.

Mon, May 27, 1:14 AM · efl

Sun, May 26

bu5hm4n added a comment to D9027: autotools: REMOVAL!.

According to the mailing thread, this should be merged on the 30.05, if nothing else comes up.

Sun, May 26, 9:42 AM · efl
bu5hm4n added a project to D9027: autotools: REMOVAL!: DO NOT MERGE.
Sun, May 26, 9:41 AM · efl

Sun, May 19

SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

can you update status of this diff?

Sun, May 19, 10:56 PM · DO NOT MERGE, efl

May 17 2019

bu5hm4n added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Thank you :)

May 17 2019, 4:01 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

I apologize. I've submitted a patch to fix it. 099eb2c315a277bda10f41709d7f936b0ae7fb20

May 17 2019, 3:53 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

@Jaehyun_Cho Can you *please* *please* *please* be more carefull reviewing these meson changes. The eo files here are just plainly not installed anymore. because line 26 was removed. Additionally, its pure luck that this still works in meson, because you actually pass now a array with a array in array element nr. 0 followed by strings. This is not supported by meson and really only works by luck.

May 17 2019, 2:18 AM · DO NOT MERGE, efl

May 14 2019

Jaehyun_Cho closed D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
May 14 2019, 12:38 AM · DO NOT MERGE, efl
Jaehyun_Cho accepted D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
May 14 2019, 12:36 AM · DO NOT MERGE, efl
Jaehyun_Cho updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

rebase

May 14 2019, 12:35 AM · DO NOT MERGE, efl

May 9 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

mesong build support

May 9 2019, 10:18 PM · DO NOT MERGE, efl
zmike removed a parent revision for D8852: evas: enable setting any object as a clipper: D8851: edje/calc: correctly handle swallow/group objects as clippers for state clips.
May 9 2019, 5:54 AM · efl
zmike added a child revision for D8852: evas: enable setting any object as a clipper: D8850: elm_test: add smart object mask test to existing masking test.
May 9 2019, 5:54 AM · efl
zmike edited parent revisions for D8850: elm_test: add smart object mask test to existing masking test, added: 1; removed: 1.
May 9 2019, 5:54 AM · efl
zmike removed a child revision for D8850: elm_test: add smart object mask test to existing masking test: D8851: edje/calc: correctly handle swallow/group objects as clippers for state clips.
May 9 2019, 5:54 AM · efl
zmike added a project to D8850: elm_test: add smart object mask test to existing masking test: DO NOT MERGE.
May 9 2019, 5:53 AM · efl
zmike added a project to D8853: edje_cc: remove compile fails when setting a complex object as a clipper: DO NOT MERGE.
May 9 2019, 5:53 AM · efl
zmike added a project to D8852: evas: enable setting any object as a clipper: DO NOT MERGE.

This is a good point. I've done some testing locally and it doesn't work quite right yet.

May 9 2019, 5:52 AM · efl

May 8 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Meson build support

May 8 2019, 11:46 PM · DO NOT MERGE, efl

May 7 2019

bu5hm4n planned changes to D8845: efl_ui_grid: refactor into container subclass.
May 7 2019, 9:31 AM · DO NOT MERGE, efl
bu5hm4n added a project to D8845: efl_ui_grid: refactor into container subclass: DO NOT MERGE.
May 7 2019, 9:31 AM · DO NOT MERGE, efl
bu5hm4n removed a parent revision for D8845: efl_ui_grid: refactor into container subclass: D8830: efl_ui_item: migrate to Efl.Ui.Clickable.
May 7 2019, 9:31 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

When I tried to build with meson, build error happens because efl_gesture_events.eo is dependent on efl_canvas_gesture_xxx.eo

May 7 2019, 4:31 AM · DO NOT MERGE, efl

May 2 2019

Jaehyun_Cho requested changes to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

need to check meson build

May 2 2019, 5:37 AM · DO NOT MERGE, efl
Jaehyun_Cho accepted D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..
May 2 2019, 5:33 AM · DO NOT MERGE, efl
CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Code clean up to following comments.

May 2 2019, 5:19 AM · DO NOT MERGE, efl
Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Could you check and remove EINA_UNUSED which are not supposed to be used?

May 2 2019, 4:10 AM · DO NOT MERGE, efl

Apr 29 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Fix build warning.

Apr 29 2019, 12:40 AM · DO NOT MERGE, efl
CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Remove Conflict

Apr 29 2019, 12:33 AM · DO NOT MERGE, efl
CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Code clean up.

Apr 29 2019, 12:02 AM · DO NOT MERGE, efl

Apr 28 2019

CHAN updated the diff for D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

Update code to supprt c# binding.

Apr 28 2019, 11:09 PM · DO NOT MERGE, efl
Jaehyun_Cho requested changes to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

@CHAN is updating this patch to support EFL C#.

Apr 28 2019, 10:11 PM · DO NOT MERGE, efl

Apr 25 2019

SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

ping?

Apr 25 2019, 10:59 PM · DO NOT MERGE, efl

Apr 12 2019

segfaultxavi added a comment to D8433: efl.pack_linear: Clarify behavior and docs.

Fixed!

Apr 12 2019, 12:04 AM · efl
segfaultxavi updated the diff for D8433: efl.pack_linear: Clarify behavior and docs.

Fix copy&paste error.

Apr 12 2019, 12:03 AM · efl

Apr 11 2019

YOhoho added inline comments to D8433: efl.pack_linear: Clarify behavior and docs.
Apr 11 2019, 11:41 PM · efl
segfaultxavi added inline comments to D8433: efl.pack_linear: Clarify behavior and docs.
Apr 11 2019, 11:08 PM · efl
YOhoho requested changes to D8433: efl.pack_linear: Clarify behavior and docs.

It's wrong copy/paste.

Apr 11 2019, 10:50 PM · efl
YOhoho updated the diff for D8280: ui.widget: remove elm_widget_sub_object_parent_add from each of widgets.

rebase

Apr 11 2019, 10:38 PM · efl

Apr 7 2019

SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

is this patch ready to go?
please comment more detail about this patch in commit-message,
and rebase on latest master.

Apr 7 2019, 10:28 PM · DO NOT MERGE, efl

Apr 5 2019

vitor.sousa closed D8431: efl-csharp: fix resource deallocation causing errors everywhere.
Apr 5 2019, 3:58 PM · DO NOT MERGE, efl: language bindings
vitor.sousa added a child revision for D8431: efl-csharp: fix resource deallocation causing errors everywhere: D8564: efl-csharp: fix crash when events trigger after C# object `Dispose`.
Apr 5 2019, 3:41 PM · DO NOT MERGE, efl: language bindings
lauromoura accepted D8431: efl-csharp: fix resource deallocation causing errors everywhere.
Apr 5 2019, 3:39 PM · DO NOT MERGE, efl: language bindings
vitor.sousa updated the diff for D8431: efl-csharp: fix resource deallocation causing errors everywhere.

fix previous update submitting to much code

Apr 5 2019, 3:37 PM · DO NOT MERGE, efl: language bindings
vitor.sousa added a parent revision for D8431: efl-csharp: fix resource deallocation causing errors everywhere: D8550: csharp: Make classes abstract and rework casting.
Apr 5 2019, 3:30 PM · DO NOT MERGE, efl: language bindings
vitor.sousa updated the diff for D8431: efl-csharp: fix resource deallocation causing errors everywhere.

rebase and adds D8550 as a dependency

Apr 5 2019, 3:29 PM · DO NOT MERGE, efl: language bindings

Apr 3 2019

bu5hm4n accepted D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

Cool, thx!

Apr 3 2019, 4:53 AM · efl
segfaultxavi accepted D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

All test suites (including the new behavioral one) pass now!

Apr 3 2019, 3:58 AM · efl
YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

Thank you to point out that.

Apr 3 2019, 3:48 AM · efl
bu5hm4n accepted D8433: efl.pack_linear: Clarify behavior and docs.
Apr 3 2019, 2:57 AM · efl
segfaultxavi requested changes to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Apr 3 2019, 2:54 AM · efl
bu5hm4n added a child revision for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box: D8520: efl_ui_widget: we should ensure that every subobject is a gfx entity.
Apr 3 2019, 2:39 AM · efl
segfaultxavi updated the diff for D8433: efl.pack_linear: Clarify behavior and docs.

Clarify docs for unpack_at()

Apr 3 2019, 2:09 AM · efl
segfaultxavi added a project to D8433: efl.pack_linear: Clarify behavior and docs: DO NOT MERGE.
Apr 3 2019, 2:04 AM · efl

Apr 2 2019

bu5hm4n requested changes to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Apr 2 2019, 8:46 AM · efl
bu5hm4n removed a child revision for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box: D8519: efl_check: add API to expect a error.
Apr 2 2019, 8:24 AM · efl
segfaultxavi resigned from D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

OK, I am happy with the docs now, thanks!
However, I will not comment on the code, since I am no expert in this area.

Apr 2 2019, 1:55 AM · efl

Apr 1 2019

YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

I forgot git add

Apr 1 2019, 8:31 PM · efl
bu5hm4n added a child revision for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box: D8519: efl_check: add API to expect a error.
Apr 1 2019, 6:02 AM · efl
segfaultxavi requested changes to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Apr 1 2019, 4:55 AM · efl

Mar 28 2019

YOhoho added a comment to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
In D8417#153395, @zmike wrote:

I am thinking that maybe we land this patch after the 1.22 release?

Mar 28 2019, 3:48 AM · efl
bu5hm4n added a project to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box: DO NOT MERGE.
Mar 28 2019, 1:51 AM · efl

Mar 27 2019

Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

This patch is going to be submitted after 1.22 release.

Mar 27 2019, 1:15 AM · DO NOT MERGE, efl
Jaehyun_Cho added a project to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic.: DO NOT MERGE.
Mar 27 2019, 1:15 AM · DO NOT MERGE, efl

Mar 25 2019

Jaehyun_Cho added a project to D8442: efl_ui_selectable: separate efl_ui_selectable into item and text: DO NOT MERGE.
Mar 25 2019, 4:58 AM · DO NOT MERGE, Restricted Project

Mar 22 2019

lauromoura added a comment to D8431: efl-csharp: fix resource deallocation causing errors everywhere.

I built and installed this patch (after rebasing to latest master).
All C# tutorials seems to segfault on exit. For example, the hello-world one, which only instantiates a window (console output: P279)

Source of the hello-word tutorial:
https://git.enlightenment.org/tools/examples.git/tree/tutorial/csharp/hello-world/src/hello-world.cs

Mar 22 2019, 2:18 PM · DO NOT MERGE, efl: language bindings
devilhorns closed D8117: wl-drm: Refactor _drm2_randr_apply function.
Mar 22 2019, 10:01 AM · enlightenment-git, DO NOT MERGE, efl
devilhorns closed D8114: ecore-drm2: Add API function to return output rotation.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8116: ecore-evas-drm: Enable rotation to work again.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8115: ecore-drm2: Factor in output rotation when getting output info.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8113: ecore-drm2: Set output rotation value.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8112: ecore-drm2: Disable hardware rotation for outputs.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8111: ecore-drm2: Update plane state values based on FB.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
bu5hm4n added a project to D8280: ui.widget: remove elm_widget_sub_object_parent_add from each of widgets: DO NOT MERGE.
Mar 22 2019, 8:45 AM · efl

Mar 21 2019

segfaultxavi requested changes to D8431: efl-csharp: fix resource deallocation causing errors everywhere.

I built and installed this patch (after rebasing to latest master).
All C# tutorials seems to segfault on exit. For example, the hello-world one, which only instantiates a window (console output: P279)

Mar 21 2019, 5:27 AM · DO NOT MERGE, efl: language bindings

Mar 20 2019

vitor.sousa added a comment to D8431: efl-csharp: fix resource deallocation causing errors everywhere.

@cedric I solved the concurrency problem using ecore_main_loop_thread_safe_call_async.
Eo error logs disappeared, but now the test prints a big list like this at the end of execution:

EINA ERROR: 'Invalid argument' on unlock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on lock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on unlock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on lock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on unlock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on lock 0x7fc693ffe980

Could you give it a look and check whether I am using it incorrectly or it is a problem with eina_thread?

Mar 20 2019, 12:38 PM · DO NOT MERGE, efl: language bindings
vitor.sousa edited projects for D8431: efl-csharp: fix resource deallocation causing errors everywhere, added: efl: language bindings, DO NOT MERGE; removed efl.
Mar 20 2019, 12:29 PM · DO NOT MERGE, efl: language bindings
devilhorns added a comment to D8114: ecore-drm2: Add API function to return output rotation.

@stefan_schmidt Do you think we can add this small API before release ?? I sent an email to the dev ml about it, but no responses from Anyone yet :(

Mar 20 2019, 10:34 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D8425: eolian: enable event redef checking by default.
Mar 20 2019, 7:17 AM · efl
bu5hm4n added a project to D8425: eolian: enable event redef checking by default: DO NOT MERGE.
Mar 20 2019, 7:17 AM · efl

Mar 19 2019

devilhorns added a child revision for D8116: ecore-evas-drm: Enable rotation to work again: D8402: evas drm: Don't use eng_output_resize or redraws clear.
Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8116: ecore-evas-drm: Enable rotation to work again.

no changes

Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8115: ecore-drm2: Factor in output rotation when getting output info.

no changes

Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8114: ecore-drm2: Add API function to return output rotation.

no changes

Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8113: ecore-drm2: Set output rotation value.

no changes

Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8112: ecore-drm2: Disable hardware rotation for outputs.

no changes

Mar 19 2019, 7:22 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8111: ecore-drm2: Update plane state values based on FB.

no changes

Mar 19 2019, 7:22 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.

no changes

Mar 19 2019, 7:22 AM · DO NOT MERGE, efl

Mar 15 2019

segfaultxavi abandoned D7618: efl-api: Mark Efl.Io.Closer as stable.

Fixed somewhere else.

Mar 15 2019, 6:15 AM · DO NOT MERGE, efl
segfaultxavi abandoned D7619: efl-api: Mark Efl.Io.Writer as stable.

Fixed somewhere else.

Mar 15 2019, 6:15 AM · DO NOT MERGE, efl
segfaultxavi abandoned D7620: efl-api: Mark Efl.Io.Reader as stable.

Fixed somewhere else.

Mar 15 2019, 6:14 AM · DO NOT MERGE, efl

Mar 14 2019

devilhorns updated the diff for D8116: ecore-evas-drm: Enable rotation to work again.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8115: ecore-drm2: Factor in output rotation when getting output info.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8114: ecore-drm2: Add API function to return output rotation.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8113: ecore-drm2: Set output rotation value.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8112: ecore-drm2: Disable hardware rotation for outputs.

Update patch based on review comments

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8111: ecore-drm2: Update plane state values based on FB.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.

Update patch based on review comments

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
zmike added inline comments to D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.
Mar 14 2019, 9:45 AM · DO NOT MERGE, efl