Page MenuHomePhabricator
Feed Advanced Search

Thu, Jan 16

Jaehyun_Cho added a comment to D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture.

There are many patches related to gesture. (D11052, D11053, ...)
Therefore, to avoid conflict to the above patches, this patch should not be merged until either those patches are merged or abandoned.

Thu, Jan 16, 9:44 PM · DO NOT MERGE, efl
Jaehyun_Cho added a project to D11110: efl_canvas_gesture: rename Gesture_XXX to XXX_Gesture: DO NOT MERGE.
Thu, Jan 16, 9:40 PM · DO NOT MERGE, efl

Wed, Jan 15

SanghyeonLee added a comment to D11106: MonoModelInteral : Add missing model events..

Do not merge yet as this implement need to be discussed in right way.

Wed, Jan 15, 4:33 AM · DO NOT MERGE, efl
SanghyeonLee added a project to D11106: MonoModelInteral : Add missing model events.: DO NOT MERGE.
Wed, Jan 15, 4:32 AM · DO NOT MERGE, efl

Fri, Jan 10

bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

forgotten changes

Fri, Jan 10, 8:02 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

update

Fri, Jan 10, 7:38 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

more changes

Fri, Jan 10, 6:26 AM · DO NOT MERGE, efl
bu5hm4n planned changes to D11018: eina: introduce Eina_Abstract_Content.
Fri, Jan 10, 2:22 AM · DO NOT MERGE, efl

Thu, Jan 9

cedric requested changes to D11018: eina: introduce Eina_Abstract_Content.

Some more review.

Thu, Jan 9, 1:59 PM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

Apply planned changes.

Thu, Jan 9, 1:07 PM · DO NOT MERGE, efl

Wed, Jan 8

bu5hm4n planned changes to D11018: eina: introduce Eina_Abstract_Content.
Wed, Jan 8, 11:57 PM · DO NOT MERGE, efl
cedric requested changes to D11018: eina: introduce Eina_Abstract_Content.
Wed, Jan 8, 3:38 PM · DO NOT MERGE, efl
bu5hm4n updated the diff for D11018: eina: introduce Eina_Abstract_Content.

add eina_value implementation

Wed, Jan 8, 1:01 PM · DO NOT MERGE, efl
cedric updated the diff for D11012: tests: start some collectionview tests.

rebase

Wed, Jan 8, 10:17 AM · efl

Sun, Jan 5

bu5hm4n added a comment to D11018: eina: introduce Eina_Abstract_Content.

This is for now just a draft, more conversions are missing, and i think we should be able to pass a content with a type as Eina_Value. However, i think feedback here could be of interest.

Sun, Jan 5, 6:10 AM · DO NOT MERGE, efl
bu5hm4n added a project to D11018: eina: introduce Eina_Abstract_Content: DO NOT MERGE.
Sun, Jan 5, 6:08 AM · DO NOT MERGE, efl

Fri, Jan 3

cedric added a child revision for D11012: tests: start some collectionview tests: D11013: elementary: properly propagate "child.selected" change..
Fri, Jan 3, 3:37 PM · efl
cedric updated the diff for D11012: tests: start some collectionview tests.
Fri, Jan 3, 3:37 PM · efl
zmike requested review of D11012: tests: start some collectionview tests.
Fri, Jan 3, 11:55 AM · efl

Thu, Dec 26

Peter2121 added a comment to D10825: eo: do not free these values here.

Another interesting log records from /tmp/efreetd_host-peter.bimp.local_xxxxxx.log:

Thu, Dec 26, 6:43 AM · DO NOT MERGE, efl
Peter2121 added a comment to D10825: eo: do not free these values here.

BTW, on a PC where I have the problem, /tmp is filled by efreetd_host-peter.bimp.local_djTpjB.log with the following content repeating continuously:

Thu, Dec 26, 6:38 AM · DO NOT MERGE, efl

Mon, Dec 23

felipealmeida commandeered D10889: csharp: Generating documentation for tuple-value properties..
Mon, Dec 23, 8:41 AM · DO NOT MERGE, efl
felipealmeida requested changes to D10889: csharp: Generating documentation for tuple-value properties..
Mon, Dec 23, 8:41 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D10825: eo: do not free these values here.

Tracing bad issues.

Mon, Dec 23, 8:01 AM · DO NOT MERGE, efl
bu5hm4n added a project to D10825: eo: do not free these values here: DO NOT MERGE.
Mon, Dec 23, 8:01 AM · DO NOT MERGE, efl

Dec 17 2019

lauromoura abandoned D10367: csharp: Do not generate wrapper for setter returning values..

This should be done in a new patch after D10791 lands.

Dec 17 2019, 5:45 AM · DO NOT MERGE, efl

Dec 12 2019

stefan_schmidt added a project to D10867: ci: create a daily build to run with coverage enabled and upload to codecov: DO NOT MERGE.

I need to put this on hold. I see some odd behaviours in other jobs from time to time. Need to investigate.

Dec 12 2019, 5:47 AM · efl

Dec 3 2019

ali.alzyod updated the diff for D10776: efl_ui_text: unit test.

add tests

Dec 3 2019, 9:16 AM · efl
ali.alzyod added inline comments to D10776: efl_ui_text: unit test.
Dec 3 2019, 4:03 AM · efl
bu5hm4n requested changes to D10776: efl_ui_text: unit test.

Can you also test that clicking in the beginning + dragging to the end of the entry is selecting all the text ? (There are helpers for that: "drag_object" in suite_helper.h).

Dec 3 2019, 1:16 AM · efl

Dec 2 2019

ali.alzyod updated the summary of D10776: efl_ui_text: unit test.
Dec 2 2019, 10:57 PM · efl
ali.alzyod added a parent revision for D10776: efl_ui_text: unit test: D10711: Efl.Ui.Text : all related interfaces.
Dec 2 2019, 10:52 PM · efl
Diffusion closed D10766: efl_ui_spotlight_container: bring in min / max handling.
Dec 2 2019, 9:32 AM · DO NOT MERGE, efl

Nov 28 2019

bu5hm4n added a child revision for D10766: efl_ui_spotlight_container: bring in min / max handling: D10767: efl_ui_test_spotlight: check correct transitions without animation.
Nov 28 2019, 10:37 AM · DO NOT MERGE, efl
bu5hm4n updated the diff for D10766: efl_ui_spotlight_container: bring in min / max handling.

test and better handling

Nov 28 2019, 10:37 AM · DO NOT MERGE, efl
bu5hm4n added a project to D10766: efl_ui_spotlight_container: bring in min / max handling: DO NOT MERGE.
Nov 28 2019, 9:06 AM · DO NOT MERGE, efl

Nov 26 2019

ali.alzyod updated the summary of D10711: Efl.Ui.Text : all related interfaces.
Nov 26 2019, 7:33 AM · efl
ali.alzyod updated the summary of D10711: Efl.Ui.Text : all related interfaces.
Nov 26 2019, 7:31 AM · efl
ali.alzyod added reviewers for D10711: Efl.Ui.Text : all related interfaces: zmike, bu5hm4n.
Nov 26 2019, 7:30 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

emit copy/paste/cut events, disable copy/cut in password mode

Nov 26 2019, 7:26 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

preedit event forward

Nov 26 2019, 7:05 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

remove debug flags

Nov 26 2019, 6:48 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

update

Nov 26 2019, 6:46 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Nov 26 2019, 3:35 AM · efl
ali.alzyod added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Nov 26 2019, 3:34 AM · efl
segfaultxavi requested changes to D10711: Efl.Ui.Text : all related interfaces.

Here come some comments!

Nov 26 2019, 2:29 AM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

remove unused events

Nov 26 2019, 12:06 AM · efl

Nov 25 2019

ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

rebase

Nov 25 2019, 10:52 PM · efl
ali.alzyod updated the diff for D10711: Efl.Ui.Text : all related interfaces.

remove password_mode and override efl_text_format_password

Nov 25 2019, 10:47 PM · efl
zmike added a project to D10711: Efl.Ui.Text : all related interfaces: DO NOT MERGE.

Please use DO NOT MERGE for all patches which should not be considered for review.

Nov 25 2019, 5:23 AM · efl

Nov 14 2019

segfaultxavi added a comment to D10615: introduce efl_canvas_object_animation.

Adds @method animation_revert(void) to Efl.Canvas.Animation

Nov 14 2019, 7:43 AM · efl
Jaehyun_Cho added a comment to D10615: introduce efl_canvas_object_animation.

This is already done for all @move Efl.Object parameters, like setting the manager in the Container and setting the animation in this patch.

Nov 14 2019, 7:06 AM · efl
Jaehyun_Cho added a comment to D10615: introduce efl_canvas_object_animation.

@segfaultxavi @bu5hm4n
I missed asking you one more thing in the original comment.

Nov 14 2019, 6:57 AM · efl
lauromoura added a comment to D10615: introduce efl_canvas_object_animation.

As StartAnimation receives their animation object by @move, the C# binding will automatically call efl_ref for it.

@lauromoura
It would be a good idea! We need to check if it would be fine for all other @move cases. (e.g. @property manager of Efl.Ui.Spotlight.Container)
But I think it would be fine for other @move cases as well :)

Nov 14 2019, 6:52 AM · efl
Jaehyun_Cho added a comment to D10615: introduce efl_canvas_object_animation.

As StartAnimation receives their animation object by @move, the C# binding will automatically call efl_ref for it.

Nov 14 2019, 6:13 AM · efl
lauromoura added a comment to D10615: introduce efl_canvas_object_animation.
Nov 14 2019, 4:45 AM · efl
Jaehyun_Cho updated subscribers of D10615: introduce efl_canvas_object_animation.

@segfaultxavi @bu5hm4n
Thank you very much for the comments! :)

Nov 14 2019, 3:26 AM · efl

Nov 13 2019

bu5hm4n added a comment to D10615: introduce efl_canvas_object_animation.

I think this is pretty fine like it is now, there are 2 more things that need to migrate away from player, but that does not block this revision here.

Nov 13 2019, 12:01 PM · efl
segfaultxavi added a comment to D10615: introduce efl_canvas_object_animation.

I think API-wise I have no more comments for this patch (pending the end of the discussion).

Nov 13 2019, 9:33 AM · efl
bu5hm4n updated the diff for D10615: introduce efl_canvas_object_animation.

asdfasdf

Nov 13 2019, 9:08 AM · efl
bu5hm4n updated the diff for D10615: introduce efl_canvas_object_animation.

its efl canvas now.

Nov 13 2019, 8:31 AM · efl
bu5hm4n updated the diff for D10615: introduce efl_canvas_object_animation.

renames

Nov 13 2019, 7:20 AM · efl
segfaultxavi added a comment to D10615: introduce efl_canvas_object_animation.

Thanks for this analysis of the situation. @bu5hm4n and I have been talking about it and we agree on almost everything, but we'd like to make some clarifications:

Nov 13 2019, 6:14 AM · efl
bu5hm4n edited parent revisions for D10615: introduce efl_canvas_object_animation, added: 1; removed: 1.
Nov 13 2019, 5:00 AM · efl

Nov 12 2019

Jaehyun_Cho added a comment to D10615: introduce efl_canvas_object_animation.

I share the collected opinions about refactoring of Canvas Animation as follows.

Nov 12 2019, 11:10 PM · efl

Nov 11 2019

segfaultxavi updated subscribers of D10615: introduce efl_canvas_object_animation.

I propose an unification of all animation flags in D10645 which should clarify things.
If you make this patch depend on D10645 (and rebase) you should be able to rename animation_object to just animation. How does that sound, @bu5hm4n @Jaehyun_Cho @zmike @cedric?

Nov 11 2019, 8:36 AM · efl
bu5hm4n added inline comments to D10615: introduce efl_canvas_object_animation.
Nov 11 2019, 3:45 AM · efl
segfaultxavi added inline comments to D10615: introduce efl_canvas_object_animation.
Nov 11 2019, 2:58 AM · efl
Jaehyun_Cho added a comment to D10615: introduce efl_canvas_object_animation.

I am afraid I need some more time (1 or 2 days) to give you opinion about this animation refactorying work.

Nov 11 2019, 2:31 AM · efl
bu5hm4n planned changes to D10615: introduce efl_canvas_object_animation.
Nov 11 2019, 1:54 AM · efl
segfaultxavi added inline comments to D10615: introduce efl_canvas_object_animation.
Nov 11 2019, 1:25 AM · efl

Nov 10 2019

bu5hm4n added a child revision for D10615: introduce efl_canvas_object_animation: D10636: elementary: move away from normal player to the new animation mixin.
Nov 10 2019, 2:14 PM · efl
bu5hm4n updated the diff for D10615: introduce efl_canvas_object_animation.

more tests, and a simple fix

Nov 10 2019, 2:14 PM · efl
bu5hm4n updated the diff for D10615: introduce efl_canvas_object_animation.

fix animation. position is now returned *always* from 0.0 to 1.0

Nov 10 2019, 3:51 AM · efl

Nov 7 2019

lauromoura added a comment to D9717: csharp: Revamp dotnet support.

@lauromoura
Is there any reason not to use csc directly?
csc has been available since mono 5.0.0 ( https://www.mono-project.com/docs/about-mono/releases/5.0.0/#c-compiler )

Nov 7 2019, 12:30 PM · DO NOT MERGE, efl
segfaultxavi added inline comments to D10615: introduce efl_canvas_object_animation.
Nov 7 2019, 9:39 AM · efl
bu5hm4n updated the diff for D10615: introduce efl_canvas_object_animation.

add a example

Nov 7 2019, 5:52 AM · efl
bu5hm4n updated the diff for D10615: introduce efl_canvas_object_animation.
Nov 7 2019, 4:58 AM · efl
bu5hm4n added a project to D10615: introduce efl_canvas_object_animation: DO NOT MERGE.
Nov 7 2019, 2:31 AM · efl
YOhoho added a comment to D9717: csharp: Revamp dotnet support.

@lauromoura
Is there any reason not to use csc directly?
csc has been available since mono 5.0.0 ( https://www.mono-project.com/docs/about-mono/releases/5.0.0/#c-compiler )

Nov 7 2019, 2:21 AM · DO NOT MERGE, efl

Nov 6 2019

lauromoura closed D9717: csharp: Revamp dotnet support.
Nov 6 2019, 6:42 AM · DO NOT MERGE, efl

Oct 29 2019

lauromoura updated the diff for D9717: csharp: Revamp dotnet support.

I put the wrong assembly name for mono...

Oct 29 2019, 2:07 PM · DO NOT MERGE, efl
lauromoura updated the diff for D9717: csharp: Revamp dotnet support.

Rebase and update after D10337 added friendly assemblies

Oct 29 2019, 1:53 PM · DO NOT MERGE, efl

Oct 28 2019

zmike added a project to D10105: test: add a new testcase for paging of scroller: DO NOT MERGE.

Disregard comments re: mainloop iterate as these tests do require a rendered frame.

Oct 28 2019, 6:03 AM · DO NOT MERGE, efl

Oct 25 2019

zmike updated the diff for D10528: tests/genlist: add behavior testing for nearly all genlist events.

tweak item move test coords to pass on CI

Oct 25 2019, 12:34 PM · efl
felipealmeida added a comment to D10432: eolian: Add user keywords to methods and classes for bindings.

IMO, using tags for error is not the best way. A typedef is much better. However, this tag is important for things that are, possibly, platform-specific. So you can tag that a method is not going to be generated for Tizen, for example.

Oct 25 2019, 11:16 AM · DO NOT MERGE, efl
zmike added a project to D10528: tests/genlist: add behavior testing for nearly all genlist events: DO NOT MERGE.

This is breaking travis somehow, still working on getting it to be consistent enough to land...

Oct 25 2019, 11:09 AM · efl
segfaultxavi added a comment to D10432: eolian: Add user keywords to methods and classes for bindings.

Hrmm.... then we are in the same situation. There's tags meant for eolian and there's tags meant for the bindings generator, but the guy creating a new EO file does not care about that distinction and will be utterly confused, unless he created the tag.
I mean, if I am creating Eo files and I need a custom tag, then I'm fine, no confusion.
But for the case we were trying to solve (reporting when a bool is indicating an error), I will need to remember that this tag is written differently than all other eolian tags.

Oct 25 2019, 1:27 AM · DO NOT MERGE, efl

Oct 24 2019

lauromoura added a comment to D10432: eolian: Add user keywords to methods and classes for bindings.
  1. Use @ in both cases, so user keywords cannot use names already in use by eolian. Downside: if we add more eolian tags in the future, we might break already-existing EO files some people might have created with user keywords.

    ....

    I like option 1 better. It means that any @tag eolian does not recognize is just stored as a user keyword. This also means that mispellings like @proprety won't be detected.
Oct 24 2019, 1:19 PM · DO NOT MERGE, efl
segfaultxavi added a comment to D10432: eolian: Add user keywords to methods and classes for bindings.

I am not sure I like the #tag syntax. From the user's perspective, some tags will need @ and some others #, for no apparent reason.

Oct 24 2019, 8:36 AM · DO NOT MERGE, efl

Oct 19 2019

felipealmeida updated the diff for D10432: eolian: Add user keywords to methods and classes for bindings.

Use eina_hash_population as reviewed by YOhoho.

Oct 19 2019, 6:33 AM · DO NOT MERGE, efl
felipealmeida updated the diff for D10432: eolian: Add user keywords to methods and classes for bindings.

Added property and class support

Oct 19 2019, 6:26 AM · DO NOT MERGE, efl

Oct 16 2019

lauromoura added a child revision for D9717: csharp: Revamp dotnet support: D10433: csharp: Add StyleCop support to dotnet build.
Oct 16 2019, 8:18 PM · DO NOT MERGE, efl
lauromoura added inline comments to D10432: eolian: Add user keywords to methods and classes for bindings.
Oct 16 2019, 7:45 PM · DO NOT MERGE, efl
YOhoho added a comment to D10432: eolian: Add user keywords to methods and classes for bindings.

You can use eina_hash_population to get the number of hash elements.

Oct 16 2019, 7:13 PM · DO NOT MERGE, efl
felipealmeida added reviewers for D10432: eolian: Add user keywords to methods and classes for bindings: lauromoura, woohyun, segfaultxavi, q66.

This is a partial implementation, but shows how to use on the test. It is still specific to methods only on this diff. But I'll expand to other entities.

Oct 16 2019, 5:21 PM · DO NOT MERGE, efl

Oct 14 2019

lauromoura added a project to D10367: csharp: Do not generate wrapper for setter returning values.: DO NOT MERGE.
Oct 14 2019, 2:43 PM · DO NOT MERGE, efl

Oct 3 2019

lauromoura updated the diff for D9717: csharp: Revamp dotnet support.

Update with support for dotnet core 3.0

Oct 3 2019, 4:08 AM · DO NOT MERGE, efl

Oct 2 2019

lauromoura updated the diff for D9717: csharp: Revamp dotnet support.

Also added a declaration of Efl.ObjectRealized using Efl.Object.NativeMethods as its NativeClass attribute. The hidden class test was failing in dotnet without it, as the class map when marshalling from C was not finding it.

Oct 2 2019, 8:43 PM · DO NOT MERGE, efl
lauromoura planned changes to D9717: csharp: Revamp dotnet support.

Needs rebase after the release.

Oct 2 2019, 3:02 PM · DO NOT MERGE, efl