Page MenuHomePhabricator
Feed Advanced Search

Fri, Apr 12

segfaultxavi added a comment to D8433: efl.pack_linear: Clarify behavior and docs.

Fixed!

Fri, Apr 12, 12:04 AM · efl
segfaultxavi updated the diff for D8433: efl.pack_linear: Clarify behavior and docs.

Fix copy&paste error.

Fri, Apr 12, 12:03 AM · efl

Thu, Apr 11

YOhoho added inline comments to D8433: efl.pack_linear: Clarify behavior and docs.
Thu, Apr 11, 11:41 PM · efl
segfaultxavi added inline comments to D8433: efl.pack_linear: Clarify behavior and docs.
Thu, Apr 11, 11:08 PM · efl
YOhoho requested changes to D8433: efl.pack_linear: Clarify behavior and docs.

It's wrong copy/paste.

Thu, Apr 11, 10:50 PM · efl
YOhoho updated the diff for D8280: ui.widget: remove elm_widget_sub_object_parent_add from each of widgets.

rebase

Thu, Apr 11, 10:38 PM · efl

Sun, Apr 7

SanghyeonLee added a comment to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.

is this patch ready to go?
please comment more detail about this patch in commit-message,
and rebase on latest master.

Sun, Apr 7, 10:28 PM · DO NOT MERGE, efl

Fri, Apr 5

vitor.sousa closed D8431: efl-csharp: fix resource deallocation causing errors everywhere.
Fri, Apr 5, 3:58 PM · DO NOT MERGE, efl: language bindings
vitor.sousa added a child revision for D8431: efl-csharp: fix resource deallocation causing errors everywhere: D8564: efl-csharp: fix crash when events trigger after C# object `Dispose`.
Fri, Apr 5, 3:41 PM · DO NOT MERGE, efl: language bindings
lauromoura accepted D8431: efl-csharp: fix resource deallocation causing errors everywhere.
Fri, Apr 5, 3:39 PM · DO NOT MERGE, efl: language bindings
vitor.sousa updated the diff for D8431: efl-csharp: fix resource deallocation causing errors everywhere.

fix previous update submitting to much code

Fri, Apr 5, 3:37 PM · DO NOT MERGE, efl: language bindings
vitor.sousa added a parent revision for D8431: efl-csharp: fix resource deallocation causing errors everywhere: D8550: csharp: Make classes abstract and rework casting.
Fri, Apr 5, 3:30 PM · DO NOT MERGE, efl: language bindings
vitor.sousa updated the diff for D8431: efl-csharp: fix resource deallocation causing errors everywhere.

rebase and adds D8550 as a dependency

Fri, Apr 5, 3:29 PM · DO NOT MERGE, efl: language bindings

Wed, Apr 3

bu5hm4n accepted D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

Cool, thx!

Wed, Apr 3, 4:53 AM · efl
segfaultxavi accepted D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

All test suites (including the new behavioral one) pass now!

Wed, Apr 3, 3:58 AM · efl
YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

Thank you to point out that.

Wed, Apr 3, 3:48 AM · efl
bu5hm4n accepted D8433: efl.pack_linear: Clarify behavior and docs.
Wed, Apr 3, 2:57 AM · efl
segfaultxavi requested changes to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Wed, Apr 3, 2:54 AM · efl
bu5hm4n added a child revision for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box: D8520: efl_ui_widget: we should ensure that every subobject is a gfx entity.
Wed, Apr 3, 2:39 AM · efl
segfaultxavi updated the diff for D8433: efl.pack_linear: Clarify behavior and docs.

Clarify docs for unpack_at()

Wed, Apr 3, 2:09 AM · efl
segfaultxavi added a project to D8433: efl.pack_linear: Clarify behavior and docs: DO NOT MERGE.
Wed, Apr 3, 2:04 AM · efl

Tue, Apr 2

bu5hm4n requested changes to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Tue, Apr 2, 8:46 AM · efl
bu5hm4n removed a child revision for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box: D8519: efl_check: add API to expect a error.
Tue, Apr 2, 8:24 AM · efl
segfaultxavi resigned from D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

OK, I am happy with the docs now, thanks!
However, I will not comment on the code, since I am no expert in this area.

Tue, Apr 2, 1:55 AM · efl

Mon, Apr 1

YOhoho updated the diff for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.

I forgot git add

Mon, Apr 1, 8:31 PM · efl
bu5hm4n added a child revision for D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box: D8519: efl_check: add API to expect a error.
Mon, Apr 1, 6:02 AM · efl
segfaultxavi requested changes to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
Mon, Apr 1, 4:55 AM · efl

Thu, Mar 28

YOhoho added a comment to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box.
In D8417#153395, @zmike wrote:

I am thinking that maybe we land this patch after the 1.22 release?

Thu, Mar 28, 3:48 AM · efl
bu5hm4n added a project to D8417: ui.box: remove leagcy evas_box from Efl.Ui.Box: DO NOT MERGE.
Thu, Mar 28, 1:51 AM · efl

Wed, Mar 27

Jaehyun_Cho added a comment to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic..

This patch is going to be submitted after 1.22 release.

Wed, Mar 27, 1:15 AM · DO NOT MERGE, efl
Jaehyun_Cho added a project to D7579: Gesture Manager: Add gestures and fix gesture managing, recognizer logic.: DO NOT MERGE.
Wed, Mar 27, 1:15 AM · DO NOT MERGE, efl

Mar 25 2019

Jaehyun_Cho added a project to D8442: efl_ui_selectable: separate efl_ui_selectable into item and text: DO NOT MERGE.
Mar 25 2019, 4:58 AM · DO NOT MERGE, Restricted Project

Mar 22 2019

lauromoura added a comment to D8431: efl-csharp: fix resource deallocation causing errors everywhere.

I built and installed this patch (after rebasing to latest master).
All C# tutorials seems to segfault on exit. For example, the hello-world one, which only instantiates a window (console output: P279)

Source of the hello-word tutorial:
https://git.enlightenment.org/tools/examples.git/tree/tutorial/csharp/hello-world/src/hello-world.cs

Mar 22 2019, 2:18 PM · DO NOT MERGE, efl: language bindings
devilhorns closed D8117: wl-drm: Refactor _drm2_randr_apply function.
Mar 22 2019, 10:01 AM · enlightenment-git, DO NOT MERGE, efl
devilhorns closed D8114: ecore-drm2: Add API function to return output rotation.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8116: ecore-evas-drm: Enable rotation to work again.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8115: ecore-drm2: Factor in output rotation when getting output info.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8113: ecore-drm2: Set output rotation value.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8112: ecore-drm2: Disable hardware rotation for outputs.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8111: ecore-drm2: Update plane state values based on FB.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
devilhorns closed D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.
Mar 22 2019, 9:42 AM · DO NOT MERGE, efl
bu5hm4n added a project to D8280: ui.widget: remove elm_widget_sub_object_parent_add from each of widgets: DO NOT MERGE.
Mar 22 2019, 8:45 AM · efl

Mar 21 2019

segfaultxavi requested changes to D8431: efl-csharp: fix resource deallocation causing errors everywhere.

I built and installed this patch (after rebasing to latest master).
All C# tutorials seems to segfault on exit. For example, the hello-world one, which only instantiates a window (console output: P279)

Mar 21 2019, 5:27 AM · DO NOT MERGE, efl: language bindings

Mar 20 2019

vitor.sousa added a comment to D8431: efl-csharp: fix resource deallocation causing errors everywhere.

@cedric I solved the concurrency problem using ecore_main_loop_thread_safe_call_async.
Eo error logs disappeared, but now the test prints a big list like this at the end of execution:

EINA ERROR: 'Invalid argument' on unlock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on lock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on unlock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on lock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on unlock 0x7fc693ffe980
EINA ERROR: 'Invalid argument' on lock 0x7fc693ffe980

Could you give it a look and check whether I am using it incorrectly or it is a problem with eina_thread?

Mar 20 2019, 12:38 PM · DO NOT MERGE, efl: language bindings
vitor.sousa edited projects for D8431: efl-csharp: fix resource deallocation causing errors everywhere, added: efl: language bindings, DO NOT MERGE; removed efl.
Mar 20 2019, 12:29 PM · DO NOT MERGE, efl: language bindings
devilhorns added a comment to D8114: ecore-drm2: Add API function to return output rotation.

@stefan_schmidt Do you think we can add this small API before release ?? I sent an email to the dev ml about it, but no responses from Anyone yet :(

Mar 20 2019, 10:34 AM · DO NOT MERGE, efl
bu5hm4n added a comment to D8425: eolian: enable event redef checking by default.
Mar 20 2019, 7:17 AM · efl
bu5hm4n added a project to D8425: eolian: enable event redef checking by default: DO NOT MERGE.
Mar 20 2019, 7:17 AM · efl

Mar 19 2019

devilhorns added a child revision for D8116: ecore-evas-drm: Enable rotation to work again: D8402: evas drm: Don't use eng_output_resize or redraws clear.
Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8116: ecore-evas-drm: Enable rotation to work again.

no changes

Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8115: ecore-drm2: Factor in output rotation when getting output info.

no changes

Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8114: ecore-drm2: Add API function to return output rotation.

no changes

Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8113: ecore-drm2: Set output rotation value.

no changes

Mar 19 2019, 7:23 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8112: ecore-drm2: Disable hardware rotation for outputs.

no changes

Mar 19 2019, 7:22 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8111: ecore-drm2: Update plane state values based on FB.

no changes

Mar 19 2019, 7:22 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.

no changes

Mar 19 2019, 7:22 AM · DO NOT MERGE, efl

Mar 15 2019

segfaultxavi abandoned D7618: efl-api: Mark Efl.Io.Closer as stable.

Fixed somewhere else.

Mar 15 2019, 6:15 AM · DO NOT MERGE, efl
segfaultxavi abandoned D7619: efl-api: Mark Efl.Io.Writer as stable.

Fixed somewhere else.

Mar 15 2019, 6:15 AM · DO NOT MERGE, efl
segfaultxavi abandoned D7620: efl-api: Mark Efl.Io.Reader as stable.

Fixed somewhere else.

Mar 15 2019, 6:14 AM · DO NOT MERGE, efl

Mar 14 2019

devilhorns updated the diff for D8116: ecore-evas-drm: Enable rotation to work again.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8115: ecore-drm2: Factor in output rotation when getting output info.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8114: ecore-drm2: Add API function to return output rotation.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8113: ecore-drm2: Set output rotation value.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8112: ecore-drm2: Disable hardware rotation for outputs.

Update patch based on review comments

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8111: ecore-drm2: Update plane state values based on FB.

no changes

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.

Update patch based on review comments

Mar 14 2019, 9:57 AM · DO NOT MERGE, efl
zmike added inline comments to D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.
Mar 14 2019, 9:45 AM · DO NOT MERGE, efl
devilhorns added inline comments to D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.
Mar 14 2019, 9:13 AM · DO NOT MERGE, efl
zmike added inline comments to D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.
Mar 14 2019, 8:14 AM · DO NOT MERGE, efl

Mar 13 2019

devilhorns updated the diff for D8117: wl-drm: Refactor _drm2_randr_apply function.

Fixed issue of e_drm2.x not properly linking for 1.22.0 added functions

Mar 13 2019, 7:35 AM · enlightenment-git, DO NOT MERGE, efl

Mar 12 2019

devilhorns updated the diff for D8117: wl-drm: Refactor _drm2_randr_apply function.

Fix comilation failures

Mar 12 2019, 7:55 AM · enlightenment-git, DO NOT MERGE, efl
devilhorns updated the diff for D8117: wl-drm: Refactor _drm2_randr_apply function.

Updated commit based on review comments. Now uses a proper dlsym to

Mar 12 2019, 6:36 AM · enlightenment-git, DO NOT MERGE, efl
devilhorns updated the diff for D8116: ecore-evas-drm: Enable rotation to work again.

No Changes

Mar 12 2019, 6:21 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8115: ecore-drm2: Factor in output rotation when getting output info.

No Changes

Mar 12 2019, 6:21 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8114: ecore-drm2: Add API function to return output rotation.

No Changes

Mar 12 2019, 6:21 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8113: ecore-drm2: Set output rotation value.

No changes

Mar 12 2019, 6:20 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8112: ecore-drm2: Disable hardware rotation for outputs.

Use #if 0 to comment out code block and add a comment about how/why

Mar 12 2019, 6:20 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8111: ecore-drm2: Update plane state values based on FB.

No changes

Mar 12 2019, 6:20 AM · DO NOT MERGE, efl
devilhorns updated the diff for D8110: ecore-drm2: Don't use AtomicAddProperty for plane rotation.

Use #if 0 to comment out code block and add a comment about how/why

Mar 12 2019, 6:20 AM · DO NOT MERGE, efl

Mar 10 2019

SanghyeonLee added a comment to D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM.

this is not a final version, only buildable one. need to figure it out which one we need and not in both of grid view and list view

Mar 10 2019, 10:54 PM · DO NOT MERGE, efl
SanghyeonLee added a project to D8285: efl_ui : introduce new abstract class efl.ui.item_view and sub-infrastructures for MVVM: DO NOT MERGE.
Mar 10 2019, 10:53 PM · DO NOT MERGE, efl

Mar 8 2019

zmike updated the diff for D8244: headers: ensure Efl.h is always included behind BETA define guards.

rebase and fix warnings

Mar 8 2019, 5:14 AM · efl: api

Mar 7 2019

zmike updated the diff for D8244: headers: ensure Efl.h is always included behind BETA define guards.

rebase

Mar 7 2019, 3:44 PM · efl: api
zmike updated the diff for D8241: eo files: mark a bunch of types with @beta.

rebase

Mar 7 2019, 3:44 PM · efl: api
zmike updated the diff for D8241: eo files: mark a bunch of types with @beta.

rebase

Mar 7 2019, 3:42 PM · efl: api
zmike added a project to D8244: headers: ensure Efl.h is always included behind BETA define guards: DO NOT MERGE.
Mar 7 2019, 3:17 PM · efl: api
zmike added a child revision for D8241: eo files: mark a bunch of types with @beta: D8243: Revert "Emile: Move colorspaces to Efl.Gfx".
Mar 7 2019, 2:43 PM · efl: api
zmike added a project to D8241: eo files: mark a bunch of types with @beta: DO NOT MERGE.

This can't be landed. It's impossible to compile efl or anything that uses efl because so many legacy types have been #defined to eo types which are no longer available if the eo type becomes beta.

Mar 7 2019, 2:00 PM · efl: api

Mar 6 2019

felipealmeida abandoned D7857: eo: Fix efl_isa for class checking of recursively inherited types.
Mar 6 2019, 12:42 PM · DO NOT MERGE, efl
devilhorns added a comment to D8114: ecore-drm2: Add API function to return output rotation.

Well, these patches are not the "full fix" at the moment anyway. They only fix rotation when using gl_drm engine. Software rotation (using evas drm engine) is still broken and am still looking into it. If you want to land the rest of them to fix gl_drm rotation, then that's fine with me (assuming we can get the API added)

Mar 6 2019, 12:35 PM · DO NOT MERGE, efl
devilhorns added a comment to D8114: ecore-drm2: Add API function to return output rotation.

Well, the patch that was landed is Part of a fix. I am unsure what effects that patch by itself would have on fixing the whole issue....I did mark them as DO NOT MERGE ;) (at least until we can find out if we are still in freeze or not)

Mar 6 2019, 12:33 PM · DO NOT MERGE, efl
cedric added a comment to D8114: ecore-drm2: Add API function to return output rotation.

Well, if we are in a freeze, then https://phab.enlightenment.org/rEFLf5fed8764df832fed9b7bb2c2a872223a983a00b will have to be reverted. By itself, the code from that one is not going to fix the rotation problem. It needs all of these commits to fix it (for gl engine anyway).

Mar 6 2019, 12:29 PM · DO NOT MERGE, efl
devilhorns added a comment to D8114: ecore-drm2: Add API function to return output rotation.

Well, if we are in a freeze, then https://phab.enlightenment.org/rEFLf5fed8764df832fed9b7bb2c2a872223a983a00b will have to be reverted. By itself, the code from that one is not going to fix the rotation problem. It needs all of these commits to fix it (for gl engine anyway).

Mar 6 2019, 12:20 PM · DO NOT MERGE, efl
cedric added a comment to D8114: ecore-drm2: Add API function to return output rotation.

I thought we were in a freeze already which is why I did not land it ... but if we are Not in a freeze currently, then Yes it would be great to have in this release because it is needed in order to fix the rotation issues (T7690)

Mar 6 2019, 12:05 PM · DO NOT MERGE, efl
cedric closed D8109: evas-gl-drm: Fix issue of rotation not actually rotating.
Mar 6 2019, 11:44 AM · DO NOT MERGE, efl
devilhorns added a comment to D8114: ecore-drm2: Add API function to return output rotation.

I thought we were in a freeze already which is why I did not land it ... but if we are Not in a freeze currently, then Yes it would be great to have in this release because it is needed in order to fix the rotation issues (T7690)

Mar 6 2019, 11:11 AM · DO NOT MERGE, efl
cedric accepted D8115: ecore-drm2: Factor in output rotation when getting output info.
Mar 6 2019, 10:56 AM · DO NOT MERGE, efl
cedric added reviewers for D8114: ecore-drm2: Add API function to return output rotation: zmike, stefan_schmidt, bu5hm4n.

Do we need to land this soon to fix a bug in E, or should it wait for next EFL release?

Mar 6 2019, 10:55 AM · DO NOT MERGE, efl
cedric accepted D8114: ecore-drm2: Add API function to return output rotation.
Mar 6 2019, 10:54 AM · DO NOT MERGE, efl
cedric accepted D8113: ecore-drm2: Set output rotation value.
Mar 6 2019, 10:52 AM · DO NOT MERGE, efl