Page MenuHomePhabricator
Feed Advanced Search

Today

bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

This revision actaully fixes that and makes it shutting down in a few seconds.

Wed, Mar 20, 8:38 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a revision to T7755: infinite loop in focus manager on destroy: D8367: elm_gengrid: speed up update order calls.
Wed, Mar 20, 8:38 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

Are you sure its a infinite loop, or just terribly slow? It takes here ~ 3 min. until the window is closed. It is faster with my recent gengrid patches ... :)

Wed, Mar 20, 8:28 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

Maaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaan :(

Wed, Mar 20, 8:24 AM · Restricted Project, efl (efl-1.22)
zmike added a comment to T7755: infinite loop in focus manager on destroy.

Probably all the gengrid tests

Wed, Mar 20, 8:19 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

This is usally a indicator that the widget tree builds a cycle in the shutdown. I can open here a lot of windows and nothing happens, it might be depending on what kind of widgets are there. Do you remember which windows you opened ?

Wed, Mar 20, 8:13 AM · Restricted Project, efl (efl-1.22)
segfaultxavi added a comment to T7760: Document event info calling convention.

I clarified a bit what this task is about. I am not sure where these docs would fit, though.
The user-facing part (retrieving event info from an event struct) probably goes here:
https://www.enlightenment.org/develop/guides/c/core/events.md
But I don't know about the internal part (calling efl_event_callback_call). Maybe in the docs for efl_event_callback_call in Eo.h?
How many methods exist which accept an event_info?

Wed, Mar 20, 5:21 AM · Restricted Project, efl (efl-1.22), efl: api
segfaultxavi renamed T7760: Document event info calling convention from Document our new calling convention to Document event info calling convention.
Wed, Mar 20, 5:17 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a comment to T7758: Resolving all problem event calls in efl.

No problem at all :)

Wed, Mar 20, 12:41 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8418: efl_ui_tab_bar: the type of this event is annotated as object.
Wed, Mar 20, 12:40 AM · Restricted Project, efl (efl-1.22), efl: api
YOhoho added a comment to T7758: Resolving all problem event calls in efl.

Oh, sorry. my bad. i didn't install latest EFL. ignore my comment above :(

Wed, Mar 20, 12:21 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a comment to T7758: Resolving all problem event calls in efl.

Why is ev->info invalid? Your funcrion here is called while the event caller is still in scope, hence this pointer is fully valid ...

Wed, Mar 20, 12:09 AM · Restricted Project, efl (efl-1.22), efl: api
YOhoho added a comment to T7758: Resolving all problem event calls in efl.

simple usecase:

Wed, Mar 20, 12:07 AM · Restricted Project, efl (efl-1.22), efl: api

Yesterday

bu5hm4n added a comment to T7758: Resolving all problem event calls in efl.

? They are never accessed outside the function scope ...

Tue, Mar 19, 11:32 PM · Restricted Project, efl (efl-1.22), efl: api
YOhoho added a comment to T7758: Resolving all problem event calls in efl.

Do not use local variable address as event_info. you can't access that outside the function.

Tue, Mar 19, 11:06 PM · Restricted Project, efl (efl-1.22), efl: api
zmike added a commit to T7758: Resolving all problem event calls in efl: rEFL049c65e7ac12: efl_io_*: apply new event calling convention.
Tue, Mar 19, 1:32 PM · Restricted Project, efl (efl-1.22), efl: api
zmike added a commit to T7758: Resolving all problem event calls in efl: rEFL6dec272d31ca: efl_ui_focus_object: apply new event calling convention.
Tue, Mar 19, 1:32 PM · Restricted Project, efl (efl-1.22), efl: api
zmike added a commit to T7758: Resolving all problem event calls in efl: rEFL60384a4d4017: evas: apply new event calling convention.
Tue, Mar 19, 1:32 PM · Restricted Project, efl (efl-1.22), efl: api
zmike added a commit to T7758: Resolving all problem event calls in efl: rEFLf5fb68e1cdba: efl_ui_win: apply new event calling convention.
Tue, Mar 19, 1:32 PM · Restricted Project, efl (efl-1.22), efl: api
zmike added a commit to T7758: Resolving all problem event calls in efl: rEFLe4e14f50db46: efl_ui_focus_manager_sub: apply new event calling convention.
Tue, Mar 19, 1:32 PM · Restricted Project, efl (efl-1.22), efl: api
zmike added a commit to T7713: some elementary_test cases no longer run: rEFL4949a8f3a72d: elm_code: add theme alias for layout group.
Tue, Mar 19, 11:20 AM · efl (efl-1.22), efl: widgets
bu5hm4n added a comment to T7758: Resolving all problem event calls in efl.

After those patches: P277

Tue, Mar 19, 8:37 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8410: efl_io_*: apply new event calling convention.
Tue, Mar 19, 8:26 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8409: efl_ui_focus_object: apply new event calling convention.
Tue, Mar 19, 8:25 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8408: evas: apply new event calling convention.
Tue, Mar 19, 8:25 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8406: efl_ui_win: apply new event calling convention.
Tue, Mar 19, 8:25 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8405: efl_ui_focus_manager_sub: apply new event calling convention.
Tue, Mar 19, 8:25 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n renamed T7760: Document event info calling convention from Document our new callign convention to Document our new calling convention.
Tue, Mar 19, 8:21 AM · Restricted Project, efl (efl-1.22), efl: api
segfaultxavi added a commit to T7752: C#: Get rid of all lower-cased methods: rEFLd10ee74b9773: csharp: rename add/remove event handler.
Tue, Mar 19, 8:10 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
segfaultxavi added a comment to T7757: C#: Remove static_cast method.

Using the language mechanisms for casting (obj as Efl.Ui.Button) sounds better than having a custom method, from an API point of view. I do not know how hard that is, though.

Tue, Mar 19, 7:49 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
bu5hm4n triaged T7760: Document event info calling convention as Showstopper Issues priority.
Tue, Mar 19, 7:22 AM · Restricted Project, efl (efl-1.22), efl: api
zmike added a revision to T7713: some elementary_test cases no longer run: D8401: efl_ui_win: avoid triggering legacy forbidden path during window finalize.
Tue, Mar 19, 7:13 AM · efl (efl-1.22), efl: widgets
bu5hm4n triaged T7759: Apply Calling convention rules checking to eolian as Showstopper Issues priority.
Tue, Mar 19, 6:26 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n edited parent tasks for T7758: Resolving all problem event calls in efl, added: T7738: Calling convention for events in eolian; removed: T7725: master ticket for 1.22 api stabilization.
Tue, Mar 19, 6:26 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n removed a subtask for T7725: master ticket for 1.22 api stabilization: T7758: Resolving all problem event calls in efl.
Tue, Mar 19, 6:26 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a subtask for T7738: Calling convention for events in eolian: T7758: Resolving all problem event calls in efl.
Tue, Mar 19, 6:26 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n triaged T7758: Resolving all problem event calls in efl as High priority.
Tue, Mar 19, 6:24 AM · Restricted Project, efl (efl-1.22), efl: api

Mon, Mar 18

Herald removed a project from T7499: solve compiler (gcc) warnings between __attribute__ ((__malloc__)) and __attribute__ ((__pure__)): Restricted Project.
Mon, Mar 18, 6:22 PM · efl (efl-1.22)
lauromoura moved T7752: C#: Get rid of all lower-cased methods from Backlog to InProgress on the efl: language bindings board.
Mon, Mar 18, 3:42 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura added a revision to T7751: C#: Add back the I prefix to interfaces: Restricted Differential Revision.
Mon, Mar 18, 3:41 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura added a revision to T7751: C#: Add back the I prefix to interfaces: D8397: efl-csharp: Add back I prefix for interfaces..
Mon, Mar 18, 3:40 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura added a revision to T7752: C#: Get rid of all lower-cased methods: D8396: csharp: rename add/remove event handler.
Mon, Mar 18, 3:38 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura triaged T7757: C#: Remove static_cast method as High priority.
Mon, Mar 18, 2:37 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura added a comment to T7751: C#: Add back the I prefix to interfaces.

In order to integrate better with the C# ecosystem, we have do adapt. This should not be a big change in current C# code, as we moved on from that old all-interface API scheme.

Mon, Mar 18, 1:53 PM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
q66 added a comment to T7738: Calling convention for events in eolian.

That works too

Mon, Mar 18, 1:45 PM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a comment to T7738: Calling convention for events in eolian.

Don't get me wrong, but this needs to be decided / done for this release, we cannot wait for new syntax, lets just go now with the syntax that is everywhere, and change it afterwards.

Mon, Mar 18, 1:25 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

I intend to do away with const() as well as ptr() in the current form entirely, so having a new syntax is the better choice for it, besides, immutable by default is a better choice than mutable by default

Mon, Mar 18, 1:15 PM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a comment to T7738: Calling convention for events in eolian.

Maybe we should just be able to have klass-types const'able... I would not create another new syntax for it tbh.

Mon, Mar 18, 12:59 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Or maybe, make them const by default and some kind of event tag to make it mutable where needed?

Mon, Mar 18, 12:13 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Understood. Do we need a way to make objects const when possible?

Mon, Mar 18, 12:13 PM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a comment to T7738: Calling convention for events in eolian.

We need to have objects mutable as this is used in our API, see Efl.Input.Hold / Efl.Input.Event. Properties like processed are required to be set.

Mon, Mar 18, 12:10 PM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

That sounds good to me. So basically the only types allowed are value types, objects and container types, minus list/iterator; everything is annotated without any qualifier, and everything is immutable and passed by reference, except objects. Maybe we should pass objects by const too? So that only @const methods can be called on it. That would make all event data completely immutable.

Mon, Mar 18, 12:02 PM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a comment to T7738: Calling convention for events in eolian.

When something gets *passed* the type of the input and output is always the same. (where input is a call to efl_event_callback_call, output is the API user that subscribed to a event)
Objects are passed as a normal Eo*, this means event subscribers can call functions on that object.
Iterators & lists should not be allowed as event types.
Structs / buildin-types / containers are *always* passed as const pointer, with exactly ONE level of indirection. The types of hashes and accessors *must* be annotated as const.

Mon, Mar 18, 11:50 AM · Restricted Project, efl (efl-1.22), efl: api
zmike updated subscribers of T7713: some elementary_test cases no longer run.
Mon, Mar 18, 11:44 AM · efl (efl-1.22), efl: widgets
zmike triaged T7756: 'part background' in elementary_test spews lots of errors and doesn't display correctly as High priority.
Mon, Mar 18, 11:42 AM · efl (efl-1.22), efl: widgets
q66 added a comment to T7738: Calling convention for events in eolian.

I'd say that allowing less is always a good thing, as it allows for fewer errors/mistakes, so if we can do away with it, let's do it

Mon, Mar 18, 11:39 AM · Restricted Project, efl (efl-1.22), efl: api
zmike added a comment to T7753: efl.ui.panel example in elementary_test hangs infinitely.

Same with Efl.Ui.Popup.Anchor.

Mon, Mar 18, 11:37 AM · efl (efl-1.22), efl: widgets
segfaultxavi added a comment to T7751: C#: Add back the I prefix to interfaces.

What? Are we going to change the API now?

Mon, Mar 18, 11:35 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
zmike triaged T7755: infinite loop in focus manager on destroy as High priority.
Mon, Mar 18, 11:34 AM · Restricted Project, efl (efl-1.22)
zmike triaged T7754: efl.ui.tags in elm_test triggers CRI error as High priority.
Mon, Mar 18, 11:27 AM · efl (efl-1.22), efl: widgets
zmike triaged T7753: efl.ui.panel example in elementary_test hangs infinitely as High priority.
Mon, Mar 18, 11:22 AM · efl (efl-1.22), efl: widgets
zmike added a revision to T7713: some elementary_test cases no longer run: D8393: elm_code: add theme alias for layout group.
Mon, Mar 18, 11:15 AM · efl (efl-1.22), efl: widgets
lauromoura moved T7751: C#: Add back the I prefix to interfaces from Backlog to InProgress on the efl: language bindings board.
Mon, Mar 18, 11:04 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura claimed T7751: C#: Add back the I prefix to interfaces.
Mon, Mar 18, 11:03 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura triaged T7752: C#: Get rid of all lower-cased methods as High priority.
Mon, Mar 18, 11:02 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
lauromoura triaged T7751: C#: Add back the I prefix to interfaces as High priority.
Mon, Mar 18, 11:01 AM · Active Work Proposal, Restricted Project, efl: language bindings, efl (efl-1.22)
bu5hm4n added a comment to T7738: Calling convention for events in eolian.

Okay this brings up another questions, are we supposed to allow changing of struct fields in event callbacks ?

Mon, Mar 18, 10:40 AM · Restricted Project, efl (efl-1.22), efl: api
zmike added a revision to T7713: some elementary_test cases no longer run: D8388: elm_test: use legacy api for glview gears test.
Mon, Mar 18, 10:34 AM · efl (efl-1.22), efl: widgets
cedric added a comment to T7738: Calling convention for events in eolian.

Hum, there is a side effect to being passed by values vs references. In one case events can not alter the value as it pass there handler. In the other, they can. Maybe we should have a "const" marker to specify explicitly this intent. I think this also make a stronger case to mark efl_event_callback_call a protected function and generate function that will have the proper type checking in their prototype.

Mon, Mar 18, 9:40 AM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

I don't think we currently specify how things are *meant* to be; we need to come up with something.

Mon, Mar 18, 9:13 AM · Restricted Project, efl (efl-1.22), efl: api
q66 added a comment to T7738: Calling convention for events in eolian.

Any proposals on this?

Mon, Mar 18, 9:13 AM · Restricted Project, efl (efl-1.22), efl: api
zmike raised the priority of T7738: Calling convention for events in eolian from TODO to Showstopper Issues.

This is currently the most urgent ticket for the 1.22 release.

Mon, Mar 18, 8:56 AM · Restricted Project, efl (efl-1.22), efl: api
zmike added a comment to T7311: fileselector unit test errors.

Still broken with that patchset.

Mon, Mar 18, 5:56 AM · Restricted Project, efl (efl-1.22), efl: data types
zmike merged T7666: elm_suite crashes intermittently into T7311: fileselector unit test errors.
Mon, Mar 18, 5:56 AM · Restricted Project, efl (efl-1.22), efl: data types
zmike merged task T7666: elm_suite crashes intermittently into T7311: fileselector unit test errors.
Mon, Mar 18, 5:56 AM · efl (efl-1.22), Restricted Project
zmike closed T7747: E segvs open emixer popup as Resolved.
Mon, Mar 18, 5:53 AM · efl (efl-1.22), enlightenment-git
zmike added a commit to T7747: E segvs open emixer popup: rEFLcced5487c83c: efl_ui_layout: call efl_del instead of efl_unref when text part does not exist.
Mon, Mar 18, 5:53 AM · efl (efl-1.22), enlightenment-git
zmike updated the task description for T7747: E segvs open emixer popup.
Mon, Mar 18, 5:37 AM · efl (efl-1.22), enlightenment-git

Sun, Mar 17

bu5hm4n closed T7224: eina safety check failed, obj == NULL in evas_object_event_callback_del_full in lib/evas/canvas/evas_callbacks.c:539, a subtask of T7030: efl internals pass null objects to functions which should not be passed null, as Resolved.
Sun, Mar 17, 8:38 AM · efl (efl-1.22), efl: data types, Restricted Project
bu5hm4n added a comment to T7666: elm_suite crashes intermittently.

@zmike Still happening ? I cannot reproduce this here. The test freezes from time to time (1/20 runs). But it never crashes ...

Sun, Mar 17, 8:31 AM · efl (efl-1.22), Restricted Project

Sat, Mar 16

bu5hm4n triaged T7747: E segvs open emixer popup as Showstopper Issues priority.
Sat, Mar 16, 9:27 AM · efl (efl-1.22), enlightenment-git

Fri, Mar 15

zmike closed T7745: elementary_config does not work anymore as Resolved.
Fri, Mar 15, 1:34 PM · efl (efl-1.22)
zmike added a commit to T7745: elementary_config does not work anymore: rEFL721f1776db5d: evas_events: prevent double event_freeze in evas_object_freeze_events_set.
Fri, Mar 15, 1:34 PM · efl (efl-1.22)
bu5hm4n added a comment to T7745: elementary_config does not work anymore.

Okay a few breadcrumps: there is a object overlaying everything.
The object is the frame object added by _elm_win_frame_add. I don't know why it overlaps everything, and i don't know why its not below.

Fri, Mar 15, 8:51 AM · efl (efl-1.22)
bu5hm4n claimed T7745: elementary_config does not work anymore.
Fri, Mar 15, 8:17 AM · efl (efl-1.22)
bu5hm4n added a comment to T7384: elm_test gengrid update speed test locks up.

Sooo - I manaed to bring down the times. However, its still lagging, the scrolling experience its less than perfect. However, on every group_calculate we walk a list of 5K items just by the design of gengrid, and that is slowing things down *a lot*. Not sure what else we can do here ....

Fri, Mar 15, 6:40 AM · efl (efl-1.22), Restricted Project
bu5hm4n added a revision to T7384: elm_test gengrid update speed test locks up: D8367: elm_gengrid: speed up update order calls.
Fri, Mar 15, 6:36 AM · efl (efl-1.22), Restricted Project
bu5hm4n added a revision to T7384: elm_test gengrid update speed test locks up: D8366: elm_gengrid: rework focus registration.
Fri, Mar 15, 6:36 AM · efl (efl-1.22), Restricted Project
segfaultxavi moved T7722: efl-mono: Generate documentation file with meson from InProgress to Done on the efl: language bindings board.
Fri, Mar 15, 6:19 AM · efl: language bindings, Restricted Project, efl (efl-1.22)
bu5hm4n added a comment to T7384: elm_test gengrid update speed test locks up.

I think we have a bigger underlaying issue, *every* item of the 5000 items is realized, is that really intended ?

Fri, Mar 15, 3:30 AM · efl (efl-1.22), Restricted Project
bu5hm4n updated the task description for T7745: elementary_config does not work anymore.
Fri, Mar 15, 3:21 AM · efl (efl-1.22)
bu5hm4n updated the task description for T7745: elementary_config does not work anymore.
Fri, Mar 15, 3:20 AM · efl (efl-1.22)
bu5hm4n updated subscribers of T7745: elementary_config does not work anymore.
Fri, Mar 15, 3:19 AM · efl (efl-1.22)
bu5hm4n added a project to T7745: elementary_config does not work anymore: efl (efl-1.22).
Fri, Mar 15, 3:19 AM · efl (efl-1.22)
raster added a comment to T7360: Evas/Edje animations not in sync .

I'm not going to have time for a few weeks...

Fri, Mar 15, 2:54 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
segfaultxavi closed T7722: efl-mono: Generate documentation file with meson as Resolved by committing rEFL9c99397cda5f: meson: Enable generation of C# docs..
Fri, Mar 15, 2:45 AM · efl: language bindings, Restricted Project, efl (efl-1.22)

Thu, Mar 14

cedric added a comment to T7311: fileselector unit test errors.

Oh, that's interesting. I had an issue on my filesystem yesterday which resulted in a stat failing all the time which would lead to an Efl.Io.Model to always be in error. The patch D8336 is solving the error path and might actually solve also this problem too. Would be interesting to see if that does the case.

Thu, Mar 14, 9:24 AM · Restricted Project, efl (efl-1.22), efl: data types
bu5hm4n added a comment to T7725: master ticket for 1.22 api stabilization.

Adding this to high, so we can make sure this is done before we do releases.

Thu, Mar 14, 7:57 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n raised the priority of T7725: master ticket for 1.22 api stabilization from TODO to High.
Thu, Mar 14, 7:56 AM · Restricted Project, efl (efl-1.22), efl: api
stefan_schmidt added a comment to T7292: Elementary test genlist crash, freeze and other bugs.

@SanghyeonLee some help on this for the upcoming 1.22 release would be appreciated

Thu, Mar 14, 7:52 AM · efl (efl-1.22)