Page MenuHomePhabricator
Feed Advanced Search

Jan 27 2020

segfaultxavi closed T8023: Efl.Ui.Text widget size is sensitive to order in which properties are set as Resolved.

Yes, it has been resolved (probably by D10981).

Jan 27 2020, 12:42 AM · regression, efl
ali.alzyod added a comment to T8023: Efl.Ui.Text widget size is sensitive to order in which properties are set.

@segfaultxavi Can you please confirm if this one is resolved?

Jan 27 2020, 12:41 AM · regression, efl
ali.alzyod assigned T8023: Efl.Ui.Text widget size is sensitive to order in which properties are set to segfaultxavi.
Jan 27 2020, 12:40 AM · regression, efl

Oct 17 2019

zmike edited projects for T7396: elementary_test's box transition test is broken under wayland, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), regression, Restricted Project
zmike edited projects for T7269: Maximized internal wins dont return to their previous size after unmaximize, added: efl (efl-1.24); removed efl (efl-1.23).
Oct 17 2019, 7:02 AM · efl (efl-1.24), enlightenment-git, regression, efl: display system, Restricted Project

Oct 4 2019

zmike added a commit to T8214: EDI Cursor issues: rEFLa20aea042832: elm_code_widget: when the position is updated, set new geom to cursor.
Oct 4 2019, 7:40 AM · efl (efl-1.23), regression, Restricted Project
zmike added a commit to T7838: Regression display application without window manager.: rEFL8edfe96df9fc: ecore-evas/x: detect and track wm existence, apply visibility correctly.
Oct 4 2019, 7:40 AM · regression, efl, Bug Report

Sep 30 2019

stefan_schmidt closed T8214: EDI Cursor issues as Resolved by committing rEFL8de8f059c94f: elm_code_widget: when the position is updated, set new geom to cursor.
Sep 30 2019, 1:47 AM · efl (efl-1.23), regression, Restricted Project
stefan_schmidt updated subscribers of T8214: EDI Cursor issues.

@brokenshakles could you please test the revision @bu5hm4n did here to fix the issue?

Sep 30 2019, 12:59 AM · efl (efl-1.23), regression, Restricted Project

Sep 27 2019

bu5hm4n added a revision to T8214: EDI Cursor issues: D10225: elm_code_widget: when the position is updated, set new geom to cursor.
Sep 27 2019, 7:40 AM · efl (efl-1.23), regression, Restricted Project
bu5hm4n added a comment to T8260: Giant memory leak.

For the record: I have a svg icon theme.

Sep 27 2019, 5:47 AM · efl: rendering, regression, efl (efl-1.23)
bu5hm4n added a commit to T8260: Giant memory leak: rEFL29beda7f4f36: evas: fix memory leak with Efl.Canvas.Vg.
Sep 27 2019, 5:47 AM · efl: rendering, regression, efl (efl-1.23)
bu5hm4n closed T8260: Giant memory leak as Resolved.

I think this is fixed by the svg fix you provided. I cannot reproduce this anymore.

Sep 27 2019, 5:47 AM · efl: rendering, regression, efl (efl-1.23)

Sep 26 2019

devilhorns added a commit to T7838: Regression display application without window manager.: rEFLfddc27ed4041: ecore-evas/x: detect and track wm existence, apply visibility correctly.
Sep 26 2019, 8:23 AM · regression, efl, Bug Report

Sep 25 2019

cedric added a comment to T8260: Giant memory leak.

Possible way to track it down is to run enlightenment under Xephyr by passing -massif to enlightenment_start and try to reproduce it that way. It should give deeper meaningful trace and associate it with timing information that could lead to an understanding of what is going on. It might be linked to specific engine configuration like texture mapping stuff.

Sep 25 2019, 1:38 PM · efl: rendering, regression, efl (efl-1.23)
cedric added a comment to T8260: Giant memory leak.

I have been running expedite under massif and only found a leak in the VG part. Nothing that would explain enlightenment leak.

Sep 25 2019, 1:37 PM · efl: rendering, regression, efl (efl-1.23)
zmike added a comment to T8260: Giant memory leak.

I expected this to be from the cursor idle animations, but I created a test app to simulate it and after an hour or so there were no leaks.

Sep 25 2019, 6:14 AM · efl: rendering, regression, efl (efl-1.23)

Sep 24 2019

zmike added projects to T8260: Giant memory leak: regression, efl: rendering.
Sep 24 2019, 1:05 PM · efl: rendering, regression, efl (efl-1.23)

Sep 18 2019

zmike added a commit to T8182: Efl.Ui.Table example does not render correctly: rEFL77fd6e02dc9a: efl_ui_table: respect col,row span in last_position calculation.
Sep 18 2019, 7:30 AM · regression, efl

Sep 13 2019

thierry1970 closed T7838: Regression display application without window manager. as Resolved.

Resolut by D9900

Sep 13 2019, 6:29 AM · regression, efl, Bug Report

Sep 11 2019

Diffusion closed T8202: widget constructor thingy as Resolved by committing rEFL602895289403: evas_callbacks: make the callback protection a little bit safer.
Sep 11 2019, 1:37 AM · regression, efl (efl-1.23), efl: widgets

Sep 10 2019

zmike added a revision to T7838: Regression display application without window manager.: D9900: ecore-evas/x: detect and track wm existence, apply visibility correctly.
Sep 10 2019, 10:18 AM · regression, efl, Bug Report

Sep 9 2019

tasn added a comment to T8214: EDI Cursor issues.

I haven't touched it, so no idea what it may be. Also, EDI uses textgrid I think, not textblock, so it's nothing I even ever touched before.

Sep 9 2019, 11:18 AM · efl (efl-1.23), regression, Restricted Project
zmike reassigned T8214: EDI Cursor issues from netstar to tasn.

This sounds like a text regression.

Sep 9 2019, 11:13 AM · efl (efl-1.23), regression, Restricted Project

Sep 6 2019

segfaultxavi closed T8182: Efl.Ui.Table example does not render correctly as Resolved.
Sep 6 2019, 12:39 AM · regression, efl
segfaultxavi added a commit to T8182: Efl.Ui.Table example does not render correctly: rEFLae29408b86ea: efl_ui_table: respect col,row span in last_position calculation.
Sep 6 2019, 12:38 AM · regression, efl

Sep 5 2019

YOhoho added a revision to T8182: Efl.Ui.Table example does not render correctly: D9854: efl_ui_table: respect col,row span in last_position calculation.
Sep 5 2019, 7:29 PM · regression, efl

Sep 4 2019

bu5hm4n added a revision to T8202: widget constructor thingy: D9841: evas_callbacks: make the callback protection a little bit safer.
Sep 4 2019, 12:25 PM · regression, efl (efl-1.23), efl: widgets
zmike triaged T8202: widget constructor thingy as Showstopper Issues priority.
Sep 4 2019, 11:17 AM · regression, efl (efl-1.23), efl: widgets

Aug 27 2019

Herald raised the priority of T8182: Efl.Ui.Table example does not render correctly from High to Showstopper Issues.
Aug 27 2019, 4:39 AM · regression, efl

Aug 12 2019

raster closed T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ) as Resolved.

cool. i saw those :) let's call this done for now.

Aug 12 2019, 3:28 AM · regression, efl

Aug 11 2019

smohanty added a comment to T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ).

Regarding other findings

Right now am concentrating on reducing number of memory allocation and string parsing during startup time as well as memory consumption ( unnecessary ) . Will tag you when I raise a patch or bug against it.
Aug 11 2019, 6:45 PM · regression, efl
smohanty added a comment to T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ).

@raster ,
I saw your patch already landed in master. Awesome :)

Aug 11 2019, 6:41 PM · regression, efl
raster added a comment to T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ).

yeah. actually found bug #2 in that patch. i still have one of my unlocked funcs still lock. forgot to remove them... now down to .... 28 locks to start elm test. so... update. locally with an updated patch... 615604 -> 28 lock+unlock cycles. i think... that will be good enough eh? :) even if a read lock is 3x as expensive... we do it 0.004% as much as before, and still get the write contention improvements. :) i call this a win.

Aug 11 2019, 4:52 AM · regression, efl
raster added a comment to T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ).

cool. so i guessed what you wanted. btw that patch has a small bug in it. find it :) (i already have and fixed it locally). it won't affect running things and testing performance though.

Aug 11 2019, 4:39 AM · regression, efl

Aug 10 2019

smohanty added a comment to T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ).

i thought my git commit log explained that - it sped things up when there was contention ? can you provide much more detailed benchmarks and tools to show all the cases? like simple usage, more complex usage in single threads, multiple threads (a few of them, many of them) etc. ?

if you mean to have an unlocked version of eet_dictionary api's and then manually take read lock on the dict when we do an eet_read... of some sort so it's only taking the lock once per eet_read... ?

Aug 10 2019, 6:05 PM · regression, efl
smohanty added a comment to T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ).

btw... that should actually be faster than the original spinlock before rwlock as it's even less lock+unlocks. as it's a rwlock multiple readers will not block each-other unlike spinlocks too. only a writer will end up blocking others and that path i have left as-is.

Aug 10 2019, 6:02 PM · regression, efl
smohanty added a comment to T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ).

so do you mean something like: P319

(patch against efl) ? (locked vs unlocked paths to reduce lock/unlocks during decode to a minimum set).

Aug 10 2019, 5:56 PM · regression, efl
raster added a comment to T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ).

btw... that should actually be faster than the original spinlock before rwlock as it's even less lock+unlocks. as it's a rwlock multiple readers will not block each-other unlike spinlocks too. only a writer will end up blocking others and that path i have left as-is.

Aug 10 2019, 4:20 AM · regression, efl
raster added a comment to T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ).

so do you mean something like: P319

Aug 10 2019, 4:15 AM · regression, efl
Herald raised the priority of T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ) from Normal to Showstopper Issues.

nah - just a performance thing and it's not a huge one... it's only in some code paths. so not showstopper

Aug 10 2019, 4:13 AM · regression, efl
Herald raised the priority of T8121: Performance Regression because of patch ( eet - dictionary - use rwlocks instead of spinlocks ) from High to Showstopper Issues.
Aug 10 2019, 3:40 AM · regression, efl

Jul 25 2019

ali.alzyod added a comment to T8023: Efl.Ui.Text widget size is sensitive to order in which properties are set.

@segfaultxavi can you please check D9391

Jul 25 2019, 1:43 AM · regression, efl

Jul 13 2019

escwyp closed T8042: Behaviour changed - elm_radio_value_set is calling evas_object_smart_callback function as Resolved.

Is fixed.

Jul 13 2019, 2:44 AM · regression, efl

Jul 11 2019

segfaultxavi closed T8044: efl-mono: Examples do not run anymore as Invalid.

False alarm, dunno what it was.

Jul 11 2019, 7:57 AM · regression, efl
Herald raised the priority of T8044: efl-mono: Examples do not run anymore from High to Showstopper Issues.
Jul 11 2019, 3:29 AM · regression, efl

Jul 9 2019

escwyp added a comment to T8042: Behaviour changed - elm_radio_value_set is calling evas_object_smart_callback function.

Yes, that fixed it, thanks.

Jul 9 2019, 12:35 PM · regression, efl

Jul 7 2019

bu5hm4n added a comment to T8042: Behaviour changed - elm_radio_value_set is calling evas_object_smart_callback function.

@escwyp Can you recheck with current master? ebf39e9fd7ba054f49031f7f4162ced8c63b1d22 should have fixed this.

Jul 7 2019, 11:40 PM · regression, efl
zmike added a commit to T8042: Behaviour changed - elm_radio_value_set is calling evas_object_smart_callback function: rEFLb5e65ed99324: tests/radio: add explicit test for verifying legacy radio callback triggering.
Jul 7 2019, 11:14 PM · regression, efl
zmike added a commit to T8042: Behaviour changed - elm_radio_value_set is calling evas_object_smart_callback function: rEFLebf39e9fd7ba: efl_ui_check/radio: restore legacy behaviour.
Jul 7 2019, 11:14 PM · regression, efl

Jun 29 2019

Herald triaged T8042: Behaviour changed - elm_radio_value_set is calling evas_object_smart_callback function as Showstopper Issues priority.
Jun 29 2019, 7:18 AM · regression, efl

Jun 20 2019

Herald raised the priority of T8023: Efl.Ui.Text widget size is sensitive to order in which properties are set from High to Showstopper Issues.
Jun 20 2019, 1:44 AM · regression, efl

Jun 19 2019

zmike closed T7980: elm_test fileselector crash as Resolved.
Jun 19 2019, 9:27 AM · regression, efl: widgets

Jun 3 2019

zmike closed T7984: Efl.Ui.Bg elementary_test is broken as Resolved by committing rEFLf05c862ac0f5: elm_test/ui.bg: use full white+opaque for unchecked 'bg color' state.
Jun 3 2019, 9:56 AM · regression, efl (efl-1.23)
zmike added a revision to T7984: Efl.Ui.Bg elementary_test is broken: D9066: elm_test/ui.bg: use full white+opaque for unchecked 'bg color' state.
Jun 3 2019, 9:01 AM · regression, efl (efl-1.23)
zmike added a comment to T7980: elm_test fileselector crash.

Here's the invalid access part:

Jun 3 2019, 6:01 AM · regression, efl: widgets

May 30 2019

cedric added a comment to T7980: elm_test fileselector crash.

This is new and I have not been able to reproduce it here. Could you run it through valgrind and post a trace?

May 30 2019, 10:44 AM · regression, efl: widgets

May 23 2019

zmike closed T7960: recent addition of gestures breaks linking on Windows as Resolved by committing rEFL029b20fa829f: efl/gesture: include .h file in private header, not .c file.
May 23 2019, 10:56 AM · regression, Restricted Project
zmike added a revision to T7960: recent addition of gestures breaks linking on Windows: D8945: efl/gesture: include .h file in private header, not .c file.
May 23 2019, 9:38 AM · regression, Restricted Project
segfaultxavi triaged T7984: Efl.Ui.Bg elementary_test is broken as Showstopper Issues priority.
May 23 2019, 7:34 AM · regression, efl (efl-1.23)

May 22 2019

zmike triaged T7980: elm_test fileselector crash as Showstopper Issues priority.
May 22 2019, 8:46 AM · regression, efl: widgets

May 20 2019

vtorri added a comment to T7960: recent addition of gestures breaks linking on Windows.

not sure, but in efl_canvas_gesture_private.h, there is the inclusion of a source file :

May 20 2019, 4:47 AM · regression, Restricted Project

May 14 2019

zmike added a project to T7960: recent addition of gestures breaks linking on Windows: regression.
May 14 2019, 6:41 AM · regression, Restricted Project

Apr 30 2019

Herald raised the priority of T7838: Regression display application without window manager. from Normal to Showstopper Issues.
Apr 30 2019, 5:00 AM · regression, efl, Bug Report

Apr 23 2019

DaveMDS added a comment to T7360: Evas/Edje animations not in sync .

Indeed, works for me!

Apr 23 2019, 12:02 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression

Apr 10 2019

zmike edited projects for T7396: elementary_test's box transition test is broken under wayland, added: efl (efl-1.23); removed efl (efl-1.22).
Apr 10 2019, 5:00 AM · efl (efl-1.24), regression, Restricted Project
zmike edited projects for T7269: Maximized internal wins dont return to their previous size after unmaximize, added: efl (efl-1.23); removed efl (efl-1.22).
Apr 10 2019, 5:00 AM · efl (efl-1.24), enlightenment-git, regression, efl: display system, Restricted Project

Mar 28 2019

raster closed T7764: evasgl usage broken as Resolved by committing rEFL3439134ea1f8: Revert "evas gl engines - avoid getting context if possible".
Mar 28 2019, 5:19 PM · regression, efl (efl-1.22), efl: rendering

Mar 25 2019

Hermet placed T7360: Evas/Edje animations not in sync up for grabs.
Mar 25 2019, 3:51 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
Hermet closed T7360: Evas/Edje animations not in sync as Resolved by committing rEFL620eb070f40f: efl_ui_image: remove job in sizing calc..
Mar 25 2019, 3:50 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
Hermet added a comment to T7360: Evas/Edje animations not in sync .

let me fix this.

Mar 25 2019, 3:35 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
Hermet added a comment to T7360: Evas/Edje animations not in sync .

This job is just a trick optimization to avoid several sizing() calls in one frame.
Actually, this is not mandatory we can revert code if it harms image behavior.

Mar 25 2019, 3:34 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression

Mar 23 2019

bu5hm4n updated subscribers of T7360: Evas/Edje animations not in sync .

Okay, cause found!

Mar 23 2019, 7:01 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
bu5hm4n added a comment to T7360: Evas/Edje animations not in sync .

A little bit more debugging information: this is related to elm_image, if you replace the elm_icon part in the test_icon.c with a direct evas_image, then everything is fine, no lacking, by the time you make it a elm_image, the lacking starts to happen.

Mar 23 2019, 6:48 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression

Mar 22 2019

cedric closed T7100: Performance issue when closing the menu as Resolved by committing rEFLe6d8ac512d21: evas_clip: check for object validity before adding fallback damage rect.
Mar 22 2019, 2:11 PM · efl (efl-1.22), regression, efl: display system
cedric closed T7421: Something is adding ridiculous damage rectangles as Resolved by committing rEFLe6d8ac512d21: evas_clip: check for object validity before adding fallback damage rect.
Mar 22 2019, 2:11 PM · efl (efl-1.22), regression, efl: canvas
cedric closed T7421: Something is adding ridiculous damage rectangles, a subtask of T7100: Performance issue when closing the menu, as Resolved.
Mar 22 2019, 2:11 PM · efl (efl-1.22), regression, efl: display system
bu5hm4n added a comment to T7360: Evas/Edje animations not in sync .

A little bit of debugging information: this is fully related to images. You can replace the icons in the genlist with a button or label, and there is no lacking.

Mar 22 2019, 8:36 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
zmike added a revision to T7421: Something is adding ridiculous damage rectangles: D8445: evas_clip: check for object validity before adding fallback damage rect.
Mar 22 2019, 6:52 AM · efl (efl-1.22), regression, efl: canvas
zmike added a revision to T7100: Performance issue when closing the menu: D8445: evas_clip: check for object validity before adding fallback damage rect.
Mar 22 2019, 6:52 AM · efl (efl-1.22), regression, efl: display system

Mar 20 2019

zmike triaged T7764: evasgl usage broken as Showstopper Issues priority.
Mar 20 2019, 12:41 PM · regression, efl (efl-1.22), efl: rendering

Mar 15 2019

raster added a comment to T7360: Evas/Edje animations not in sync .

I'm not going to have time for a few weeks...

Mar 15 2019, 2:54 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression

Mar 14 2019

stefan_schmidt assigned T7360: Evas/Edje animations not in sync to raster.

@raster assigning this to you in the hope you could help with this regression before the 1.22 release.

Mar 14 2019, 7:50 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
RX14 added a comment to T7409: Terminology does not start on xwayland.

The workaround env -u WAYLAND_DISPLAY -u ELM_DISPLAY /usr/bin/terminology doesn't work for me. It still hangs on startup. Fortunately terminology works quite well on wayland.

Mar 14 2019, 6:32 AM · regression, efl, Terminology

Mar 13 2019

Jaehyun_Cho added a comment to T6931: elm_layout_text_set() should return EINA_FALSE when it fails to set a text.

D7888 is reverted since it breaks the backward compatibility. So D7603 is also reverted since it is based on D7888.
Now a new proper patch is required instead of D7888 to fulfill D7603.

Mar 13 2019, 3:31 AM · regression, efl (efl-1.22)

Mar 1 2019

devilhorns placed T7409: Terminology does not start on xwayland up for grabs.
Mar 1 2019, 7:57 AM · regression, efl, Terminology
zmike assigned T7409: Terminology does not start on xwayland to devilhorns.
Mar 1 2019, 7:37 AM · regression, efl, Terminology

Feb 28 2019

Herald raised the priority of T7409: Terminology does not start on xwayland from Normal to Showstopper Issues.
Feb 28 2019, 2:38 AM · regression, efl, Terminology

Feb 27 2019

zmike added a commit to T6931: elm_layout_text_set() should return EINA_FALSE when it fails to set a text: rEFL0e027980f6c2: tests: add test for elm_layout_text_set.
Feb 27 2019, 1:04 PM · regression, efl (efl-1.22)
zmike closed T6931: elm_layout_text_set() should return EINA_FALSE when it fails to set a text as Resolved by committing rEFL649433560b5b: efl_ui_layout: check part existence in text_set.
Feb 27 2019, 1:04 PM · regression, efl (efl-1.22)

Feb 6 2019

zmike added a revision to T6931: elm_layout_text_set() should return EINA_FALSE when it fails to set a text: D7888: efl_ui_layout: check part existence in text_set.
Feb 6 2019, 12:57 PM · regression, efl (efl-1.22)
zmike removed a parent task for T6931: elm_layout_text_set() should return EINA_FALSE when it fails to set a text: T7621: efl_ui_text is pretty fucked.
Feb 6 2019, 12:57 PM · regression, efl (efl-1.22)

Jan 17 2019

stephenmhouston closed T7263: Wrong handler are executed as Resolved by committing rE4097a9d2f63f: Mixer Gadget: Give the mixer gadget its own actions as to not conflict with the….
Jan 17 2019, 9:37 AM · regression, enlightenment-git

Jan 15 2019

raster added a comment to T7409: Terminology does not start on xwayland.

Just tried here and forced terminology to use X11 (unset WAYLAND_DISPLAY and ELM_DISPLAY terminology comes up fine in x11 mode as the only display info it has int he env is for x11). i checked with xwininfo -tree -root to see the x11 window as there in xwayland...

Jan 15 2019, 3:42 AM · regression, efl, Terminology

Jan 14 2019

devilhorns added a comment to T7421: Something is adding ridiculous damage rectangles.

Can anyone confirm that this is still happening ?? I ran some tests here today with some printfs added, and I am not seeing any odd damage rectangles from evas_clip.c anymore...

Jan 14 2019, 12:41 PM · efl (efl-1.22), regression, efl: canvas
Herald raised the priority of T7360: Evas/Edje animations not in sync from High to Showstopper Issues.
Jan 14 2019, 11:29 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression
zmike edited projects for T7396: elementary_test's box transition test is broken under wayland, added: regression, efl (efl-1.22); removed efl.
Jan 14 2019, 11:17 AM · efl (efl-1.24), regression, Restricted Project
zmike added projects to T7421: Something is adding ridiculous damage rectangles: regression, efl (efl-1.22).
Jan 14 2019, 11:15 AM · efl (efl-1.22), regression, efl: canvas
zmike added a subtask for T7100: Performance issue when closing the menu: T7421: Something is adding ridiculous damage rectangles.
Jan 14 2019, 11:14 AM · efl (efl-1.22), regression, efl: display system
zmike merged T7439: EFL wayland clients conflict with Xwayland into T7409: Terminology does not start on xwayland.
Jan 14 2019, 11:13 AM · regression, efl, Terminology