Page MenuHomePhabricator
Feed Advanced Search

Today

bu5hm4n added a comment to T7725: master ticket for 1.22 api stabilization.

With the script given in [1] you can check how many problem cases we have. We have 0 *direct* problem cases, but ~8 cases that cannot be checked by the script. However, they are looking fine to me.

Thu, Mar 21, 4:09 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n updated the task description for T7725: master ticket for 1.22 api stabilization.
Thu, Mar 21, 4:08 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n requested changes to D8375: elementary: destroy fileselector children when they are not itemized yet..

Does not apply here ...

Thu, Mar 21, 3:24 AM · efl
bu5hm4n added a comment to T7760: Document event info calling convention.

Looks fine to add them to Eo.h efl_event_callback_call is the only one accepting event_info afair.

Thu, Mar 21, 3:20 AM · efl: docs, Restricted Project, efl (efl-1.22), efl: api
bu5hm4n requested changes to D8336: elementary: improve lifecycle of model object in the fileselector widget..

#1 Open a large directory in fileselector, close the window -> SEGV
#2 Open a large directory in fileselector, click on home -> things get added to the view that are not in the directory that is least recently opened
#3 Open a fileselector, click arround -> observe a giant amount of errors in the console

Thu, Mar 21, 3:17 AM · efl
bu5hm4n accepted D8336: elementary: improve lifecycle of model object in the fileselector widget..
Thu, Mar 21, 3:09 AM · efl
bu5hm4n accepted D8429: Revert "efl_ui_layout: call efl_del instead of efl_unref when text part does not exist".
Thu, Mar 21, 2:37 AM · efl
bu5hm4n accepted D8359: elementary: only apply text when the object is not invalidated and dying..

I wait for the day we get a bug report "But i wanted to set text while the object was beeing deleted! I used that to safe a string Plz fix!"

Thu, Mar 21, 2:37 AM · efl
bu5hm4n closed T7476: efl: Rename duplicated event names as Resolved.

ab30ff3f9bd8b82c5df9c97e0092d18221f0b7dc

Thu, Mar 21, 2:36 AM · efl: language bindings
bu5hm4n accepted D8372: eio: add test to ensure proper lifecycle of Efl_Io object and futures..
Thu, Mar 21, 2:32 AM · efl
bu5hm4n accepted D8335: eio: path and filename property should always remind accessible even in case of error..

_eio_build_st is protecting itself from doing what I wrote above, it just feels a little bit fragile, since changing this would leave the world in parts, maybe make pd->st = NULL and pd->info = NULL; in case of an error ?

Thu, Mar 21, 2:31 AM · efl
bu5hm4n awarded D8433: efl.pack_linear: enhance documentation a Orange Medal token.
Thu, Mar 21, 2:24 AM · efl
bu5hm4n accepted D8434: elm : fallback orientation_mode_disable_set legacy behavior to get true disabled state as what we set..
Thu, Mar 21, 2:20 AM · efl
bu5hm4n accepted D8436: elm : fix wrong layout class comparing in orientation mode disable.
Thu, Mar 21, 2:17 AM · efl
bu5hm4n added a comment to T7701: Rename Efl.Ui.Stack.

Let's just keep this here open until the release is out, then we can still decide on a name :)

Thu, Mar 21, 1:48 AM · efl: api

Yesterday

bu5hm4n updated the diff for D8425: eolian: enable event redef checking by default.

use less stupid API in eolian.

Wed, Mar 20, 12:26 PM · efl
bu5hm4n added a comment to D8425: eolian: enable event redef checking by default.

Maybe just try to use inline comments for once, it might be usefull...

Wed, Mar 20, 12:19 PM · efl
bu5hm4n updated the diff for D8425: eolian: enable event redef checking by default.

update

Wed, Mar 20, 12:03 PM · efl
bu5hm4n claimed T7758: Resolving all problem event calls in efl.
Wed, Mar 20, 10:51 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a revision to T7476: efl: Rename duplicated event names: D8425: eolian: enable event redef checking by default.
Wed, Mar 20, 10:45 AM · efl: language bindings
bu5hm4n added a task to D8425: eolian: enable event redef checking by default: T7476: efl: Rename duplicated event names.
Wed, Mar 20, 10:45 AM · efl
bu5hm4n added reviewers for D8425: eolian: enable event redef checking by default: q66, lauromoura, zmike, cedric, stefan_schmidt, devilhorns.
Wed, Mar 20, 10:44 AM · efl
bu5hm4n added a comment to D8425: eolian: enable event redef checking by default.

This can now be reviewed!

Wed, Mar 20, 10:44 AM · efl
bu5hm4n removed a project from D8425: eolian: enable event redef checking by default: DO NOT MERGE.
Wed, Mar 20, 10:44 AM · efl
bu5hm4n accepted D8426: csharp: Remove test about conflicting events..
Wed, Mar 20, 10:43 AM · efl
bu5hm4n added a comment to D8350: efl_canvas_vg_object: Fix dereference after null check.

If one, either pname or fileis NULL then the pl / cl is different, and the block is executed. Hence, if the strcmp is executed either both are NULL or both are not NULL. Thus This commit seems fine.

Wed, Mar 20, 10:06 AM · efl
bu5hm4n accepted D8350: efl_canvas_vg_object: Fix dereference after null check.
Wed, Mar 20, 9:48 AM · efl
bu5hm4n added a comment to D6895: eolian-cxx: Add dummy -S parameter to be compatible with eolian variable in pkgconfig.

I cannot find -S in a .pc file ...

Wed, Mar 20, 9:25 AM · efl
bu5hm4n requested changes to D7242: Efl.Ui.Tree_View: added new MVVM asynchronous widget.

Segarray is still in the API so cedrics wish was not fullfilled.

Wed, Mar 20, 9:06 AM · efl
bu5hm4n added reviewers for D8324: csharp: Export correct headers and files: bu5hm4n, segfaultxavi, cedric, devilhorns.
Wed, Mar 20, 9:01 AM · efl
bu5hm4n accepted D8416: ci: disable exit-on-error during configure and also grab stderr.
Wed, Mar 20, 8:55 AM · efl
bu5hm4n requested changes to D8426: csharp: Remove test about conflicting events..

Autotools support (marking is as RC so its out of the pipeline)

Wed, Mar 20, 8:55 AM · efl
bu5hm4n requested changes to D8427: efl_access: add test cases for reading_info_type_set/get API.

Uhhm, this is the same test just twice under a different function name... Is this a cnp error ?

Wed, Mar 20, 8:53 AM · efl
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

This revision actaully fixes that and makes it shutting down in a few seconds.

Wed, Mar 20, 8:38 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a revision to T7755: infinite loop in focus manager on destroy: D8367: elm_gengrid: speed up update order calls.
Wed, Mar 20, 8:38 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a task to D8367: elm_gengrid: speed up update order calls: T7755: infinite loop in focus manager on destroy.
Wed, Mar 20, 8:38 AM · efl
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

Are you sure its a infinite loop, or just terribly slow? It takes here ~ 3 min. until the window is closed. It is faster with my recent gengrid patches ... :)

Wed, Mar 20, 8:28 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

Maaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaan :(

Wed, Mar 20, 8:24 AM · Restricted Project, efl (efl-1.22)
bu5hm4n requested review of D8428: build: codegen generation should depend on elementary_codegen.
Wed, Mar 20, 8:24 AM · efl
bu5hm4n added a comment to T7755: infinite loop in focus manager on destroy.

This is usally a indicator that the widget tree builds a cycle in the shutdown. I can open here a lot of windows and nothing happens, it might be depending on what kind of widgets are there. Do you remember which windows you opened ?

Wed, Mar 20, 8:13 AM · Restricted Project, efl (efl-1.22)
bu5hm4n added a comment to D8426: csharp: Remove test about conflicting events..

Is there a reason why this does not change Makefiles ?

Wed, Mar 20, 8:01 AM · efl
bu5hm4n added a comment to D8424: efl_ui_selection: give this event a better name.

Right. And the window manager selection is the current active selection in one of the clients that are opened in the window manager. Which is something different ...

Wed, Mar 20, 7:57 AM · efl
bu5hm4n accepted D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

Wonderfull :)

Wed, Mar 20, 7:28 AM · efl
bu5hm4n added a comment to D8425: eolian: enable event redef checking by default.
Wed, Mar 20, 7:17 AM · efl
bu5hm4n added a project to D8425: eolian: enable event redef checking by default: DO NOT MERGE.
Wed, Mar 20, 7:17 AM · efl
bu5hm4n requested review of D8424: efl_ui_selection: give this event a better name.
Wed, Mar 20, 7:16 AM · efl
bu5hm4n requested review of D8425: eolian: enable event redef checking by default.
Wed, Mar 20, 7:16 AM · efl
bu5hm4n added a child revision for D8424: efl_ui_selection: give this event a better name: D8425: eolian: enable event redef checking by default.
Wed, Mar 20, 7:16 AM · efl
bu5hm4n added a child revision for D8423: efl_ui_list_view: remove not used event: D8424: efl_ui_selection: give this event a better name.
Wed, Mar 20, 7:16 AM · efl
bu5hm4n added a revision to T7476: efl: Rename duplicated event names: D8424: efl_ui_selection: give this event a better name.
Wed, Mar 20, 7:16 AM · efl: language bindings
bu5hm4n requested review of D8423: efl_ui_list_view: remove not used event.
Wed, Mar 20, 7:16 AM · efl
bu5hm4n requested changes to D8392: elm_test: set accel for all glview tests.

Okay, after i switched from full opengl to egl-es, i managed to have it running. However, if i am setting elm_config to No Accelation, then i am still not getting something to render, something does not seem to work here ... Can I help debugging ?

Wed, Mar 20, 3:13 AM · efl: widgets
bu5hm4n added a comment to D8392: elm_test: set accel for all glview tests.

I tried to review this patchset, but i cannot get it to work, undependend from what i am doing the gl tests will not render, and give me these errors:

ERR<5324>:EvasGL ../src/modules/evas/engines/gl_common/evas_gl_core.c:3155 evgl_api_get() OpenGL ES 3.x is not supported.
## Copy & Paste the below (until EOF) into a terminal, then hit Enter
Wed, Mar 20, 3:04 AM · efl: widgets
bu5hm4n added a comment to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

I would like to merge this soon. The test case could be added by separated patch set (@bu5hm4n)

Wed, Mar 20, 12:47 AM · efl
bu5hm4n added a comment to D8411: efl_net: resolve cases where we passed something as event_info.

Damn! You have been faster than i could write a comment! :D

Wed, Mar 20, 12:42 AM · efl
bu5hm4n abandoned D8411: efl_net: resolve cases where we passed something as event_info.

Please see D8419

Wed, Mar 20, 12:42 AM · efl
bu5hm4n added a comment to T7758: Resolving all problem event calls in efl.

No problem at all :)

Wed, Mar 20, 12:41 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n requested review of D8419: efl_con: fixup copy'n paste error.
Wed, Mar 20, 12:40 AM · efl
bu5hm4n added a child revision for D8418: efl_ui_tab_bar: the type of this event is annotated as object: D8419: efl_con: fixup copy'n paste error.
Wed, Mar 20, 12:40 AM · efl
bu5hm4n requested review of D8418: efl_ui_tab_bar: the type of this event is annotated as object.
Wed, Mar 20, 12:40 AM · efl
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8418: efl_ui_tab_bar: the type of this event is annotated as object.
Wed, Mar 20, 12:40 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a comment to T7758: Resolving all problem event calls in efl.

Why is ev->info invalid? Your funcrion here is called while the event caller is still in scope, hence this pointer is fully valid ...

Wed, Mar 20, 12:09 AM · Restricted Project, efl (efl-1.22), efl: api

Tue, Mar 19

bu5hm4n added a comment to T7758: Resolving all problem event calls in efl.

? They are never accessed outside the function scope ...

Tue, Mar 19, 11:32 PM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n abandoned D8395: efl_ui_widget: resolve warning about multiple defines.

Please see D8415

Tue, Mar 19, 1:26 PM · efl
bu5hm4n requested review of D8415: efl_ui_widget: resolve warning about multiple defines.
Tue, Mar 19, 1:26 PM · efl
bu5hm4n updated the diff for D8395: efl_ui_widget: resolve warning about multiple defines.

use return macro

Tue, Mar 19, 1:05 PM · efl
bu5hm4n added a comment to D8408: evas: apply new event calling convention.

Well i tend to not care here, but just check it for a second,the event_info now *is* the pointer we passed in, which is a horrible idea IMO, but whatever.

Tue, Mar 19, 1:00 PM · efl
bu5hm4n updated the diff for D8408: evas: apply new event calling convention.

lets give legacy a random pointer where noone knows what it is doing.

Tue, Mar 19, 12:59 PM · efl
bu5hm4n requested review of D8408: evas: apply new event calling convention.
Tue, Mar 19, 11:32 AM · efl
bu5hm4n updated the diff for D8411: efl_net: resolve cases where we passed something as event_info.

replace with event forwarder

Tue, Mar 19, 11:27 AM · efl
bu5hm4n planned changes to D8411: efl_net: resolve cases where we passed something as event_info.
Tue, Mar 19, 11:15 AM · efl
bu5hm4n accepted D8364: efl_ui_text_alert_popup: use correct theme klass name.

Looks correct to me, the theme does exist and looks like this is the one that should be used.

Tue, Mar 19, 11:04 AM · efl
bu5hm4n requested changes to D8386: efl_access: Add attribute_del API, Add test cases for all access_object_attribute* APIs.

This API lacks a bit of a usecase for me, and additionally a test would be good. Without this i cannot see the intend or reason for this patch ... :|

Tue, Mar 19, 11:03 AM · efl
bu5hm4n requested changes to D8387: efl_access_text_selections_count_get implementation for Entry.

This seems wrong considering the documentation of atspi. According to [1] the idea of this API is that this returns the number of *contiguous* selections in the current text object. Considering this, this patch looks wrong.

Tue, Mar 19, 11:01 AM · efl
bu5hm4n accepted D8393: elm_code: add theme alias for layout group.
Tue, Mar 19, 10:56 AM · efl
bu5hm4n accepted D8400: efl_ui_win: mark legacy forbidden during bg part load always.
Tue, Mar 19, 10:55 AM · efl: widgets
bu5hm4n requested review of D8414: efl_ui: rename select and unselected of efl_ui_selectable.
Tue, Mar 19, 9:45 AM · efl
bu5hm4n added a child revision for D8413: elm: do not use eo events here: D8414: efl_ui: rename select and unselected of efl_ui_selectable.
Tue, Mar 19, 9:45 AM · efl
bu5hm4n requested review of D8413: elm: do not use eo events here.
Tue, Mar 19, 9:45 AM · efl
bu5hm4n added a child revision for D8412: Revert "efl_ui_selectable: namespace events to avoid conflicts": D8413: elm: do not use eo events here.
Tue, Mar 19, 9:45 AM · efl
bu5hm4n requested review of D8412: Revert "efl_ui_selectable: namespace events to avoid conflicts".
Tue, Mar 19, 9:45 AM · efl
bu5hm4n added a child revision for D8411: efl_net: resolve cases where we passed something as event_info: D8412: Revert "efl_ui_selectable: namespace events to avoid conflicts".
Tue, Mar 19, 9:45 AM · efl
bu5hm4n requested review of D8411: efl_net: resolve cases where we passed something as event_info.
Tue, Mar 19, 9:08 AM · efl
bu5hm4n added a comment to T7758: Resolving all problem event calls in efl.

After those patches: P277

Tue, Mar 19, 8:37 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n requested review of D8410: efl_io_*: apply new event calling convention.
Tue, Mar 19, 8:26 AM · efl
bu5hm4n added a child revision for D8409: efl_ui_focus_object: apply new event calling convention: D8410: efl_io_*: apply new event calling convention.
Tue, Mar 19, 8:26 AM · efl
bu5hm4n requested review of D8409: efl_ui_focus_object: apply new event calling convention.
Tue, Mar 19, 8:26 AM · efl
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8410: efl_io_*: apply new event calling convention.
Tue, Mar 19, 8:26 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n requested review of D8408: evas: apply new event calling convention.
Tue, Mar 19, 8:26 AM · efl
bu5hm4n added a child revision for D8408: evas: apply new event calling convention: D8409: efl_ui_focus_object: apply new event calling convention.
Tue, Mar 19, 8:25 AM · efl
bu5hm4n requested review of D8407: efl_ui_tags: apply new event calling convention.
Tue, Mar 19, 8:25 AM · efl
bu5hm4n added a child revision for D8407: efl_ui_tags: apply new event calling convention: D8408: evas: apply new event calling convention.
Tue, Mar 19, 8:25 AM · efl
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8409: efl_ui_focus_object: apply new event calling convention.
Tue, Mar 19, 8:25 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a child revision for D8406: efl_ui_win: apply new event calling convention: D8407: efl_ui_tags: apply new event calling convention.
Tue, Mar 19, 8:25 AM · efl
bu5hm4n requested review of D8406: efl_ui_win: apply new event calling convention.
Tue, Mar 19, 8:25 AM · efl
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8408: evas: apply new event calling convention.
Tue, Mar 19, 8:25 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n added a child revision for D8405: efl_ui_focus_manager_sub: apply new event calling convention: D8406: efl_ui_win: apply new event calling convention.
Tue, Mar 19, 8:25 AM · efl
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8406: efl_ui_win: apply new event calling convention.
Tue, Mar 19, 8:25 AM · Restricted Project, efl (efl-1.22), efl: api
bu5hm4n requested review of D8405: efl_ui_focus_manager_sub: apply new event calling convention.
Tue, Mar 19, 8:25 AM · efl
bu5hm4n added a revision to T7758: Resolving all problem event calls in efl: D8405: efl_ui_focus_manager_sub: apply new event calling convention.
Tue, Mar 19, 8:25 AM · Restricted Project, efl (efl-1.22), efl: api