With the script given in  you can check how many problem cases we have. We have 0 *direct* problem cases, but ~8 cases that cannot be checked by the script. However, they are looking fine to me.
Does not apply here ...
Looks fine to add them to Eo.h efl_event_callback_call is the only one accepting event_info afair.
#1 Open a large directory in fileselector, close the window -> SEGV
#2 Open a large directory in fileselector, click on home -> things get added to the view that are not in the directory that is least recently opened
#3 Open a fileselector, click arround -> observe a giant amount of errors in the console
I wait for the day we get a bug report "But i wanted to set text while the object was beeing deleted! I used that to safe a string Plz fix!"
_eio_build_st is protecting itself from doing what I wrote above, it just feels a little bit fragile, since changing this would leave the world in parts, maybe make pd->st = NULL and pd->info = NULL; in case of an error ?
Let's just keep this here open until the release is out, then we can still decide on a name :)
use less stupid API in eolian.
Maybe just try to use inline comments for once, it might be usefull...
This can now be reviewed!
If one, either pname or fileis NULL then the pl / cl is different, and the block is executed. Hence, if the strcmp is executed either both are NULL or both are not NULL. Thus This commit seems fine.
I cannot find -S in a .pc file ...
Segarray is still in the API so cedrics wish was not fullfilled.
Autotools support (marking is as RC so its out of the pipeline)
Uhhm, this is the same test just twice under a different function name... Is this a cnp error ?
This revision actaully fixes that and makes it shutting down in a few seconds.
Are you sure its a infinite loop, or just terribly slow? It takes here ~ 3 min. until the window is closed. It is faster with my recent gengrid patches ... :)
This is usally a indicator that the widget tree builds a cycle in the shutdown. I can open here a lot of windows and nothing happens, it might be depending on what kind of widgets are there. Do you remember which windows you opened ?
Is there a reason why this does not change Makefiles ?
Right. And the window manager selection is the current active selection in one of the clients that are opened in the window manager. Which is something different ...
Okay, after i switched from full opengl to egl-es, i managed to have it running. However, if i am setting elm_config to No Accelation, then i am still not getting something to render, something does not seem to work here ... Can I help debugging ?
I tried to review this patchset, but i cannot get it to work, undependend from what i am doing the gl tests will not render, and give me these errors:
ERR<5324>:EvasGL ../src/modules/evas/engines/gl_common/evas_gl_core.c:3155 evgl_api_get() OpenGL ES 3.x is not supported. ## Copy & Paste the below (until EOF) into a terminal, then hit Enter
I would like to merge this soon. The test case could be added by separated patch set (@bu5hm4n)
Damn! You have been faster than i could write a comment! :D
Please see D8419
No problem at all :)
Why is ev->info invalid? Your funcrion here is called while the event caller is still in scope, hence this pointer is fully valid ...
Tue, Mar 19
? They are never accessed outside the function scope ...
Please see D8415
use return macro
Well i tend to not care here, but just check it for a second,the event_info now *is* the pointer we passed in, which is a horrible idea IMO, but whatever.
lets give legacy a random pointer where noone knows what it is doing.
replace with event forwarder
Looks correct to me, the theme does exist and looks like this is the one that should be used.
This API lacks a bit of a usecase for me, and additionally a test would be good. Without this i cannot see the intend or reason for this patch ... :|
This seems wrong considering the documentation of atspi. According to  the idea of this API is that this returns the number of *contiguous* selections in the current text object. Considering this, this patch looks wrong.
After those patches: P277