Page MenuHomePhabricator
Feed Advanced Search

Today

bu5hm4n requested review of D9167: efl_input_interface: fix key down / key up structure.

Done with the word "fix" for anymore detail - either adjust the commit message on your own. I am 100% bored of revisiting patches because someone wants to have a different commit message. Take it as it is here, or change it yourself, everything that i will write will look the same.

Tue, Jun 25, 10:04 AM · efl
bu5hm4n requested review of D9167: efl_input_interface: fix key down / key up structure.

It says it fixes the up / down structure.

Tue, Jun 25, 9:59 AM · efl
bu5hm4n accepted D9177: tests: fix unforked efl_ui_radio_group completion.
Tue, Jun 25, 9:47 AM · efl
bu5hm4n requested review of D9167: efl_input_interface: fix key down / key up structure.

The patch adds a test + the fix. and that is expressed in the title and documentation. I do not see a big reason for splitting this.

Tue, Jun 25, 9:46 AM · efl
bu5hm4n updated the summary of D9167: efl_input_interface: fix key down / key up structure.
Tue, Jun 25, 9:38 AM · efl
bu5hm4n requested review of D9167: efl_input_interface: fix key down / key up structure.
Tue, Jun 25, 9:38 AM · efl
bu5hm4n updated the task description for T7948: Efl.Ui.Alert_Popup.
Tue, Jun 25, 9:35 AM · efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7847: efl.ui.clickable.
Tue, Jun 25, 9:34 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7847: efl.ui.clickable.
Tue, Jun 25, 9:34 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7847: efl.ui.clickable.
Tue, Jun 25, 9:33 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7898: efl.ui.format.

I am fine with this.

Tue, Jun 25, 8:24 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n removed a parent revision for D9174: meson: fix building of svg / eet / json loader if its disabled: D9173: view_manager_scroll: fix not to move view position by click.
Tue, Jun 25, 7:56 AM · efl
bu5hm4n removed a child revision for D9173: view_manager_scroll: fix not to move view position by click: D9174: meson: fix building of svg / eet / json loader if its disabled.
Tue, Jun 25, 7:56 AM · efl
bu5hm4n requested review of D9174: meson: fix building of svg / eet / json loader if its disabled.
Tue, Jun 25, 7:55 AM · efl
bu5hm4n added a child revision for D9173: view_manager_scroll: fix not to move view position by click: D9174: meson: fix building of svg / eet / json loader if its disabled.
Tue, Jun 25, 7:55 AM · efl
bu5hm4n requested changes to D9173: view_manager_scroll: fix not to move view position by click.

Looks good otherwise :)

Tue, Jun 25, 6:51 AM · efl
bu5hm4n added a comment to D9169: efl_input_interface: test pointer in and out events on a object.

This seems again to explode on our CI. works with clang and gcc-8 not with gcc-9 ...

Tue, Jun 25, 1:37 AM · efl
bu5hm4n added a project to D9171: efl_input_interface: WIP check cancel event: DO NOT MERGE.

This here is a funny one, we are defining the event, but we are not emitting it at all, where or how should we emit this one ? In legacy it seems like we do not have something like this.
Does someone know where or how to emit this ?

Tue, Jun 25, 1:36 AM · DO NOT MERGE, efl
bu5hm4n requested review of D9171: efl_input_interface: WIP check cancel event.
Tue, Jun 25, 1:16 AM · DO NOT MERGE, efl
bu5hm4n added a child revision for D9170: efl_input_interface: add tests for mouse wheel emitting: D9171: efl_input_interface: WIP check cancel event.
Tue, Jun 25, 1:16 AM · efl
bu5hm4n requested review of D9170: efl_input_interface: add tests for mouse wheel emitting.
Tue, Jun 25, 1:16 AM · efl
bu5hm4n requested review of D9169: efl_input_interface: test pointer in and out events on a object.
Tue, Jun 25, 1:15 AM · efl
bu5hm4n added a child revision for D9169: efl_input_interface: test pointer in and out events on a object: D9170: efl_input_interface: add tests for mouse wheel emitting.
Tue, Jun 25, 1:15 AM · efl
bu5hm4n added a child revision for D9168: efl_input_interface: test pointer move down up: D9169: efl_input_interface: test pointer in and out events on a object.
Tue, Jun 25, 1:15 AM · efl
bu5hm4n requested review of D9168: efl_input_interface: test pointer move down up.
Tue, Jun 25, 1:15 AM · efl
bu5hm4n added a child revision for D9167: efl_input_interface: fix key down / key up structure: D9168: efl_input_interface: test pointer move down up.
Tue, Jun 25, 1:15 AM · efl
bu5hm4n requested review of D9167: efl_input_interface: fix key down / key up structure.
Tue, Jun 25, 1:15 AM · efl
bu5hm4n added a child revision for D9166: efl_input_interface: add test to verify focus in/out: D9167: efl_input_interface: fix key down / key up structure.
Tue, Jun 25, 1:15 AM · efl
bu5hm4n requested review of D9166: efl_input_interface: add test to verify focus in/out.
Tue, Jun 25, 1:15 AM · efl

Yesterday

bu5hm4n added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

okay - but mprotect has nothing to do as far as i can see with malloc_usable_size. So i would rather add there a guard for if mprotect is available or not (Or emulate mprotect with VirtualProtect?)

Mon, Jun 24, 11:32 PM · Restricted Project
bu5hm4n added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

Thank you for pointing out how to search the repository, i still don't get what you are talking about.

Mon, Jun 24, 7:31 AM · Restricted Project
bu5hm4n added a comment to T8031: meson: defines EINA_DEBUG_MALLOC only if malloc_usable_size is used.

That would just turn off more debugging that we can actually provide without malloc_usable_size, i don't think this is what we want ?

Mon, Jun 24, 7:19 AM · Restricted Project
bu5hm4n accepted D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.

User error - sorry.

Mon, Jun 24, 6:39 AM · efl: widgets
bu5hm4n accepted D9152: tests/slider: verify emission of changed and delay,changed events.

Macro later:

Mon, Jun 24, 6:32 AM · efl: widgets
bu5hm4n created Image Macro "later".
Mon, Jun 24, 6:32 AM
bu5hm4n requested changes to D9151: efl_ui_slider: remove setting pass_events on internal spacer in constructor.

Mhm - the theme does not specify this property ... and as far as breakpoints tell, this is not set to false after this call...

Mon, Jun 24, 6:30 AM · efl: widgets
bu5hm4n added a comment to D9152: tests/slider: verify emission of changed and delay,changed events.

Can you add the same for the unified widget ?

Mon, Jun 24, 6:28 AM · efl: widgets
bu5hm4n added a comment to T7948: Efl.Ui.Alert_Popup.

I just wanted to ensure we have thought about button as part, so this is fine to me :)
So action items for this here are :

  • Change of Event type & Removal of struct type
  • Write Tests. / Verify event emission / Veryfy funcitonal icon / str parts.
Mon, Jun 24, 5:46 AM · efl (efl-1.23), efl: language bindings

Sat, Jun 22

bu5hm4n added a comment to T7898: efl.ui.format.

The one side is the API, the other side is how we are *using* this API from the widget.

  • Calendar does use efl_ui_format_cb internally, which means, setting the format_string to the object *does* changes the format_cb, which looks super weird to me. Additionally, the format_cb does not handle all the format symbols that others do.
  • efl_ui_spin only works with format_cb, setting the string does not work.
  • efl_ui_tags only works with format_cb, setting the string does not work.
Sat, Jun 22, 7:33 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7947: Efl.Ui.Anchor_Popup.

Why do we need align_priority ?

Sat, Jun 22, 1:38 AM · efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7948: Efl.Ui.Alert_Popup.

The event looks a bit overengeneered to me. Why passing a struct if its just a enum in the struct ? I think passing Efl.Ui.Alert_Popup_Button as event type is totally enough.

Sat, Jun 22, 1:35 AM · efl (efl-1.23), efl: language bindings
bu5hm4n added a comment to T7902: efl.ui.popup.

I am wondering a little bit about align / popup_size.

Sat, Jun 22, 1:31 AM · efl: api, efl (efl-1.23), efl: language bindings

Fri, Jun 21

bu5hm4n added a comment to T8028: no default for native-arch-optimization builds.

@sharkcz The grand council has decided that we should support this case, can you check the revision above ?

Fri, Jun 21, 7:49 AM · Restricted Project
bu5hm4n added a reviewer for D9150: meson: do not error when no optimization architecture is there: sharkcz.
Fri, Jun 21, 7:48 AM · efl
bu5hm4n requested review of D9150: meson: do not error when no optimization architecture is there.
Fri, Jun 21, 7:48 AM · efl
bu5hm4n added a revision to T8028: no default for native-arch-optimization builds: D9150: meson: do not error when no optimization architecture is there.
Fri, Jun 21, 7:48 AM · Restricted Project
bu5hm4n requested review of D9149: efl_input_key: declare stable.
Fri, Jun 21, 7:38 AM · efl
bu5hm4n added a child revision for D9148: efl_input_hold: declare stable: D9149: efl_input_key: declare stable.
Fri, Jun 21, 7:38 AM · efl
bu5hm4n requested review of D9148: efl_input_hold: declare stable.
Fri, Jun 21, 7:38 AM · efl
bu5hm4n added a revision to T7964: Efl.Input.Key: D9149: efl_input_key: declare stable.
Fri, Jun 21, 7:38 AM · efl (efl-1.23), efl: api
bu5hm4n added a child revision for D9147: efl_input_device_type: declare stable: D9148: efl_input_hold: declare stable.
Fri, Jun 21, 7:38 AM · efl
bu5hm4n added a revision to T7965: Efl.Input.Hold: D9148: efl_input_hold: declare stable.
Fri, Jun 21, 7:38 AM · efl (efl-1.23), efl: api
bu5hm4n requested review of D9147: efl_input_device_type: declare stable.
Fri, Jun 21, 7:38 AM · efl
bu5hm4n added a revision to T7970: Efl.Input.Device_Type: D9147: efl_input_device_type: declare stable.
Fri, Jun 21, 7:37 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7971: Efl.Input.Lock as Invalid.

Already Stable

Fri, Jun 21, 7:08 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7971: Efl.Input.Lock, a subtask of T7968: Efl.Input.State, as Invalid.
Fri, Jun 21, 7:08 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7972: Efl.Input.Modifier as Invalid.

Already Stable

Fri, Jun 21, 7:08 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7972: Efl.Input.Modifier, a subtask of T7968: Efl.Input.State, as Invalid.
Fri, Jun 21, 7:08 AM · efl (efl-1.23), efl: api
bu5hm4n abandoned D9145: efl_input_modifiers: rename to efl_input_key_modifiers.

Already Stable

Fri, Jun 21, 7:08 AM · efl
bu5hm4n abandoned D9146: efl_input_lock: rename to efl_input_key_lock.

Already Stable.

Fri, Jun 21, 7:07 AM · efl
bu5hm4n requested review of D9146: efl_input_lock: rename to efl_input_key_lock.
Fri, Jun 21, 6:53 AM · efl
bu5hm4n added a child revision for D9145: efl_input_modifiers: rename to efl_input_key_modifiers: D9146: efl_input_lock: rename to efl_input_key_lock.
Fri, Jun 21, 6:52 AM · efl
bu5hm4n added a revision to T7971: Efl.Input.Lock: D9146: efl_input_lock: rename to efl_input_key_lock.
Fri, Jun 21, 6:52 AM · efl (efl-1.23), efl: api
bu5hm4n requested review of D9145: efl_input_modifiers: rename to efl_input_key_modifiers.
Fri, Jun 21, 6:52 AM · efl
bu5hm4n added a revision to T7972: Efl.Input.Modifier: D9145: efl_input_modifiers: rename to efl_input_key_modifiers.
Fri, Jun 21, 6:52 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7971: Efl.Input.Lock.

@segfaultxavi on my dell laptop i can hit shift 5 times which activates the shift-lock. Differentence between those two: Make caps lock on, and press "-". Make shift lock on (or just hold it) and press "-".

Fri, Jun 21, 6:39 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

I am not against your proposal, it makes sense. However, its quite abstract, and i do not see how it will work later on in terms of API.

Fri, Jun 21, 6:24 AM
bu5hm4n updated the diff for D9144: efl_ui_win: fix emitting of object focus events.

this time - at least try to include the fix ...

Fri, Jun 21, 6:18 AM · efl
bu5hm4n requested review of D9144: efl_ui_win: fix emitting of object focus events.
Fri, Jun 21, 6:02 AM · efl
bu5hm4n added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.
In T8019#137678, @zmike wrote:

Furthermore, I'm not sure that your "active_gesture_object" idea is actually feasible; the edje callback which emits the original signals is before any of the widget callbacks, so it cannot be intercepted. This means the button will be in the "pressed" state. So now the move events start to occur, and "active_gesture_object" is set. How does the button stop being in the "pressed" state?

Fri, Jun 21, 5:33 AM
bu5hm4n added a comment to T8028: no default for native-arch-optimization builds.

Well, its kind of an policy we started to use for building efl with meson. Everything is a explicit option, nothing is decided implicit. :/

Fri, Jun 21, 4:55 AM · Restricted Project
bu5hm4n claimed T8028: no default for native-arch-optimization builds.

Mhm, is your arch capable of any of the optimizations that you can see in this file ?
If not, then i think there is no native-arch-optimization for you, and -Dnative-arch-optimization=false should be applied ...

Fri, Jun 21, 4:46 AM · Restricted Project

Thu, Jun 20

bu5hm4n added a comment to T8019: Block clicked event of efl_ui_clickable_util_bind_to_theme if input processed is set.

The idea of mike a little bit more in detail (continuing brainstorming):
To me this sounds like we are only running in this issue when we are capturing gestures which are decided "to be gestures" after the inital down event.
So how about this, we add a property to the scene, something like "active_gesture_object" if this is set, evas will move the mouse "virtually" outside the object it is in right now, so the objects will stop beeing in "down" mode. By the time there is a active_gesture_object, only this object will get the move events.
The active_gesture_object for us would then be scroller / active_view (and others?)

Thu, Jun 20, 10:44 PM
bu5hm4n updated the diff for D9143: remove more files.

more files

Thu, Jun 20, 8:53 AM · efl
bu5hm4n requested review of D9143: remove more files.
Thu, Jun 20, 8:48 AM · efl
bu5hm4n triaged T8026: efl.ui.radio_box as TODO priority.
Thu, Jun 20, 8:43 AM · efl (efl-1.23), efl: language bindings
bu5hm4n triaged T8025: efl.ui.radio_group_impl as TODO priority.
Thu, Jun 20, 8:42 AM · efl (efl-1.23), efl: language bindings
bu5hm4n triaged T8024: efl.ui.radio_group as TODO priority.
Thu, Jun 20, 8:42 AM · efl (efl-1.23), efl: language bindings
bu5hm4n updated the task description for T7867: efl.ui.radio.
Thu, Jun 20, 8:40 AM · efl: api, efl (efl-1.23), efl: language bindings
bu5hm4n accepted D9086: build: remove no longer needed eolian-bootstrap target.
Thu, Jun 20, 8:29 AM · efl
bu5hm4n added a comment to T7967: Efl.Input.Event.

Ah! those are actually mirrored properties, for convinience usage i guess, sometimes just &'ing values is better, sometimes a property is easier ... :)

Thu, Jun 20, 8:23 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7967: Efl.Input.Event.

processed means that someone did something with this event, and none else should deal with it again.

Thu, Jun 20, 8:18 AM · efl (efl-1.23), efl: api
bu5hm4n updated the diff for D9142: efl_input_device: split up has_pointer_cap.

doc update

Thu, Jun 20, 8:08 AM · efl
bu5hm4n updated the diff for D9138: efl_ui_win: repair scene event emission.

rebase

Thu, Jun 20, 7:45 AM · efl
bu5hm4n updated the diff for D9135: efl_input_pointer: rename tool to touch_id.

also rename the enum

Thu, Jun 20, 6:50 AM · efl
bu5hm4n requested review of D9142: efl_input_device: split up has_pointer_cap.
Thu, Jun 20, 6:32 AM · efl
bu5hm4n added a child revision for D9141: efl_input_key: compose -> compose_string: D9142: efl_input_device: split up has_pointer_cap.
Thu, Jun 20, 6:32 AM · efl
bu5hm4n added a revision to T7963: Efl.Input.Pointer: D9142: efl_input_device: split up has_pointer_cap.
Thu, Jun 20, 6:32 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7968: Efl.Input.State as Resolved.

This is already stable.

Thu, Jun 20, 6:20 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7968: Efl.Input.State, a subtask of T7963: Efl.Input.Pointer, as Resolved.
Thu, Jun 20, 6:20 AM · efl (efl-1.23), efl: api
bu5hm4n closed T7968: Efl.Input.State, a subtask of T7964: Efl.Input.Key, as Resolved.
Thu, Jun 20, 6:20 AM · efl (efl-1.23), efl: api
bu5hm4n requested review of D9141: efl_input_key: compose -> compose_string.
Thu, Jun 20, 6:01 AM · efl
bu5hm4n added a revision to T7964: Efl.Input.Key: D9141: efl_input_key: compose -> compose_string.
Thu, Jun 20, 6:01 AM · efl (efl-1.23), efl: api
bu5hm4n added a comment to T7967: Efl.Input.Event.

There is no has_pointer_caps in efl_input_event ... ?

Thu, Jun 20, 5:39 AM · efl (efl-1.23), efl: api
bu5hm4n updated the diff for D9135: efl_input_pointer: rename tool to touch_id.

doc cop does doc cop things

Thu, Jun 20, 5:35 AM · efl
bu5hm4n abandoned D9132: efl_input_pointer: rename tool to touch_id.

phab transmitted it twice ... yey

Thu, Jun 20, 5:35 AM · efl
bu5hm4n abandoned D9133: efl_canvas_scene: we never provided a object as event type here.
Thu, Jun 20, 5:27 AM · efl
bu5hm4n abandoned D9134: evas: emit the corrent event here,.
Thu, Jun 20, 5:27 AM · efl
bu5hm4n accepted D9139: ci: use ccache also in the mingw cross build.
Thu, Jun 20, 5:03 AM · efl
bu5hm4n requested review of D9138: efl_ui_win: repair scene event emission.
Thu, Jun 20, 4:56 AM · efl