Page MenuHomePhabricator
Feed Advanced Search

Yesterday

felipealmeida added reviewers for D10432: eolian: (WIP) Add user keywords to methods: lauromoura, woohyun, segfaultxavi, q66.

This is a partial implementation, but shows how to use on the test. It is still specific to methods only on this diff. But I'll expand to other entities.

Wed, Oct 16, 5:21 PM · DO NOT MERGE, efl
felipealmeida requested review of D10432: eolian: (WIP) Add user keywords to methods.
Wed, Oct 16, 5:19 PM · DO NOT MERGE, efl
felipealmeida added a revision to T8294: eolian: Add a way to add custom information in eo files: D10432: eolian: (WIP) Add user keywords to methods.
Wed, Oct 16, 5:19 PM · Restricted Project

Tue, Oct 15

felipealmeida closed D10385: csharp: Add since documentation to struct and struct fields.
Tue, Oct 15, 12:03 PM · efl
felipealmeida accepted D10385: csharp: Add since documentation to struct and struct fields.
Tue, Oct 15, 12:03 PM · efl

Sat, Oct 12

felipealmeida requested review of D10385: csharp: Add since documentation to struct and struct fields.
Sat, Oct 12, 3:53 PM · efl
felipealmeida added a child revision for D10384: csharp: Add since documentation to Async methods: D10385: csharp: Add since documentation to struct and struct fields.
Sat, Oct 12, 3:53 PM · efl
felipealmeida added a revision to T8359: C#: Add since information to second class API citizens: D10385: csharp: Add since documentation to struct and struct fields.
Sat, Oct 12, 3:53 PM · efl: language bindings, efl: docs
felipealmeida updated the diff for D10384: csharp: Add since documentation to Async methods.

Add since documentation to Async methods

Sat, Oct 12, 3:53 PM · efl
felipealmeida requested review of D10384: csharp: Add since documentation to Async methods.
Sat, Oct 12, 3:41 PM · efl
felipealmeida added a revision to T8359: C#: Add since information to second class API citizens: D10384: csharp: Add since documentation to Async methods.
Sat, Oct 12, 3:41 PM · efl: language bindings, efl: docs
felipealmeida reopened T8359: C#: Add since information to second class API citizens as "Open".
Sat, Oct 12, 3:23 PM · efl: language bindings, efl: docs
felipealmeida closed T8359: C#: Add since information to second class API citizens as Resolved.
Sat, Oct 12, 3:23 PM · efl: language bindings, efl: docs
felipealmeida added a commit to T8359: C#: Add since information to second class API citizens: rEFL3358d9d475c3: csharp: Add since info to members related to events..
Sat, Oct 12, 3:23 PM · efl: language bindings, efl: docs
felipealmeida closed D10382: csharp: Add since info to members related to events..
Sat, Oct 12, 3:23 PM · efl: language bindings
felipealmeida closed D10381: eolian-cxx: Make events inherit beta info from klass..
Sat, Oct 12, 3:20 PM · efl
felipealmeida added a comment to D10380: eolian-cxx: Rename fields to standard naming.

Sorry. Forgot to accept it first. But I've tested and "accepted" it.

Sat, Oct 12, 2:37 PM · efl
felipealmeida closed D10380: eolian-cxx: Rename fields to standard naming.
Sat, Oct 12, 2:37 PM · efl
felipealmeida accepted D10381: eolian-cxx: Make events inherit beta info from klass..
Sat, Oct 12, 2:36 PM · efl

Tue, Oct 1

felipealmeida requested review of D10267: elementary: Add documentatio to efl_ui_layout_factory.eo.
Tue, Oct 1, 7:02 PM · efl

Mon, Sep 30

felipealmeida accepted D10260: csharp: Add missing since docs to a bunch of classes..
Mon, Sep 30, 8:06 PM · efl
felipealmeida closed D10252: mono_docs:adding and updating eina_binbuf.cs..
Mon, Sep 30, 7:18 PM · efl
felipealmeida closed D10251: mono-docs: adding and updating docs for eina_array..
Mon, Sep 30, 7:16 PM · efl
felipealmeida added a commit to T8293: C#: Document manual Eina bindings: rEFL465b049d5b6b: csharp: Document Eina.List.
Mon, Sep 30, 7:14 PM · Restricted Project, efl: language bindings
felipealmeida closed D10254: csharp: Document Eina.List.
Mon, Sep 30, 7:14 PM · efl
felipealmeida closed D10253: csharp: Allow improved cbs in eina comparators.
Mon, Sep 30, 7:12 PM · efl
felipealmeida added a commit to T8293: C#: Document manual Eina bindings: rEFL16e21c331472: csharp: Document Eina.Log.
Mon, Sep 30, 7:08 PM · Restricted Project, efl: language bindings
felipealmeida closed D10255: csharp: Document Eina.Log.
Mon, Sep 30, 7:08 PM · efl
felipealmeida added a commit to T8293: C#: Document manual Eina bindings: rEFL774bc7332055: csharp: Add since to Eina.Promise.
Mon, Sep 30, 7:07 PM · Restricted Project, efl: language bindings
felipealmeida closed D10256: csharp: Add since to Eina.Promise.
Mon, Sep 30, 7:07 PM · efl
felipealmeida accepted D10255: csharp: Document Eina.Log.
Mon, Sep 30, 7:02 PM · efl
felipealmeida requested review of D10258: csharp: Load library in permanent way for static members and not rely on leaks.
Mon, Sep 30, 6:57 PM · efl
felipealmeida accepted D10252: mono_docs:adding and updating eina_binbuf.cs..
Mon, Sep 30, 6:50 PM · efl
felipealmeida accepted D10253: csharp: Allow improved cbs in eina comparators.
Mon, Sep 30, 6:50 PM · efl
felipealmeida accepted D10254: csharp: Document Eina.List.
Mon, Sep 30, 6:49 PM · efl
felipealmeida accepted D10256: csharp: Add since to Eina.Promise.
Mon, Sep 30, 6:48 PM · efl

Sep 9 2019

felipealmeida requested review of D9888: Add PostUiDelegate and PostUiDelegateAsync methods to Efl.App.
Sep 9 2019, 1:52 PM · efl
felipealmeida requested review of D9887: CSharp: Cleanup test that inserts idle event and do not remove it.
Sep 9 2019, 1:50 PM · efl

Sep 4 2019

felipealmeida created T8203: Create manual binding for ecore_main_loop_thread_safe_call_async and ecore_main_loop_thread_safe_call_sync for C#.
Sep 4 2019, 3:26 PM

Sep 3 2019

felipealmeida added a comment to T7240: Not allow multi class inheritance in eo.

Still missing the check by C#

Sep 3 2019, 1:33 PM · efl: language bindings, Restricted Project

Aug 23 2019

felipealmeida closed D9638: csharp: add legacy eo in mono blacklist.
Aug 23 2019, 10:34 AM · efl
felipealmeida closed D9690: eolian-mono: Add support for partial classes.
Aug 23 2019, 10:28 AM · efl
felipealmeida closed D9714: csharp: Only build extension methods for beta.
Aug 23 2019, 10:27 AM · efl
felipealmeida closed T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono as Resolved by committing rEFLf3d9238e15ce: csharp: Add bindable factory parts support.
Aug 23 2019, 10:18 AM · efl: mvvm
felipealmeida closed T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono, a subtask of T7627: Support Efl.Ui.Item_Factory, as Resolved.
Aug 23 2019, 10:18 AM · efl: mvvm
felipealmeida closed D9653: csharp: Add bindable factory parts support.
Aug 23 2019, 10:18 AM · efl
felipealmeida accepted D9653: csharp: Add bindable factory parts support.
Aug 23 2019, 10:17 AM · efl
felipealmeida closed D9577: eolian-mono: Add support for multi-value properties with tuples.
Aug 23 2019, 10:08 AM · efl
felipealmeida accepted D9577: eolian-mono: Add support for multi-value properties with tuples.
Aug 23 2019, 10:07 AM · efl

Aug 21 2019

felipealmeida requested review of D9690: eolian-mono: Add support for partial classes.
Aug 21 2019, 12:11 PM · efl

Aug 19 2019

felipealmeida added a comment to D9577: eolian-mono: Add support for multi-value properties with tuples.

I'd really like @segfaultxavi opinion about the idea.

Aug 19 2019, 6:29 PM · efl
felipealmeida closed D9564: csharp: MVVM parts support.
Aug 19 2019, 6:07 PM · efl
felipealmeida added a comment to D9564: csharp: MVVM parts support.

arc patch didn't retrieve a different commit message

Aug 19 2019, 1:40 PM · efl

Aug 16 2019

felipealmeida requested review of D9588: eo-cxx: Add second NULL sentinel to avoid buffer overrun by efl_check.h.
Aug 16 2019, 11:16 AM · efl
felipealmeida added a comment to T8137: Heap use after free detected from ASAN in cxx bindings generator.

The D9576 also fixes one problem with ASAN when building. For me when both patches are applied no issues appear in ASAN. Can you check that D9576 fixes the building ASAN issue? I"ll check the test one, I forgot to test it when fixing the normal build.

Aug 16 2019, 6:17 AM

Aug 15 2019

felipealmeida added a comment to T8093: Name conflict between class and property.

Env class has an env property. It is multi-valued, so it is not generating a problem for C# yet. But it may in the future.

Aug 15 2019, 5:08 PM · efl (efl-1.24), efl: api, efl: language bindings
felipealmeida requested review of D9577: eolian-mono: Add support for multi-value properties with tuples.
Aug 15 2019, 5:04 PM · efl
felipealmeida requested review of D9576: eolian-mono: Use correct allocator to free with free, and not delete.
Aug 15 2019, 1:48 PM · efl
felipealmeida requested review of D9575: eolian-cxx: Fix use after free for base variable.
Aug 15 2019, 1:47 PM · efl
felipealmeida claimed T8137: Heap use after free detected from ASAN in cxx bindings generator.
Aug 15 2019, 1:19 PM

Aug 14 2019

felipealmeida added a comment to T8048: eolian_mono: setters returning complex values should not be mapped to properties.

The property could still be generated, but only with get;

Aug 14 2019, 10:15 AM · Restricted Project, efl: language bindings
felipealmeida added a comment to T8133: C#: Support multi-value properties.

Also, we can use property names in tuples, so users can set by property name instead of using ordering.

Aug 14 2019, 10:11 AM
felipealmeida claimed T8048: eolian_mono: setters returning complex values should not be mapped to properties.
Aug 14 2019, 9:59 AM · Restricted Project, efl: language bindings

Aug 13 2019

felipealmeida added a comment to D9510: eolian: Add @static to classes.

@bu5hm4n indeed.

Aug 13 2019, 6:52 PM · efl

Aug 11 2019

felipealmeida accepted D9529: elementary: add tests for the efl_part support of efl_ui_property_bind..
Aug 11 2019, 5:51 PM · efl
felipealmeida accepted D9527: elementary: add support for widget part property bind..
Aug 11 2019, 5:51 PM · efl
felipealmeida accepted D9528: elementary: add support for efl_ui_property_bind to all efl_part inheriting from widget using reflection..

OK. This is what we needed to modify factories.

Aug 11 2019, 5:51 PM · efl

Aug 8 2019

felipealmeida added a comment to T7675: Do not allow static-function polymorphism.

I'll let other people chime in. If nobody else opposes, then IMO you can go ahead and reinclude it. If that happens, then we need a solution for T8118 first, IMO.

Aug 8 2019, 2:47 PM · BBQ, efl: data types, Restricted Project
felipealmeida updated subscribers of T7675: Do not allow static-function polymorphism.

By size I mean typing more. I'm not against it per se, but for static use it doesn't look like a good tradeoff to me. This is going to uglify bindings and I don't really see much of a difference in change the name of the method or pass a different type. It actually creates one more point for error, where people can pass wrong classes, they can't when the class is embed in the function name.

Aug 8 2019, 2:26 PM · BBQ, efl: data types, Restricted Project
felipealmeida added a comment to T7675: Do not allow static-function polymorphism.

About factories: what is the difference between:

Aug 8 2019, 12:35 PM · BBQ, efl: data types, Restricted Project
felipealmeida added a comment to T7675: Do not allow static-function polymorphism.

Do we have a use case? Features are nice, but I think they must be justifiable.

Aug 8 2019, 12:32 PM · BBQ, efl: data types, Restricted Project

Aug 7 2019

felipealmeida closed D9524: cxx: Fix funcptr c_args declaration..
Aug 7 2019, 12:16 PM · efl
felipealmeida accepted D9524: cxx: Fix funcptr c_args declaration..
Aug 7 2019, 10:51 AM · efl

Aug 5 2019

felipealmeida closed D9457: csharp: fix ownership of value types in arrays and lists.
Aug 5 2019, 3:30 PM · efl
felipealmeida accepted D9457: csharp: fix ownership of value types in arrays and lists.
Aug 5 2019, 3:29 PM · efl
felipealmeida closed D9467: csharp: re-enable binbuf tests with -Dmono-beta=false.
Aug 5 2019, 3:10 PM · efl
felipealmeida requested review of D9510: eolian: Add @static to classes.
Aug 5 2019, 1:23 PM · efl

Jul 31 2019

felipealmeida added a comment to D9445: efl_ui_position_manager: move from accessor to function callback.

C++ patches are pushed

Jul 31 2019, 3:13 PM · efl
felipealmeida closed D9469: eolian-cxx: Add special type tags to make function_wrapper specializations unique.
Jul 31 2019, 3:12 PM · efl
felipealmeida closed D9468: eolian-cxx: Generate eot files.
Jul 31 2019, 3:12 PM · efl
felipealmeida added a comment to D9445: efl_ui_position_manager: move from accessor to function callback.

D9469 e D9468 are needed to fix the C++ binding bugs which this patch reproduces

Jul 31 2019, 12:41 PM · efl
felipealmeida requested review of D9469: eolian-cxx: Add special type tags to make function_wrapper specializations unique.
Jul 31 2019, 12:39 PM · efl
felipealmeida requested review of D9468: eolian-cxx: Generate eot files.
Jul 31 2019, 12:39 PM · efl

Jul 25 2019

felipealmeida requested review of D9412: eolian-cxx: Add binbuf and event keywords handling n.
Jul 25 2019, 1:40 PM · efl

Jul 23 2019

felipealmeida added a comment to D9369: eolian: start to express ownership transfere.

Well, a clang frontend plugin could guarantee that EFL_TRANSFER_OWNERSHIP is written in all EFL where it should.

Jul 23 2019, 7:32 AM · efl
felipealmeida added a comment to D9369: eolian: start to express ownership transfere.

Without typing checking, how useful it really is? Can't we make it type-checked? Even if by use of extension for a single compiler?

Jul 23 2019, 7:30 AM · efl

Jul 22 2019

felipealmeida requested review of D9377: efl-js: Remove private keys for Twitter API from example.
Jul 22 2019, 6:17 PM · efl

Jul 17 2019

felipealmeida added inline comments to D9350: eo: Improve documentation of internal _efl_add_internal_start_external_constructor.
Jul 17 2019, 11:20 PM · efl
felipealmeida requested review of D9350: eo: Improve documentation of internal _efl_add_internal_start_external_constructor.
Jul 17 2019, 6:27 PM · efl
felipealmeida added a comment to T8056: Improve/Fix _add_internal_start_bindings function docs and behavior.

and https://phab.enlightenment.org/D9071

Jul 17 2019, 1:30 PM
felipealmeida added a comment to T8056: Improve/Fix _add_internal_start_bindings function docs and behavior.

This task is related to https://phab.enlightenment.org/D9070

Jul 17 2019, 1:21 PM

Apr 23 2019

felipealmeida added a comment to D8678: eo: add events to track the ownership status of an Eo object.

We can avoid the performance problems by creating a boolean if someone is registered in the event. The event won't get called most of the time because most objects have a parent anyway and the event gets called just for objects with C# wrappers.

Apr 23 2019, 5:01 PM · efl

Apr 15 2019

felipealmeida added a comment to T7800: C#: Attach wrapper lifetime to the Eo instance.

So we looked into the problems of finalizers and dispose and we found out that using that is not possible. It is possible the GC collects members of a class that we decide later to ressucitate. That surely wouldn't work, because the members would not have the same state when the class is revived.

Apr 15 2019, 3:03 PM · efl: language bindings

Apr 9 2019

felipealmeida accepted D8588: csharp: Fix GetUserMethods and NativeClass.
Apr 9 2019, 5:13 PM · efl
felipealmeida closed D8579: efl-mono: Make override of methods only for methods that are defined by the user.
Apr 9 2019, 7:24 AM · efl
felipealmeida updated the diff for D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.

Remove test that is not working

Apr 9 2019, 7:14 AM · efl
felipealmeida closed D8573: efl-mono: Fix --enable-mono-beta for tests.
Apr 9 2019, 7:09 AM · efl

Apr 8 2019

felipealmeida requested review of D8579: efl-mono: Make override of methods only for methods that are defined by the user.
Apr 8 2019, 3:49 PM · efl
felipealmeida updated the diff for D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.

Do not register Efl.Object again and again

Apr 8 2019, 12:48 PM · efl
felipealmeida updated the diff for D8573: efl-mono: Fix --enable-mono-beta for tests.

Fix to use += instead of = in ifdef

Apr 8 2019, 12:47 PM · efl