Page MenuHomePhabricator
Feed Advanced Search

Apr 23 2019

felipealmeida added a comment to D8678: eo: add events to track the ownership status of an Eo object.

We can avoid the performance problems by creating a boolean if someone is registered in the event. The event won't get called most of the time because most objects have a parent anyway and the event gets called just for objects with C# wrappers.

Apr 23 2019, 5:01 PM · efl

Apr 15 2019

felipealmeida added a comment to T7800: C#: Attach wrapper lifetime to the Eo instance.

So we looked into the problems of finalizers and dispose and we found out that using that is not possible. It is possible the GC collects members of a class that we decide later to ressucitate. That surely wouldn't work, because the members would not have the same state when the class is revived.

Apr 15 2019, 3:03 PM · efl: language bindings

Apr 9 2019

felipealmeida accepted D8588: csharp: Fix GetUserMethods and NativeClass.
Apr 9 2019, 5:13 PM · efl
felipealmeida closed D8579: efl-mono: Make override of methods only for methods that are defined by the user.
Apr 9 2019, 7:24 AM · efl
felipealmeida updated the diff for D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.

Remove test that is not working

Apr 9 2019, 7:14 AM · efl
felipealmeida closed D8573: efl-mono: Fix --enable-mono-beta for tests.
Apr 9 2019, 7:09 AM · efl

Apr 8 2019

felipealmeida requested review of D8579: efl-mono: Make override of methods only for methods that are defined by the user.
Apr 8 2019, 3:49 PM · efl
felipealmeida updated the diff for D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.

Do not register Efl.Object again and again

Apr 8 2019, 12:48 PM · efl
felipealmeida updated the diff for D8573: efl-mono: Fix --enable-mono-beta for tests.

Fix to use += instead of = in ifdef

Apr 8 2019, 12:47 PM · efl

Apr 7 2019

felipealmeida added a comment to T7773: Unhandled Exception with custom widget class.

D8574

Apr 7 2019, 8:22 AM
felipealmeida requested review of D8575: efl-mono: Fix example for new Application API for C#.
Apr 7 2019, 8:22 AM · efl
felipealmeida requested review of D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.
Apr 7 2019, 8:21 AM · efl
felipealmeida added a revision to T7783: improve CI usage: D8574: efl-mono: Add test and fix problem with private dynamic types passed as parameters.
Apr 7 2019, 8:21 AM · Restricted Project, efl: meson
felipealmeida requested review of D8573: efl-mono: Fix --enable-mono-beta for tests.
Apr 7 2019, 8:21 AM · efl
felipealmeida added a comment to T7773: Unhandled Exception with custom widget class.

I agree with @segfaultxavi and @bu5hm4n .

Apr 7 2019, 6:49 AM

Mar 22 2019

felipealmeida accepted D8441: efl-csharp: Remove spaces from type strings in generator..
Mar 22 2019, 2:32 PM · efl

Mar 18 2019

felipealmeida added a comment to T7659: Fix efl_part issues in C#.

@segfaultxavi You're right on both questions.

Mar 18 2019, 2:36 PM · efl: mvvm

Mar 17 2019

felipealmeida requested review of D8384: efl-mono: Add Remove method to list, arrays and eina_value containers. T7401.
Mar 17 2019, 5:00 PM · efl

Mar 6 2019

felipealmeida abandoned D7857: eo: Fix efl_isa for class checking of recursively inherited types.
Mar 6 2019, 12:42 PM · DO NOT MERGE, efl

Feb 28 2019

felipealmeida added a reviewer for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories: SanghyeonLee.
Feb 28 2019, 5:28 PM · DO NOT MERGE, efl
felipealmeida added a project to D8080: efl-mono: Add Model manual implementation to C# and MVVM factories: DO NOT MERGE.
Feb 28 2019, 5:27 PM · DO NOT MERGE, efl
felipealmeida added reviewers for D8080: efl-mono: Add Model manual implementation to C# and MVVM factories: cedric, lauromoura, bu5hm4n, zmike.
Feb 28 2019, 5:27 PM · DO NOT MERGE, efl
felipealmeida requested review of D8080: efl-mono: Add Model manual implementation to C# and MVVM factories.
Feb 28 2019, 5:24 PM · DO NOT MERGE, efl

Feb 1 2019

felipealmeida added a comment to D7860: eo: fix efl_isa to work propertly with interfaces.

I'd never think that the class vtable contains the object's vtable. I thought the klass vtable would contain only the vtable for Efl_Class and Efl_Object methods.

Feb 1 2019, 3:45 AM · efl
felipealmeida requested review of D7858: efl-cxx: Fix compilation error when using a ptr to const any_value.
Feb 1 2019, 12:15 AM · efl

Jan 31 2019

felipealmeida requested review of D7857: eo: Fix efl_isa for class checking of recursively inherited types.
Jan 31 2019, 11:23 PM · DO NOT MERGE, efl
felipealmeida added a comment to D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

Going to add _append, _prepend (for cases without an anchoring child, so beggining and end) and _insert_at for index. Going to do that after I come back to Brazil next week.

Jan 31 2019, 1:31 AM · efl

Jan 27 2019

felipealmeida closed D7794: eolian-cxx: Add constructor_def.
Jan 27 2019, 11:23 PM · efl
felipealmeida closed D7793: elementary: Declare style as a Widget constructor.
Jan 27 2019, 11:19 PM · efl
felipealmeida accepted D7793: elementary: Declare style as a Widget constructor.
Jan 27 2019, 11:19 PM · efl
felipealmeida closed D7792: eo: Replace ptr(Eina.Strbuf) with plain strbuf..
Jan 27 2019, 11:15 PM · efl
felipealmeida accepted D7794: eolian-cxx: Add constructor_def.
Jan 27 2019, 11:10 PM · efl
felipealmeida accepted D7792: eo: Replace ptr(Eina.Strbuf) with plain strbuf..
Jan 27 2019, 11:08 PM · efl
felipealmeida added a comment to D7789: eolian-mono: Provide constructor parameters based on the constructors section of the Eo files..

I've updated examples.git with new syntax from this diff.

Jan 27 2019, 11:05 PM · efl
felipealmeida closed D7780: efl_ui_list_view_seg_array: remove seg_array from Elementary.h.
Jan 27 2019, 10:45 PM · efl
felipealmeida accepted D7780: efl_ui_list_view_seg_array: remove seg_array from Elementary.h.
Jan 27 2019, 10:39 PM · efl
felipealmeida requested review of D7789: eolian-mono: Provide constructor parameters based on the constructors section of the Eo files..
Jan 27 2019, 7:47 AM · efl

Jan 25 2019

felipealmeida requested review of D7770: efl-mono: Add new dependencies to autotools.
Jan 25 2019, 12:38 AM · efl

Jan 24 2019

felipealmeida closed D7724: efl_ui_list_view: Hide SegArray and PreciseLayouter.
Jan 24 2019, 5:30 AM · efl
felipealmeida accepted D7724: efl_ui_list_view: Hide SegArray and PreciseLayouter.
Jan 24 2019, 5:29 AM · efl

Jan 21 2019

felipealmeida added a comment to T7523: eolian inlist-inarray.

inlists should allow any value-type, not just structs.

Jan 21 2019, 5:13 AM · efl: language bindings, Restricted Project

Jan 18 2019

felipealmeida closed D7683: efl-mono: Fix calling non-static methods with garbage collectable NativeInherits.
Jan 18 2019, 5:06 AM · efl
felipealmeida requested review of D7683: efl-mono: Fix calling non-static methods with garbage collectable NativeInherits.
Jan 18 2019, 1:37 AM · efl

Jan 17 2019

felipealmeida closed D7675: efl-mono: Fix lots of warnings in tests.
Jan 17 2019, 5:46 AM · efl
felipealmeida closed D7633: eolian-cxx: Fix order of initialization.
Jan 17 2019, 5:45 AM · efl
felipealmeida added a commit to T7240: Not allow multi class inheritance in eo: rEFL8e487069c970: eolian: add api to access the requires field.
Jan 17 2019, 5:23 AM · efl: language bindings, Restricted Project
felipealmeida closed D7674: eolian: add api to access the requires field.
Jan 17 2019, 5:23 AM · efl
felipealmeida accepted D7674: eolian: add api to access the requires field.
Jan 17 2019, 5:22 AM · efl
felipealmeida closed D7637: efl-mono: Enable selecting to build @beta items.
Jan 17 2019, 4:52 AM · efl
felipealmeida closed D7636: eolian-mono: Add interface registration to inherited classes.
Jan 17 2019, 4:42 AM · efl
felipealmeida closed D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces.
Jan 17 2019, 4:41 AM · efl
felipealmeida closed D7634: efl-mono: Add proper test for interface inheritance.
Jan 17 2019, 4:41 AM · efl
felipealmeida added a comment to D7674: eolian: add api to access the requires field.

This seems to be more than just an API to get the requires?

Jan 17 2019, 3:35 AM · efl
felipealmeida added a comment to D7633: eolian-cxx: Fix order of initialization.

D7675 is the other commit now

Jan 17 2019, 3:32 AM · efl
felipealmeida requested review of D7675: efl-mono: Fix lots of warnings in tests.
Jan 17 2019, 3:32 AM · efl
felipealmeida updated the diff for D7633: eolian-cxx: Fix order of initialization.

Updating to have just one single commit

Jan 17 2019, 3:31 AM · efl
felipealmeida added a comment to D7633: eolian-cxx: Fix order of initialization.

I've tried but didn't work for me.

Jan 17 2019, 3:26 AM · efl
felipealmeida added a comment to D7633: eolian-cxx: Fix order of initialization.

This is what happens when you arc diff multiple commits :-(

Jan 17 2019, 3:24 AM · efl
felipealmeida added a comment to T7240: Not allow multi class inheritance in eo.

thanks

Jan 17 2019, 3:16 AM · efl: language bindings, Restricted Project
felipealmeida added a comment to T7240: Not allow multi class inheritance in eo.

OK, then a way to extract that information from Eolian would be necessary.

Jan 17 2019, 3:03 AM · efl: language bindings, Restricted Project
felipealmeida added a comment to T7240: Not allow multi class inheritance in eo.

Maybe, or Eo could enforce this too.

Jan 17 2019, 2:56 AM · efl: language bindings, Restricted Project
felipealmeida added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

In eolian, but it is not in Eo, so the C# class will not be enforced by this.

Jan 17 2019, 2:55 AM · efl: language bindings, Restricted Project
felipealmeida added a comment to T7240: Not allow multi class inheritance in eo.

@bu5hm4n I think he is mentioning that if a C# programmer implements a mixin, then the regular class will not appear in its class's hierarchy. However, the user should inherit from the regular class (or some derived class) since the mixin requires it.

Jan 17 2019, 2:54 AM · efl: language bindings, Restricted Project
felipealmeida added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

Shouldn't the user that will be inheriting from the mixin also inherit from the same regular class? It is not tested, but we could add a runtime test. This needs documentation, however.

Jan 17 2019, 2:52 AM · efl: language bindings, Restricted Project

Jan 16 2019

felipealmeida accepted D7556: efl_mono: move Eina.Error.Init() to a static constructor.
Jan 16 2019, 3:21 AM · efl
felipealmeida accepted D7555: efl_mono: move Eina.Log.Init to class consturctor.
Jan 16 2019, 3:20 AM · efl

Jan 15 2019

felipealmeida added a comment to T7498: C#: Add build option to control generation of @beta items..

It was half-finished in @lauromoura branch. I've finished and created the D7637.

Jan 15 2019, 8:30 PM · efl: language bindings
felipealmeida requested review of D7637: efl-mono: Enable selecting to build @beta items.
Jan 15 2019, 8:29 PM · efl
felipealmeida requested review of D7636: eolian-mono: Add interface registration to inherited classes.
Jan 15 2019, 8:00 PM · efl
felipealmeida added a comment to T7526: C#: Create interface-aware inherited C# classes (with reflection help).

This gets fixed with D7634, D7635, D7636

Jan 15 2019, 7:57 PM · efl: mvvm, efl: language bindings
felipealmeida added a parent revision for D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces: D7634: efl-mono: Add proper test for interface inheritance.
Jan 15 2019, 7:56 PM · efl
felipealmeida added a child revision for D7634: efl-mono: Add proper test for interface inheritance: D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces.
Jan 15 2019, 7:56 PM · efl
felipealmeida requested review of D7636: eolian-mono: Add interface registration to inherited classes.
Jan 15 2019, 7:55 PM · efl
felipealmeida added a child revision for D7634: efl-mono: Add proper test for interface inheritance: D7636: eolian-mono: Add interface registration to inherited classes.
Jan 15 2019, 7:55 PM · efl
felipealmeida added a child revision for D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces: D7636: eolian-mono: Add interface registration to inherited classes.
Jan 15 2019, 7:55 PM · efl
felipealmeida requested review of D7635: eolian_mono: fix inheriting from efl types not considering additional interfaces.
Jan 15 2019, 7:52 PM · efl
felipealmeida requested review of D7634: efl-mono: Add proper test for interface inheritance.
Jan 15 2019, 7:50 PM · efl
felipealmeida requested review of D7633: eolian-cxx: Fix order of initialization.
Jan 15 2019, 7:37 PM · efl
felipealmeida closed D7613: efl-mono: Remove trailings from template file.
Jan 15 2019, 7:02 PM · efl
felipealmeida updated subscribers of T7526: C#: Create interface-aware inherited C# classes (with reflection help).
Jan 15 2019, 6:15 PM · efl: mvvm, efl: language bindings
felipealmeida added a comment to T7526: C#: Create interface-aware inherited C# classes (with reflection help).

Please review branch devs/felipealmeida/interface_inherit

Jan 15 2019, 6:14 PM · efl: mvvm, efl: language bindings

Jan 14 2019

felipealmeida added a comment to T7366: Evaluate work needed to fix EO classes inheriting from more than one regular class or abstract.

C# binding is not suppose to be doing that. It, AFAIR, just ignores regular classes in mixins.

Jan 14 2019, 1:35 AM · efl: language bindings, Restricted Project
felipealmeida updated the diff for D7615: efl-mono: Include EinaTestData.cs and StructHelpers.cs that is missing from test.

trying again...

Jan 14 2019, 1:26 AM · efl
felipealmeida updated the diff for D7615: efl-mono: Include EinaTestData.cs and StructHelpers.cs that is missing from test.

fixing diff

Jan 14 2019, 1:18 AM · efl
felipealmeida updated the diff for D7613: efl-mono: Remove trailings from template file.

fixing what I screwed up

Jan 14 2019, 1:16 AM · efl
felipealmeida added a comment to D7613: efl-mono: Remove trailings from template file.

oh my god!

Jan 14 2019, 1:14 AM · efl
felipealmeida updated the diff for D7613: efl-mono: Remove trailings from template file.

well, somehow everything got included

Jan 14 2019, 1:13 AM · efl
felipealmeida requested review of D7615: efl-mono: Include EinaTestData.cs and StructHelpers.cs that is missing from test.
Jan 14 2019, 1:01 AM · efl

Jan 13 2019

felipealmeida closed T7525: C#: Fix marshalling of structs with complex types as Resolved.

This is fixed by ede219c453 in D7539.

Jan 13 2019, 11:38 PM · efl: mvvm, efl: language bindings
felipealmeida added a comment to T7525: C#: Fix marshalling of structs with complex types.

This is fixed by ede219c453 in D7539.

Jan 13 2019, 11:38 PM · efl: mvvm, efl: language bindings
felipealmeida added a comment to T7487: efl-mono: Remove initializer methods and add constructor parameters.

@lauromoura is going to test this hypothesis in his branch

Jan 13 2019, 11:36 PM · efl: language bindings
felipealmeida added a comment to T7487: efl-mono: Remove initializer methods and add constructor parameters.

The only thing missing is the optional parameters.
I think we can use Nullable<T> for non-object types and for object types the only options are always going to be null for default values, or no default-value. So we can fix null as being a default and that's it. I don't think we need default-values.

Jan 13 2019, 11:36 PM · efl: language bindings
felipealmeida closed D7539: efl-mono: Fix marshalling of struct in event data..
Jan 13 2019, 11:23 PM · efl
felipealmeida closed D7538: efl-mono: Share test data among other files..
Jan 13 2019, 11:21 PM · efl
felipealmeida updated the diff for D7538: efl-mono: Share test data among other files..

rebased

Jan 13 2019, 11:20 PM · efl
felipealmeida updated the diff for D6895: eolian-cxx: Add dummy -S parameter to be compatible with eolian variable in pkgconfig.

Added description in commit

Jan 13 2019, 11:11 PM · efl
felipealmeida added a comment to D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

I like the way it is.

Jan 13 2019, 11:01 PM · efl
felipealmeida closed D7597: efl_mono: remove '_' from type for C# naming convention.
Jan 13 2019, 10:41 PM · efl
felipealmeida accepted D7597: efl_mono: remove '_' from type for C# naming convention.
Jan 13 2019, 10:36 PM · efl
felipealmeida requested review of D7613: efl-mono: Remove trailings from template file.
Jan 13 2019, 3:04 PM · efl