Page MenuHomePhabricator
Feed Advanced Search

Tue, May 14

ali.alzyod updated the test plan for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.
Tue, May 14, 11:09 PM · efl
ali.alzyod updated the diff for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.

update test cases, and Fix searching UTF8 instead on unicode

Tue, May 14, 11:04 PM · efl

Thu, May 9

ali.alzyod added a comment to T7849: efl.ui.text.

I always prefer general functions with Enums/flags for specific option
1- understanding SDK much simpler (specially from documentation)
2- adding features will never break comparability in future

Thu, May 9, 5:41 AM · efl: api, efl (efl-1.23), efl: language bindings
ali.alzyod added a comment to T7849: efl.ui.text.

I still think this property should be removed from Efl.Ui.Text, which should then only override the one in Efl.Text. Do you agree?
Yes I agree

Thu, May 9, 4:01 AM · efl: api, efl (efl-1.23), efl: language bindings
ali.alzyod added a comment to T7849: efl.ui.text.

@segfaultxavi I think Efl.Ui.Text.password_mode should be removed

Thu, May 9, 12:21 AM · efl: api, efl (efl-1.23), efl: language bindings

Wed, May 8

ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.

@segfaultxavi sorry I was away from computer, I think you already added the comment.
Thank you

Wed, May 8, 6:16 AM · efl
ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.

@bu5hm4n sure, should I add it directly there or inside sub task

Wed, May 8, 4:00 AM · efl
ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.

@woohyun @segfaultxavi
This is not related directly to this patch, but you can detect the issue here.

Wed, May 8, 3:35 AM · efl
ali.alzyod accepted D8856: efl_ui_text: make password mode work properly.
Wed, May 8, 2:50 AM · efl
ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.

patch seems fine to me

Wed, May 8, 2:32 AM · efl
ali.alzyod added a comment to D8856: efl_ui_text: make password mode work properly.
Wed, May 8, 2:20 AM · efl
ali.alzyod added inline comments to D8856: efl_ui_text: make password mode work properly.
Wed, May 8, 1:04 AM · efl
ali.alzyod added inline comments to D8856: efl_ui_text: make password mode work properly.
Wed, May 8, 12:23 AM · efl

Tue, May 7

ali.alzyod added a reviewer for D8843: evas_object_textblock: utf8_to_markup support all escapse chars: bu5hm4n.
Tue, May 7, 3:54 AM · efl
ali.alzyod updated the diff for D8843: evas_object_textblock: utf8_to_markup support all escapse chars.

update

Tue, May 7, 3:52 AM · efl
ali.alzyod added reviewers for D8843: evas_object_textblock: utf8_to_markup support all escapse chars: lauromoura, CHAN, woohyun.
Tue, May 7, 3:50 AM · efl
ali.alzyod requested review of D8843: evas_object_textblock: utf8_to_markup support all escapse chars.
Tue, May 7, 3:47 AM · efl
ali.alzyod added inline comments to D8803: evas_object_textblock: Fix binary search fail..
Tue, May 7, 1:55 AM · efl

Mon, May 6

This is a test notification, sent at Tue, May 7, 9:30 AM.
Mon, May 6, 11:30 PM
ali.alzyod added a comment to D8833: efl_ui_text: clear selection after cut.

@segfaultxavi
with keyboard there are additional processing for keydown (_key_down_cb), and maybe it some point it handle updating selection

Mon, May 6, 10:09 PM · efl
ali.alzyod closed D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.
Mon, May 6, 8:08 AM · efl

Sun, May 5

ali.alzyod added reviewers for D8833: efl_ui_text: clear selection after cut: woohyun, bowonryu.
Sun, May 5, 11:33 PM · efl
ali.alzyod added a comment to D8833: efl_ui_text: clear selection after cut.

Before

Sun, May 5, 11:32 PM · efl
ali.alzyod updated the test plan for D8833: efl_ui_text: clear selection after cut.
Sun, May 5, 11:31 PM · efl
ali.alzyod requested review of D8833: efl_ui_text: clear selection after cut.
Sun, May 5, 11:31 PM · efl

Sun, Apr 28

ali.alzyod added a comment to T6537: Efl.Text.Markup: Add <br> support to markup_set.

Please note that https://www.enlightenment.org/develop/tutorials/c/hello-world-gui.md still do not use (multi-line function)

Sun, Apr 28, 6:06 AM · efl (efl-1.23), efl: layout engine
ali.alzyod added a comment to T6537: Efl.Text.Markup: Add <br> support to markup_set.

Is this still an issue ? https://phab.enlightenment.org/D8391
Where multi-line support is disabled by default, if you enable it, it will work same as legacy

Sun, Apr 28, 4:30 AM · efl (efl-1.23), efl: layout engine

Apr 26 2019

ali.alzyod retitled D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer from Speed up setting text (check if same text is already set), fix setting same text pointer to elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.
Apr 26 2019, 9:44 AM · efl

Apr 25 2019

ali.alzyod closed D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 25 2019, 5:04 AM · efl

Apr 23 2019

ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.

fix code convention issues

Apr 23 2019, 9:52 AM · efl
ali.alzyod added a comment to D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

@raster is this what you want to do ?

Apr 23 2019, 8:47 AM · efl
ali.alzyod updated the diff for D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

save sd->text if text did not change

Apr 23 2019, 8:46 AM · efl

Apr 22 2019

ali.alzyod added a comment to D8603: Change Single Line Mode behaviour in Entry.

This is strange, Why efl_text_multiline_set(EINA_FALSE) break lines if it find <ps/> !!

Apr 22 2019, 7:04 AM · efl
ali.alzyod added inline comments to D8603: Change Single Line Mode behaviour in Entry.
Apr 22 2019, 3:51 AM · efl

Apr 21 2019

ali.alzyod added a comment to D8603: Change Single Line Mode behaviour in Entry.

@bu5hm4n sorry but what part exactly Needs Revision

Apr 21 2019, 4:37 AM · efl
ali.alzyod added a comment to D8603: Change Single Line Mode behaviour in Entry.

@bu5hm4n we were talking about this comment "If this textobject is not a legacy object then this will throw an error.", I reply that if you added TextBlock using evas_object_textblock_add then it is will construct it as EFL_CANVAS_TEXT_CLASS object, where efl_text_multiline_set is implemented.

Apr 21 2019, 3:06 AM · efl
ali.alzyod added a comment to D8603: Change Single Line Mode behaviour in Entry.

I though you had an error, Will text block added with evas_text_block_add is actually is EFL_CANVAS_TEXT_CLASS object

Apr 21 2019, 1:59 AM · efl

Apr 20 2019

ali.alzyod added a comment to D8603: Change Single Line Mode behaviour in Entry.

@bu5hm4n what is the error you got ?

Apr 20 2019, 10:41 PM · efl

Apr 18 2019

ali.alzyod added a comment to D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

Ok I see, I think we can move all the sd->text free before done label, because it is initialize only in entry_text_get function.
I will do a test that it did not called and move it, or save it in local var and free it.

Apr 18 2019, 11:40 AM · efl
ali.alzyod added a comment to D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

@raster if I understand your comment well, I think the (sd->text) does not always have the entry text, specially if you append text in-front or back, so condition will be on "elm.text" part to ensure this is entry latest text

Apr 18 2019, 6:24 AM · efl
ali.alzyod added a comment to D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

developer should not do case 1 it is invalid, but it case he did it, we will help him :)

Apr 18 2019, 6:08 AM · efl
ali.alzyod updated the diff for D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

use goto label

Apr 18 2019, 6:06 AM · efl
ali.alzyod updated the diff for D8603: Change Single Line Mode behaviour in Entry.

Move logic to edje_entry

Apr 18 2019, 5:49 AM · efl
ali.alzyod added a comment to D8578: Freeing Global Memory list on destructor.

@raster again I am not against caching, caching is great.

Apr 18 2019, 3:38 AM · efl
ali.alzyod added a comment to D8578: Freeing Global Memory list on destructor.

Normally inside destructor you will check all data members for your object. (so you will not forget them), but for global maybe you did not know that you have global ones.

Apr 18 2019, 12:36 AM · efl
ali.alzyod updated the test plan for D8578: Freeing Global Memory list on destructor.
Apr 18 2019, 12:17 AM · efl
ali.alzyod added a comment to D8578: Freeing Global Memory list on destructor.

@bu5hm4n It is bad Idea because it lead to :
1- Hard to follow memory leaks,
2- With any updating to the code,There is high probability to accidentally forget about global vars ,(This case shows my point) (like this memory leak)

Apr 18 2019, 12:10 AM · efl
ali.alzyod added a comment to D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

It work if we are going to set text in "elm.text", else we do not care inside this function

Apr 18 2019, 12:07 AM · efl
ali.alzyod updated the diff for D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

add event thaw

Apr 18 2019, 12:05 AM · efl

Apr 17 2019

ali.alzyod updated the diff for D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

move code, and align with code convention

Apr 17 2019, 11:45 PM · efl
ali.alzyod closed D8578: Freeing Global Memory list on destructor.
Apr 17 2019, 11:33 PM · efl
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.

code convention

Apr 17 2019, 5:57 AM · efl
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.

follow EFL code convention for while/if statments

Apr 17 2019, 5:54 AM · efl
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 17 2019, 5:51 AM · efl
ali.alzyod added inline comments to D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 17 2019, 3:34 AM · efl
ali.alzyod added inline comments to D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 17 2019, 3:30 AM · efl
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.
  • fix typo in the comments
Apr 17 2019, 1:47 AM · efl
ali.alzyod added a comment to D8610: evas: change way of searching for Escape strings/values in textblock.

@segfaultxavi I already update them in Test Plan

Apr 17 2019, 1:32 AM · efl
ali.alzyod added a comment to T7788: Memory Leak efl_add.

Thanks for all the information

Apr 17 2019, 12:44 AM · enlightenment-git
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 17 2019, 12:05 AM · efl

Apr 16 2019

ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 16 2019, 11:58 PM · efl
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 16 2019, 11:57 PM · efl
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 16 2019, 11:48 PM · efl
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 16 2019, 11:47 PM · efl
ali.alzyod updated the test plan for D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 16 2019, 11:41 PM · efl
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.

-search common escapes first
-EFL coding conventions

Apr 16 2019, 11:40 PM · efl
ali.alzyod added a comment to D8610: evas: change way of searching for Escape strings/values in textblock.

@segfaultxavi I can update the code to get better results than old one for pure common escapes,
But still I think even if there are comment in the code that these are most common tags,this is not 100% true. (I mean that these are necessary the common ones), I can not find reference telling what are the most common one, for example this site show different list
https://www.impressivewebs.com/html-entity-reference-common/

Apr 16 2019, 11:55 AM · efl
ali.alzyod added a comment to T7788: Memory Leak efl_add.

I think it is make sense to reuse memory, instead of realloc

Apr 16 2019, 11:48 AM · enlightenment-git
ali.alzyod updated the diff for D8610: evas: change way of searching for Escape strings/values in textblock.
  • fix typo in the comments
Apr 16 2019, 10:02 AM · efl
ali.alzyod added a comment to D8610: evas: change way of searching for Escape strings/values in textblock.

Old Code
total time for escape_string is 2.370570
total time for common escape_string is 0.100057
total time for string_escape is 2.430365

Apr 16 2019, 9:53 AM · efl
ali.alzyod updated the test plan for D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 16 2019, 9:31 AM · efl
ali.alzyod added inline comments to D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 16 2019, 5:54 AM · efl
ali.alzyod added a comment to D8610: evas: change way of searching for Escape strings/values in textblock.

@segfaultxavi Yes I think we can skip first '&' and last ';' from checking, this will enhance performance more, but I suggest doing it in other patch.
because this required other changes for exposed function, where we need to handle & in begining of string before passing it to internal algorithm, also to trim last ; from string

Apr 16 2019, 5:16 AM · efl
ali.alzyod updated the test plan for D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 16 2019, 5:13 AM · efl
ali.alzyod added a comment to T7788: Memory Leak efl_add.
#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include<Eina.h>
#include<Efl.h>
#include <Elementary.h>
Apr 16 2019, 3:56 AM · enlightenment-git

Apr 15 2019

ali.alzyod updated the summary of D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 15 2019, 10:46 AM · efl
ali.alzyod added reviewers for D8610: evas: change way of searching for Escape strings/values in textblock: woohyun, bowonryu.
Apr 15 2019, 10:43 AM · efl
ali.alzyod updated the summary of D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 15 2019, 10:42 AM · efl
ali.alzyod updated the summary of D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 15 2019, 10:38 AM · efl
ali.alzyod requested review of D8610: evas: change way of searching for Escape strings/values in textblock.
Apr 15 2019, 10:32 AM · efl

Apr 14 2019

ali.alzyod updated the summary of D8603: Change Single Line Mode behaviour in Entry.
Apr 14 2019, 7:09 AM · efl
ali.alzyod added reviewers for D8603: Change Single Line Mode behaviour in Entry: bowonryu, woohyun.
Apr 14 2019, 6:41 AM · efl
ali.alzyod updated the summary of D8603: Change Single Line Mode behaviour in Entry.
Apr 14 2019, 6:40 AM · efl
ali.alzyod requested review of D8603: Change Single Line Mode behaviour in Entry.
Apr 14 2019, 6:36 AM · efl
ali.alzyod added a comment to T7788: Memory Leak efl_add.
#define EFL_EO_API_SUPPORT 1
#define EFL_BETA_API_SUPPORT 1
#include<Eina.h>
#include<Efl.h>
#include <Elementary.h>
Apr 14 2019, 5:42 AM · enlightenment-git
ali.alzyod added a comment to T7788: Memory Leak efl_add.

@raster Thank you for clear it out.

Apr 14 2019, 5:19 AM · enlightenment-git
ali.alzyod updated subscribers of T7788: Memory Leak efl_add.

@raster Can you please take look at this?

Apr 14 2019, 12:01 AM · enlightenment-git

Apr 11 2019

ali.alzyod added a comment to D8578: Freeing Global Memory list on destructor.

99% of the time, it is a bad idea to use global variables inside library

Apr 11 2019, 9:32 AM · efl

Apr 9 2019

ali.alzyod updated the test plan for D8578: Freeing Global Memory list on destructor.
Apr 9 2019, 8:22 AM · efl
ali.alzyod updated the diff for D8578: Freeing Global Memory list on destructor.

remove merged changes

Apr 9 2019, 8:17 AM · efl

Apr 8 2019

ali.alzyod added reviewers for D8578: Freeing Global Memory list on destructor: woohyun, bowonryu.
Apr 8 2019, 9:54 AM · efl
ali.alzyod updated the summary of D8578: Freeing Global Memory list on destructor.
Apr 8 2019, 9:53 AM · efl
ali.alzyod retitled D8578: Freeing Global Memory list on destructor from Speed up setting text (check if same text is already set), fix setting same text pointer to Freeing Global Memory list on destructor.
Apr 8 2019, 9:52 AM · efl
ali.alzyod requested review of D8578: Freeing Global Memory list on destructor.
Apr 8 2019, 9:50 AM · efl
ali.alzyod updated the task description for T7788: Memory Leak efl_add.
Apr 8 2019, 9:45 AM · enlightenment-git
Herald added a project to T7788: Memory Leak efl_add: enlightenment-git.
Apr 8 2019, 9:44 AM · enlightenment-git

Apr 7 2019

ali.alzyod updated the test plan for D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.
Apr 7 2019, 6:26 AM · efl
ali.alzyod added reviewers for D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer: bu5hm4n, zmike.
Apr 7 2019, 6:25 AM · efl
ali.alzyod added reviewers for D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer: woohyun, bowonryu.
Apr 7 2019, 6:24 AM · efl
ali.alzyod updated the summary of D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.
Apr 7 2019, 6:23 AM · efl