LGTM, thanks.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Oct 12 2019
Bug report, analysis, and fix are almost a year old ???
Jun 23 2019
No problem!
Jun 19 2019
Nov 27 2018
Nov 24 2017
Probably duplicate of T5282.
Mar 1 2016
Aug 6 2015
May 18 2015
Yep, although this one can just be fixed by someone with a commit bit.
May 15 2015
Apr 17 2015
So. The deadlock seems to be a leak on lock_non_0_ref. Every other caller is simply stacked behind RWLOCK on thq.lock_write, which is held by the thread in send -> msg_alloc.
Apr 13 2015
Thread 3 (Thread 809c06c00 (LWP 101243)): #0 0x000000080216bc69 in pthread_spin_trylock () from /lib/libthr.so.3 #1 0x00000008018dbd6d in eina_spinlock_take (spinlock=<optimized out>) at ../src/lib/eina/eina_inline_lock_posix.x:683 #2 eina_thread_queue_send (thq=<optimized out>, size=<optimized out>, allocref=0x7fffdfffdf58) at lib/eina/eina_thread_queue.c:385 #3 0x00000000004084e4 in th31_do (data=<optimized out>, th=<optimized out>) at tests/ecore/ecore_test_ecore_thread_eina_thread_queue.c:268 #4 0x0000000801d23a0b in _ecore_direct_worker (work=0x809ce4020) at lib/ecore/ecore_thread.c:424 #5 0x00000008018cdee2 in _eina_internal_call (context=0x809c3cb80) at lib/eina/eina_thread.c:109 #6 0x000000080216c6f4 in ?? () from /lib/libthr.so.3 #7 0x0000000000000000 in ?? () Backtrace stopped: Cannot access memory at address 0x7fffdfffe000
dude, please set your git config right... because of the lack of your correct git config it put me as the author of the commit. I forgot to check and now it's pushed. Fix it for your next revision
Apr 12 2015
Thanks!
Apr 9 2015
Apr 8 2015
Rebase against master, add new 3d SHADERS as well.
This is incomplete. I will update for master (adds shaders_3d) and invoke with bash specifically (uses non-sh features and shebang line specifies bash).
Instead, we dislike the lack of authorship. Your name gets lost. And this actually adds burden to us reviewers as we need to manually amend the commit to add your name. Otherwise git log will show patches that were authored by someone else under our name (not a huge deal, but it actually matters to some of us). Please configure git in your EFL/Elm/E repos:
Apr 7 2015
Missed the header definition — did not expect a function with underscore-prefix to be exposed outside of the CU. Fixed.
I appreciate your submission, and I would be grateful it if you could change your local configuration to add in the authorship info prior to updating this patch with it.
Are you kidding me? It's completely trivial and you can credit yourself if you like. This patch is released into the public domain or MIT-licensed if you live somewhere that the public domain doesn't exist.