Page MenuHomePhabricator
Feed Advanced Search

Thu, Oct 10

SanghyeonLee triaged T8329: Need to be stabilized mono classes. as High priority.
Thu, Oct 10, 4:58 AM
SanghyeonLee triaged T8327: Range Insfrastructures in Eina as Wishlist priority.
Thu, Oct 10, 3:04 AM
SanghyeonLee added a comment to T8312: elm_list_select_mode_set -> ELM_OBJECT_SELECT_MODE_ALWAYS issue/question.

... ELM_OBJECT_SELECT_MODE_ALWAYS : This means that, even if selected, every click will make the selected callbacks be called. ...

Thu, Oct 10, 2:29 AM · efl: widgets
SanghyeonLee added a comment to D10300: csharp: Add Efl.Model implementations to internal model.

code seems fine, but one question in inline.

Thu, Oct 10, 1:20 AM · efl
SanghyeonLee closed D10332: elm: fix legacy callback names..
Thu, Oct 10, 12:54 AM · efl

Wed, Oct 9

SanghyeonLee requested review of D10332: elm: fix legacy callback names..
Wed, Oct 9, 11:29 PM · efl

Thu, Sep 26

SanghyeonLee removed a project from T7871: efl.ui.multi_selectable: efl (efl-1.23).
Thu, Sep 26, 9:38 PM · efl: api, efl: language bindings
SanghyeonLee added a comment to D10215: efl_ui : stabilized Efl.Ui.List_Placeholder_Item.

oops. i'm late on this.

Thu, Sep 26, 9:07 PM · efl
SanghyeonLee requested review of D10215: efl_ui : stabilized Efl.Ui.List_Placeholder_Item.
Thu, Sep 26, 7:31 PM · efl
SanghyeonLee updated subscribers of D10191: efl_ui : stabilized Efl.Ui.Select_Model.

and for the notice,
me and @bu5hm4n agreed to keep multi_selectable and multi_selectable in beta,
while the selectable and single_selectale is stabilized.

Thu, Sep 26, 7:38 AM · efl
SanghyeonLee added a comment to D10190: efl_core : stabilized Efl.Boolean_Model.

hmm... I think boolean model is quite useful to userside, but still user can access boolean data by property get right?
if then it seems not serious problem in here,
at least we still have a moment to out of beta for this class in tizen side, only few weeks though.

Thu, Sep 26, 7:36 AM · efl
SanghyeonLee added a comment to D10189: efl_core : stabilized Efl.Generic_Model.

can you land it before we release it?
if we not release door shutdown till tomorrow I can do that.

Thu, Sep 26, 7:32 AM · efl
SanghyeonLee added a comment to D10191: efl_ui : stabilized Efl.Ui.Select_Model.

hmmm could be.
anyway we have change to make it public after released, so okay I agreed.

Thu, Sep 26, 7:31 AM · efl
SanghyeonLee added a comment to D10191: efl_ui : stabilized Efl.Ui.Select_Model.

it has same problem iterator<ptr(uint64)> stable error.

Thu, Sep 26, 4:54 AM · efl
SanghyeonLee requested review of D10191: efl_ui : stabilized Efl.Ui.Select_Model.
Thu, Sep 26, 4:53 AM · efl
SanghyeonLee added a child revision for D10190: efl_core : stabilized Efl.Boolean_Model: D10191: efl_ui : stabilized Efl.Ui.Select_Model.
Thu, Sep 26, 4:53 AM · efl
SanghyeonLee added a comment to D10190: efl_core : stabilized Efl.Boolean_Model.

is there any problem on iterator<ptr()>?
should we make this method @beta?

Thu, Sep 26, 4:52 AM · efl
SanghyeonLee added a comment to D10190: efl_core : stabilized Efl.Boolean_Model.

build failed by boolean_iterator_get

Thu, Sep 26, 4:51 AM · efl
SanghyeonLee requested review of D10190: efl_core : stabilized Efl.Boolean_Model.
Thu, Sep 26, 4:49 AM · efl
SanghyeonLee added a child revision for D10189: efl_core : stabilized Efl.Generic_Model: D10190: efl_core : stabilized Efl.Boolean_Model.
Thu, Sep 26, 4:49 AM · efl
SanghyeonLee requested review of D10189: efl_core : stabilized Efl.Generic_Model.
Thu, Sep 26, 4:47 AM · efl
SanghyeonLee added a child revision for D10188: efl_ui : stablized Efl.Ui.View: D10189: efl_core : stabilized Efl.Generic_Model.
Thu, Sep 26, 4:47 AM · efl
SanghyeonLee abandoned D9749: elementary: Initialize object position in widget_factory building.
Thu, Sep 26, 4:44 AM · efl
SanghyeonLee added a comment to D10188: efl_ui : stablized Efl.Ui.View.

@cedric
can you have a look and land it if its okay?
I will be offline when you online.

Thu, Sep 26, 4:37 AM · efl
SanghyeonLee added a project to T7480: Add multi factory class: efl: mvvm.
Thu, Sep 26, 4:36 AM · efl: mvvm, efl: data types, Restricted Project
SanghyeonLee added a comment to T7480: Add multi factory class.

we are not ready for this class yet but it seems we need this factory for supporting multi-style item yet without factory customize?
add tag mvvm for issue tracking

Thu, Sep 26, 4:36 AM · efl: mvvm, efl: data types, Restricted Project
SanghyeonLee added a comment to T8146: Enforce canvas hierarchy on Efl.Ui.Factory.

are we have any stuff regarding this?
are we need efl-1.23 tagging still in here?

Thu, Sep 26, 4:33 AM · efl (efl-1.23), efl: mvvm, efl: data types
SanghyeonLee removed a project from T8177: Collection_View Tracking ticket: efl (efl-1.23).
Thu, Sep 26, 4:31 AM · efl: mvvm
SanghyeonLee added a comment to T8177: Collection_View Tracking ticket.

I think we should keep this task for tracking mvvm related work after 1.23 released, so remove 1.23 tag as I see we finished all 1.23 related task on this.

Thu, Sep 26, 4:31 AM · efl: mvvm
SanghyeonLee added a comment to T8221: mvvm: users cannot use model property names that clash with EO properties.

yes... we should fix this or at least well-explain in document, though it looks very weird that "name" cannot be name of property :p

Thu, Sep 26, 4:30 AM · efl: mvvm
SanghyeonLee added a comment to T7659: Fix efl_part issues in C#.

it seems issue is solved now.

Thu, Sep 26, 4:28 AM · efl: mvvm
SanghyeonLee added a task to D10188: efl_ui : stablized Efl.Ui.View: T7578: efl.ui.view.
Thu, Sep 26, 4:26 AM · efl
SanghyeonLee added a revision to T7578: efl.ui.view: D10188: efl_ui : stablized Efl.Ui.View.
Thu, Sep 26, 4:26 AM · efl (efl-1.23), efl: api
SanghyeonLee requested review of D10188: efl_ui : stablized Efl.Ui.View.
Thu, Sep 26, 4:26 AM · efl
SanghyeonLee closed T8266: efl.ui.item_clickable as Resolved.

It seems done by D10173 D10181

Thu, Sep 26, 4:23 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee closed T8266: efl.ui.item_clickable, a subtask of T8261: efl.ui.collection_view, as Resolved.
Thu, Sep 26, 4:23 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee closed T8266: efl.ui.item_clickable, a subtask of T8096: efl.ui.collection, as Resolved.
Thu, Sep 26, 4:23 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee renamed T8266: efl.ui.item_clickable from efl.ui.collection_events to efl.ui.item_clickable.
Thu, Sep 26, 4:21 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee closed T7885: efl.ui.list_view, a subtask of T7510: evaluate stabilization potential of efl.ui classes and dependencies, as Resolved.
Thu, Sep 26, 4:20 AM · efl: api, efl (efl-1.23)
SanghyeonLee closed T7885: efl.ui.list_view as Resolved.

I think this task is closed by D10035

Thu, Sep 26, 4:20 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee closed T8261: efl.ui.collection_view as Resolved.
Thu, Sep 26, 4:19 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee closed T8261: efl.ui.collection_view, a subtask of T7885: efl.ui.list_view, as Resolved.
Thu, Sep 26, 4:19 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee added a comment to T8261: efl.ui.collection_view.

I think this task is closed by D10171

Thu, Sep 26, 4:19 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee added a comment to T8265: efl.ui.multi_selectable_async.

keep @beta in this released version same as T7871.

Thu, Sep 26, 4:19 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee added a comment to T7922: enum Efl.Ui.Select_Mode.

it is beta for this release version same as T7871
the mode itself is stable but it must comes with multi_selectable.

Thu, Sep 26, 4:18 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

reopen task as we decide to mark it beta in this release version.

Thu, Sep 26, 4:17 AM · efl: api, efl: language bindings
SanghyeonLee reopened T7871: efl.ui.multi_selectable as "Open".
Thu, Sep 26, 4:16 AM · efl: api, efl: language bindings
SanghyeonLee reopened T7871: efl.ui.multi_selectable, a subtask of T7870: efl.ui.grid, as Open.
Thu, Sep 26, 4:16 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee reopened T7871: efl.ui.multi_selectable, a subtask of T7881: efl.ui.list, as Open.
Thu, Sep 26, 4:16 AM · efl: api, efl (efl-1.23), efl: language bindings
SanghyeonLee updated the diff for D10184: efl: mark selectable stable.

mark select_mode and multi_selectable @beta.
basic selection is completed by single_selectable,
so will discuss more about multi selection after release done.

Thu, Sep 26, 3:36 AM · efl
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

after discussion on D10184 we decide to mark multi_selectable and multi_selectable_async as @beta for this release.

Thu, Sep 26, 3:28 AM · efl: api, efl: language bindings
SanghyeonLee added a comment to D10184: efl: mark selectable stable.

after have a look on multi_selectable_async..

Thu, Sep 26, 3:05 AM · efl
SanghyeonLee added a comment to D10184: efl: mark selectable stable.

I think this *should* stable for MVVM and other selected related widgets.

Thu, Sep 26, 2:43 AM · efl
SanghyeonLee added a commit to T7871: efl.ui.multi_selectable: rEFL1df17abba575: efl_ui_*selectable: unify these APIs with the same c_prefix.
Thu, Sep 26, 2:32 AM · efl: api, efl: language bindings
SanghyeonLee closed D10183: efl_ui_*selectable: unify these APIs with the same c_prefix.
Thu, Sep 26, 2:32 AM · efl
SanghyeonLee added a comment to D10184: efl: mark selectable stable.

that is strange as it is not adding @beta but removing beta...let me have a look.

Thu, Sep 26, 2:29 AM · efl
SanghyeonLee added reviewers for D10184: efl: mark selectable stable: SanghyeonLee, cedric, segfaultxavi, zmike.
Thu, Sep 26, 2:10 AM · efl
SanghyeonLee added a comment to D10184: efl: mark selectable stable.
NOTE: we should not forget to remove @beta on Efl.Ui.Multi_Selectable_Async after collection_view is stabled.
Thu, Sep 26, 2:10 AM · efl
SanghyeonLee updated subscribers of D10183: efl_ui_*selectable: unify these APIs with the same c_prefix.

I'm good with this,
but let me wait to get others opinion.
@segfaultxavi @cedric are we good with this?

Thu, Sep 26, 2:06 AM · efl
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

actually I think it would better to both of single_selectable and multi_selectable have common API,
like "efl_ui_selectable". is it strange? if it is strange then.. just make them be their own name is okay.

Thu, Sep 26, 12:52 AM · efl: api, efl: language bindings
SanghyeonLee abandoned D10180: efl_ui: renaming container selectable interface to selection..

drop it as the result of dicussion in T7871

Thu, Sep 26, 12:24 AM · efl
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

sorry for spping :p
okay than... stay current name I'll drop the patch
now only matter we take care is prefixes.

Thu, Sep 26, 12:23 AM · efl: api, efl: language bindings

Wed, Sep 25

SanghyeonLee updated the diff for D10180: efl_ui: renaming container selectable interface to selection..

update:

Wed, Sep 25, 10:14 PM · efl
SanghyeonLee requested review of D10181: efl_ui : add document comment on efl_ui_item_clickable event data.
Wed, Sep 25, 10:09 PM · efl
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

if we go
clickable
&
item_clickable,

Wed, Sep 25, 9:56 PM · efl: api, efl: language bindings
SanghyeonLee updated the diff for D10180: efl_ui: renaming container selectable interface to selection..

remove c_prefix.
it is on discussion in T7871
now build is passed.

Wed, Sep 25, 9:55 PM · efl
SanghyeonLee added a comment to D10173: elementary: stabilize Efl.Ui.Item_Clickable..

src/bindings/mono/efl_ui_item_clickable.eo.cs(502,15): error CS1591: Warning as Error: Missing XML comment for publicly visible type or member `Efl.Ui.ItemClickableClicked'
src/bindings/mono/efl_ui_item_clickable.eo.cs(506,24): error CS1591: Warning as Error: Missing XML comment for publicly visible type or member `Efl.Ui.ItemClickableClicked.Item'

Wed, Sep 25, 9:54 PM · efl
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

and... what about event name?
EFL_UI_EVENT_SELECT_CHANGED looks fine
but
EFL_UI_SINGLE_SELECTION_EVENT_SELECTION_CHANGED
looks not good..

Wed, Sep 25, 9:30 PM · efl: api, efl: language bindings
SanghyeonLee added a comment to D10180: efl_ui: renaming container selectable interface to selection..

build failed. need to check more.

Wed, Sep 25, 9:26 PM · efl
SanghyeonLee requested review of D10180: efl_ui: renaming container selectable interface to selection..
Wed, Sep 25, 9:22 PM · efl
SanghyeonLee added a comment to T7578: efl.ui.view.

agree!

Wed, Sep 25, 9:16 PM · efl (efl-1.23), efl: api
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

and single selection event name maybe?

Wed, Sep 25, 6:52 PM · efl: api, efl: language bindings
SanghyeonLee accepted D10175: elementary: rename Efl.Ui.Collection_Event to Efl.Ui.Item_Clickable.
Wed, Sep 25, 6:21 PM · efl
SanghyeonLee accepted D10171: elementary: stabilize Efl.Ui.Collection_View..
Wed, Sep 25, 6:21 PM · efl
SanghyeonLee abandoned D8024: efl_ui : renaming list_view sub classes..
Wed, Sep 25, 6:18 PM · efl
SanghyeonLee abandoned D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Wed, Sep 25, 6:17 PM · efl
SanghyeonLee abandoned D9201: efl_ui_item : redefine default_item on efl_ui_item from list_item and grid_item..
Wed, Sep 25, 6:16 PM · efl
SanghyeonLee accepted D10173: elementary: stabilize Efl.Ui.Item_Clickable..
Wed, Sep 25, 6:16 PM · efl
SanghyeonLee closed D10148: efl_ui : change selected_items_get to selected_iterator_new..
Wed, Sep 25, 12:14 PM · efl
SanghyeonLee added a comment to D9749: elementary: Initialize object position in widget_factory building.

seems we don't need this patch anymore as I tested in efl_ui_list_view_example_1
let me wait till tomorrow and no other comments, I'll drop it.

Wed, Sep 25, 3:59 AM · efl
SanghyeonLee added a comment to D10148: efl_ui : change selected_items_get to selected_iterator_new..

build checked.

Wed, Sep 25, 3:57 AM · efl
SanghyeonLee requested review of D10148: efl_ui : change selected_items_get to selected_iterator_new..
Wed, Sep 25, 3:57 AM · efl
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

oh that is the changed "Selectable" to "Selection" on Single and Multi actually.
but we should talk about prefix also.

Wed, Sep 25, 3:35 AM · efl: api, efl: language bindings
SanghyeonLee abandoned D9742: elementary: fix the size calculation on the collection view..
Wed, Sep 25, 2:07 AM · efl: widgets
SanghyeonLee closed D10145: efl_ui : put beta on range select/unselect as parameter unstable.
Wed, Sep 25, 2:06 AM · efl
SanghyeonLee closed D10144: efl_ui : reverse the select method name to be ended verb on the last..
Wed, Sep 25, 1:12 AM · efl
SanghyeonLee abandoned D9741: elementary: add document of Collection_View_Item_Event for mono build.

drop this patch as we already have collectionview in master.

Wed, Sep 25, 1:11 AM · efl
SanghyeonLee updated the diff for D10144: efl_ui : reverse the select method name to be ended verb on the last..

more. done.
build tested.

Wed, Sep 25, 1:10 AM · efl
SanghyeonLee requested review of D10144: efl_ui : reverse the select method name to be ended verb on the last..

yet there are remaining changes.

Wed, Sep 25, 1:04 AM · efl
SanghyeonLee added a comment to D9749: elementary: Initialize object position in widget_factory building.

not sure we still need this patch or not,
let me try without this patch and if it need I'll rebase the patch.

Wed, Sep 25, 1:00 AM · efl
SanghyeonLee added a comment to D10145: efl_ui : put beta on range select/unselect as parameter unstable.

yes. we don't know what Eina.Range will be yet,

Wed, Sep 25, 12:56 AM · efl
SanghyeonLee added a comment to D10145: efl_ui : put beta on range select/unselect as parameter unstable.

for the future usage of Eina_Range.
if Eina_Range comes,

Wed, Sep 25, 12:53 AM · efl
SanghyeonLee requested review of D10145: efl_ui : put beta on range select/unselect as parameter unstable.
Wed, Sep 25, 12:50 AM · efl
SanghyeonLee added a child revision for D10144: efl_ui : reverse the select method name to be ended verb on the last.: D10145: efl_ui : put beta on range select/unselect as parameter unstable.
Wed, Sep 25, 12:50 AM · efl
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

sorry for spamming reply,

Wed, Sep 25, 12:46 AM · efl: api, efl: language bindings
SanghyeonLee updated the diff for D10144: efl_ui : reverse the select method name to be ended verb on the last..

add missing changes.

Wed, Sep 25, 12:42 AM · efl
SanghyeonLee added reviewers for D10144: efl_ui : reverse the select method name to be ended verb on the last.: bu5hm4n, cedric, segfaultxavi.
Wed, Sep 25, 12:40 AM · efl
SanghyeonLee requested review of D10144: efl_ui : reverse the select method name to be ended verb on the last..
Wed, Sep 25, 12:39 AM · efl
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

what about unselect / deselect? we go for current one?
access using deselect, that is one worry that going unselect.

Wed, Sep 25, 12:30 AM · efl: api, efl: language bindings
SanghyeonLee added a comment to T7871: efl.ui.multi_selectable.

I would try to leave out Group as much as possible from the name, as Group is logically somehow orthogonal to Single ...

Wed, Sep 25, 12:28 AM · efl: api, efl: language bindings