Page MenuHomePhabricator
Feed Advanced Search

Yesterday

SanghyeonLee accepted D7650: eina: add Eina_Value helper that convert efficiently to a target native C type..

I think this macro looks nice work but seems @segfaultxavi again review once about it? I 'll leave the decision on you @cedric

Mon, Jan 21, 2:52 AM · efl

Fri, Jan 18

SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

today I discussed about this with @felipealmeida and I think we could have few doable candidates which is not exactly what we want.
I hope he will update those candidates till end of this week, so let's vote and decide the way what we go.

Fri, Jan 18, 3:30 AM · efl
SanghyeonLee accepted D7652: eina: fix memory leak when a Eina_Value as promise is returned, but no dispatching Eina_Future is listening on it..

looks good to me.

Fri, Jan 18, 3:26 AM · efl
SanghyeonLee accepted D7650: eina: add Eina_Value helper that convert efficiently to a target native C type..

if you have plan to update the patch with macro by @segfaultxavi's comment's I'll be waiting it.
the patch is buildable and test passed, all good so far.

Fri, Jan 18, 3:25 AM · efl
SanghyeonLee accepted D7649: eina: add tests for Eina_Value utility function eina_value_*_get..

I've checked test passed well. I think its ready to land.

Fri, Jan 18, 3:10 AM · efl
SanghyeonLee updated the diff for D7682: efl_ui_grid : apply relative size feature and row/column count..

fallback to IMAX size in original value

Fri, Jan 18, 1:08 AM · efl
SanghyeonLee added a comment to D7682: efl_ui_grid : apply relative size feature and row/column count..

Additionally,
while I making this features,
I need to use struct about row, column repeatly,
so I wonder that we could add some public structure about row and column like, Eina_Table, {int row, int col} what you guys think?

Fri, Jan 18, 1:07 AM · efl
SanghyeonLee updated the diff for D7682: efl_ui_grid : apply relative size feature and row/column count..

fix typos

Fri, Jan 18, 1:04 AM · efl
SanghyeonLee requested review of D7682: efl_ui_grid : apply relative size feature and row/column count..
Fri, Jan 18, 1:00 AM · efl

Thu, Jan 17

SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

yeah. I think that is make sense.
if we really make every thing to be an view,
the factory could generate the widget and so on.
I agreed.

Thu, Jan 17, 7:18 PM · efl

Wed, Jan 16

SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

yes as I mentioned,
it won't be fixed at all yet,
only I updated efl_ui_property.eo file.

Wed, Jan 16, 3:02 AM · efl

Tue, Jan 15

SanghyeonLee added inline comments to D7529: efl_ui : rename model connect and factory connect to bind property and factory..
Tue, Jan 15, 6:46 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

well about those thing,
we need more detail explain about @felipealmeida , so I'll request his comment when he come to the office :)
but felipe was on the side of not using dynamic class...
okay I stop to update the patch for now...
and let's get clear conclusion regarding this matter.

Tue, Jan 15, 6:25 PM · efl
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

hmm... yeah I agreed with that. so I'll update the patch with making it inherit from layout.

Tue, Jan 15, 6:16 PM · efl
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

Actually I thought that we might need to remove layout factory cause I cannot find any case of using it till now, but still you think it is necessary, I can go with your idea.
but we have to think about maintaining one more class which may not often used.... if you can find any use case, it should be left.

Tue, Jan 15, 5:40 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

we do this because,
factory.icon.bind_factory(imgf);
is unable with current list item factory design.

Tue, Jan 15, 5:33 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

can you check the efl_ui_property.eo?
about the factory,
we all know the purpose of factory bind, so it need to be called always these two API as the pair.
so why not making it one API?
porperty bind will be internally handled.

Tue, Jan 15, 5:30 PM · efl
SanghyeonLee updated the diff for D7529: efl_ui : rename model connect and factory connect to bind property and factory..

proposal interface eo.
the code is not working yet.
If property_bind_part is too ambigiuous, we can go with property_bind_text.

Tue, Jan 15, 5:27 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

and.. about

efl_ui_bind_property(imgf, "", "path"); //connect to "path" property
efl_ui_bind_factory(factory, "efl.icon", imgf);
Tue, Jan 15, 5:00 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

@cedric I know its same but we can have this specific function for explicit declaring on Efl.Part controls. so this will let user/widget both understand what action will happen by API calls.
if you not a fan of this idea, okay, I can drop it.

Tue, Jan 15, 4:54 PM · efl
SanghyeonLee updated the diff for D7529: efl_ui : rename model connect and factory connect to bind property and factory..

rebase the patch with resolving merge conflict.
this patch need to be fixed yet.

Tue, Jan 15, 4:42 PM · efl
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

and also need to fix few thing in the view... it still using layout terms and class so it need to be changed Efl.Ui.Item as I see.. will be updated soon.

Tue, Jan 15, 4:33 PM · efl
SanghyeonLee added a comment to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

@cedric that's true but I wonder we still need to maintain layout_factory or not. do we need it?
and also some style set and size calculation will be different, so I don't know we can solve this with calling efl_super...
layout factory may need to be fixed too then.

Tue, Jan 15, 4:15 PM · efl
SanghyeonLee updated the diff for D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..

rebasing patch

Tue, Jan 15, 4:12 PM · efl
SanghyeonLee added a comment to T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono.

yes it is duplication but I want to make an implementing task because efl_part discussion is little bit ambiguous about what we need to do.
this is talking about supporting overall bind feature in factory including eo and c#,
cause I think there are more extra helper necessary in c# level to using Efl.Part in bind functions.

Tue, Jan 15, 2:11 AM · efl: mvvm
SanghyeonLee added a task to D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view.: T7627: Support Efl.Ui.Item_Factory.
Tue, Jan 15, 2:07 AM · efl
SanghyeonLee added a revision to T7627: Support Efl.Ui.Item_Factory: D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Tue, Jan 15, 2:07 AM · efl: mvvm
SanghyeonLee added a comment to T7627: Support Efl.Ui.Item_Factory.

yes. 1,2 is already done and I updated it D7625.
3 is exactly same as efl_part task but only this T7627 is about real implementing task.

Tue, Jan 15, 2:06 AM · efl: mvvm
SanghyeonLee requested review of D7625: efl_ui : add item factory for using efl.ui.item on efl.ui.view..
Tue, Jan 15, 2:02 AM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

So this is interface about Properties on the model so how about,

Tue, Jan 15, 12:29 AM · efl

Mon, Jan 14

SanghyeonLee added a project to D7614: efl_ui : add dummy object for verificate factory class.: DO NOT MERGE.
Mon, Jan 14, 9:38 PM · DO NOT MERGE, efl
SanghyeonLee added a comment to D7614: efl_ui : add dummy object for verificate factory class..

I also agree that is best for us.
this patch is not intended to fix real problem but just shows how it could be the worst :p

Mon, Jan 14, 8:46 PM · DO NOT MERGE, efl
SanghyeonLee triaged T7628: Support Efl.Ui.Item_Factory Binding Features and static Efl.Part in mono as High priority.
Mon, Jan 14, 1:05 AM · efl: mvvm
SanghyeonLee added a project to T7627: Support Efl.Ui.Item_Factory: efl: mvvm.
Mon, Jan 14, 12:59 AM · efl: mvvm
SanghyeonLee triaged T7627: Support Efl.Ui.Item_Factory as High priority.
Mon, Jan 14, 12:59 AM · efl: mvvm
SanghyeonLee added reviewers for D7614: efl_ui : add dummy object for verificate factory class.: cedric, felipealmeida.
Mon, Jan 14, 12:29 AM · DO NOT MERGE, efl
SanghyeonLee requested review of D7614: efl_ui : add dummy object for verificate factory class..
Mon, Jan 14, 12:28 AM · DO NOT MERGE, efl

Fri, Jan 11

SanghyeonLee closed D7476: Efl.Ui.List_View: precise layout async.
Fri, Jan 11, 12:21 AM · efl
SanghyeonLee added a comment to D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

well...I think... , I like the way of having some default actions.
what I think is...

Fri, Jan 11, 12:19 AM · efl

Thu, Jan 10

SanghyeonLee accepted D7476: Efl.Ui.List_View: precise layout async.

oh sorry. I was misunderstand this patch.
I've checked current list_view is broken and the root reason is precise_layouter is not written as asyncrous future action on the realized item.
patch works very well, item shows little delay, but still it works,
we have to fixing delay issue after this,
but it looks good to me.

Thu, Jan 10, 11:32 PM · efl

Wed, Jan 9

SanghyeonLee added a comment to D7562: efl: Rename efl_model_child_add to efl_model_child_append and add prepend method.

patch looks good to me, but I didn't tested this yet, so I'll check again :)
Thanks for fast feedback!

Wed, Jan 9, 1:27 AM · efl
SanghyeonLee updated subscribers of T7458: Composite Model renaming.
Wed, Jan 9, 12:11 AM · efl (efl-1.22), efl: mvvm

Tue, Jan 8

SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

One proposal to make it clear what action it takes.

Tue, Jan 8, 11:44 PM · efl
SanghyeonLee accepted D7557: elementary genlist: make it sure object type..

It looks good to me.
the reason of recursive call of widget calculation is to get final calculated size of sub-groups, so non-group-object case need to be skipped.

Tue, Jan 8, 2:50 AM · efl

Mon, Jan 7

SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

I understanding about your point but,

Mon, Jan 7, 9:47 PM · efl

Thu, Jan 3

SanghyeonLee updated the diff for D7533: efl_model : rename all efl_model based classes..

rebasing patch on top of D7529

Thu, Jan 3, 4:05 AM · efl
SanghyeonLee updated the diff for D7529: efl_ui : rename model connect and factory connect to bind property and factory..

update indent errors and change connects hash to binds

Thu, Jan 3, 4:03 AM · efl
SanghyeonLee added reviewers for D7533: efl_model : rename all efl_model based classes.: felipealmeida, woohyun, Hermet.
Thu, Jan 3, 3:53 AM · efl
SanghyeonLee requested review of D7533: efl_model : rename all efl_model based classes..
Thu, Jan 3, 3:47 AM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

Need to fix indent errors.

Thu, Jan 3, 1:46 AM · efl

Wed, Jan 2

SanghyeonLee updated the diff for D7529: efl_ui : rename model connect and factory connect to bind property and factory..

update efl_ui_layout.eo

Wed, Jan 2, 10:06 PM · efl
SanghyeonLee added a comment to D7529: efl_ui : rename model connect and factory connect to bind property and factory..

Nope. you are correct! thanks.

Wed, Jan 2, 9:30 PM · efl
SanghyeonLee added a task to D7529: efl_ui : rename model connect and factory connect to bind property and factory.: T7469: Find a better name for Efl.Factory.model_connect.
Wed, Jan 2, 3:23 AM · efl
SanghyeonLee added a revision to T7469: Find a better name for Efl.Factory.model_connect: D7529: efl_ui : rename model connect and factory connect to bind property and factory..
Wed, Jan 2, 3:23 AM · efl: mvvm, Restricted Project
SanghyeonLee added reviewers for D7529: efl_ui : rename model connect and factory connect to bind property and factory.: netstar, felipealmeida.
Wed, Jan 2, 3:21 AM · efl
SanghyeonLee requested review of D7529: efl_ui : rename model connect and factory connect to bind property and factory..
Wed, Jan 2, 3:20 AM · efl

Fri, Dec 28

SanghyeonLee added a comment to T7381: [MVVM] Efl.Ui.View_List Performance Improvement.

Additionally, this is secondary work I guess,
I've recently got some request about genlist improvement by using buffer scroll.
It means, do not move the item manually by scroll moves,
draw the item in image buffer, and when it scrolls,
move the buffer only so reduce scene graph traverse and move function calls.
I think it may be possible by using map in our case.
I've heard some framework (android or IOS) do the optimization by this way,
but I'm not sure this will be helpful to improve scrolling performance.

Fri, Dec 28, 3:16 AM · efl: mvvm

Thu, Dec 27

SanghyeonLee added a comment to T7379: [MVVM] Support disabled composite model.

Well I think about this as some package with selection for widget status.
we can just using boolean model and I fairly think that is enough for data storing..
but the way of providing API like disable set / get will be on item and widget unlikely selection will have helper in model.
that is one worry that I have about it.

Thu, Dec 27, 11:07 PM · efl: mvvm
SanghyeonLee added a comment to T7378: [MVVM] Model Composite Features.

Yes this is not an urgent feature and can wait next release. just the discussion for which way is proper is the purpose for now.
the way I think about this is quite similar as QT sort/filter model does,
http://doc.qt.io/qt-5/qsortfilterproxymodel.html
but we have more enough time to discuss about this.
until we finish all urgent features of MVVM,
it will just remain as wishlist.

Thu, Dec 27, 9:37 PM · Restricted Project, efl: mvvm

Wed, Dec 26

SanghyeonLee closed D7465: efl_ui: activate widget focus on efl.ui.item..
Wed, Dec 26, 4:08 AM · efl
SanghyeonLee added a comment to T7381: [MVVM] Efl.Ui.View_List Performance Improvement.

I've got lots of requirements regarding size calculation and your idea about average size model looks very helpful for them.
let's start with homogeneous first, and after that will go exact and average.

Wed, Dec 26, 4:02 AM · efl: mvvm
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7458: Composite Model renaming.
Wed, Dec 26, 3:58 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a parent task for T7458: Composite Model renaming: T5354: Provide infrastructure for MVVM.
Wed, Dec 26, 3:58 AM · efl (efl-1.22), efl: mvvm
SanghyeonLee added a comment to T7405: [MVVM] Multistyle Factory.

this task is discussed fragmentary in other tasks,
so I write some agreement of this multiple factory.

Wed, Dec 26, 3:56 AM · efl: mvvm
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7405: [MVVM] Multistyle Factory.
Wed, Dec 26, 3:42 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a parent task for T7405: [MVVM] Multistyle Factory: T5354: Provide infrastructure for MVVM.
Wed, Dec 26, 3:42 AM · efl: mvvm
SanghyeonLee added a parent task for T7404: [MVVM] Factory text property handles: T5354: Provide infrastructure for MVVM.
Wed, Dec 26, 3:38 AM
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7404: [MVVM] Factory text property handles.
Wed, Dec 26, 3:38 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a comment to T7458: Composite Model renaming.

please vote V41/V42/V43.

Wed, Dec 26, 3:36 AM · efl (efl-1.22), efl: mvvm
SanghyeonLee closed T7404: [MVVM] Factory text property handles as Resolved.

I think we discuss about it in T5365,
so this task is no more necessary.
I'll close the task.

Wed, Dec 26, 3:34 AM
SanghyeonLee added a task to D7444: elementary: enable caching for Efl.Ui.ImageFactory.: T7382: [MVVM] Efl.Ui.View_List Homogenous Support.
Wed, Dec 26, 3:32 AM · efl
SanghyeonLee added revisions to T7382: [MVVM] Efl.Ui.View_List Homogenous Support: D7443: elementary: add a factory that handle caching for you., D7444: elementary: enable caching for Efl.Ui.ImageFactory., D7445: elementary: enable caching for Efl.Ui.LayoutFactory..
Wed, Dec 26, 3:32 AM · efl: mvvm
SanghyeonLee added a task to D7445: elementary: enable caching for Efl.Ui.LayoutFactory.: T7382: [MVVM] Efl.Ui.View_List Homogenous Support.
Wed, Dec 26, 3:32 AM · efl
SanghyeonLee added a task to D7443: elementary: add a factory that handle caching for you.: T7382: [MVVM] Efl.Ui.View_List Homogenous Support.
Wed, Dec 26, 3:32 AM · efl
SanghyeonLee added a comment to T7469: Find a better name for Efl.Factory.model_connect.

so we go
property_bind
factory_bind
?

Wed, Dec 26, 3:30 AM · efl: mvvm, Restricted Project
SanghyeonLee added a parent task for T7382: [MVVM] Efl.Ui.View_List Homogenous Support: T5354: Provide infrastructure for MVVM.
Wed, Dec 26, 3:28 AM · efl: mvvm
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7382: [MVVM] Efl.Ui.View_List Homogenous Support.
Wed, Dec 26, 3:28 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a parent task for T7381: [MVVM] Efl.Ui.View_List Performance Improvement: T5354: Provide infrastructure for MVVM.
Wed, Dec 26, 3:27 AM · efl: mvvm
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7381: [MVVM] Efl.Ui.View_List Performance Improvement.
Wed, Dec 26, 3:27 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a parent task for T7380: [MVVM] Efl.Ui.Viewlist renaming.: T5354: Provide infrastructure for MVVM.
Wed, Dec 26, 3:27 AM
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7380: [MVVM] Efl.Ui.Viewlist renaming..
Wed, Dec 26, 3:27 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a parent task for T7379: [MVVM] Support disabled composite model: T5354: Provide infrastructure for MVVM.
Wed, Dec 26, 3:26 AM · efl: mvvm
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7379: [MVVM] Support disabled composite model.
Wed, Dec 26, 3:26 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7376: [MVVM] Model Selection Support.
Wed, Dec 26, 3:25 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a parent task for T7376: [MVVM] Model Selection Support: T5354: Provide infrastructure for MVVM.
Wed, Dec 26, 3:25 AM · efl (efl-1.22), efl: mvvm
SanghyeonLee added a parent task for T7377: [MVVM] Model Insertion Features: T5354: Provide infrastructure for MVVM.
Wed, Dec 26, 3:24 AM · efl (efl-1.22), efl: mvvm
SanghyeonLee added a subtask for T5354: Provide infrastructure for MVVM: T7377: [MVVM] Model Insertion Features.
Wed, Dec 26, 3:24 AM · efl (efl-1.22), efl: mvvm, efl: data types
SanghyeonLee added a comment to T7379: [MVVM] Support disabled composite model.

well enable/disable is only the boolean data,
and principle is quite simple as all we know,

Wed, Dec 26, 3:23 AM · efl: mvvm
SanghyeonLee added a comment to T7378: [MVVM] Model Composite Features.

@cedric in case of mega-data model, we might need to restrict data, and in unlimited-data case, it definitely necessary.
I don't think it may need to be an exposed API for every model,
why not Proxy Model itself?

Wed, Dec 26, 3:10 AM · Restricted Project, efl: mvvm
SanghyeonLee added a comment to T7377: [MVVM] Model Insertion Features.

@felipealmeida ping, any update on this task?

Wed, Dec 26, 3:05 AM · efl (efl-1.22), efl: mvvm
SanghyeonLee added a comment to T7376: [MVVM] Model Selection Support.

here it may confusing me,
you meant, Composite_Boolean will stay for multi selection and Composite_Selection will only works in single selection?

Wed, Dec 26, 3:01 AM · efl (efl-1.22), efl: mvvm
SanghyeonLee added a comment to D7465: efl_ui: activate widget focus on efl.ui.item..

@bu5hm4n I think list need to take controls manually about their children at the end,
but before that we might need focus feature in scroller.

Wed, Dec 26, 2:43 AM · efl
SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

I think we almost get some conculsion, so we need only @felipealmeida 's opinion.
get an agreement and let's finish it.

Wed, Dec 26, 2:38 AM · efl (efl-1.22), efl: mvvm, efl: widgets

Dec 20 2018

SanghyeonLee added a comment to D7465: efl_ui: activate widget focus on efl.ui.item..

@bu5hm4n Hello.
Which example did you tried to excuted?
I've tested both of list & grid, but it works well except some crash of efl_del() and it is not related with this patch. I have to fix it too.
If you tested efl_ui_list_view_example,
this is not list_view and list_view is on discussion yet so it may crash for now.
please check you correctly tested efl_ui_list/grid_example.
thanks :)

Dec 20 2018, 4:30 AM · efl
SanghyeonLee accepted D7447: elementary: make all view generate an event when the item is created..

Looks good to me.

Dec 20 2018, 3:08 AM · efl
SanghyeonLee accepted D7446: efl: add facility to generate an event when an item is created by the factory..

Looks good to me now.

Dec 20 2018, 3:08 AM · efl
SanghyeonLee added a comment to D7476: Efl.Ui.List_View: precise layout async.

I agree that it would be much better to separate the layouting method,
but I'm not sure why this content_created need to be asynchronous.
I've faced a lot of issue when group calculation demand view update, but view deffered the update.
I think if it reached group_calculate, view need to be updated in the same render frame.

Dec 20 2018, 1:42 AM · efl
SanghyeonLee accepted D7488: ecore: test for Efl.ModelView..

looks good to me.
I think we could add more hard test case with model on huge data,
but this is good enough for first step.

Dec 20 2018, 1:35 AM · efl
SanghyeonLee accepted D7489: ecore: define behavior when no getter/setter callback function is defined for ModelView property logic..

looks good to me.

Dec 20 2018, 1:32 AM · efl
SanghyeonLee added a comment to T5365: Use efl.part for efl.ui.model.connect.

I'm not 'LIKE' it but we don't have much time to waste a week more in this task,
so let's get conclusion one way.

Dec 20 2018, 1:29 AM · efl (efl-1.22), efl: mvvm, efl: widgets