Page MenuHomePhabricator
Feed Advanced Search

Fri, Dec 6

q66 added a comment to T8514: remove @move from get { } if ownership is not moved by getter.

馃憤

Fri, Dec 6, 4:05 AMefl: api, efl (efl-1.24)

Wed, Dec 4

q66 added a commit to T8491: eolian: composite does not follow inheritance: rEFL387947f6b151: eolian: account for entire inheritance trees when compositing.
Wed, Dec 4, 7:08 AMRestricted Project
q66 added a comment to D10734: efl_ui_mutli_selectable: stabelize interfaces.

T8491 is fixed now.

Wed, Dec 4, 6:34 AMefl
q66 closed T8491: eolian: composite does not follow inheritance as Resolved by committing rEFLc360f5edb699: eolian: account for entire inheritance trees when compositing.
Wed, Dec 4, 6:33 AMRestricted Project
q66 added a comment to D10734: efl_ui_mutli_selectable: stabelize interfaces.
Wed, Dec 4, 6:10 AMefl
q66 added a comment to D10734: efl_ui_mutli_selectable: stabelize interfaces.
Wed, Dec 4, 6:07 AMefl

Tue, Dec 3

q66 edited the content of Enlightenment Developer Days 2019.
Tue, Dec 3, 6:09 AM
q66 accepted D10734: efl_ui_mutli_selectable: stabelize interfaces.

Otherwise looks good to me

Tue, Dec 3, 4:47 AMefl
q66 added a comment to D10734: efl_ui_mutli_selectable: stabelize interfaces.

yeah, i'm on it

Tue, Dec 3, 4:46 AMefl

Mon, Dec 2

q66 added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 4:38 AMefl
q66 added inline comments to D10711: Efl.Ui.Text : all related interfaces.
Mon, Dec 2, 2:49 AMefl

Fri, Nov 29

q66 accepted D10769: eo files: Avoid container<ptr(value_type)> usage..
Fri, Nov 29, 12:16 PMefl

Thu, Nov 21

q66 added inline comments to D10646: Efl.Text.Attribute_Factory.
Thu, Nov 21, 4:37 AMefl

Wed, Nov 13

q66 added a comment to D10660: eo: do not over compute the hash when propagating events..

Well, I fixed the root cause: 9ca573f40f1065cc717c0c5aabb787671bab852b

Wed, Nov 13, 7:24 PMefl
q66 requested changes to D10660: eo: do not over compute the hash when propagating events..

Still makes edje_cc hang, after introduction of 7f53d9158395504151e1ff3dcae715a799d913a8.

Wed, Nov 13, 6:50 PMefl

Nov 5 2019

q66 accepted D10601: eolian: Imply @no_unused if @move in return..

lgtm

Nov 5 2019, 11:49 AMefl

Oct 9 2019

q66 added a comment to D10318: add title headers for methods and properties.

It definitely generated title headings last time I tried... that's the reason I added the distinction in the first place.

Oct 9 2019, 1:56 PM
q66 closed D10316: include PROPERTY documentation.

35b2a10dd5e05e668e025697075076851acff845

Oct 9 2019, 11:18 AM
q66 accepted D10316: include PROPERTY documentation.
Oct 9 2019, 11:16 AM
q66 requested changes to D10317: prevent crash.

This is already done differently

Oct 9 2019, 11:14 AM
q66 requested changes to D10318: add title headers for methods and properties.

You shouldn't need this. A title header is already emitted by the writer itself, see writer.lua, the __ctor method. It just uses the Dokuwiki title plugin by default, if you don't have it, pass --disable-title and it will fall back to headers.

Oct 9 2019, 11:14 AM
q66 accepted D10285: eolian: Leave default text for libeolian users.
Oct 9 2019, 7:17 AMefl

Sep 30 2019

q66 added a commit to T7704: verify @since tags for stabilized apis: rEFL71c83d2005e0: efl: add code to enforce presence of @since tags.
Sep 30 2019, 11:13 AMefl (efl-1.24), efl: docs, efl: api
q66 closed T8291: eolian: allow enabling the missing documentation check through a parameter as Wontfix.

No. This would create disparity in how the API behaves depending on an arbitrary switch, which is completely unacceptable.

Sep 30 2019, 11:06 AMefl: docs, Restricted Project
q66 closed T7180: Make eolian_gen warn about missing documentation as Resolved.

2946cb3c325f27d77354ac1b83b614e3a1d9e1d5

Sep 30 2019, 10:00 AMRestricted Project, efl: docs, Restricted Project
q66 closed T7180: Make eolian_gen warn about missing documentation, a subtask of T5826: Improve overall EFL documentation, as Resolved.
Sep 30 2019, 10:00 AMefl: docs, Restricted Project
q66 closed D10238: eolian-cxx: Release iterators.
Sep 30 2019, 7:08 AMefl
q66 added a commit to T8280: eolian_cxx not freeing iterators (thus leaking memory): rEFLf3199ba04bcb: eolian-cxx: Release iterators.
Sep 30 2019, 7:08 AMefl (efl-1.24)
q66 added a commit to T8280: eolian_cxx not freeing iterators (thus leaking memory): rEFL507061a145b8: bindings: Fix disposal of eolian state.
Sep 30 2019, 7:08 AMefl (efl-1.24)
q66 closed D10237: bindings: Fix disposal of eolian state.
Sep 30 2019, 7:08 AMefl
q66 accepted D10238: eolian-cxx: Release iterators.
Sep 30 2019, 6:36 AMefl
q66 accepted D10237: bindings: Fix disposal of eolian state.
Sep 30 2019, 6:36 AMefl
q66 closed T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20) as Resolved.

Yeah, so it was the issue then :) I suspected something with alignment/padding with the union'd definition of Eolian_Expression not playing nice with the typecast, looks like my suspicion was correct.

Sep 30 2019, 5:07 AM
q66 added a comment to T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20).

can you try again after the latest commit?

Sep 30 2019, 2:34 AM
q66 triaged T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20) as High priority.
Sep 30 2019, 2:33 AM
q66 reopened T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20) as "Open".
Sep 30 2019, 2:33 AM
q66 closed T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20) as Resolved by committing rEFL27291b4486db: eolian: fix potential ABI violation in expr serialization.
Sep 30 2019, 2:33 AM

Sep 27 2019

q66 triaged T8280: eolian_cxx not freeing iterators (thus leaking memory) as Showstopper Issues priority.
Sep 27 2019, 6:31 AMefl (efl-1.24)
q66 added a comment to T8276: eolian_cxx segfaults on armv7 since 61ce4c79fd (2019-09-20).

i'll need a better backtrace for this...

Sep 27 2019, 6:20 AM

Sep 20 2019

q66 added a commit to T8050: Inconsistencies in the usage of `Eina_Hash` make it unsuitable for bindings.: rEFL718f3cd49586: eolian: make hashes beta-only for now.
Sep 20 2019, 8:05 AMRestricted Project, efl: api
q66 added a comment to T8012: Support default values @property's keys and method's params in eo.

This appears to be wrong. The "default values" are only allowed for property values {} block as well as for @out parameters, Eolian will not accept them for @in parameters. I.e. those values are default fallbacks.

Sep 20 2019, 8:03 AMefl: language bindings, Restricted Project

Sep 19 2019

q66 moved T7462: eolian: add information to .eot/.eo files about what library module to link/load from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 19 2019, 9:24 AMRestricted Project
q66 closed T8218: eolian: typo in "composite" keyword as Resolved by committing rEFLbc793753cb5c: eolian: allow composites keyword in place of composite.
Sep 19 2019, 9:21 AMRestricted Project, efl (efl-1.23)
q66 abandoned D10017: eolian: use composites as keyword name to harmonize on third person singular.
Sep 19 2019, 7:53 AMefl
q66 commandeered D10017: eolian: use composites as keyword name to harmonize on third person singular.
Sep 19 2019, 7:53 AMefl
q66 requested changes to D10017: eolian: use composites as keyword name to harmonize on third person singular.

Please don't, I already have this mostly done with other changes and this just creates more work for me.

Sep 19 2019, 5:10 AMefl

Sep 13 2019

q66 closed T8213: eolian: support $[...] syntax as Resolved by committing rEFL266fd9bb368b: eolian: support complex monospace syntax $[...].
Sep 13 2019, 8:08 AMRestricted Project, efl
q66 closed T8169: how to reference events with commas in eo docs? as Resolved.

as @segfaultxavi said

Sep 13 2019, 7:56 AMRestricted Project

Sep 12 2019

q66 added a comment to T8184: Composite objects are esentially broken because of recent Eolian regressions.
In T8184#142189, @tasn wrote:
In T8184#142185, @q66 wrote:

@raster that's because requires is not extends, requires pretty much specifies a list of classes that are required to be in inheritance tree of the thing using the mixin; by specifying it, you tell eolian that it's guaranteed it'll be there, and the mixin can safely implement it.

Yeah, we understand what "requires" means, as in why the name is there. Though how is it different than implements? As that's exactly what's going on here?

Sep 12 2019, 12:00 PM
q66 added a comment to T8184: Composite objects are esentially broken because of recent Eolian regressions.

@raster that's because requires is not extends, requires pretty much specifies a list of classes that are required to be in inheritance tree of the thing using the mixin; by specifying it, you tell eolian that it's guaranteed it'll be there, and the mixin can safely implement it.

Sep 12 2019, 7:52 AM

Sep 10 2019

q66 closed T7460: eolian: remove ptr() as Resolved.

As of afc011d8931006bd020ba5130a581580f709edcf, usage of ptr() is banned in stable API. That's bound to be good enough for now, and removing it from beta is a separate task, so closing this as resolved.

Sep 10 2019, 5:40 AMRestricted Project

Sep 9 2019

q66 closed D9867: eolian_cxx: Add support for @by_ref.
Sep 9 2019, 9:19 AMefl
q66 accepted D9867: eolian_cxx: Add support for @by_ref.
Sep 9 2019, 9:09 AMefl
q66 closed D9875: docs: remove nstate preview.
Sep 9 2019, 6:56 AMefl: docs
q66 accepted D9875: docs: remove nstate preview.
Sep 9 2019, 6:55 AMefl: docs

Sep 6 2019

q66 requested changes to D9867: eolian_cxx: Add support for @by_ref.

this doesn't correctly fix the eolian_type_c_type_get usage yet, which means this will behave wrong with the tag; i still see EOLIAN_C_TYPE_DEFAULT/PARAM/RETURN being passed around.

Sep 6 2019, 4:00 PMefl
q66 closed D9866: eolian_cxx: Remove last usage of type_is_owned.
Sep 6 2019, 3:57 PMefl
q66 accepted D9866: eolian_cxx: Remove last usage of type_is_owned.
Sep 6 2019, 3:56 PMefl
q66 added a comment to T6890: Eolian error integration.

OK, I did that for now, but we'll need to figure out a proper one...

Sep 6 2019, 9:05 AMefl: language bindings, Restricted Project
q66 added a commit to T6890: Eolian error integration: rEFLcb2b6d666cf2: eolian_gen: make errors compile/work.
Sep 6 2019, 9:04 AMefl: language bindings, Restricted Project
q66 closed T8183: Eolian and composite objects: weird syntax as Resolved by committing rEFLeb25e92770f9: eolian: change composite syntax from block to inheritance section.
Sep 6 2019, 6:14 AM

Sep 5 2019

q66 closed D9844: bindings: Rename test cxx and csharp eo ownership tags.
Sep 5 2019, 11:05 AMefl
q66 added a commit to T8199: eolian_cxx: Update after @move/@owned changes: rEFL17c6cabaa44a: bindings: Rename test cxx and csharp eo ownership tags.
Sep 5 2019, 11:05 AMRestricted Project, efl: language bindings
q66 closed T8199: eolian_cxx: Update after @move/@owned changes as Resolved by committing rEFL1e8554821406: eolian_cxx: Replace type_is_owned with is_move.
Sep 5 2019, 11:05 AMRestricted Project, efl: language bindings
q66 closed D9843: eolian_cxx: Replace type_is_owned with is_move.
Sep 5 2019, 11:05 AMefl
q66 accepted D9844: bindings: Rename test cxx and csharp eo ownership tags.
Sep 5 2019, 11:04 AMefl
q66 accepted D9843: eolian_cxx: Replace type_is_owned with is_move.
Sep 5 2019, 11:03 AMefl
q66 closed T8035: Unify handling of contents of complex types as Resolved.

I think we've got this down, eolian properly checks and verifies this

Sep 5 2019, 7:37 AMRestricted Project
q66 moved T7955: eolian: remove keyword legacy from enums from Restricted Project Column to Restricted Project Column on the Restricted Project board.
Sep 5 2019, 5:23 AMRestricted Project
q66 lowered the priority of T7955: eolian: remove keyword legacy from enums from High to TODO.

this is now banned in stable API... removal still pending

Sep 5 2019, 5:23 AMRestricted Project

Aug 29 2019

q66 added a comment to T6890: Eolian error integration.

Hm, what should be do about this? Do we want this to be thread-safe? Because the error API is not...

Aug 29 2019, 9:12 AMefl: language bindings, Restricted Project
q66 closed T7461: eolian: evaluate our type ownership system and find out if it covers all cases and is generally sufficient as Resolved.

Closing this as the system is generally sound. Syntax changes may happen but no design alterations

Aug 29 2019, 6:29 AMRestricted Project

Aug 28 2019

q66 requested changes to D9510: eolian: Add @static to classes.

Please rebase for the @class -> @static method change

Aug 28 2019, 1:23 AMefl
q66 closed D9626: pyolian: Update after event and binbuf keywords.
Aug 28 2019, 1:21 AMefl
q66 closed D9421: eolian_aux: this must be recursive.
Aug 28 2019, 1:21 AMefl
q66 accepted D9421: eolian_aux: this must be recursive.
Aug 28 2019, 1:20 AMefl
q66 accepted D9626: pyolian: Update after event and binbuf keywords.
Aug 28 2019, 1:20 AMefl
q66 placed T8181: Memory Issue with Eo Legacy Widget Implementation. up for grabs.
Aug 28 2019, 1:17 AM
q66 added a comment to T8181: Memory Issue with Eo Legacy Widget Implementation..

Okay, but I'm not sure why you assigned this to me, considering I'm not dealing with widgets.

Aug 28 2019, 1:16 AM

Aug 16 2019

q66 closed T8140: ASAN detected memory leaks in eolian_gen as Resolved.
Aug 16 2019, 4:45 AM
q66 added a commit to T8140: ASAN detected memory leaks in eolian_gen: rEFL9f2e2f99c666: eolian: fix function pointer leak as reported by asan.
Aug 16 2019, 4:34 AM

Aug 14 2019

q66 closed D9572: efl_ui/win: implement unimplemented methods.
Aug 14 2019, 10:35 AMefl
q66 closed D9562: efl_ui/layout: implement unimplemented methods.
Aug 14 2019, 10:35 AMefl
q66 closed D9561: efl_ui: mark localization methods with @empty for containers.
Aug 14 2019, 10:35 AMefl
q66 closed D9560: efl: remove Efl.Ui.I18n from canvas object inheritance.
Aug 14 2019, 10:35 AMefl
q66 closed D9559: efl: mark a couple internal eo files as @beta.
Aug 14 2019, 10:34 AMefl
q66 accepted D9572: efl_ui/win: implement unimplemented methods.
Aug 14 2019, 10:23 AMefl
q66 accepted D9562: efl_ui/layout: implement unimplemented methods.
Aug 14 2019, 10:23 AMefl
q66 accepted D9561: efl_ui: mark localization methods with @empty for containers.
Aug 14 2019, 10:22 AMefl
q66 accepted D9560: efl: remove Efl.Ui.I18n from canvas object inheritance.
Aug 14 2019, 10:22 AMefl
q66 accepted D9559: efl: mark a couple internal eo files as @beta.
Aug 14 2019, 10:22 AMefl

Aug 9 2019

q66 added a comment to T7675: Do not allow static-function polymorphism.

Hm? why not just rename current @class to @static (which is easy and quick) and then only re-add @class later if it ends up being needed?

Aug 9 2019, 9:27 AMBBQ, efl: data types, Restricted Project
q66 added a comment to T7675: Do not allow static-function polymorphism.

If it's just renaming to @static, then that's fine and easy

Aug 9 2019, 8:57 AMBBQ, efl: data types, Restricted Project

Jul 26 2019

q66 closed D9412: eolian-cxx: Add binbuf and event keywords handling n.
Jul 26 2019, 4:21 AMefl
q66 accepted D9412: eolian-cxx: Add binbuf and event keywords handling n.
Jul 26 2019, 4:01 AMefl

Jul 23 2019

q66 closed D9349: eolian_mono: parse `binbuf` and `event` keywords, also re-enable binbuf tests.
Jul 23 2019, 5:10 AMefl
q66 accepted D9349: eolian_mono: parse `binbuf` and `event` keywords, also re-enable binbuf tests.
Jul 23 2019, 5:09 AMefl
q66 accepted D9369: eolian: start to express ownership transfere.

I think this is good

Jul 23 2019, 5:07 AMefl

Jul 8 2019

q66 closed D9124: eolian: fix leak in eolian_state_file_path_parse.
Jul 8 2019, 7:56 AMefl
q66 closed D9237: eolian_cxx: update eolian_cxx to recognize slice and rw_slice.
Jul 8 2019, 7:56 AMefl