Page MenuHomePhabricator
Feed Advanced Search

Wed, Sep 18

myoungwoon added a comment to T7717: docs todo.

I submitted my patches for my part. Please review D10002.
https://phab.enlightenment.org/D10002
Thanks.

Wed, Sep 18, 1:32 AM · efl (efl-1.23), efl: docs, efl: api
myoungwoon updated the task description for T7717: docs todo.
Wed, Sep 18, 1:31 AM · efl (efl-1.23), efl: docs, efl: api
myoungwoon requested review of D10002: doc: improves single line description of gesture class..
Wed, Sep 18, 1:30 AM · efl

Tue, Sep 17

myoungwoon added a comment to D10000: docs: Fill-in docs for Efl.Threadio, Efl.Appthread.

Is there any differences between EflThreadIOCall and EflThreadIOCallSync?
and I recommend to change from "Write" to "Writes" according to third person singular representation like "Sets/Gets".

Tue, Sep 17, 10:03 PM · efl

Sep 10 2019

myoungwoon added inline comments to D9795: doc: improve single line descriptions.
Sep 10 2019, 4:43 PM · efl

Aug 29 2019

myoungwoon added a comment to T7717: docs todo.

I submitted my patches for my part. Please review D9795.
https://phab.enlightenment.org/D9795
Thanks.

Aug 29 2019, 11:53 PM · efl (efl-1.23), efl: docs, efl: api
myoungwoon updated the task description for T7717: docs todo.
Aug 29 2019, 11:52 PM · efl (efl-1.23), efl: docs, efl: api
myoungwoon requested review of D9795: doc: improve single line descriptions.
Aug 29 2019, 11:51 PM · efl

Aug 28 2019

myoungwoon updated the task description for T7717: docs todo.
Aug 28 2019, 11:29 PM · efl (efl-1.23), efl: docs, efl: api
myoungwoon updated subscribers of T7717: docs todo.

I revmoved ector related eo files because ectors are neither using the actual header files nor installed.
and I assigned you to eldbus because eldbus and dbus had not been using owing to security issue and there are no one to have knowledge and experience about dbus.
So I think that it is enough for @segfaultxavi to add brief description to each APIs.
Mainly, elementary related to eo files will be handled by @woohyun and evas related to eo files will be covered by @Hermet and rest will be handled by @myoungwoon.

Aug 28 2019, 1:12 AM · efl (efl-1.23), efl: docs, efl: api
myoungwoon updated the task description for T7717: docs todo.
Aug 28 2019, 1:05 AM · efl (efl-1.23), efl: docs, efl: api

May 12 2019

myoungwoon requested review of D8885: docs: Fix a wrong ingroup name of textpath..
May 12 2019, 7:12 PM · efl

Mar 4 2019

myoungwoon added a comment to T7715: Cannot launch terminology in Ubuntu 16.04.

The main reason is that the permissions of all edj files for terminology theme (/usr/local/share/terminology/themes/)
I had changed permissions of all themes and then terminology is working well.
Thanks. :)

Mar 4 2019, 10:36 PM · Terminology

Mar 3 2019

myoungwoon added a comment to T7715: Cannot launch terminology in Ubuntu 16.04.

roy:(~/efl/git/apps/terminology) EINA_LOG_LEVELS="edje:4" terminology
clouseau_debug_init - In
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/win/base/default': 1.
INF<22966>:edje lib/edje/edje_calc.c:2710 _edje_part_recalc_single() file /usr/local/share/elementary/themes/default.edj, group elm/win/base/default has a non-fixed part 'elm.swallow.menu'. You should add 'fixed: 0 1'. But in order to optimize the edje calc, we add it automatically.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/border/base/default': 1.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/icon/terminology/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/icon/terminology/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/icon/terminology/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/icon/terminology/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/top_side/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/top_side/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/bottom_side/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/bottom_side/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/top_left_corner/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/top_left_corner/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/bottom_left_corner/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/bottom_left_corner/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/bottom_right_corner/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/bottom_right_corner/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/top_right_corner/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/cursor/top_right_corner/default': 0.
DBG<22966>:edje lib/edje/edje_load.c:348 edje_mmap_group_exists() edje_file_group_exists: '/usr/local/share/elementary/themes/default.edj', 'elm/conformant/base/default': 1.
ERR<22966>:terminology ../src/bin/utils.c:48 theme_apply() Could not load any theme for group=terminology/base: File Does Not Exist
ERR<22966>:terminology ../src/bin/utils.c:48 theme_apply() Could not load any theme for group=terminology/core: File Does Not Exist
ERR<22966>:terminology ../src/bin/utils.c:48 theme_apply() Could not load any theme for group=terminology/background: File Does Not Exist
CRI<22966>:win ../src/bin/win.c:5631 term_new() Couldn't find terminology theme! Forgot 'ninja install'?
CRI<22966>:terminology ../src/bin/main.c:906 elm_main() Could not create terminal widget.
DBG<22966>:edje lib/edje/edje_program.c:1444 _edje_emit_handle() EDJE EMIT: (0x26037e0) signal: "seat,added,seat1,default" source: ""
DBG<22966>:edje lib/edje/edje_program.c:1444 _edje_emit_handle() EDJE EMIT: (0x26037e0) signal: "edje,language," source: "edje"
DBG<22966>:edje lib/edje/edje_program.c:1444 _edje_emit_handle() EDJE EMIT: (0x26037e0) signal: "edje,state,ltr" source: "edje"
DBG<22966>:edje lib/edje/edje_program.c:1444 _edje_emit_handle() EDJE EMIT: (0x26037e0) signal: "load" source: ""
DBG<22966>:edje lib/edje/edje_program.c:1444 _edje_emit_handle() EDJE EMIT: (0x26037e0) signal: "edje,state,ltr" source: "edje"

Mar 3 2019, 3:38 PM · Terminology

Feb 27 2019

myoungwoon created T7715: Cannot launch terminology in Ubuntu 16.04.
Feb 27 2019, 11:07 PM · Terminology

Jan 29 2019

myoungwoon abandoned D7814: Fix: Removes unreachable codes..

This is a duplicated of D7816.

Jan 29 2019, 4:28 PM · efl
myoungwoon abandoned D7815: Fix: Removes unreachable codes..

This is a duplicated of D7816.

Jan 29 2019, 4:28 PM · efl
myoungwoon retitled D7816: elm: fix dereferencing issue and add error handling and remove unreachable codes. from Fix: fix dereferencing issue and add error handling and removes unreachable codes. to elm: fix dereferencing issue and add error handling and remove unreachable codes..
Jan 29 2019, 4:26 PM · efl
myoungwoon updated the diff for D7816: elm: fix dereferencing issue and add error handling and remove unreachable codes..

elm: fix deferencing issue and add error handling and remove unreachable codes

Jan 29 2019, 4:25 PM · efl
myoungwoon abandoned D7817: Handling failed memory allocation.

Changes title and submit new revision.

Jan 29 2019, 3:58 PM · efl
myoungwoon requested review of D7829: efl_ui_list_view: Handling failed memory allocation.
Jan 29 2019, 3:56 PM · efl
myoungwoon updated the diff for D7817: Handling failed memory allocation.

Changes title according to review comments

Jan 29 2019, 3:54 PM · efl

Jan 28 2019

myoungwoon requested review of D7817: Handling failed memory allocation.
Jan 28 2019, 11:37 PM · efl
myoungwoon requested review of D7816: elm: fix dereferencing issue and add error handling and remove unreachable codes..
Jan 28 2019, 11:22 PM · efl
myoungwoon requested review of D7815: Fix: Removes unreachable codes..
Jan 28 2019, 11:20 PM · efl
myoungwoon requested review of D7814: Fix: Removes unreachable codes..
Jan 28 2019, 11:06 PM · efl

Oct 4 2018

myoungwoon added a comment to D7126: eolian: Fixed possibility of duplication due to @ingroup auto generation.

Hi Daniel,

Oct 4 2018, 8:08 PM · efl

Aug 29 2018

myoungwoon requested review of D6943: docs: Fix typos and some wrong expressions in API reference doc..
Aug 29 2018, 9:03 PM · efl

Aug 8 2018

myoungwoon added a watcher for reviewers: myoungwoon.
Aug 8 2018, 1:06 AM
myoungwoon added a member for reviewers: myoungwoon.
Aug 8 2018, 1:05 AM

Jun 29 2018

Herald added a reviewer for D6479: Add information about the location of CC BY-SA 3.0 related icon files.: devilhorns.
Jun 29 2018, 2:23 AM · efl

May 7 2018

myoungwoon accepted D6052: edje: return proper value from the function..

It looks good to me.

May 7 2018, 4:31 PM · efl

Feb 18 2018

myoungwoon updated the diff for D5804: Replace ecore_wl_dpi_get with ecore_wl2_output_dpi_get.

Move variable declaration to the top of function.

Feb 18 2018, 3:42 PM

Feb 11 2018

myoungwoon added a comment to D5794: ecore_file: check for a valid url header.
In D5794#99187, @raster wrote:

For the first, I think ecore_file_download should return more meaningful return values. for example, error codes.

Can't do that as return is Eina_Bool ... so only true or false... changing that would break ABI/API.

:)

Feb 11 2018, 4:16 PM · efl

Feb 8 2018

myoungwoon updated the diff for D5794: ecore_file: check for a valid url header.

replacee checking codes.

Feb 8 2018, 9:10 PM · efl
myoungwoon added a comment to D5794: ecore_file: check for a valid url header.
In D5794#99151, @raster wrote:

ummm... you mean ecore_file_download_protocol_available right? well technically that should be fixed to list more schemes. ftps is kind of important for starters (ssl ftp).

Feb 8 2018, 9:09 PM · efl

Feb 7 2018

myoungwoon updated the diff for D5794: ecore_file: check for a valid url header.

update error messages.

Feb 7 2018, 9:18 PM · efl
myoungwoon added a comment to D5794: ecore_file: check for a valid url header.
In D5794#99066, @raster wrote:

ummm you know HTTP:// is also valid, as it Http:// and HtTp:// etc. ... case insensitive. also ftps://, file:// and probably other schemes that curl may support. you basically need to handle all the possible url schemes that curl may support here if you want to verify first... :) here's a quick list i found:

https://ec.haxx.se/protocols-curl.html

Feb 7 2018, 9:16 PM · efl
myoungwoon updated the diff for D5794: ecore_file: check for a valid url header.

Currently available protocols of ecore_file_download are file://, http://, https://, ftp://
from ecore_file_download_available().

Feb 7 2018, 8:48 PM · efl
myoungwoon added a comment to D5789: ecore_ipc: restore ability for negative port on local/remote ipc connection.
In D5789#99069, @raster wrote:

cedric's point is that ecore_ipc just sits on top of ecore_con and if ecore_con does these checks already... it will fail there and ecore_ipc will fail to connect or seet up a server, so there is no need to check twice.

Feb 7 2018, 6:22 PM
myoungwoon updated the diff for D5789: ecore_ipc: restore ability for negative port on local/remote ipc connection.

update comments.

Feb 7 2018, 6:03 PM
myoungwoon updated the diff for D5789: ecore_ipc: restore ability for negative port on local/remote ipc connection.

Port is an abstraction for socket ipc communication.
If port is not NULL when calling ecore_ipc_server_add, it means users try to use sockets with port.
If users use sockets with port, port number should be checked.
Zero port number is no issue because it means select any available local port.

Feb 7 2018, 5:39 PM

Feb 5 2018

myoungwoon added a comment to D5789: ecore_ipc: restore ability for negative port on local/remote ipc connection.
In D5789#98982, @cedric wrote:

Actually do we need to do any check here because ecore_con does the check for us, no ?

Feb 5 2018, 5:55 PM

Jan 31 2018

myoungwoon updated the diff for D5776: ecore_event: Check for the valid type.

Removes spaces

Jan 31 2018, 1:21 AM
myoungwoon updated the diff for D5776: ecore_event: Check for the valid type.

update a path according to comments.

Jan 31 2018, 1:19 AM

Jan 30 2018

myoungwoon added reviewers for D5776: ecore_event: Check for the valid type: cedric, raster, jpeg, stefan_schmidt, Jaehyun_Cho.
Jan 30 2018, 11:12 PM
myoungwoon updated the diff for D5776: ecore_event: Check for the valid type.

fix wrong submit message

Jan 30 2018, 11:11 PM

Jan 25 2018

myoungwoon updated the diff for D5762: ecore_timer: Check for the valid callback func.

Add a simple test case which checks argument of callback function.

Jan 25 2018, 12:33 AM

Jan 24 2018

myoungwoon updated the diff for D5762: ecore_timer: Check for the valid callback func.

Add the logic for ecore_timer_loop_add as well.

Jan 24 2018, 10:48 PM
myoungwoon updated the diff for D5762: ecore_timer: Check for the valid callback func.

Remove spaces.

Jan 24 2018, 10:39 PM

Jan 22 2018

myoungwoon updated the diff for D5754: ecore_main: Check for null ptr deref.

Fix return type.

Jan 22 2018, 1:48 AM
myoungwoon updated the diff for D5753: ecore_evas: Check for null ptr deref.

Remove spaces from below line.

Jan 22 2018, 12:40 AM

Jan 21 2018

myoungwoon updated the diff for D5752: ecore_anim: Check for null ptr deref.

Revert a patch for evore_evas patch

Jan 21 2018, 11:10 PM
myoungwoon updated the diff for D5752: ecore_anim: Check for null ptr deref.

ecore evas: Check for null ptr deref

Jan 21 2018, 9:38 PM

Jan 1 2018

myoungwoon added a comment to T6261: Create Permanent Boxout for Prerequisites, Navigation.

Regarding the created permanent Boxout, is it possible to keep the position while scrolling contents.
For quick navigation, generally user could see TOC of Navigation and Page contents always.
Is it supported by Dokuwiki? or, Can we make it easily by ourself?

Jan 1 2018, 5:31 PM · efl

Dec 20 2017

myoungwoon closed T6530: eeze: Remove unused device values as Resolved.

Chris alreadh had fixed those issues regarding unused device values and memory leak.
Thanks.

Dec 20 2017, 4:24 PM · efl
myoungwoon created T6530: eeze: Remove unused device values.
Dec 20 2017, 12:43 AM · efl

Aug 22 2017

myoungwoon updated the diff for D5106: docs: Add information about texture size limitations.

Add meat of this statement about texture size limitations.
And fix typos and wrong expressions according to Raster's comments.

Aug 22 2017, 9:26 PM
myoungwoon added a comment to D5106: docs: Add information about texture size limitations.

Thanks a lot :)
I can see/smell a difference in ability to write.
I will submit revised patch right away.

Aug 22 2017, 7:11 PM
myoungwoon added a comment to D5106: docs: Add information about texture size limitations.

Here, I want to know the meat of the issue and any typos or wrong expressions in my comments. :)
Actually, I am not a good technical writer but just want to be a good one if possible.

Aug 22 2017, 6:20 PM

Aug 16 2017

myoungwoon updated the diff for D5106: docs: Add information about texture size limitations.

Fix typos

Aug 16 2017, 6:43 PM
myoungwoon created D5106: docs: Add information about texture size limitations.
Aug 16 2017, 6:40 PM

Jun 6 2017

myoungwoon created D4943: docs: Fix typos and some wrong expressions in Ecore, Ecore_Audio, Ecore_Cocoa, Ecore_Con, and Ector API reference doxygen..
Jun 6 2017, 6:22 PM

May 23 2017

myoungwoon accepted D4886: spinner: Add signal to notify the value of spinner has been reached at min, max..

LGTM :)
I think it'd better for you to add any test cases about user cases for understanding new signals.

May 23 2017, 9:17 PM

Feb 24 2017

myoungwoon created D4680: docs: Fix typos and some wrong expressions in Ecore_Drm, Ecore_Evas, Ecore_File, Ecore_IMF, and Ecore_IMF_Evas API reference doxygen..
Feb 24 2017, 11:40 PM

Feb 22 2017

myoungwoon updated the diff for D4677: docs: Fix typos and some wrong expressions in Ecore and Edje API reference doxygen..

Update D4677: fixd typos.

Feb 22 2017, 6:05 PM
myoungwoon created D4677: docs: Fix typos and some wrong expressions in Ecore and Edje API reference doxygen..
Feb 22 2017, 5:55 PM

Feb 17 2017

myoungwoon created D4674: docs: Fix typos and some wrong expressions in Eina API reference doxygen..
Feb 17 2017, 8:32 PM

Feb 16 2017

myoungwoon created D4666: Fix typos and some wrong expressions in Edje and Eet API reference doxygen..
Feb 16 2017, 12:46 AM

Feb 13 2017

myoungwoon created D4658: Fix typos and some wrong expressions in API reference doxygen..
Feb 13 2017, 12:42 AM

Feb 9 2017

myoungwoon created D4652: Fix typos, cacologigue statements in API reference doxygen of ecore's audio, avahi, buffer, and con..
Feb 9 2017, 8:06 PM

Feb 8 2017

myoungwoon created D4651: Fix typos, cacologique statements in API reference doxygen of Ecore_Getopt and Ecore_Legacy.
Feb 8 2017, 8:19 PM

Feb 7 2017

myoungwoon created D4650: Fix typos, cacologique statements in API reference doxygen of Ecore_Common.
Feb 7 2017, 10:41 PM

Feb 6 2017

myoungwoon created D4646: Fix typo, cacologique expressions in API reference doxygen..
Feb 6 2017, 11:54 PM

Jul 8 2015

myoungwoon updated subscribers of Eflete.
Jul 8 2015, 6:36 PM
myoungwoon edited the content of Eflete.
Jul 8 2015, 6:35 PM