Page MenuHomePhabricator
Feed Advanced Search

Sun, Jun 23

raster accepted D9156: BUILD: Fix EFL build (1.22.x) on OpenBSD..

oh... just push it :)

Sun, Jun 23, 12:24 AM · efl

Thu, Jun 20

raster closed D9129: tests: fix warnings and undef ref on Windows (using meson :-) ).
Thu, Jun 20, 4:51 AM · efl
raster accepted D9129: tests: fix warnings and undef ref on Windows (using meson :-) ).
Thu, Jun 20, 4:50 AM · efl

Tue, Jun 18

raster closed D9107: define HAVE_REALPATH in evil_stdlib.h.
Tue, Jun 18, 5:47 AM · efl
raster closed D9106: Ecore net dialer Windows example: fix undeclared symbols.
Tue, Jun 18, 5:47 AM · efl
raster accepted D9106: Ecore net dialer Windows example: fix undeclared symbols.
Tue, Jun 18, 5:23 AM · efl
raster accepted D9107: define HAVE_REALPATH in evil_stdlib.h.
Tue, Jun 18, 5:23 AM · efl

Mon, Jun 17

raster closed T8018: Notify on volume change does nothing as Invalid.

yeah. what @jf_simon said - i get them as i have enabled all 3 levels of notification... :) so... works for me. :) this is perhaps something to address in future to make it possible for one module to modify config of another... or roll notification config and functionality into core E and out of a module? yes - small usability issue. I might actually say that the mixer should show its OWN popup when changing volume so u see the slider... and not use system notifications. but this is a polish/prettiness thing.

Mon, Jun 17, 1:14 AM · Restricted Project, enlightenment-git

Fri, Jun 7

raster edited projects for T6726: E/EFL Flat Theme, added: Restricted Project; removed Restricted Project.
Fri, Jun 7, 5:57 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project

Mon, Jun 3

raster accepted D8095: Add json-c dependency.

we're good now. can be better using ecore_con_url and probably have some things be real buttons/links to yahoo.com so u just click the link or a built-in place name search/browser... but... this is a good step so thumbs up. :)

Mon, Jun 3, 8:49 AM
raster closed D9023: sysinfo: Use unifed API for querrying CPU state..
Mon, Jun 3, 3:08 AM · enlightenment-git
raster accepted D9023: sysinfo: Use unifed API for querrying CPU state..
Mon, Jun 3, 2:48 AM · enlightenment-git

May 21 2019

raster closed D7639: emixer: Add volume channels control on emixer.
May 21 2019, 6:58 AM · enlightenment-git
raster accepted D7639: emixer: Add volume channels control on emixer.
May 21 2019, 6:41 AM · enlightenment-git

May 17 2019

raster closed D8909: Eet: remove useless inclusion of Evil.h.
May 17 2019, 3:54 AM · efl
raster closed D8908: bin/efl and ecore: include evil_private.h when appropriate.
May 17 2019, 3:53 AM · efl
raster accepted D8908: bin/efl and ecore: include evil_private.h when appropriate.
May 17 2019, 3:53 AM · efl
raster accepted D8909: Eet: remove useless inclusion of Evil.h.
May 17 2019, 3:53 AM · efl

May 16 2019

raster updated the task description for T6726: E/EFL Flat Theme.
May 16 2019, 9:30 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster updated the task description for T6726: E/EFL Flat Theme.
May 16 2019, 9:10 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster updated the task description for T6726: E/EFL Flat Theme.
May 16 2019, 9:08 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster closed D7602: screensaver: Allow to set hibernate on blank into blanking setup.
May 16 2019, 5:54 AM · enlightenment-git
raster accepted D7602: screensaver: Allow to set hibernate on blank into blanking setup.

:) :) :)

May 16 2019, 5:52 AM · enlightenment-git
raster requested changes to D7639: emixer: Add volume channels control on emixer.

hmmm... we're in massive conflict land here. :(

May 16 2019, 5:49 AM · enlightenment-git

May 15 2019

raster closed D8893: Evil: move the inclusion of all headers in evil_private.h.
May 15 2019, 4:35 AM · efl
raster accepted D8893: Evil: move the inclusion of all headers in evil_private.h.
May 15 2019, 4:26 AM · efl

May 14 2019

raster requested changes to D8891: Evil: remove usage of EVIL_UNUSED and just cast to (void).

i'm not sure i like this change - the UNUSED macro is much nicer/better... :|

May 14 2019, 2:45 AM · efl
raster added a comment to T7958: don't use long in eina value tests as they are 32 bits types on Windows.

Well they were already longs - I just made it explicit with the cast. The test is broken on 32bit already. In fact eina_value is broken on 32bit SPECIFICALLY with longs and you are right - windows on 64bit here will behave like 32bit in these cases. Already broken. :(

May 14 2019, 2:18 AM · efl

May 13 2019

raster added a comment to D8095: Add json-c dependency.

oh while i'm at it...

May 13 2019, 7:51 AM
raster requested changes to D8095: Add json-c dependency.

i had some stale forecasts config that didn't have a server to contact in it....

May 13 2019, 7:44 AM

May 10 2019

raster updated the task description for T6726: E/EFL Flat Theme.
May 10 2019, 3:58 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster updated the task description for T6726: E/EFL Flat Theme.
May 10 2019, 3:20 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster updated the task description for T6726: E/EFL Flat Theme.
May 10 2019, 3:19 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project

May 9 2019

raster updated the task description for T6726: E/EFL Flat Theme.
May 9 2019, 10:23 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster updated the task description for T6726: E/EFL Flat Theme.
May 9 2019, 10:13 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster updated the task description for T6726: E/EFL Flat Theme.
May 9 2019, 10:07 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster added a comment to D8106: canvas map: introduce a new texture mapping for better quality..

hermet. you need to take a good hard loo at this. i''m seeing coordinates that are negative and i think other out of bounds coordinates as well. you need to have extensive tests with different resolution input, output, many angles and so on... i've already put a quick and dirty fixup for negative uv coords, but even with that i see rendering bugs in some cases. :)

May 9 2019, 10:01 AM · efl

May 8 2019

raster reopened D8854: Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined.

it seems this breaks on osx:

May 8 2019, 6:00 AM · efl
raster closed D8854: Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined.
May 8 2019, 4:47 AM · efl
raster accepted D8854: Evil: remove localtime_r as mingw-w64 defines it when _POSIX_C_SOURCE is defined.
May 8 2019, 4:47 AM · efl

May 7 2019

raster closed D8842: eina_file: speed up listing of directories on Windows.
May 7 2019, 3:16 AM · efl
raster accepted D8842: eina_file: speed up listing of directories on Windows.
May 7 2019, 3:15 AM · efl
raster added a comment to T7907: about localtime_r (unix and windows).

so do you think that there is a problem if we define _POSIX_C_SOURCE just before including time.h in Elementary.h and Efl_UI.h ?

May 7 2019, 2:55 AM · Restricted Project

May 3 2019

raster closed D8814: replace strndup with eina_strndup, remove strndup definition in evil and elm_test_dnd.
May 3 2019, 5:14 AM · efl
raster accepted D8814: replace strndup with eina_strndup, remove strndup definition in evil and elm_test_dnd.

much better! :)

May 3 2019, 5:13 AM · efl
raster requested changes to D8814: replace strndup with eina_strndup, remove strndup definition in evil and elm_test_dnd.
May 3 2019, 3:17 AM · efl

May 2 2019

raster added a comment to D8792: eina_debug - fix init of cpu, bt and timer debug subsystems..

@bu5hm4n thanks for pointing that out :)

May 2 2019, 9:10 AM · efl
raster added a comment to D8792: eina_debug - fix init of cpu, bt and timer debug subsystems..

move these just above the:

May 2 2019, 9:09 AM · efl
raster added a comment to D8792: eina_debug - fix init of cpu, bt and timer debug subsystems..

how doe sit break bsd?

May 2 2019, 9:00 AM · efl

Apr 30 2019

raster closed D8785: eina_unicode: return NULL if allocation fails.
Apr 30 2019, 1:25 AM · efl
raster accepted D8785: eina_unicode: return NULL if allocation fails.
Apr 30 2019, 1:23 AM · efl

Apr 26 2019

raster updated the task description for T6726: E/EFL Flat Theme.
Apr 26 2019, 5:46 AM · Restricted Project, efl: widgets, enlightenment-git, Restricted Project
raster added a comment to D8678: eo: add events to track the ownership status of an Eo object.

expedite is not the right test for this. things like elementary - like genlist and things that create, destroy and move objects in and out of parents and have complex call trees - those are the things u need to look at

Apr 26 2019, 2:29 AM · efl

Apr 24 2019

raster added a comment to D8678: eo: add events to track the ownership status of an Eo object.

what they said. this is going to be costly...

Apr 24 2019, 2:10 PM · efl

Apr 23 2019

raster added a comment to T7821: terminology double char width computation breaks mutt.

hmm whilst unicode says they are emoji.. they don't come out as ones according to terminal apps so yeah - keep the entire range out.

Apr 23 2019, 3:19 AM · Terminology
raster added a comment to T7821: terminology double char width computation breaks mutt.

the problem is 25AA, 25AB, 25B6, 25C0, 25FB->25FE are emoji...

Apr 23 2019, 1:45 AM · Terminology

Apr 18 2019

raster added a comment to D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

oh i had an idea over lunch... store sd->text in a local var and do the free at the end of the function. then it can't ever be an invalid pointer. the check for it being the same ptr can avoid doing the duplicate and the free to as it does now so store and move the free before the done label and there will be no crash. right?

Apr 18 2019, 6:16 AM · efl
raster requested changes to D8572: elm_entry: speed up setting text (check if same text is already set), fix setting same text pointer.

small change i think ... it's less code and less prone to error.

Apr 18 2019, 5:09 AM · efl
raster added a comment to D8578: Freeing Global Memory list on destructor.

but those functions then access the globals anyway so it's just pushing the problem away one level into another function, and if someone forgets a RemoveSharedStyle() call just like the list remove above - same thing happens. it's not really any different. these functions are indeed good to avoid copy & paste code if you have lots of places that do the same list remove and to be fair - efl has a lot of things like this that have crept in over many years.this is an area that efl could do with some attention to look for "copy & paste" code even if it looks different on the surface and possibly has minor difference (that could be bugs - careful thought and attention would need to be applied to see if they are really intended or not). if these bits of code can be refactored to share more common functions like you describe above where there is duplication, code size can be reduced and the chances of future problems where a list remove is forgotten in 1 case but not the other reduce. so to some extent you have a point, but in this case there isn't anything really to gain. indirection to a function which is all of 1 or 2 lines of code is generally not that useful. if its a larger blob of complexity then it'd probably worth a look. :) i hope this serves as some encouragement and guidance. in this case you found a bug, but your solution is IMHO with the above functions won't help IMHO, but there are enough other cases where this is really needed and you'll get little argument over :) i know the code exists. i know i've been guilty of doing it myself often enough. :)

Apr 18 2019, 5:01 AM · efl
raster added a comment to D8578: Freeing Global Memory list on destructor.

@bu5hm4n is right - this has nothing to do with globals. it'd be the same as if obj->styles = eina_list_remove(obj->styles, ts); was missing in the free func for the obj.

Apr 18 2019, 1:37 AM · efl

Apr 17 2019

raster closed D8633: eina_vpath: port to Windows.
Apr 17 2019, 9:44 AM · efl
raster accepted D8633: eina_vpath: port to Windows.

;]

Apr 17 2019, 7:30 AM · efl
raster accepted D8632: efl-net.pc.in : honor datarootdir.

;]

Apr 17 2019, 7:29 AM · efl
raster accepted D8552: evas gl: move to floating point coordinate system..

yup. no big difference. ok. i'm comfortable with moving to float entirely.

Apr 17 2019, 1:29 AM · efl

Apr 16 2019

raster added a comment to T7788: Memory Leak efl_add.

there isn't a single control. evas has various caches, edje has, there are mempools and those are set up by code, and so on etc. etc. - so you'd have to tweak various things to force free and some cant be force freed at all without modifying the code to no longer use a pool etc.

Apr 16 2019, 3:22 PM · enlightenment-git
raster added a comment to T7788: Memory Leak efl_add.

you'd have to stress it and re-use a lot of objects to see if there is a leak. we do have memory pools and trash etc. like @bu5hm4n says - we alloc and keep around that memory then re-use it again. you'd have to do a lot of allocs over and over and then see the mem footprint keep going up and up and never stabilizing. i adapted your code a bit to do this with a timer ever 0.01 sec:

Apr 16 2019, 11:09 AM · enlightenment-git
raster closed D8621: evil: remove tmp and home dir get.
Apr 16 2019, 10:00 AM · efl
raster accepted D8621: evil: remove tmp and home dir get.

;]

Apr 16 2019, 9:58 AM · efl

Apr 15 2019

raster closed D8602: Windows : fix the definition of EAPI.
Apr 15 2019, 5:34 AM · efl
raster accepted D8602: Windows : fix the definition of EAPI.

;]

Apr 15 2019, 5:32 AM · efl
raster added a comment to T7788: Memory Leak efl_add.

because the canvas didn't go through a render cycle - nothing changed visually thus it didn't render. it has to actually go through a full cycle. try show some of those rects and leave them there for 1 frame.... then delete them.

Apr 15 2019, 12:53 AM · enlightenment-git

Apr 14 2019

raster closed T7788: Memory Leak efl_add as Invalid.

because evas object deletions are DEFERRED. they require render cycles to drive the deletion. they will be kept around for 2 render cycles so evas can do a prev state vs current state check., imagine u delete a visible object - how can evas know what changes - what area is occupied that now needs re-rendering? was it visible or not, was it set to a color of 0 0 0 0 which EFFECTIVELY made it invisible to rendering even if it was shown... thus objects invisibly have extra references to them that are removed if delete flags are set by the render cycles, so the above case is just "invalid" in that any real process will never do the above and will have a fairly limited upper bound on how many objects will be created then deleted before a render cycle happens. if there really is a very big spate of creating invisible objects (e.g. you're using evas as an image processing engine where you might load an image file into an image object then save it out as another format) then there is evas_norender(evas); which does a render cycle without doing the actual rendering thus driving the object deletion pump. it's an incredibly rare day this is ever needed and if it is used, any updates from objects that really did need a render will be lost. you would need to manually add a damaged region for the whole canvas output to force a full re-render to avoid this if this ever were the case.

Apr 14 2019, 4:01 AM · enlightenment-git

Apr 11 2019

raster closed D8598: elementary: rename ELEMENTARY_BUILD to EFL_BUILD like all other libs.
Apr 11 2019, 9:59 AM · efl
raster accepted D8598: elementary: rename ELEMENTARY_BUILD to EFL_BUILD like all other libs.
Apr 11 2019, 9:58 AM · efl

Apr 9 2019

raster closed D8583: eldbus unit test: fix warnings.
Apr 9 2019, 4:37 AM · Restricted Project
raster accepted D8583: eldbus unit test: fix warnings.

:)

Apr 9 2019, 4:36 AM · Restricted Project

Apr 7 2019

raster added a commit to T7728: eina_test_vpath.c : getuid() does not exists on Windows: rEFL954a534bc0e7: remove vpath test for user dir the test was broken and fixing is insane.
Apr 7 2019, 5:19 AM · Restricted Project
raster closed T7728: eina_test_vpath.c : getuid() does not exists on Windows as Resolved by committing rEFLe25ba74d2ba4: remove vpath test for user dir the test was broken and fixing is insane.
Apr 7 2019, 5:19 AM · Restricted Project
raster added a comment to T7728: eina_test_vpath.c : getuid() does not exists on Windows.

actually struct passwd and getpwuid are probably a major problem...

Apr 7 2019, 5:02 AM · Restricted Project

Apr 5 2019

raster added a comment to D8552: evas gl: move to floating point coordinate system..

I mean weak performance is "weak point" as you can see the video attached.

Apr 5 2019, 3:46 AM · efl

Apr 4 2019

raster added a comment to D8552: evas gl: move to floating point coordinate system..

But obviously, efl animation show us very weak performance than other decent frameworks.

Apr 4 2019, 8:58 AM · efl
raster requested changes to D8552: evas gl: move to floating point coordinate system..

this has a downside. it doubles the memory needed for coord storage/copying to gpu etc. .... that will mean some performance drop and the only benefits are when using msaa... but even then evas object geometry is done with integers only so it can only help with map and even then map reduces to integers anyway at the engine api....

Apr 4 2019, 1:15 AM · efl
raster accepted D8551: efreetd: remove a tentative global variable definition.

that is indeed a bug... thanks!

Apr 4 2019, 1:11 AM · efl

Apr 3 2019

raster requested changes to D8540: elementary: add a queue to postpone object destruction when necessary..

this does have a problem - nothing ever calls eina_freeq_reduce()/eina_freeq_clear()/eina_freeq_reduce(), so anything put on this freeq will never get freed until process exit.

Apr 3 2019, 4:22 PM · efl

Apr 2 2019

raster closed T7685: Video wallpapers for e broken - doesn't seem to propagate update rects as Resolved by committing rEFL07f0044d281b: evas image - fix proxy change propagation to fix e video wallpapers.
Apr 2 2019, 10:25 AM · efl
raster closed T7776: compilation error on Windows : elm_naviframe_item_push() is redeclared differently as Resolved by committing rEFL96f1e2970921: elm naviframe - remove duplicated func prototype in headers.
Apr 2 2019, 5:59 AM · Restricted Project

Apr 1 2019

raster added a comment to D8478: evas_render: Process deferred callback in the sync render case..

@Hermet - actually gl rendering is still sync mode... :)

Apr 1 2019, 7:10 AM · efl

Mar 30 2019

raster closed T6247: Please install engine headers again as Wontfix.

:)

Mar 30 2019, 6:56 AM · efl

Mar 28 2019

raster closed T7764: evasgl usage broken as Resolved by committing rEFL3439134ea1f8: Revert "evas gl engines - avoid getting context if possible".
Mar 28 2019, 5:19 PM · regression, efl (efl-1.22), efl: rendering

Mar 19 2019

raster accepted D8106: canvas map: introduce a new texture mapping for better quality..

aaah ok. that's a good selection there. thanks! :) so impact can vary from almost nothing to "pretty big". at least it's an option - aa and smooth on at the same time i think is good enough. if it was not that much more i was going to suggest we adopt it as the default "smooth". :)

Mar 19 2019, 4:06 PM · efl
raster raised the priority of T7685: Video wallpapers for e broken - doesn't seem to propagate update rects from High to Showstopper Issues.
Mar 19 2019, 4:03 PM · efl

Mar 15 2019

raster added a comment to T7360: Evas/Edje animations not in sync .

I'm not going to have time for a few weeks...

Mar 15 2019, 2:54 AM · efl: layout engine, efl: rendering, efl (efl-1.22), regression

Mar 12 2019

raster triaged T7737: efl-git 1.22.0beta1.61484 + enlightenment-git: icon menu properties not diplayed (wayland) as High priority.
Mar 12 2019, 10:39 PM · enlightenment-git, efl (efl-1.22)

Mar 10 2019

raster added a comment to T7734: windows : could not open src\lib\ecore\efl_loop_timer.eo.legacy.h.eo.legacy.h.

i can't reproduce... now that autotools is working enough again...

Mar 10 2019, 6:16 AM · efl (efl-1.23), Restricted Project
raster added a comment to T7734: windows : could not open src\lib\ecore\efl_loop_timer.eo.legacy.h.eo.legacy.h.

autotools was broken for me anyway. so i couldn't build with it. iut literally deleted files committed to git and failed to build part way thru

Mar 10 2019, 5:05 AM · efl (efl-1.23), Restricted Project

Mar 9 2019

raster abandoned D8099: evas: make convert_rgb_32 keep consistency.
Mar 9 2019, 7:22 AM · efl
raster commandeered D8099: evas: make convert_rgb_32 keep consistency.

going to close this as 4758f06e637239f981eedbaaf8c0d613b78e4417 solves it better by moving to tiled rendering

Mar 9 2019, 7:22 AM · efl
raster added a comment to D8099: evas: make convert_rgb_32 keep consistency.

on arm32 the tiled rotate is 2.4x faster vs the neon. the neon interestingly is also about 1.8x faster than the plain C code.

Mar 9 2019, 6:37 AM · efl
raster requested changes to D8099: evas: make convert_rgb_32 keep consistency.

ok i checked on arm32 and yeah - the neon is broken. but... it's half the speed of the tiled rotator... so why fix something that is slow when we can just switch to the faster one. :) i think its best to reject this and instead just remove any rotate code/paths that are not the tiled rotates... :)

Mar 9 2019, 5:49 AM · efl

Mar 8 2019

raster added a comment to D8095: Add json-c dependency.

forecasts doesn't work for me - only says it supports us zip codes (and i don't live there) and can't enter anything in the entry box there in settings anyway, so can't test it.

Mar 8 2019, 7:27 AM